From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E67FE77187 for ; Wed, 18 Dec 2024 19:20:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 183B86B007B; Wed, 18 Dec 2024 14:20:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 10D536B0082; Wed, 18 Dec 2024 14:20:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EEF8C6B0083; Wed, 18 Dec 2024 14:20:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D24CC6B007B for ; Wed, 18 Dec 2024 14:20:33 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7B7A28113A for ; Wed, 18 Dec 2024 19:20:33 +0000 (UTC) X-FDA: 82909045716.11.BE7DEFE Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf08.hostedemail.com (Postfix) with ESMTP id D1668160019 for ; Wed, 18 Dec 2024 19:20:09 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=dVcjyo9T; dmarc=none; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734549617; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=y+H9mbq07YmrLuzXQ/5j05Zjf+pa75UyPx0ekdw5M40=; b=zUxvf+n2KLUk9afmEfbRoLInB5B16W8FcoD0HpZ9rburpCRBWnoWmBbS34OQz/S3qEoRv2 JqhH7iQHXJg0w0easxUJVHGIvdwjnRa7eEGfeqneHfGDxdcW9CM6X9N4AFXvJfJjKYjkt8 g7PSzcgd3pW7O7jkVmO/4+rhJ2ji/lU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734549617; a=rsa-sha256; cv=none; b=su4S0LRvQv6AWxIaJGgTa0hha5XYE/Bi3TOKXtjWjHGfatVceVoJ26S3s3uuJtQ17CnYI4 avRYhAWbtHvEscfsPT4hkb0lf5p1+Zf7sXyDFafJMe4nFPgb6vlJ93TUmXlkG/07Xv0TUx W/74L5UICWtx4zd7s2G1CvMrEoeVu3I= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=dVcjyo9T; dmarc=none; spf=none (imf08.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=y+H9mbq07YmrLuzXQ/5j05Zjf+pa75UyPx0ekdw5M40=; b=dVcjyo9TeM8t8yyHKAvE06yW1b 6dvo+oWvfE1e1HDS0w8nFVagY6dfnoqUOEDoETffTcThfsnzrFZoVv3lDpg0Qyg8V9wSOqEKoPNKO 1+wiUEfJYuU26EkFXBi53t4kD5Z5LJW4Iyp93IM6rpY35y6DEu3L9uS9OFSIrfEHcmsFpErIb5Rnq /ZnItbzfHWRcVeFR10JMZhm7lpOgZdDZku3aDFMnBAX7iz0k1ReWpk6l72JexGCbzzGPjWRtrPdXo Zy8bbp0CwoFbhLT6C8hkGxxC4ZfF5d/Uf6tvqYSpaxTm60Bw3HT+VtHMsqL7sPU0WDu8sxMuP2Arn wTsuGQog==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tNzaq-00000000VuC-0B2T; Wed, 18 Dec 2024 19:20:24 +0000 Date: Wed, 18 Dec 2024 19:20:23 +0000 From: Matthew Wilcox To: Luis Chamberlain Cc: hare@suse.de, dave@stgolabs.net, david@fromorbit.com, djwong@kernel.org, kbusch@kernel.org, john.g.garry@oracle.com, hch@lst.de, ritesh.list@gmail.com, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com, kernel@pankajraghav.com Subject: Re: [PATCH 3/5] fs/buffer: add a for_each_bh() for block_read_full_folio() Message-ID: References: <20241218022626.3668119-1-mcgrof@kernel.org> <20241218022626.3668119-4-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241218022626.3668119-4-mcgrof@kernel.org> X-Stat-Signature: f6k9mt5kmktgiyf8fbjephhmgtwni3pj X-Rspamd-Queue-Id: D1668160019 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1734549609-564979 X-HE-Meta: U2FsdGVkX18Rcrxnit6UbldkXXIZtjBoBR50vJkv4iTVYN4cRgQ11NtWCf020pCQkFhbrDiFy58jc9qz0nDb7IE+cvay772czMFQeNaThMbhgh0+yzQG/+bE5Sv3BsqB4JCC7XDx2xtoRu6yV6rVV8sueoTHF+VGIVxBxoMZFx7Ig0b5xr+j+auUo9xdwDo6PP8n5Sf8wSLAEZssix5UiGA8xq7e9F+AbEZtPMbu4/oxL6g8JGv9m6o5OsPxzUVhnbf3mHVoa+cNIYzxkW+r/Pe+VjEBEaooKbNvCxNOEvhJ4sY5OnqRKI5i09iRyA8HAIaIKUQSzfX9CMqTdfx8aApP8zRDhETrGEPPDKN3IDi6KErq4vLaCBzLW9GuZBw/AGSd1PTV9+xkmeGRgPiAJk0c/l2UJP1Tt5MNwrZNxIKonvqHrr83dkhJ/0XuLNjtnKi7eWsp0m3bIWYGRSRCljeDfonk6ZNH1w7UX9tQrlez/LeEM8xUmLUwDv/Nx6F/zTeymLstrnjRn7bVYQsgFoL6rQRacuu7hNzFnhljUfmAiv3XHhASsM1J2Gwl9Sdd35538C8AtB4/prFpjSaxGY4ofOS53yP/7bm6uNdSG7cEIlUbVx4G+HFTnT1TNilB67CLB7AXoSr6pqtpWzaU4Zkzpsxe1mv2OHN/6hkeOIhFi+bZoQgQ7uxhDyQMNaxp8KtGcj3LYqmxZekvX0eH+PlABQyuWoMjZ7xgvzkJJW2AYxHcxFFMOHPHdEHrKUQ35a5HAwH4XtlD+i2ihSrq4W11FhP3rChvsCLTe7hjTFegNsSupDNkmRTd/DJSluLrthsLc83TvBmJxh1hlfRcMhiOMd2cyvQzcUprua0qBaZtUWnhPJX3nVhttkph7Bx69cwMiqk2fS/fC3pRSnv9PvVY2cCaA45kZwrL/14/li4dV6cDu1zt8KQ/4HF6bqTTNt5iarWf8ZbNsd+qKM+ j76XZOb4 MlCBJrhomLhcEpng8suKHMOJA6RsA8Ifug+P+ptZ12W1tADFhmDxC+KUVFhKgbvp21JP7Ee3zsgYzxqlneTBckxVsNzocNmcMrtpYYWafJVFSMFTY3MhWBJZw/uIxVfTUrhdv4HcPqkDjd88FFyA/2Y8G4bFbLUg6Xop6WP9QbkU+u9qPho1IgNo65e87MwJ3gCuL7hZrVVsDWphIxcgZGYUdbNw9omOOFYXmfYdX3ni7nPdDimzcerZeE5bZVTOhIgDdrhZoplMvMEw3VvtDJm6c8VsePG7TG7PXrkZEBI9DoZmuiiWAH02K/nEwjlXxUN3odZ8Z1Bv1YsTh9cVTJzUjPd5mjPJd1IXC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Dec 17, 2024 at 06:26:24PM -0800, Luis Chamberlain wrote: > /* Stage one - collect buffer heads we need issue a read for */ > - do { > - if (buffer_uptodate(bh)) > + for_each_bh(bh, head) { > + if (buffer_uptodate(bh)) { > + iblock++; > continue; > + } I'm not loving this. It's fragile to have to put 'iblock++' before each continue.