From: Matthew Wilcox <willy@infradead.org>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: hare@suse.de, dave@stgolabs.net, david@fromorbit.com,
djwong@kernel.org, kbusch@kernel.org, john.g.garry@oracle.com,
hch@lst.de, ritesh.list@gmail.com, linux-fsdevel@vger.kernel.org,
linux-xfs@vger.kernel.org, linux-mm@kvack.org,
linux-block@vger.kernel.org, gost.dev@samsung.com,
p.raghav@samsung.com, da.gomez@samsung.com,
kernel@pankajraghav.com
Subject: Re: [PATCH 3/5] fs/buffer: add a for_each_bh() for block_read_full_folio()
Date: Wed, 18 Dec 2024 19:20:23 +0000 [thread overview]
Message-ID: <Z2Mgd4kYqPeDC4mP@casper.infradead.org> (raw)
In-Reply-To: <20241218022626.3668119-4-mcgrof@kernel.org>
On Tue, Dec 17, 2024 at 06:26:24PM -0800, Luis Chamberlain wrote:
> /* Stage one - collect buffer heads we need issue a read for */
> - do {
> - if (buffer_uptodate(bh))
> + for_each_bh(bh, head) {
> + if (buffer_uptodate(bh)) {
> + iblock++;
> continue;
> + }
I'm not loving this. It's fragile to have to put 'iblock++' before each
continue.
next prev parent reply other threads:[~2024-12-18 19:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-18 2:26 [PATCH 0/5] fs/buffer: strack reduction on async read Luis Chamberlain
2024-12-18 2:26 ` [PATCH 1/5] fs/buffer: move async batch read code into a helper Luis Chamberlain
2024-12-18 2:26 ` [PATCH 2/5] fs/buffer: simplify block_read_full_folio() with bh_offset() Luis Chamberlain
2024-12-18 2:26 ` [PATCH 3/5] fs/buffer: add a for_each_bh() for block_read_full_folio() Luis Chamberlain
2024-12-18 19:20 ` Matthew Wilcox [this message]
2024-12-18 2:26 ` [PATCH 4/5] fs/buffer: add iteration support " Luis Chamberlain
2024-12-18 2:26 ` [PATCH 5/5] fs/buffer: reduce stack usage on bh_read_iter() Luis Chamberlain
2024-12-18 2:47 ` Luis Chamberlain
2024-12-18 20:05 ` [PATCH 0/5] fs/buffer: strack reduction on async read Matthew Wilcox
2024-12-19 2:27 ` Luis Chamberlain
2024-12-19 3:51 ` Matthew Wilcox
2024-12-30 17:30 ` Luis Chamberlain
2025-01-31 16:54 ` Luis Chamberlain
2025-01-31 22:01 ` Matthew Wilcox
2025-02-03 14:00 ` Luis Chamberlain
2024-12-19 6:28 ` Christoph Hellwig
2024-12-19 17:53 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z2Mgd4kYqPeDC4mP@casper.infradead.org \
--to=willy@infradead.org \
--cc=da.gomez@samsung.com \
--cc=dave@stgolabs.net \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=gost.dev@samsung.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=john.g.garry@oracle.com \
--cc=kbusch@kernel.org \
--cc=kernel@pankajraghav.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=p.raghav@samsung.com \
--cc=ritesh.list@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox