From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8A8BE77188 for ; Wed, 18 Dec 2024 11:32:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 499526B0089; Wed, 18 Dec 2024 06:32:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 449616B008A; Wed, 18 Dec 2024 06:32:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 312BA6B008C; Wed, 18 Dec 2024 06:32:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 113B06B0089 for ; Wed, 18 Dec 2024 06:32:47 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C6325140DB8 for ; Wed, 18 Dec 2024 11:32:46 +0000 (UTC) X-FDA: 82907867196.02.B556B08 Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) by imf09.hostedemail.com (Postfix) with ESMTP id 36FF714000B for ; Wed, 18 Dec 2024 11:32:23 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=En014gd9; spf=pass (imf09.hostedemail.com: domain of mhocko@suse.com designates 209.85.208.50 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734521543; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LZJwwmcQBEF7Vv0pbmFocrZnFohz2fBt7d/cH/Oco8c=; b=TjjjzPjoMyjEw/WFSFIvI/ClwSqy34/Zh82skhAFhRRSmIR/prHqnYnXBa3RVncwsqoXux UPIAe0uBW9j93Sl7kgTJc0DcVzPGRi7k2cQyLl4QNFAa69TyoEEg/tDMFJmpplyVxI0hMT +1OqpkzlC2+AiOTMlEv6t21kno3l7lc= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=En014gd9; spf=pass (imf09.hostedemail.com: domain of mhocko@suse.com designates 209.85.208.50 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734521543; a=rsa-sha256; cv=none; b=ALf2hKThECCXvL54MCMBTZlNokKoFXDyYgU+mOkd/GJgUWGtj6Yoz9FFEM2SJcsvEPJgar ibaPI31K+6ojPRyZs1W67wIAdJXTx4VFWp5fxK9Kdb8J9ZIDXrKp+NA2VzhGdwP9If7gNG qxeiK8DREaf6XAAtG6WC7HamFM2+zbE= Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-5d3e9f60bf4so10141242a12.3 for ; Wed, 18 Dec 2024 03:32:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1734521563; x=1735126363; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=LZJwwmcQBEF7Vv0pbmFocrZnFohz2fBt7d/cH/Oco8c=; b=En014gd9lGUXXBmzMv+GUL5iNh6b1lnfOrvY2u1J+khVzgntGmq2RM4stbPiRh5Dd8 w7LWe7u/3diRPXLaco6J72ayGvI967TbxWV+13t6fh0NN3s/JXNUwBOCo1F38s8JTkol WGZrV0cx5+/OAnK3qO5NWs9fyCWv9N2ZJ/0cFJGoZ1RJiJJ4hPuRn92CCCeNhfVcQT0G 1pU+/++kWWRYF+o9Kd49ON3zbSo1BqbwW5tHfIKLTxYaoxKZHJiEgQDfQPczO4vDND82 9dh7t+bcy5R+qYKBhblnDPUqtBsX/CeAjIvUb9JgCOhqpk5GgZ6s+zHQ9ILTn8TvLW01 bCzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734521563; x=1735126363; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=LZJwwmcQBEF7Vv0pbmFocrZnFohz2fBt7d/cH/Oco8c=; b=AKf4DZmHsXk2ziGZj+w+m1qsiRHcWc6DPYJQBvpgPxGRXP1VEdMuiKe9r5qDFoAV6b 7ifdrw1u9VdzFqA5Y1fFrTH6KnTssLfdyPWvskmVxSADAmakrHQZaCPqtdx7QhE6DSpQ pld7w9h/THBcNlu1woi0vi86RUO9bj6ZROx+71JMKa2zrN2xdundJ0tThDcZo7I1hWqm MNbIOklIPDOHD92npY6QsdeegyF66aJnW6nP7NPzyWW9zv8PcudisZZVuQFUQksuB1Kg ZiMGKVqU4aHp92e76XJkURqks4eXFa1uIQWGfi5xSu4QRlVL1wYmGCqw2Wed3DjKKjbF idjQ== X-Forwarded-Encrypted: i=1; AJvYcCWiAjFjRmX/ckab6Tq28mZmFZs2sxKWQxcSlia8tEXJa0XoXyEye6PJil6o6RYw0GuEAm8x27D93w==@kvack.org X-Gm-Message-State: AOJu0Yz9wYDLvdc+hhEJiHvwzGakKZbeoqox80THpc7GvXb8q71YAnrc c8gGA/H0AXAJMzOnVwAmQTC6C2G5SKO/gZ9mgsUGFjjhBdXSyhtZUltouarxBaw= X-Gm-Gg: ASbGncukd89ruaKtn0SJV5AOf/CyUQam2Di9R0ME6D3uVtQ2D0hjVVLlyZXE5jbQWzu 018ifHomeQh/qfbnxDp7RNpQDeAKkq1D/uf+TiNNVz6/0DsTdK3zjdRd7iDtZ4V4xqOcdfVWLo/ QdySCZGSTYbXVdHy9qKHyvJzOHT1uAHY/8alTvTj+EqMec68HnJMecLTWkscBl7dbKEgG7+6fiG 8H74aGyYC3IfdUMuCu+OeoTUMT9DhAk4UudFdOLRmcUDeVNfmMDEtusLyuLCGerffI= X-Google-Smtp-Source: AGHT+IE5VujHh3Dnv9oj0fGchFrHkd+6EqA5Iv+rxWcXjMtHztBOzGDREwwyqalQIENpXUEQsgVa2g== X-Received: by 2002:a05:6402:2113:b0:5d3:d8b9:674d with SMTP id 4fb4d7f45d1cf-5d7ee2dcfd5mr2281660a12.0.1734521563418; Wed, 18 Dec 2024 03:32:43 -0800 (PST) Received: from localhost (109-81-89-64.rct.o2.cz. [109.81.89.64]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5d7e5ceff0bsm1303313a12.65.2024.12.18.03.32.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Dec 2024 03:32:43 -0800 (PST) Date: Wed, 18 Dec 2024 12:32:42 +0100 From: Michal Hocko To: alexei.starovoitov@gmail.com Cc: bpf@vger.kernel.org, andrii@kernel.org, memxor@gmail.com, akpm@linux-foundation.org, peterz@infradead.org, vbabka@suse.cz, bigeasy@linutronix.de, rostedt@goodmis.org, houtao1@huawei.com, hannes@cmpxchg.org, shakeel.butt@linux.dev, willy@infradead.org, tglx@linutronix.de, jannh@google.com, tj@kernel.org, linux-mm@kvack.org, kernel-team@fb.com Subject: Re: [PATCH bpf-next v3 4/6] memcg: Use trylock to access memcg stock_lock. Message-ID: References: <20241218030720.1602449-1-alexei.starovoitov@gmail.com> <20241218030720.1602449-5-alexei.starovoitov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241218030720.1602449-5-alexei.starovoitov@gmail.com> X-Rspamd-Server: rspam05 X-Stat-Signature: rpr5rgp9io957bp7swf7rtfiaja1n69p X-Rspamd-Queue-Id: 36FF714000B X-Rspam-User: X-HE-Tag: 1734521543-161402 X-HE-Meta: U2FsdGVkX1/Zn8kueOCii+UWwtP5cwJLLZ2tf9sDt2GYv+2rKMu0TEnVEUPrbBX/bXvxKkawAnauMA2CwIULlPU6m5zWjhlerIjgwqvxnxpRYY9IGh86qUpDLjFlsmcRNTKd0jxAxUhpinBgqAPkAG5anTBNCCNohe6WMgYRuwMbk6dgtyBKw7st7ZzG2197TYbCRDJ9cPxsVbW/hrQt6fkpIqTDejQhJnaPLUumoZOuNrWrAX4X28l5JpDVqH1HPskGWXiMyiWZGXFTDbynuEbaXKaLA1Hxia0yeMQ6kHV3JjqMaZJfyy5l9kKZjGDI77yloSsa2ZIZ9cJll6veyi2ZNYtDn99XRE0ihAVvmecxmh5SdCZbFWKkueNrgkbX3Pnv7CVH118WwX8LnNqe9wiYgqMr60EqxCU7cVuQoYJsNzF8Y3Kl5ejOCouPuX/sFn5tnVXa5yT8vybhngEqNkFUVDjRkWO14JnERdV+H7TqokC8k+tEbIhZ/XzN2ViJwQAuuOZkT5OElkKZI6M2FbDwVKT3mcGd+UxtcGWyTXQcM0tEiFrPRVmJAmUNsJ7D9YCvxT9Z0e4CQDUkXk2kGOHmTwPqz+fGnWkCz+CHeAR6PkExn/uPVEPf+Ac0JU0iGiIbHUXGnljD31Q929C9p2VqjcGtdyCF8T2N/qrUNxlkchDJbD0Z1bIV8h+ekld5dj/Z8icoJLptT/NRooV7NO3n+chf4iKbyuCKN/EJCg6G6ehNp4kK03hdSjEC46FTTtxKI0AMLrRcE6O+60NT5op4LW4WgD+jh+3TyaaaUQzOdq+ddKHWMzOCpnBNJufbsSaPwYuFFW2jbyTyvbs6TRpfLxwbJ/7yI3FpLxnj0XY4gXnCWpMsdGfzBQ/I835YmazCf+zMk4fsUkIDQxrkhdbIQVveO6pGbx8Qyua28JOmUS6d/CZ9L50UMQTm0Fae0RSlJcOtIIiMIiZ7wFJ TS8Am3tF brI6ngCeq4cxipfa56PXP8uUHY4GNGscJHPJaHEuZG8E82Uex3tKBxL1WDryhmuJZ17gA9+LEGDZ/P9XnfIDBjd2ZyQAc21Wh3MheOrlc8Ae6wf3E9d7cF9d8/gLecpjzWG15Mtx44dNX5BcyKpoFBb3XElkcY/rLRS6Nj2IKmqHwfhKvfHkHyFA7AxzDGeqhrOtlRy5f+zdCz94ALQP4deJuPQuKGL1ocC5J3vpslOCmjadCy/htgYshCFIrpyyroBFK8pzLLjZbGxdueRgB/tsKP+1zYQ7Qq/uZLHsJ+j4HOwlnATzyfHs9BZk646D2aVuM252fmPhGBtidEmwKMR2TdXlPNzYrwng2TXdktXyix9MP5OTt1s1aII9MAJfBpQmCgzll1XhqKl6JTSsP0Ca46UzmbNtCwjhpwPRGiXPigbXPWx2LQoJ99w+29y0jN5ij4kFQ00KDgZMH4TnvCML2lfrDOuP3boWE X-Bogosity: Ham, tests=bogofilter, spamicity=0.209786, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue 17-12-24 19:07:17, alexei.starovoitov@gmail.com wrote: > From: Alexei Starovoitov > > Teach memcg to operate under trylock conditions when > spinning locks cannot be used. Can we make this trylock unconditional? I hope I am not really missing anything important but if the local_lock is just IRQ disabling on !RT. For RT this is more involved but does it make sense to spin/sleep on the cache if we can go ahead and charge directly to counters? I mean doesn't this defeat the purpose of the cache in the first place? -- Michal Hocko SUSE Labs