From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCF9AE7717F for ; Tue, 17 Dec 2024 17:31:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 674EB6B0089; Tue, 17 Dec 2024 12:31:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5FDD16B008A; Tue, 17 Dec 2024 12:31:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 450126B008C; Tue, 17 Dec 2024 12:31:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 23F806B0089 for ; Tue, 17 Dec 2024 12:31:31 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id BB6AB1C7353 for ; Tue, 17 Dec 2024 17:31:30 +0000 (UTC) X-FDA: 82905142068.18.38225DA Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf20.hostedemail.com (Postfix) with ESMTP id E26C71C000E for ; Tue, 17 Dec 2024 17:30:55 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b="MTO/Z+o6"; spf=pass (imf20.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734456673; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Qku009jdAu0Sgq06JBD3twBP+vP3Ple+4ZyDkim0IzU=; b=EXAkEeFu0GzYUgx7lZ9gsIROQgxVWJs6A6bLHbbxbAmAJ0pv4QGUVdzmVNzW9O9IsrW7OX ehJZUJeaxUP2hzHrXHld1GtFzHRogC4JtKWF+1Jxv7PaP35wppDqt6C0pR90mLkHfNJXNx ndetEu2f11MBoTTBG4tcNqVX2CJFMTs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734456673; a=rsa-sha256; cv=none; b=bHiVrwGEOqWwGzVKRednIC1zteQ3yZXTlqeZgDmcsOct2W5VVTeCL2cvwrInlVtqKqIHyA s+SWvS0xy4WUzdhPPqJx+TYPVQbYrZLCyLpLQJcrVswKvV7Gynbdr2cTBcPAYKBVDfWf6b 37r4J+q9Xp3VlyWXS+y2Zr6UOvNjZ/A= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b="MTO/Z+o6"; spf=pass (imf20.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BHE6H87020846; Tue, 17 Dec 2024 17:31:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=Qku009jdAu0Sgq06JBD3twBP+vP3Pl e+4ZyDkim0IzU=; b=MTO/Z+o64j+lMdlSt7lwGrgEQppRaLzv9IemetXvJVf+eQ cDcMHOowL34r8UPq4AkzwJy+6AWYi1tChb1UBoo4veqGiPUdkwFr8rpVFiuN71m8 4Wx9vkdpH3EtO5Hv3GdirgS69Lcr5+qFtZbefM2/H+mmJp/+ICb8xWKAOli3haFo 9qNOCbrE9oWnu8acOVKIDOgwMbAarQxEacZSNkXgLjhk512BYMMs29gN0AV2mmsQ PdhP7cGWESbpvwRlQJc8Ko7koVPBuDV/7R/r8/lqWG+jNl3AtSdaRFKqfO/+GxUQ UlSlIuxSuvNJlTiWhAHsT2md7A5meFzErQ9cQ+1A== Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 43kas4s2rw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 17 Dec 2024 17:31:23 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 4BHDwPa9014391; Tue, 17 Dec 2024 17:31:22 GMT Received: from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 43hq21kftu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 17 Dec 2024 17:31:22 +0000 Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 4BHHVImO33161492 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 17 Dec 2024 17:31:18 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7AC1320040; Tue, 17 Dec 2024 17:31:18 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3AC5E20043; Tue, 17 Dec 2024 17:31:17 +0000 (GMT) Received: from li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com (unknown [9.155.204.135]) by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTPS; Tue, 17 Dec 2024 17:31:17 +0000 (GMT) Date: Tue, 17 Dec 2024 18:31:16 +0100 From: Alexander Gordeev To: Easwar Hariharan Cc: Pablo Neira Ayuso , Jozsef Kadlecsik , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Julia Lawall , Nicolas Palix , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Russell King , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , Ofir Bitton , Oded Gabbay , Lucas De Marchi , Thomas =?iso-8859-1?Q?Hellstr=F6m?= , Rodrigo Vivi , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jeroen de Borst , Praveen Kaligineedi , Shailend Chand , Andrew Lunn , James Smart , Dick Kennedy , "James E.J. Bottomley" , "Martin K. Petersen" , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Jens Axboe , Kalle Valo , Jeff Johnson , Catalin Marinas , Andrew Morton , Jack Wang , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Greg Kroah-Hartman , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Xiubo Li , Ilya Dryomov , Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Petr Mladek , Joe Lawrence , Jaroslav Kysela , Takashi Iwai , Louis Peens , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, cocci@inria.fr, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-scsi@vger.kernel.org, xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-mm@kvack.org, linux-bluetooth@vger.kernel.org, linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, ceph-devel@vger.kernel.org, live-patching@vger.kernel.org, linux-sound@vger.kernel.org, oss-drivers@corigine.com, linuxppc-dev@lists.ozlabs.org, Anna-Maria Behnsen Subject: Re: [PATCH v3 04/19] s390: kernel: Convert timeouts to use secs_to_jiffies() Message-ID: References: <20241210-converge-secs-to-jiffies-v3-0-ddfefd7e9f2a@linux.microsoft.com> <20241210-converge-secs-to-jiffies-v3-4-ddfefd7e9f2a@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241210-converge-secs-to-jiffies-v3-4-ddfefd7e9f2a@linux.microsoft.com> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: FFAKPmsOF7TzSfPGY_r91-e9_TqDPMGg X-Proofpoint-GUID: FFAKPmsOF7TzSfPGY_r91-e9_TqDPMGg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 bulkscore=0 mlxlogscore=999 mlxscore=0 impostorscore=0 lowpriorityscore=0 priorityscore=1501 malwarescore=0 spamscore=0 clxscore=1011 phishscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412170134 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: E26C71C000E X-Stat-Signature: emhjdkjdo3i4rgzuer3iz9m5ax4jxthd X-Rspam-User: X-HE-Tag: 1734456655-972063 X-HE-Meta: U2FsdGVkX18U6ldoX7ypN4pDxgB8K9kTStomx4CXWL24R9a0W+MCol3SFYDOvtG3Y+jVJhj/VmfIgYfpMkqUmpSSMyVoIMrA0mLhv9Z2gmSqKujGH5SYAuqUYmDjMY9zulz4pkUGkiZs0cXu+Ibv4IE4cMVhi6KRKNnHBJCBM6tFl+1RJm/E5crqA42nKXAV3zF2od+dGgStbeKvh8ikEWDRlJ4WqVLPa/r40FNiZOXU1ZZUAdUhqPArwIWL2V/60Bz2pb7SWM6hNCwrWMtSSfULYYtFfnQI3Hsv4lo+tQSXLTj21hv6IHzc+lyaeNrGuyNYl2s1XQCPqSlONxTqhQ8SURRpE/4fu6qysJOf000LqBBHfhpyb0txMFJV0c5e5MUfMlGAs9rEPG0b4ikf6imklNSMasye+6xp6i5AN87KYlRF9v6+2DXs5AjTvLU7a4a6dNKdw+wao8J3aoVCgXdVVnqr0e3DpeVxDy4+DoHyzAz/Y+kkDLsgJJdYmy8cvKN3zewey9RVoP6qDhGT0EOkTp6kkeD5gQ6Oqyi23V79DtolNatQ1mqYVn4h/0Hy481NtpMKIE+ZpcN3GFBp1BRRWpo/TxudjrG3D0bc8iz+AvUSExc1LWmzgInHtqwDtN2lCPH9no6SEgz786a995pR3RzQwHVzVb1xijs8Vu0NMoSjIUz2i1YVCrxDrpdCn+hZu9moT8gjteVHZkGYhQeXXmYATg+WHO+UhYh949CsCcWVSW2brJBNZAxn/gXzF7ilGdoQStBnoafaLh95yaL2x/9bemFK7ISE/6cVHD9jlXzvZYb8tCNvaslMQFE4YxF2U6u0B44EgAQ1njvKI1tGtaKcb4ba2fTpTq7lR0/37SLLz4QMExc50QYDpEjkri2QGxVnrw/KSnG8ZkLeWpL/ABDv5p86efFaGnIr0yJC5Okr2bJc+D7F60Kx2QxcY7yoCULWdP6ATbqI91J SsXynqy4 KRmiiWAJ7U2TQ7BG8tHMibiK/Gm6hudurGlgy8085ZZk2vlzYoFm8RdFAeA3jSHa0TcWNx5nMVWatTX+DVKnS+6xr/r7I5RIKh7NFdZEV05b3lcYnyFB5+C4VqLPVG+b5GD6vjamwCPaxo4gE+qsvY4rKIrxdA6IpPZK4SWPgTdc7RdNdu4dV8dKDpcwLNF9WxDq54aeWlhhW3oBi/sZ9j7eDveQwYL0ks2coldXFNssuIbqjjiHJ+QF2pzsM2n4Ia9aV/cHaA7FHWklMnsQxBrIbou9wOJJ0h6vWHUQXL5D5YbeKtAUhwEFknnO2lN7sbKple3/q7S1pA6mQxB5ObD+K6FyJimSJ0SAX5MiL0CZ3nNhpwKwa1XIRZTi1aYYRqT7noZMFdTP6n1kfW4gmLwLkjtW0bsSuuLggdU7QZ+oH7dXzzEjUyEkSSIgMp77mz48SfpQhNj9IjOZGDC9UH6Q9sxLTG+1YCLsisesEt5XqOB4A4+db073joPTR/UlP3TEzPn6+MXVJmrk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Dec 10, 2024 at 10:02:35PM +0000, Easwar Hariharan wrote: > Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced > secs_to_jiffies(). As the values here are a multiple of 1000, use > secs_to_jiffies() instead of msecs_to_jiffies to avoid the multiplication. > > This is converted using scripts/coccinelle/misc/secs_to_jiffies.cocci with > the following Coccinelle rules: > > @@ constant C; @@ > > - msecs_to_jiffies(C * 1000) > + secs_to_jiffies(C) > > @@ constant C; @@ > > - msecs_to_jiffies(C * MSEC_PER_SEC) > + secs_to_jiffies(C) > > Signed-off-by: Easwar Hariharan > --- > arch/s390/kernel/lgr.c | 2 +- > arch/s390/kernel/time.c | 4 ++-- > arch/s390/kernel/topology.c | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/s390/kernel/lgr.c b/arch/s390/kernel/lgr.c > index 6652e54cf3db9fbdd8cfb06f8a0dc1d4c05ae7d7..6d1ffca5f798086160112990cb947ec8deed0659 100644 > --- a/arch/s390/kernel/lgr.c > +++ b/arch/s390/kernel/lgr.c > @@ -166,7 +166,7 @@ static struct timer_list lgr_timer; > */ > static void lgr_timer_set(void) > { > - mod_timer(&lgr_timer, jiffies + msecs_to_jiffies(LGR_TIMER_INTERVAL_SECS * MSEC_PER_SEC)); > + mod_timer(&lgr_timer, jiffies + secs_to_jiffies(LGR_TIMER_INTERVAL_SECS)); > } > > /* > diff --git a/arch/s390/kernel/time.c b/arch/s390/kernel/time.c > index 34a65c141ea076ba97b3238f1f36f077b15961df..e9f47c3a61978a45c72aee23bc44dcb128113c8c 100644 > --- a/arch/s390/kernel/time.c > +++ b/arch/s390/kernel/time.c > @@ -662,12 +662,12 @@ static void stp_check_leap(void) > if (ret < 0) > pr_err("failed to set leap second flags\n"); > /* arm Timer to clear leap second flags */ > - mod_timer(&stp_timer, jiffies + msecs_to_jiffies(14400 * MSEC_PER_SEC)); > + mod_timer(&stp_timer, jiffies + secs_to_jiffies(14400)); > } else { > /* The day the leap second is scheduled for hasn't been reached. Retry > * in one hour. > */ > - mod_timer(&stp_timer, jiffies + msecs_to_jiffies(3600 * MSEC_PER_SEC)); > + mod_timer(&stp_timer, jiffies + secs_to_jiffies(3600)); > } > } > > diff --git a/arch/s390/kernel/topology.c b/arch/s390/kernel/topology.c > index 4f9c301a705b63f8dd0e7bc33e7206ad1222e7a7..0fd56a1cadbd4f41a9876a3a3fec7f5dc08ac2db 100644 > --- a/arch/s390/kernel/topology.c > +++ b/arch/s390/kernel/topology.c > @@ -371,7 +371,7 @@ static void set_topology_timer(void) > if (atomic_add_unless(&topology_poll, -1, 0)) > mod_timer(&topology_timer, jiffies + msecs_to_jiffies(100)); > else > - mod_timer(&topology_timer, jiffies + msecs_to_jiffies(60 * MSEC_PER_SEC)); > + mod_timer(&topology_timer, jiffies + secs_to_jiffies(60)); > } > > void topology_expect_change(void) With this chunk added to the patch: diff --git a/arch/s390/mm/cmm.c b/arch/s390/mm/cmm.c index d01724a715d0..7bf0f691827b 100644 --- a/arch/s390/mm/cmm.c +++ b/arch/s390/mm/cmm.c @@ -204,7 +204,7 @@ static void cmm_set_timer(void) del_timer(&cmm_timer); return; } - mod_timer(&cmm_timer, jiffies + msecs_to_jiffies(cmm_timeout_seconds * MSEC_PER_SEC)); + mod_timer(&cmm_timer, jiffies + secs_to_jiffies(cmm_timeout_seconds)); } static void cmm_timer_fn(struct timer_list *unused) Acked-by: Alexander Gordeev