From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC207E7717F for ; Tue, 17 Dec 2024 17:29:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3B4776B0083; Tue, 17 Dec 2024 12:29:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3637F6B0088; Tue, 17 Dec 2024 12:29:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 203FE6B0089; Tue, 17 Dec 2024 12:29:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 03E5F6B0083 for ; Tue, 17 Dec 2024 12:29:36 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9B2DB80894 for ; Tue, 17 Dec 2024 17:29:36 +0000 (UTC) X-FDA: 82905137364.16.0178570 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf12.hostedemail.com (Postfix) with ESMTP id 048924000E for ; Tue, 17 Dec 2024 17:29:20 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=cl9r35o3; spf=pass (imf12.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734456540; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=g1hrCVwsLDHFXBw9S8SSEtW44ND3hIe5hEs7mvzMcv0=; b=jFLLhZyYEEo21PoTjEo5u4D0Ie+25kIO9W0IW0FTAl3ym+zG/BjxJmnngWIEf4pb2VWPOz IIb7roFacWoPFMDXpTGLWNRg5kD7gTidcMfDYuCZx+2WQBe5ewtV6HxiBm+0F5+TtIEuzr DKzJJTeFZT82i+taMFT6EmfV66Ryoek= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734456540; a=rsa-sha256; cv=none; b=U2wRi04vIHT0k8kCPHNh7K0Uikc05k9fMn0QqgpOcSapsPGBU56M4+hqa1R2HBaP5I571h GUCIEyFQskKf+HUcWZuOUl7idMGiiMCGYD0oZ1W9DK3mSDsDX4NJpJaxmESkPhDSdfHxqT 0DfJivAazWi5dDikQN64iTxOvD17EsQ= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=cl9r35o3; spf=pass (imf12.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BHHJOLq032407; Tue, 17 Dec 2024 17:29:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=g1hrCVwsLDHFXBw9S8SSEtW44ND3hI e5hEs7mvzMcv0=; b=cl9r35o36KsL7jJKYCoj5LWAqgbCAwKQJ20PeY0lNPC00K Wb2kXbck5OilzEheJEhO1UdwI+su1vwZEx+ymJ0mFVZPhk383HWoO7VUfjl4QPyC NRZU5GuH7HUeI7pIrbgheTo3G3YyL9iJUTzTdJ2rQy11ZZUXxk/oz1ZsT4ro/HXW RF1p1weL++6yCLkAsXqi4doi+5uKWL9CuTqE9RqoY9qtQhM5eVDQSPo42O2F/pZf 1E2hEAM56w/Zk8qrE4sU++MACbkaEvxnTnuSkGX19AfN+yNNhecbQM6ZfMsHhRv0 9OFeYY0UtsvX1JEiQmcTgZp6vrtBDv/o0B5nndaw== Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 43k5g2jmnp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 17 Dec 2024 17:29:14 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 4BHDmDdx014412; Tue, 17 Dec 2024 17:29:03 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 43hq21kfhm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 17 Dec 2024 17:29:03 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 4BHHT0u259441574 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 17 Dec 2024 17:29:00 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0EEE820040; Tue, 17 Dec 2024 17:29:00 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E39DD2004B; Tue, 17 Dec 2024 17:28:58 +0000 (GMT) Received: from li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com (unknown [9.155.204.135]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTPS; Tue, 17 Dec 2024 17:28:58 +0000 (GMT) Date: Tue, 17 Dec 2024 18:28:57 +0100 From: Alexander Gordeev To: Easwar Hariharan Cc: Pablo Neira Ayuso , Jozsef Kadlecsik , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Julia Lawall , Nicolas Palix , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Russell King , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , Ofir Bitton , Oded Gabbay , Lucas De Marchi , Thomas =?iso-8859-1?Q?Hellstr=F6m?= , Rodrigo Vivi , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jeroen de Borst , Praveen Kaligineedi , Shailend Chand , Andrew Lunn , James Smart , Dick Kennedy , "James E.J. Bottomley" , "Martin K. Petersen" , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Jens Axboe , Kalle Valo , Jeff Johnson , Catalin Marinas , Andrew Morton , Jack Wang , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Greg Kroah-Hartman , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Xiubo Li , Ilya Dryomov , Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Petr Mladek , Joe Lawrence , Jaroslav Kysela , Takashi Iwai , Louis Peens , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, cocci@inria.fr, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-scsi@vger.kernel.org, xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-mm@kvack.org, linux-bluetooth@vger.kernel.org, linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, ceph-devel@vger.kernel.org, live-patching@vger.kernel.org, linux-sound@vger.kernel.org, oss-drivers@corigine.com, linuxppc-dev@lists.ozlabs.org, Anna-Maria Behnsen Subject: Re: [PATCH v3 02/19] coccinelle: misc: Add secs_to_jiffies script Message-ID: References: <20241210-converge-secs-to-jiffies-v3-0-ddfefd7e9f2a@linux.microsoft.com> <20241210-converge-secs-to-jiffies-v3-2-ddfefd7e9f2a@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241210-converge-secs-to-jiffies-v3-2-ddfefd7e9f2a@linux.microsoft.com> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: fnzByXeLFO0AZ_AJF8SbPJqhCHN_hCrL X-Proofpoint-GUID: fnzByXeLFO0AZ_AJF8SbPJqhCHN_hCrL X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 bulkscore=0 phishscore=0 clxscore=1011 priorityscore=1501 lowpriorityscore=0 impostorscore=0 suspectscore=0 spamscore=0 mlxlogscore=985 malwarescore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412170134 X-Rspamd-Queue-Id: 048924000E X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: km7imbye16fizactmrj6bwxt1p8t5guu X-HE-Tag: 1734456560-741675 X-HE-Meta: U2FsdGVkX192JCMW09eGNFQAik96V3AABv1AgHIcV+1zq+rRf0PCGY+i/+6HfmEWWqR25XAe1ZeNP14wZBAw4LTeWg+zfOQ7jLKoXTA/0wfEc9M5YHqWVLterx94jAFW6WbvUf7ZnLjjeGXZRg/8DeEFqHMsumbjagVII3Eys00R4iaEwHhOBc4uVEQQRXEerJjmBd6JC3gc+3rSpfZ8wn2G1E7pJFnPN22YKXJL3vYqseqAj3dzJyzV4eDE0MEpzbXhwhktfP2EXwHY7UTgUC8W6sf64OI7ZvDsfxH+BIUhp+eIgM5ut/Zph0TVHarAlCUEEzL9CMBNaGicVF9hXzFwg3ETi4d1mSGUpHo10NfaQchz4+n5SoHPIjPYfIqqWiTsKluMCGCPmLvq1BU5LaNjc1ssYZw5SFjgGA1PRkPDnxa1EgFhSTaU3oUTt7d0qGCzjDccl1/WpKZM/5xeqQDNwR576ewVY0l4eooqLwryR8WYEPaU+qTJGz6anNzglX/0nXc0+rhNhvWQyDe4UAQqZM02GiHZw7wj7Z31l1Ngfy3UbsTnaVsY7SFCPwMD5dw0pghB1H7V4gBjMp4USOitW4711c6eAhTCBdUasDPZECdycV5SAqRKbuo8lzrK/Oq/qJANEEjC2aNDL+nq6x8DWgFrgfJNKMEM+edxJAHfNqtSo1j33qsX87huqhNzFeSnKiXiRGHcdTiXlAqfm0SDmL0Y3bn9QyrgjgwYPJC/Rf4ixH3JRHioSZRi1y0xQjDo6hsvZQZQ/HhovXNgT/Q4twNleodGKnmH9iVkTfkmExjCnkoMegCpru6p5YwWPSr8TCvFFyXKMXcv/ncJR9g5XgMk5cVenpMjUy/biIkIciulaRPxlraErBRpC6WxvJZQsvl4djA2lsW+kBF+AunD0dpDJLXhtLPPpirD5CRUXmJiawd0I9+zMOrDrtWKI5G6GsIhkPHGG2MRcTn 3kyD+BpR z7NtTcEz8jEDbtJf9dyuEhFmFYC15LAtu/oKrUPA5FhHrq026hZsZSdNKxUqCWcwgAYnnG4xNL7DdZgDPJpyZVmgSQvpbb4+Hq5tqBp6HS1Q0pxIRVLZM9CTo/k/Q2vEGJrCCMpiHDBod5xG/JNv8FroZWqBVFWxUEJ5r4+9Xfg/+qD6OsjoYRRrik8q8DHMhSWfC8M8dsa5sqYs4deLNNMr3hMJbeLKH9SwULqHu/QvMffchR2WYcv3ehKpjYm3j9hNSDkrCmmqUxr9WVI2NqE1DKf6MUX0u6HU7+qud/dPeKfQTK3EdoDFSBQLPGLSFz2ddnSFZtDBUJW3Fy1vXYyGilGa2Bh6Jyf5CQJvUZZ2Z64K1YKrX1tt30veZKT7No1VENCZrM8jX2P6jgSM805tqlet8ddRV4uNrJEn+1Bdgn0rYzRA6UMxtebU3jnmtE0ZKC3Xa/7+Nh4B5z7hLtJpuEnYuvYZ0f9a+ykdoFZUC/chGTzj94mdqEg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Dec 10, 2024 at 10:02:33PM +0000, Easwar Hariharan wrote: Hi Easwar, > This script finds and suggests conversions of timeout patterns that > result in seconds-denominated timeouts to use the new secs_to_jiffies() > API in include/linux/jiffies.h for better readability. > > Suggested-by: Anna-Maria Behnsen > Signed-off-by: Easwar Hariharan > --- > scripts/coccinelle/misc/secs_to_jiffies.cocci | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/scripts/coccinelle/misc/secs_to_jiffies.cocci b/scripts/coccinelle/misc/secs_to_jiffies.cocci > new file mode 100644 > index 0000000000000000000000000000000000000000..8bbb2884ea5db939c63fd4513cf5ca8c977aa8cb > --- /dev/null > +++ b/scripts/coccinelle/misc/secs_to_jiffies.cocci > @@ -0,0 +1,22 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/// > +/// Find usages of: > +/// - msecs_to_jiffies(value*1000) > +/// - msecs_to_jiffies(value*MSEC_PER_SEC) > +/// > +// Confidence: High > +// Copyright: (C) 2024 Easwar Hariharan, Microsoft > +// Keywords: secs, seconds, jiffies > +// > + > +virtual patch > + > +@depends on patch@ constant C; @@ > + > +- msecs_to_jiffies(C * 1000) > ++ secs_to_jiffies(C) > + > +@depends on patch@ constant C; @@ > + > +- msecs_to_jiffies(C * MSEC_PER_SEC) > ++ secs_to_jiffies(C) If you used this script only, then it did not seem to recognize line arch/s390/mm/cmm.c:207 mod_timer(&cmm_timer, jiffies + msecs_to_jiffies(cmm_timeout_seconds * MSEC_PER_SEC)); Thanks!