From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25396E7717F for ; Tue, 17 Dec 2024 12:54:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 815716B00BE; Tue, 17 Dec 2024 07:54:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7C5226B00C0; Tue, 17 Dec 2024 07:54:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 63E786B00C1; Tue, 17 Dec 2024 07:54:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 467BB6B00BE for ; Tue, 17 Dec 2024 07:54:40 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A0B3A1206EB for ; Tue, 17 Dec 2024 12:54:39 +0000 (UTC) X-FDA: 82904444490.04.856AA40 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by imf16.hostedemail.com (Postfix) with ESMTP id 6F4D8180005 for ; Tue, 17 Dec 2024 12:54:06 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=XbzqkmoR; spf=pass (imf16.hostedemail.com: domain of mhocko@suse.com designates 209.85.221.42 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734440049; a=rsa-sha256; cv=none; b=LWhM4Nq/59GRt2U6LCUcuWgZRDki297ij9fCyiulJ5/AsjWGBPCg5YDCIehbN35M24N3Zw aaByzz4cIBiFW38OtK296/zirekLFBE2fLmHZOxy1JxXcpoMoFGynz3g7OPcaAtvyc2Awb y95RZ5TFkLt7B+09zEUXYWHa9K3Fkxw= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=XbzqkmoR; spf=pass (imf16.hostedemail.com: domain of mhocko@suse.com designates 209.85.221.42 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734440049; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wNJH0bZIRp/lLbJRiuys3BD3sasknh5mv0Tb1tCrHk4=; b=fBDJEJgvS+fOAKiitRaWq0yKjQKP8y/IpzBJ5OJSiGqPc3MaIPIl8G1lJiBT+LZtjkAKDP aEWKgzUiL1GN84vsaJFvpP80/TIv0lPDpXrmKDC3alWXRMpswJKGhFlBYf4Wfj/Thr6guR WhKDD79n+SXs+6T7/vHYusj0VYq1f64= Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-3862ca8e0bbso4495991f8f.0 for ; Tue, 17 Dec 2024 04:54:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1734440076; x=1735044876; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wNJH0bZIRp/lLbJRiuys3BD3sasknh5mv0Tb1tCrHk4=; b=XbzqkmoR8f2HGhpctBMKacXQQ6kmF7uqXAfcpWNrMUnVAJQbFYLZnVN8akX5OXMfHq do7sxj4En5PXDhOD+V2dG4AFfww/bCrtiemrZ4zR+I0EBM9jaC5UXCRQH1AyL6vEa0bF bQ7kHP9Q6wkzvrubzJ5ionqfBrgDr9pe4zMzmGs/ye4ieGukg6xs3Xgi+N+Kh1DitefC SNl72mHDfiXyytGX4Pm63fd3+PDndt65GEvtmy2cXTLotC1N/9H2kfUzy6st2Nkhok4z Ry3DXiJjUkNOGIBer8IhQiwdK94+QDwao+fL69qQn8daZQOsW1EupIsmauA21jukpPsJ tz6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734440076; x=1735044876; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wNJH0bZIRp/lLbJRiuys3BD3sasknh5mv0Tb1tCrHk4=; b=LlLifWk3oEwpLY2nyamtwFZCUtwoQ3L5zTtSVFI68ww68cPSPKpx9VbRWxSVmCA5ez 4ycYNiaCvqvb7xy4qUv9VIoaJof9ah3HCLvQPwlWFVFQZEclEGs48Fb7P9njytzdVIFJ XHQyCypce/+bm3ApvwKvU7QETUEET5iyF9/fbubkuOXJRNgFaodW4pvHwbehOKs6VwE7 /fJTdS9BrKH523H6aNq7/ZKfujiUo5iX74s55jqDHj6Walwzct3fok7JnHI12uCtuQ4b 1eQfRW5sfKkQ5s4Jo5Suln9Fe9ujLID89fjNYwWEBSGS8pldppA14VI5lvOrl3erRrGq APVQ== X-Forwarded-Encrypted: i=1; AJvYcCUtWCjjTGxv5PZGmwP4O2kE21xf6j+PRH8v4eIOcNL/QvQ1yTQKw7DnDf7CrCLNHw3kF/Nbq/tSAg==@kvack.org X-Gm-Message-State: AOJu0YxcQ7vmYfpvvSFRrJVufDQ5zsiL+iMvyZcpMUUaHkjtcMxifigW Pvf0rQ1ciAOFFVnxc/mli+M1CPj4/N/W0t+TQkq3vSyx7LBHDEg+2rXHfAPdkxY= X-Gm-Gg: ASbGncsqfhKY/bbBTlQOavPsr2iiRe6w1DDUj9XxZzOdA47L5tPstEDWl657dVqZKYi 6bwurb6SKExaDZlKIswlnY9mGipFEsFVzIj5oKZRKOZCSaJt3Ldi19hWZRiR37iUtz7oconyPOg U/fGvRDY6uin7n7CLmPPwVxHn7Cqaz8RrDaBvibsLidteR674bp2BH0aB3EALFrCMeiG0hi/YM2 yaVG0UUbbBsClJkRRfOS7SJjurtwJKpoJNNISsy6u5lbR1BQmP1LIHshnZ45KHwX4g= X-Google-Smtp-Source: AGHT+IGIkCksbdZEfvo6ki5xx29/1TnH2HLfVEMtjsycZHejT40HWMLMjlwqoedRINBd6o/828MIhA== X-Received: by 2002:a5d:5886:0:b0:385:f66a:4271 with SMTP id ffacd0b85a97d-38880ac61f7mr14775811f8f.4.1734440076073; Tue, 17 Dec 2024 04:54:36 -0800 (PST) Received: from localhost (109-81-89-64.rct.o2.cz. [109.81.89.64]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aab963cdfa5sm442501466b.199.2024.12.17.04.54.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Dec 2024 04:54:35 -0800 (PST) Date: Tue, 17 Dec 2024 13:54:35 +0100 From: Michal Hocko To: Chen Ridong Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, yosryahmed@google.com, roman.gushchin@linux.dev, shakeel.butt@linux.dev, muchun.song@linux.dev, davidf@vimeo.com, vbabka@suse.cz, handai.szj@taobao.com, rientjes@google.com, kamezawa.hiroyu@jp.fujitsu.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, chenridong@huawei.com, wangweiyang2@huawei.com Subject: Re: [PATCH v1] memcg: fix soft lockup in the OOM process Message-ID: References: <20241217121828.3219752-1-chenridong@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241217121828.3219752-1-chenridong@huaweicloud.com> X-Rspamd-Queue-Id: 6F4D8180005 X-Stat-Signature: 37m8a5yn3obnzg6mk7733dehfs9k54ty X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1734440046-182630 X-HE-Meta: U2FsdGVkX18/XBnNLJW3NiflqOmU15090RsL/sqvYju0GageNA0jt/Yb8C78q0/TvxDHXcYnjvC489rgeWC3nL7gnIhVMLGCcixZKLha9FPspibCJzXI4hOkdo1GB4xkVEB/xsJNZYWMAdgpq4S9xQWDWo/hgw/G4sEcpnWHD4Y5YrxucAQoJYxJEoRudR2EuSWAZt+S3Po5HMYvT7iRuLGL9RcMqnq7oghIVW80LX5L6CJ5+h0O0RY9Ou4h91eleSxzGb1bv/YWEJCPkawjR/aQSAaDOFXrtFC3YFZkL9cMpCeBFWWt/1cLfsqXjnqIy1vSMjtX4qwODQi/nrtk9VhZ/tll5i66cyRamFjN1x81XlHAEkT2kqlHQR4ydBMNIdIN69YPHf1GioqGymkf1EdLnB6PXlbjx/i/hV57UpWeVUFcLsXD/UmgwtD7X95f8r84yZk4aBmnhK1ICKip7IF1VZqwwQAQJ7+mks9rnpOE5u79ZaUzIRij3Atz5hsjBtL2t+U/T1+dtFIAKAkrwu1O0Fia7vqgWb/sYFLHMHZQap0rJnohapkb/wVHSsNAdShr9y/H5ypqJDi9BUtlMCA6a3ArkIELZkjNIvutY18J3BUgCj0kRyndWuPjlo2TyBYmw1NZoRo34aQWbQ8RUzGn1i8sk55hIjn42IBqrUpIJfMPQuc4cl/oM2jVoPymXAeMDKN/9Wq9spEBMQnUjg7Q1QRDJixVd6ctODSOtRsDtpuHL8dTy69vWaEUTvgkUgEifWez3PbR7htphMf+M1UE4mVmrod3nWeh+vFB+OCUOZl5kZFEHrr45SwG+LLs5p6f7cokiO8Cv9smrdRfnVEXZav78Nt4PBbGpN0/qqAuDPdKnWJS1h+B7JLL++ejevP+k3qa7U0q5XjNqHHoRW0zYkg8hPTEFAdIi3KamhpOXq3EiR9o++m8sEyREMKxuJhYk6XWphIGvCnEn2x crXVobpj f4zjCUbe9Oe2Vw9JGqX52pH/hLUK7f+wje+WDNMLXG6E4HTiwFTcYM6DR9egZre6WdOIuPvExd9XFDLOerwf3SuJPtcOr4p1Gtm/WzAXI6NUR1wxwFYmokBqaqU/qxfcA4h98rdvcGZ71ZeDhQCCgAlhCBOvYawET1UVPs9YmpZHDqhWywLHgwl9QhSslTNK4ETwFQK8sEg1mClNH7KBqoSQ9T9VMSzistmP3OX66cONJ4IXFFZvMmUsfSvCXAMYdbQFX7cFw2flaigibE7IyzGRZZ3MVr7Zjz4oN0sljmqrpYc+y5oOpGBy4ng== X-Bogosity: Ham, tests=bogofilter, spamicity=0.311898, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue 17-12-24 12:18:28, Chen Ridong wrote: [...] > diff --git a/mm/oom_kill.c b/mm/oom_kill.c > index 1c485beb0b93..14260381cccc 100644 > --- a/mm/oom_kill.c > +++ b/mm/oom_kill.c > @@ -390,6 +390,7 @@ static int dump_task(struct task_struct *p, void *arg) > if (!is_memcg_oom(oc) && !oom_cpuset_eligible(p, oc)) > return 0; > > + cond_resched(); > task = find_lock_task_mm(p); > if (!task) { > /* This is called from RCU read lock for the global OOM killer path and I do not think you can schedule there. I do not remember specifics of task traversal for crgoup path but I guess that you might need to silence the soft lockup detector instead or come up with a different iteration scheme. -- Michal Hocko SUSE Labs