From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C854AE7716A for ; Tue, 17 Dec 2024 04:32:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5E2466B007B; Mon, 16 Dec 2024 23:32:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 592886B0082; Mon, 16 Dec 2024 23:32:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4801F6B0083; Mon, 16 Dec 2024 23:32:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 298026B007B for ; Mon, 16 Dec 2024 23:32:54 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id CD5951A02D3 for ; Tue, 17 Dec 2024 04:32:53 +0000 (UTC) X-FDA: 82903180038.11.3D15CE8 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf22.hostedemail.com (Postfix) with ESMTP id 9208BC0004 for ; Tue, 17 Dec 2024 04:32:20 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Oq3OoyoJ; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734409944; a=rsa-sha256; cv=none; b=Nj0uZj1akt26kareLRukJVvdwZbNy9Eelt4JLEYlnZQTfHzxZa9eiAZNheRgQxuRawkG/g iCynxKtzNq9oPpe6jRV1cFdugsTrSBDr8pjea/tgqcisCrGYOXoAbHYYYk38YzS0qbIMcS y3cZxP8o4nYgp7iryXPw7R9JCfPpBFI= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Oq3OoyoJ; spf=none (imf22.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734409944; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mwdKcfCFIULPvQgRme/rxFTQjrctWSSEqgxMd/sJ7Qs=; b=wQwUG1kFOIBLmiUbIvD47V3lTHXvexNF1C0va4mpazf5xnWc9xSMPL6EXyE58e5+EdbU/O 0dX2boWtHBfTxguhVJHBi3vWwrQODbM8fcxlymAGHTLY+MH7HsODQ98DU5p48Te4jxicph rLt8lApcUdeW9GBZdhWd7OmYvvSwla0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=mwdKcfCFIULPvQgRme/rxFTQjrctWSSEqgxMd/sJ7Qs=; b=Oq3OoyoJb4z382imCKiKPnvw55 0BqkqdrwqTdwvGm+Z1Foeq7SbgNMOsVz1Y2ruScOLmYNY5GKmtxJ2kC7lUJrra9q9jpr9dlPsYPnZ V+T4bpWFuLoOcOC/ZiTsGnYqyNGZVmAF+rqWL5Egst1mAMyu2/JGw/h0jxJJnrvKk/FDDsG2jm+ND TmpDgJhZvQQW5ChogL0vEN53ZegPY9vTabil4ErCOJ/dnnThSvHipSf2+21TBkiTMWgaxIsfAVc66 3b6FqpO5m9poz8WnN4mlmhej69pa829qRA4FQtHLCfVNM+CdRmlOdghLwd3fdm2gsfXcxhDMNbiOx ZvV6FVHQ==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tNPGB-00000004pWG-3AEd; Tue, 17 Dec 2024 04:32:39 +0000 Date: Tue, 17 Dec 2024 04:32:39 +0000 From: Matthew Wilcox To: Dev Jain , g@casper.infradead.org Cc: akpm@linux-foundation.org, david@redhat.com, kirill.shutemov@linux.intel.com, ryan.roberts@arm.com, anshuman.khandual@arm.com, catalin.marinas@arm.com, cl@gentwo.org, vbabka@suse.cz, mhocko@suse.com, apopple@nvidia.com, dave.hansen@linux.intel.com, will@kernel.org, baohua@kernel.org, jack@suse.cz, srivatsa@csail.mit.edu, haowenchao22@gmail.com, hughd@google.com, aneesh.kumar@kernel.org, yang@os.amperecomputing.com, peterx@redhat.com, ioworker0@gmail.com, wangkefeng.wang@huawei.com, ziy@nvidia.com, jglisse@google.com, surenb@google.com, vishal.moola@gmail.com, zokeefe@google.com, zhengqi.arch@bytedance.com, jhubbard@nvidia.com, 21cnbao@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 05/12] khugepaged: Generalize __collapse_huge_page_isolate() Message-ID: References: <20241216165105.56185-1-dev.jain@arm.com> <20241216165105.56185-6-dev.jain@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241216165105.56185-6-dev.jain@arm.com> X-Rspamd-Queue-Id: 9208BC0004 X-Stat-Signature: fce1hfzxegsx36n496ob5ye59fid9mdg X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1734409940-774333 X-HE-Meta: U2FsdGVkX18CSqCXD9W+a567HVPmx2gCIxYSnMPiSEC91O+BelvpZQnFeMZ+EsM+/+TdA/XvYUNfLVF3CQfY8GGmp6Y9lUkgyyD+GFpANwkQFtqSH8doeOqzP1efe/zDbA4ERT4UKXP+6eV93xVv8QuXyTNjjZM5hSr6t/afLgtNujDgeHGvoBRNUY++85Cbn6DS8kV2kMTlDa3qzu4VpN7IUy2T8HR0qapDtxJ09I/Gl86Zi6v6pAX6zCVI93VGuLGwhfTSFZzBpV8vjygIWtGaXh/HZ+Gy6Q0pV1ZF7sYtm54NlDeR/XZZ/GVCyr0R2BYjKaf4s5NgffZuL1CJp3+xsFO8hpmgVB9YHUInzta8xj5B8NJ6/52ZdSrPDUi0P+paKr3iedUVqjCJ6wWkuNBij0+YG2pWNFcSe0VHJRm6E7AOyHMabkjVac0WYWwG+oOAJTeGEY7UAyMVWXAlpTsDJj50M2oE7gQHe39NqYKXxexQ9zg7i5ypyTD9Jg1F+Dpj03QZDIQjTvFZECBKZWwk8+EOXyqcv7ZAbn4Y9VZNwCwa749W1vlVte1gisI0Z/ORlpkLjuc5nmhNh/UpmpFKsssqa0u/LtgaT+7P/vkNyRaUdoUXEVi2opREGtVP/UYmg6+MFJHgoJKJoyd9A+xpClVAZ4upVM6bOlBm6hxSRTgk60tyfj4YtWFVzIK7bjK8O8nrRTfDaKZcA3SD6lSpyw3nxuVe4H+KYBHh0kvFvTRYUDVxJvczYkoXHvg5COFXeHezNHAxrdmltS/Z4o2HVtYGgM8ox1F789zMOZ4lGu/+tc46S7hpbw8Q1R4+Iglmj8MAcsMylxLOjd+jKm9JD+NBUf3POeCRhCZ2kV3r5keSTH98IZDdRiHwwiFrrYP4b1bFcWB6wmWHtH0VbRFJyRfQmGpit3D8aVuevFkdqqwMaQXh901gB3NOovwgJqpp1bIQfW2ICCdFC5y uagMQ+dm /WM1RkQbzsaQBsGIw02B+jIOZbaYlET7lqd8ZF1HjED0+gtAnIXGxQEb4o/kraT61EjrjJOgSvFDjQDPskyjkDW5sTrA1cSBzuV9b7reQDTQBWGzEQy4+jyesrsB39g3dibas7xO/3xaDVf+pc5HF+HYg/4roRmDshZJQo3Sf1ZDFs9mtkMzMlhWTOR578egzpREJLMpBXa5DNlUh9hROJxJ4ydggTBn16Gbq2HWZtqdRwiXilf2ljWTNhqzrR3kMoSDbJyw24vzLybitRTv485feh/xYonRfKyLV67xY5NnSFHigHvj5U7eoxEy39oxY2bk5qWPu9i2sdSPFpMNQHX2Pn2d+6zR0P7oA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Dec 16, 2024 at 10:20:58PM +0530, Dev Jain wrote: > { > - struct page *page = NULL; > - struct folio *folio = NULL; > - pte_t *_pte; > + unsigned int max_ptes_shared = khugepaged_max_ptes_shared >> (HPAGE_PMD_ORDER - order); > + unsigned int max_ptes_none = khugepaged_max_ptes_none >> (HPAGE_PMD_ORDER - order); > int none_or_zero = 0, shared = 0, result = SCAN_FAIL, referenced = 0; > + struct folio *folio = NULL; > + struct page *page = NULL; why are you moving variables around unnecessarily? > bool writable = false; > + pte_t *_pte; > > - for (_pte = pte; _pte < pte + HPAGE_PMD_NR; > + > + for (_pte = pte; _pte < pte + (1UL << order); spurious blank line also you might first want to finish off the page->folio conversion in this function first; we have a vm_normal_folio() now.