From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C509CE77183 for ; Mon, 16 Dec 2024 21:46:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 105BE6B00A8; Mon, 16 Dec 2024 16:46:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0B4DF6B00A9; Mon, 16 Dec 2024 16:46:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E4A246B00BE; Mon, 16 Dec 2024 16:46:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C4B066B00A8 for ; Mon, 16 Dec 2024 16:46:32 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7830A41417 for ; Mon, 16 Dec 2024 21:46:32 +0000 (UTC) X-FDA: 82902155952.05.59BBC15 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf14.hostedemail.com (Postfix) with ESMTP id F3451100015 for ; Mon, 16 Dec 2024 21:45:57 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ovHyIWwL; spf=pass (imf14.hostedemail.com: domain of mcgrof@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=mcgrof@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734385559; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jQkWoZJI7dfOL6UUfAVacYNrINyXmRGMrRRAdOedRmU=; b=VGNxqheq3j8jRZxWi15F0SFF28cQTLrjOvaUw/hB+gIjqiDLjyl5Zo/uEQ22dsNnjsNeiB IS1KklOhgCYoRc3nmLplwG+K2BQ9UUqHV5ZqW3FUekOS1NBEYhTl8exq13t+hF2R+G8FxR ioHkV+h5gQuecZ1t+zs5UGekmfQVbb0= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=ovHyIWwL; spf=pass (imf14.hostedemail.com: domain of mcgrof@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=mcgrof@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734385559; a=rsa-sha256; cv=none; b=afyhB8LVLTvCENGE1fEPBadJiwq7YbOuAOurVYtwjuWiv1jaKjR50i52cP0fmMVIHfI1FC 6znWtXzxc1UHKjbC4QJ9m+gWPrtb3ReIYG3v5I1zpswSLXbgq5GSUSeqTF3t97yJvfB2bd PGCC6uSXIIZs9yuLOEpO84AVdRU8a1A= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 42BD4A41A73; Mon, 16 Dec 2024 21:44:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2D196C4CED0; Mon, 16 Dec 2024 21:46:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1734385589; bh=zVoa/3Oc5FzS+EfNO9uf7upvkjncYUhVe8FspYxQz0c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ovHyIWwLQVRPv9DaeMkNyocG87kBANi07qRqLesaOz+3eArdoGEUnfr25PEYT4qfr NeOkL47ZrQfAKxt2gvH0rTccMi3cyne/v8H4zs9hFo1vPKIpPBrkr9nhDSsogFmFTW HFqdFJdAxFB+9Qm/dKqzpaogSOs7W69TVNTqUmaxU723xAnviAj70dIKvPxEKC4K2c 1+ie53f4tgO95INdj1LngPqapMxppyL5//8Gb7ePQZtr+ZcNBg8kE9LSWTxuEAxtJv rUOfGMGg/sj7MRwXSi60gSdkldoemEHoSJuQ4EQU9/SLKwmfIh57dpJStL+mIuWiMf +iLYqg3qh1SDw== Date: Mon, 16 Dec 2024 13:46:27 -0800 From: Luis Chamberlain To: Matthew Wilcox Cc: hch@lst.de, hare@suse.de, dave@stgolabs.net, david@fromorbit.com, djwong@kernel.org, john.g.garry@oracle.com, ritesh.list@gmail.com, kbusch@kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com, kernel@pankajraghav.com Subject: Re: [RFC v2 02/11] fs/buffer: add a for_each_bh() for block_read_full_folio() Message-ID: References: <20241214031050.1337920-1-mcgrof@kernel.org> <20241214031050.1337920-3-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: F3451100015 X-Rspam-User: X-Stat-Signature: gwn3y6uqzf5dfjgfief6po4w6bjqwb17 X-HE-Tag: 1734385557-916914 X-HE-Meta: U2FsdGVkX19n02/R4mrlayrr32tLO3lngTx9/NN9FZDVChPD/tabWFP/FCsSm/McmbJPaIU5Cf/A+HxQsnsGt5tLuFz8O5b3V63FwPV89/Hvr9DAdaCRTTTSsSLvgDJ7fNEVlggA7gb6gNfhKSJ0NkclMZrml7xsux1DvHHLvd8U4qNroEfpY1hiM6uKnNQJUweTMSwi/9LIHWVwcJznQupSQwTYzArU2Z2e9d26IW3U7uvjtdEOfhVxR000tF++N/UG16RtLUw3R3rbDgsrbR0OZNUKa8DrwL+33lebRnPFJOWUKRLRcKkvMHCCYkA0VpaIanMw53ckiZSFFm5vqGAI0VbEzGlyiKOzP4azztZ777RQcqiLIZogtQ8P2bsEoGMBxYCUud8NlecY+LXuGzSQJpXF5Nkoy2TNlIJ8/2K7EphV25vVQS0URkjWpqyHLaJnNcfQht8Xa44Q68xP2GHvRDZSeDp+YmstNBZECwna9AG62SD8fBJpoaTOCevNWJ/ZRz+8sNQ4lfHSkjakM8DNCDy4uRggBJYvC0IXl0wvgDZhGpkWYaV7HB6rOVdSyRm/XLDIp3Qd8FiCu7UxPmltGTKF8LtmlNYf+4hcuY+TwCL9kdWCqKBoVcrrIHubv1pMKuiVDZ74Ghbkx6xiawJNyL/5rhudKKs+Cu2xhYHpW8HPPVgwzpCHRNsENChfm0lA8mV788tG7H045GMZfIRSrBxKyLPszX4Fg0fDkuiJI1P5rmuMp/Nvg08HIz8mwhaMsOjYgt1dQ7uzyDxnELnDLqee2zgbPkIHPMY5QRQxqStfLWpjQpRp5No9xEtdIRc5ivJY9UdMmQUjD5ovtEp/UMcDV3gSA4FMOEqxdCiCPW30J9BeWP8ooBS8CtZ2CO/INKlbyjSgI6F481F+cy+5lb89EtnAAnmcJ7iM5hdt77gQvGF1dBtklIx5Z2INOA0Ff3Y/shN4phf2IYy 3t/zXj3O 3pYoCvpHfB4y8S+5z1S94snGIbLLThLuIf6Oo+nIFsLncoVkdGy7SEgX+VocI7LK4Q88jTha3aavL3++wZ6isPdXEH782LDyKL4OfguA4GQqy99ytxeRZJr/SE+9zRRpZw8IhIsNKODx/dkTuprfZR7La+fheZSQ/FW31A9yGEsb+aeukelkhc62tdMQK5ORoTH9vc691rqB89h/oEcyLG9p7pAeqaKKdZ1AIJijcNxDxLZbuQ868qgxoemUMcctHiJCIqwKm0MpcK0MB7ZTTBJgWKDO4GO8T8Jse6txU/U+ltLHPzolL/LrydDSOSF0Q87VLOeRnEGxSr0k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000170, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Dec 16, 2024 at 12:05:54PM -0800, Luis Chamberlain wrote: > On Mon, Dec 16, 2024 at 10:56:44AM -0800, Luis Chamberlain wrote: > > On Sat, Dec 14, 2024 at 04:02:53AM +0000, Matthew Wilcox wrote: > > > On Fri, Dec 13, 2024 at 07:10:40PM -0800, Luis Chamberlain wrote: > > > > - do { > > > > + for_each_bh(bh, head) { > > > > if (buffer_uptodate(bh)) > > > > continue; > > > > > > > > @@ -2454,7 +2464,9 @@ int block_read_full_folio(struct folio *folio, get_block_t *get_block) > > > > continue; > > > > } > > > > arr[nr++] = bh; > > > > - } while (i++, iblock++, (bh = bh->b_this_page) != head); > > > > + i++; > > > > + iblock++; > > > > + } > > > > > > This is non-equivalent. That 'continue' you can see would increment i > > > and iblock. Now it doesn't. > > > > Thanks, not sure how I missed that! With that fix in place I ran a full > > baseline against ext4 and all XFS profiles. > > > > For ext4 the new failures I see are just: > > > > * generic/044 > > * generic/045 > > * generic/046 > > Oh my, these all fail on vanilla v6.12-rc2 so its not the code which is > at fault. I looked inside my bag of "tribal knowedlge" and found that these are known to fail because by default ext4 uses mount -o data=ordered mode in favor of performance instead of the mount -o data=journal mode. And I confirm using mount -o data=journal fixes this for both the baselines v6.13-rc2 and with these patches. In fstets you do that with: MOUNT_OPTIONS='-o data=journal' And so these failure are part of the baseline, and so, so far no regressions are found with ext4 with this patch series. Luis