From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EA5CE7717F for ; Mon, 16 Dec 2024 18:56:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F29746B0099; Mon, 16 Dec 2024 13:56:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ED8256B009F; Mon, 16 Dec 2024 13:56:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D51B16B00AA; Mon, 16 Dec 2024 13:56:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B50066B0099 for ; Mon, 16 Dec 2024 13:56:47 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 59A35A078F for ; Mon, 16 Dec 2024 18:56:47 +0000 (UTC) X-FDA: 82901728140.15.57A76C1 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf03.hostedemail.com (Postfix) with ESMTP id 32E8C20022 for ; Mon, 16 Dec 2024 18:56:31 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="XL/8K94b"; spf=pass (imf03.hostedemail.com: domain of mcgrof@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=mcgrof@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734375383; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=E+8+lVFfZpG8KO2E0qnAqGE5h+FKt+PVXV3rvDAOQT8=; b=1op+0XGjrdCn+rmkQru3BJJjc/LvdzWkB3BH7pYzDtbIhHA5FVdWSm5jmWXWkMdn8bIlvI JQKa2VApt/NxEZMlIti0e521sirYGaIGsQjs8FAHHMwAuJ9fA7kZizmFzlivfHWDxYueKO QJjuuQcLqLchMuwpN44S+DHeVUBVV6U= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="XL/8K94b"; spf=pass (imf03.hostedemail.com: domain of mcgrof@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=mcgrof@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734375383; a=rsa-sha256; cv=none; b=vzn1brgKJMHqCVhtjAU8R2Up0zHHhYqPZLMoUcr6zwZCUXlun+f1UoUnkYheYotaglavfS ETWP+q/9QDbDU5vPXd21rhNBm5alCmDvMV88/9Xv11eSWAIiuHTQgmGHl0yHHL0aZJgwNZ vbjbnXxRhguNz4mxujetQYCYkBzSVEA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 3412B5C617E; Mon, 16 Dec 2024 18:56:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A3A06C4CED0; Mon, 16 Dec 2024 18:56:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1734375404; bh=jQqbBOb+E43+hPO1peHJzewU9cr88vaZCS1ujUob/JE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XL/8K94b0BkJs5Mft8XdhrnKfzHUkspUBRWfaLpHGLCEaiKZ9Z7ROiu5g8xtiutXI /OU+wjHGqgxO4Dn/cMgiZJ30IGj/lUa6cvztzC1QLY7mHJTgzzX7lnX/gvOg4e+je+ Y6l1dx6zi+yd0ChVy1ByPoqGM93T3zPORn9cufWae9vG5YKD7HtbBn1+Z8/IZoCEmO uGZZik01l9teWXxCK1ikEXAM8FFnVXlpmt/Z2+IjYn+DQiXa25taIgWwiXXFNI+Wdi ZHXD++EuYFXstkNStmsSjJNow1VF1j699eiXKcR1lObv9SzVk7ul/MG1mxXFbfe3NS 3nf5th2W4SK4g== Date: Mon, 16 Dec 2024 10:56:42 -0800 From: Luis Chamberlain To: Matthew Wilcox Cc: hch@lst.de, hare@suse.de, dave@stgolabs.net, david@fromorbit.com, djwong@kernel.org, john.g.garry@oracle.com, ritesh.list@gmail.com, kbusch@kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com, kernel@pankajraghav.com Subject: Re: [RFC v2 02/11] fs/buffer: add a for_each_bh() for block_read_full_folio() Message-ID: References: <20241214031050.1337920-1-mcgrof@kernel.org> <20241214031050.1337920-3-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 32E8C20022 X-Rspamd-Server: rspam12 X-Stat-Signature: rxfxjrqyfpmqg9oriewmu3fohr1r7p8f X-Rspam-User: X-HE-Tag: 1734375391-61558 X-HE-Meta: U2FsdGVkX1/PEIQTW65/TlPThV0lzMSGpstLegW/5a9sexXEUfyigyIAoe0Xfx49EHOqNfvqORDS3GI0K5aw1FflhsugQ8d+LYn9cv/j45TdmPCgPFWdDCTsXgu6zDiVIzTVdQQUXQMBzkfE9vEVNN19mNzxBXDWC2+GbmN2SMNc3pIDtuwCFUN98oleM6b8HN+xJVcR+Vh0T0D0bOYcDhgz3UvYXT8zaME3dcMLbRXjMxgqynv37wksPke/Pg7QHKbyeumYE8SQOKpISrmVrK5ahg2nRRZHpa8Cwmj28vuF/AKBcScyne523+8f/6saK5IzcC8HtFTM9I4aUSrRctYSknU1kCaotznh6V0oM+zDrXzyOAIO278nf/ih6EoGe4mJcHLyPrFCZkkelCBqAP4vjTEA3/8BSP9KGi3ee2ZuI8GkWO14BNpeN3Wa/nLClbNzYIq+S3ugF3cawDFfwlpk2io3cJiFi1xm+E6jVoCh+gQwUxar0QtI5P8Eim38hBOLifIxfEDqoiry7BRxFHCbRbN71LtfXLmjAqKjtnRQYiqiqnM58HcOj4tzv/2Pk55N1PN7NFCJtl9W6eiGaZ0UNAApyg3WPHOXtOowcIckDcIzYi6Cdg6RgCr1WrzAGw5Mfvk1+qP8b8w7/NO1Nc9pNI6/rURZqkvcUN9NC3/Yls89Kzw5Iitl7kYpU16gxb9MtY546Fjn03gt0ol0vilPRV2M8IajjKob1SqAG1qruS2YK7iozeqP7sZAfZ6PFb22ZodFLaVkoc8QlBs+e6ygNOdNbxFr4ySaFdtTLjJVBIo2SMJ38piSaboX9fNZK3Jm4uwj0taA9B0rvsmU3//5Qbr4N7Nne1BrSItXe3uwqx7SWWtvtDaNDKFkBhJLU04Bftr7t+7VScE6chOQasI4zvg72rtMU2QEBNQqKTZ+YIS5UmjhDS+1OzIdlwL26mrjKwjnmilXd04yaTE HRaQaqxp f6wYOjKFLi54voqptF66L/FdaE4gRrJDLcZIJbZRFdPkmQnRMFArEtWqKVt0SyzBYEesb6H7e8caWM5uGrc6q/BMBRmkQ09zxSJuP9PXlHNMxxCYdS4y97GDehE6vSMZvQMWwG2ANtTOGbrb/MEz9PEcM7XueUcuEU88rIA1gDCgVk1BNfXfZKhhXRfpEnSruIANAqhDyZFDaaOnikvM1wZJKYuldDKKKaBaTVsdLJt7zY322ETQwCN+EuAOGNADwk/ZZBTb1AZMCNFYz5XYmqjwwGl55xS/drWOoWM5UuREwJqpopWcDPAemr98/gBPt4kvcgmSx8cmfY/iKKIq8cZB3/RsnZhzRONocMA5F0QdOIleu/5+IbSgfXVwa1D3Ri8US X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Dec 14, 2024 at 04:02:53AM +0000, Matthew Wilcox wrote: > On Fri, Dec 13, 2024 at 07:10:40PM -0800, Luis Chamberlain wrote: > > - do { > > + for_each_bh(bh, head) { > > if (buffer_uptodate(bh)) > > continue; > > > > @@ -2454,7 +2464,9 @@ int block_read_full_folio(struct folio *folio, get_block_t *get_block) > > continue; > > } > > arr[nr++] = bh; > > - } while (i++, iblock++, (bh = bh->b_this_page) != head); > > + i++; > > + iblock++; > > + } > > This is non-equivalent. That 'continue' you can see would increment i > and iblock. Now it doesn't. Thanks, not sure how I missed that! With that fix in place I ran a full baseline against ext4 and all XFS profiles. For ext4 the new failures I see are just: * generic/044 * generic/045 * generic/046 For cases where we race writing a file, truncate it and check to verify if the file is non-zero it should have extents. I'll do a regression test to see which commit messes this up. For XFS I've tested 20 XFS proflies (non-LBS) and 4 LBS profiles, and using the latest kdevops-results-archive test results for "fixes-6.13_2024-12-11" as the baseline and these paatches + the loop fix you mentioned as a test I mostly see these I need to look into: * xfs/009 * xfs/059 * xfs/155 * xfs/168 * xfs/185 * xfs/301 * generic/753 I'm not sure yet if these are flaky or real. The LBS profiles are using 4k sector sizes. Also when testing with the xfs 32k secttor size profile generic/470 reveals device mapper needs to be updated to reject larger sector sizes if it does not yet support it as we do with nvme block driver. The full set of failures for XFS with 32k sector sizes: generic/054 generic/055 generic/081 generic/102 generic/172 generic/223 generic/347 generic/405 generic/455 generic/457 generic/482 generic/500 generic/741 xfs/014 xfs/020 xfs/032 xfs/049 xfs/078 xfs/129 xfs/144 xfs/149 xfs/164 xfs/165 xfs/170 xfs/174 xfs/188 xfs/206 xfs/216 xfs/234 xfs/250 xfs/253 xfs/284 xfs/289 xfs/292 xfs/294 xfs/503 xfs/514 xfs/522 xfs/524 xfs/543 xfs/597 xfs/598 xfs/604 xfs/605 xfs/606 xfs/614 xfs/631 xfs/806 The full output I get by comparing the test results from fixes-6.13_2024-12-11 and the run I just did with inside kdevops-results-archive: ./bin/compare-results-fstests.py d48182fc621f87bc941ef4445e4585a3891923e9 cd7aa6fc6e46733a5dcf6a10b89566cabe0beaf Comparing commits: Baseline: d48182fc621f | linux-xfs-kpd: Merge tag 'fixes-6.13_2024-12-11' of https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux into next-rc Test: cd7aa6fc6e46 | linux-xfs-kpd: loop fix noted by willy Baseline Kernel:6.13.0-rc2+ Test Kernel: 6.13.0-rc2+ Test Results Comparison: ================================================================================ Profile: xfs_crc New Failures: + xfs/059 Profile: xfs_crc_rtdev_extsize_28k New Failures: + xfs/301 Resolved Failures: - xfs/185 Profile: xfs_crc_rtdev_extsize_64k New Failures: + xfs/155 + xfs/301 Resolved Failures: - xfs/629 Profile: xfs_nocrc New Failures: + generic/753 Profile: xfs_nocrc_2k New Failures: + xfs/009 Profile: xfs_nocrc_4k New Failures: + xfs/301 Profile: xfs_reflink_1024 New Failures: + xfs/168 Resolved Failures: - xfs/033 Profile: xfs_reflink_16k_4ks New Failures: + xfs/059 Profile: xfs_reflink_8k_4ks New Failures: + xfs/301 Profile: xfs_reflink_dir_bsize_8k New Failures: + xfs/301 Profile: xfs_reflink_stripe_len New Failures: + xfs/301 [0] https://github.com/linux-kdevops/kdevops-results-archive Luis