From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 273C4E7718B for ; Fri, 27 Dec 2024 16:04:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4E96D6B0093; Fri, 27 Dec 2024 11:04:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 499796B0095; Fri, 27 Dec 2024 11:04:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 360D16B0096; Fri, 27 Dec 2024 11:04:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 19AF06B0093 for ; Fri, 27 Dec 2024 11:04:15 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id BA2201A1D5A for ; Fri, 27 Dec 2024 16:04:14 +0000 (UTC) X-FDA: 82941209484.23.423D8FE Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) by imf29.hostedemail.com (Postfix) with ESMTP id E6F9C120027 for ; Fri, 27 Dec 2024 16:03:11 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=Hsw+ZdW1; spf=pass (imf29.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.174 as permitted sender) smtp.mailfrom=gourry@gourry.net; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735315408; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BohRVSSvN0r8ok43rMrQlmWcz2gz4cQtz0ZWkUDg+/k=; b=7ktTuMF0Bwgujq7YGx/YMq4Rcz2ESDBo0qnHZN4eDNjEuMkBxfGmycbpbjerVxHNCNXCzY HwBo4gDratwYAXmwWBxBMN0nvq/QtZizE5jppAPjvIGj7XEj5YlA7iISHE+ApDVQg+xY3j n+WQR/OvacZOQCJfl4IGYXrWZRNgNj4= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=Hsw+ZdW1; spf=pass (imf29.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.174 as permitted sender) smtp.mailfrom=gourry@gourry.net; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735315408; a=rsa-sha256; cv=none; b=L9HfXHcYG1u62IyX8a4vegxd3Wpp/HL4F6xDHmbC5Bp1qG3IBUplwboMexcKbXxwDWcocy njtDdmojkIj55WCii1OiKbqPVlj/1SHtqJG03/yWcT0Dq/Duu2pVobBSHZIzMM7HYYnziA cPjugCW6Hqaqe9ShLggWTEov43RzGhg= Received: by mail-qk1-f174.google.com with SMTP id af79cd13be357-7b6ef047e9bso646319685a.1 for ; Fri, 27 Dec 2024 08:04:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1735315452; x=1735920252; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=BohRVSSvN0r8ok43rMrQlmWcz2gz4cQtz0ZWkUDg+/k=; b=Hsw+ZdW1RwY2CS4N9BkZQR5T4oGZJ4crVlVN/B8BLBOXNRgYLDS1wmjII4wpDgw7Cf RLRdzzXx8JBX5qM84psxeaStIfuC68ed23ph0cK81capIf5P0zM+M4/Z/UubgwjtLgTa MAoNm+GHn8TzvQCRTVPoUIvQtMJZ9MONUXWCabwYXZKRMkWUPbDzc4gS5Bac9Dz5CtVu dMDw9Iaxhx/NdTqRMr3HQpZaizgFzwlexoCxmF/fPVSfe94rFv6Pn5FGK+EE8fTiTUeO 7nlvMW6c18+J/1zwzOLVhTkju+X71c15lb2JoS6I4yMbd3LtJCJIRxCIOS1r9nX1WzVT nDGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735315452; x=1735920252; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BohRVSSvN0r8ok43rMrQlmWcz2gz4cQtz0ZWkUDg+/k=; b=GMMec9D3npLKQgZJXxG2hO75Al22NkVU9bvvSrH5jXHGY0MZdPPOAcpLJgc8+YsEKX we639tfNu2yWIFPW17oYfl4RySAT86Q8d8M39e0JtdIe09NbXnATzb/GLlmtfwM5WD3P nJiNxN99wgkXfLnDc0Qt4W3l+2JBUOyD6evWxmF6tmtSqQxeZEdbSokr4cWbBemL1daF pugHw6oGPzg/m9je6+ZUVtv5+dyU8Nr2ghjPfOxVYiY3GWQ9FdwIiAgYi6ucbIve+ZLm 1yJQyMVmLxKwBQkxL9Q/WhJF5V3sQErFID45FV4PaHnDq7kFi/nSpIuTKEgLemHHGkxI RD3A== X-Forwarded-Encrypted: i=1; AJvYcCVEv8d5JKE0oIkEsQ1U08MFCj403TBdC2VQm0WOuzy1nODtKXmMfoPyKplGyPcRBDn1LZDbk8YgTw==@kvack.org X-Gm-Message-State: AOJu0YxLg2BhI41ItVtAgYF0LyMm8fbpNqDk0+2Nlyll7WdauURZleXn nT+TvqIrvlNFOnQrsjEkkuEOfc2VcllnNo0Q2350Yl6rjGN7WtatvMPkWaRKmWIor/QNucbF/l8 / X-Gm-Gg: ASbGncvK6kL5sqSyJzOxm+fHbOsVRLfhzt/tR9OxMFom1wajMg+OQXQkpWcxbjZRlKr OvGqBA/Mut016jRmzOscUa7l7k91goeE8M2DngzklEOZ/ZEpUkfXg71Xj0qfoAdgd8fF4mYRzeN MdvxiHMAlM9AdzPK8SGL0YidWXt/liLdpyvkEv+oZJ+OUy0v9HfukWrh9AYvaFOmqCzoc1PQfbn dvggtWpjFgOdcmnWa/bbLWybxGSh/O3jrNK974T6K5kCJcfJUo9RAg8y4bp/R2wcXIvUDICrMnG kQh39GAcJzYycfuIIz+0gHelqTQTcJ7jEaEmJE+SOj3+h4xjpSd5Dj8= X-Google-Smtp-Source: AGHT+IEbTliZMMMteEdizRos+1AHu9FPoptyHe9Rh+lSNJ1QAXfL4AckTCSdn7gI/5xVZtXQZ5HdFA== X-Received: by 2002:a05:6214:e4a:b0:6d4:1613:be3e with SMTP id 6a1803df08f44-6dd155eded1mr491439636d6.22.1735315022047; Fri, 27 Dec 2024 07:57:02 -0800 (PST) Received: from gourry-fedora-PF4VCD3F (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6dd181d5ac1sm78866146d6.120.2024.12.27.07.57.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Dec 2024 07:57:01 -0800 (PST) From: Gregory Price X-Google-Original-From: Gregory Price Date: Fri, 27 Dec 2024 10:56:59 -0500 To: Donet Tom Cc: Gregory Price , linux-mm@kvack.org, linux-kernel@vger.kernel.org, nehagholkar@meta.com, abhishekd@meta.com, kernel-team@meta.com, david@redhat.com, nphamcs@gmail.com, akpm@linux-foundation.org, hannes@cmpxchg.org, kbusch@meta.com, ying.huang@linux.alibaba.com Subject: Re: [RFC v2 PATCH 5/5] migrate,sysfs: add pagecache promotion Message-ID: References: <20241210213744.2968-1-gourry@gourry.net> <20241210213744.2968-6-gourry@gourry.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: E6F9C120027 X-Rspam-User: X-Stat-Signature: sfedtitc76bty44tdyhwoqc9mu9jkfbc X-HE-Tag: 1735315391-76232 X-HE-Meta: U2FsdGVkX18ZnxyDFQvsQbMjBCMV4SPHMyp0+Z8OPRsG4N8II/HNIEuav0knrP9eu/ax3kP84iSssX91xG92M3BeKSAHJHoIha6Ja94YqkoUi+h8QkmD4/MOmqubgk6SMjFzjKAkb1g7xO3065DcUijr9PUM/dAfQV2Q/wUoWapnjwIocHp36ubzFug2eM+jy+GxgSbuEbovt3WTGHoFs76mYK2AMa0moyeqXD7lKiuPyKTYL7rbf54JP2kmAe1uJnS32Od4NOlknKd7HlrTSjrEKWsd6Buv4oZxm0NxbalC+CX01c3gtL1nmrJDdvBURWhO7jYrbGVar9Pz5V8g1/oi0uutZO6mxkVdfqv8vrRqrqoZp3s8W3/49dHhCuGoQbEbJQ3gHak4YtYe5GfAHr+tHAfkq+Sjyq6HD8rJlP5k0StKSrOZXVskjFZl+gUYzVJm1ZzdlkZT1cmCPXqb9Mo98WnpU+x8vbFRiyJGFaCCQ7girQCaBLZjNZ3b/FqyucBRoBsw/WsNrJz7MadBdUEe2avxkDS9xQw5gGvZQlBXmKNA5YOmFSJbYea5m9g45fv+8ptIpKuCtgsEDJfBctbS3XshJysnDlQ7oZHH89W38gpSFDRTi/SlRC8/eO7ahBOSyqZNCzPWNIpdIEJkSwMlP1EupOoQoWcU+ZEIJ1lCSBDRGOQhtTS88xu0c7RIfM7DhNXQB8yKlaGHfb4YlSQiftkTBNpNqs2IbN6M8VTTtLW6G5ZoviQaBTnimZj0ORMuVlaW8OKPJGIJs4tysFYL19iBXKB+knv5qpC29P2MWDgkPGz6UINIKPke6naBlrkTqYIfprrOXy8iyIh/SHqyDvR6f1y1P8urOmgIg4Nd3llCWR/b62pMTEKkBfa2LvG0cZi9qvStIy9LlWPKoZnoUEzxI+/AC+POmWvYP67Zn8OyA8ZF6hOBTUWtJz91Y5Njckmw4CsbUcYWfFW pd901pDe 94FqEs+X6qK8I3QXeEpx73cST7u5is7UZbVOLTDImHZ81AWVpI85lQsXMhGbsnelQ11tRqzUzmxy8+Fg1Eg2zFEhkJ+dRmt59plpq+DfpO2BC85Jc3lUVFyKk/qd0zdGlxL8mNULYzDaXV8v9zpSh37ccMLNCFKyCKwfqnAisukVMAmJKD5rt9Od7O76kJDTHVST8K3CUm/WchyP9+eavqRcI3Ls4VW/7Yy8ZW2pki5uwgSLSBMlmIU8KtRrLuzSg8urY7deLYy+Vc/nskbbgHtHgrPkoHN5gSGWdpMKsDbHg9ikVSUobT2zzYMCek6e1Fnx/hFZC+utzwM8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000953, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 27, 2024 at 04:31:48PM +0530, Donet Tom wrote: > > > folio_clear_referenced(folio); > > workingset_activation(folio); > > + } else { > > + > > In the current implementation, promotion will not work if we enable MGLRU, > right? > Is there any specific reason we are not enabling promotion with MGLRU? > folio_mark_accessed may not be the best place to interpose for MGLRU, since MGLRU's semantics are so different. I didn't want to dive that deep until I could show traditional LRU benefit. Certainly open to ideas if you're familiar with MGLRU semantics. ~Gregory