From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E474E7718F for ; Fri, 27 Dec 2024 15:49:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AA7DA6B008C; Fri, 27 Dec 2024 10:49:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A567B6B0092; Fri, 27 Dec 2024 10:49:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 91E646B0093; Fri, 27 Dec 2024 10:49:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7356C6B008C for ; Fri, 27 Dec 2024 10:49:42 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1F708161357 for ; Fri, 27 Dec 2024 15:49:42 +0000 (UTC) X-FDA: 82941172776.21.99C2231 Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) by imf03.hostedemail.com (Postfix) with ESMTP id 8BC1320004 for ; Fri, 27 Dec 2024 15:49:20 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=qDPu8+tY; dmarc=none; spf=pass (imf03.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.169 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735314560; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4UOU6oWextV2G+tUTB+1mr03GjM/WyWFtMHRRkOsfTU=; b=LVz/dWpAq24uDBiSTtITDxZBUa50+BGCPEcwBrx2eMFbhD9mU9YzA1s3+JszaF+NGG8Vjb E4Lu0tiON1ebiPnBzrjHcg14DwLJZYhhTOvsYpeodbaufetdcX5VzzGLHK//WuMFlqU/ya YqGIEBLu9dwJIVZiVlk6WaKwYfn3k6w= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735314560; a=rsa-sha256; cv=none; b=g1tH3mPA/fPaPysMKBcoNINcKwNy4EBoxA9yRXVEazWmyNenJhImFpFV2xuHTKO31d9ljx Fs8qEFE7YckaGJBSDucd/247wN8edJ5Ujl2GE3zHZkd+IQgM5XXU/PrWS23+n16rFKDj5z y8h99R1CEpgwDzGjWHW0y2uy6WgEseQ= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=qDPu8+tY; dmarc=none; spf=pass (imf03.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.169 as permitted sender) smtp.mailfrom=gourry@gourry.net Received: by mail-qk1-f169.google.com with SMTP id af79cd13be357-7b702c3c021so627361485a.3 for ; Fri, 27 Dec 2024 07:49:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1735314579; x=1735919379; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=4UOU6oWextV2G+tUTB+1mr03GjM/WyWFtMHRRkOsfTU=; b=qDPu8+tYz+urpqipS4YQ9aBny61yb3b1v7YfnVz6oXEdJADQmKTZCE15GF2CibGOYl wGpOkzPgy+T2nyz/C0Ce0BlGcnBYlEWRHTC7G8DueDBlC5DJY+diJ/SPRKRxzTFT20Tj 6r9wERk7U1VspZJDnpcVKv2/ZY9wTk0ZFFcaVJ6IDtE8xDWjtsqhe0kpUiirqGoJ6SVu Mo5KTP973byOTKi0bK7koE/rKSqi8zBjiG1qhbAOLXeBte4orgf5KanL4BX7FgtZ/j6G g/z4oxoJsh4T0zHWrRM2leN1EbZXzmQ3gSDiJQpqHyIKd2iBgXuIl5K1YMds45m+kwEb 2RAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735314579; x=1735919379; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4UOU6oWextV2G+tUTB+1mr03GjM/WyWFtMHRRkOsfTU=; b=N2nEFPuvCD8xheulfzMKbx5diT88WMBcUo7r1b5Ti55smpuyEpAL9azX4n6APr/0tS qi56UL8hg9ecXhi1+GFCQ3zQhsgf9yq7EjqHx88IDlejqXY7eIKTW0inyJQFedOf9Suh +wMAcQbZwPFlH8H6tH0V5hsqj5KA6+st8NNFlEX6A5xQZU5w1GXPcJtaTz499w6gLIMI M9qU6SmHdlWGkPNxgb18s5MOdYoVk2WGnKi2WGl6QmLuTPJwRKhMgequcJTQ8Tuq7n8Q X9IMI7kAAlqB7JSM8JCvzqyjVwdik40O/6MFR+w4CvLDER0IwoDxc0kD1UjwrWswc0wn T9uQ== X-Forwarded-Encrypted: i=1; AJvYcCVLyjEPwINNZlh/XacXjeN3jJjJ2vNIUhxX2Es2pqu9Uswk/lzuEug4caIJto61IJ56Tc7R2kXEYA==@kvack.org X-Gm-Message-State: AOJu0Ywhl/4GbnDiS32132c93WcOT8h64VoeRY2qY0oiO0FtWet9v8Ix ipNB5CcqsUtIjp0xfs6SaR3fERy8eHpT+TlK+kj6lenW4/D/CJLMmaqC4J1cppI= X-Gm-Gg: ASbGncucHBmrh003BKLZSq3SpzKhhZYW+f9kzrjJ0bhoxClNsuUy+ciokg+OhbyXL+/ erEGCtl7Ova9QxGf6PWYoIMlyF0W6CRBb9xDj5trlUIdCTdRnvic1CcmUiIO6fBRAm2ML5iK6OE EW/JR7qGRGoqiJjpKnNOQV0bCmi9+64hh5+YJyDY0BQsls8+OAx3hjPC1FGNPI2Cyql6aLZ6rN5 jqnC5I/o9bcDMiTvryvms76H+H9EU2LZaRdgxEnGjaFScL1OFrC7o41OZWaB9AasOcvcfYPUFDm hc9uZiq4Cf1Nid5cjElSuVRqcAksYXrzfC5zFq+RkhMvm6NByLgRoqU= X-Google-Smtp-Source: AGHT+IHT0Ulq+soX8EHJOQDzDKMjCxLBpAXhwtbTu+KTS/F1WjF4MyTA+x0YrC5N503P3jgZK8Xibw== X-Received: by 2002:a05:620a:1792:b0:7b6:f17d:f5a7 with SMTP id af79cd13be357-7b9ba716fc4mr4258800485a.6.1735314579366; Fri, 27 Dec 2024 07:49:39 -0800 (PST) Received: from gourry-fedora-PF4VCD3F (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7b9ac2bd995sm708597085a.21.2024.12.27.07.49.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Dec 2024 07:49:38 -0800 (PST) From: Gregory Price X-Google-Original-From: Gregory Price Date: Fri, 27 Dec 2024 10:49:37 -0500 To: Donet Tom Cc: Gregory Price , linux-mm@kvack.org, linux-kernel@vger.kernel.org, nehagholkar@meta.com, abhishekd@meta.com, kernel-team@meta.com, david@redhat.com, nphamcs@gmail.com, akpm@linux-foundation.org, hannes@cmpxchg.org, kbusch@meta.com, ying.huang@linux.alibaba.com Subject: Re: [RFC v2 PATCH 4/5] vmstat: add page-cache numa hints Message-ID: References: <20241210213744.2968-1-gourry@gourry.net> <20241210213744.2968-5-gourry@gourry.net> <4504da8d-a5e7-45a1-9feb-167f94210200@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4504da8d-a5e7-45a1-9feb-167f94210200@linux.ibm.com> X-Stat-Signature: dpstjjz3xzmsnwyuubisgjm1yyeag4zw X-Rspamd-Queue-Id: 8BC1320004 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1735314560-184049 X-HE-Meta: U2FsdGVkX19IiGxiuidHCHHkxkRn8I9GuYYJEMZgQYkJJOgvjc9OERM4OLLOCeI/xOfdc/ceuazpuqxrJiBGlRMBc7Iz7AyzsTSZ3mrJ66IWnAFeNVhRCSAV1mTpSsLrP143puDe3/PhLXnEacJujRC6RqDgMaXKY6vNwjQDdAn7dqPVtzplH51CHUHb3iflV9QqWRdbD4ny8eg9ck802Gw3Gs1mKB04nOvoQsGcShevz53gcKHdPaCh80MkM6N2NzFU23BNbBggCql8XRtdHmlNpeAoA+VXmMZBQhG34XWoBaswAzQGGskIJkTxL4QwUFSnAhRp/gknpQdsojUtJFdOfMJkGmrlKroJIlQvmUORhdumZo67SWg450cpdPMePeGKi9vEex4FYk/JsM5t2vtfJm8fF2KlzhIuSIjBSPEHY2gbrEpt2JIyVowL8+qSBkTDSuhBDw3caiYn+q4eXXDXxTyhdHxpmma23pQ2SlwupFDYGf7CNY2Wu3unjan47wZH3Ojfk2V14akcBbA3Us8x7wcb9HGZTU6Ziu3CQDwbokutgQBfS8AhppOyusOwKuomWOvpwTkxCNvUTGiPFmKuyQ2XPVRHeR28HP8QI7RIWL7pw6DlJG4jzG2roO6ozGgp9bqlvKBolf8HIATWQ50HrJAXXejNKr647LWQn1dPHdoL6YfHlxiSjdPryGIZok5fw62kCPNpQjyMUkWt/Yk0zSecT8qSWxr5rCi3Wplusc5wwLbffA/ZkxInMcSCdIhsPpRSOyQbz+BrYuQ+vZpeBupgZKhO7dChBfXNXC7Ssk4y+fIjhn9a0dBstL+6Fz5VQOs36bt7exyrV8l8AwM0aAwHAPre1mvMCAxOkoL3rc8mWs0CGtwHuCw+oSM4MOtfLLuDkL3sqe8RyjZWO7PNAD8qSOtBhSrlBmIrYrg/r8bNxWVcNqBXWBPEBeD2gcmN3ST42esStp+8aYt V2JSwbw/ 5aPjdx4RO/AK74vyMU2vmhInn1wVeoNyCcGOWPaJwqo41LM4K4XDAidNFr+QgQX1uWIUdPa8UCHBl1nq1rk0IMRqsnfP4LKQFz4aN+DckeZ8Se/Dy45MuHo2YyQio5GPvOnnNNKgGK5/Q8MyT043UVcNAuRIVyUBS/iCpY5x+aQ/0GpF1IRWEEI4ayW10S5FFHSvxFRJYCAaFYN+iBZHoY09YHLecxrqClyOKrxfLWzvSftNooq0FLAEFWunxm7VO4YuK5VXoBobcfrJW/0T2f6PueqJhA6mpRHgQKHoq5pBS6tQG2Jdx/c8zsDfHWnqdlt7MzHJeqVxwpKw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 27, 2024 at 04:18:24PM +0530, Donet Tom wrote: > > On 12/11/24 03:07, Gregory Price wrote: ... snip ... > > + NUMA_HINT_PAGE_CACHE, > > + NUMA_HINT_PAGE_CACHE_LOCAL, > > NUMA_PAGE_MIGRATE, ... snip ... > > if (folio_nid(folio) == numa_node_id()) { > > - count_vm_numa_event(NUMA_HINT_FAULTS_LOCAL); > > + count_vm_numa_event(NUMA_HINT_TYPE_LOCAL(vmf)); > > I have tested this patch series on my system with my test program. I am able > to see unmapped page cache pages are getting promoted. > numa_hint_faults2269numa_hint_faults_local2245numa_hint_page_cache1244numa_hint_page_cache_local0numa_pages_migrated4501 > > In my test result numa_hint_page_cache_local is 0. I am seeing > numa_hint_page_cache_local will only be incremented if the folio's > node and the process's running node are the same. This condition > does not occur in the current implementation, correct? > I did not want to assume we'd never use this interface where such a scenario could occur - so i wanted to: a) make such a scenario visible b) make the code consistent with existing fault counts I'm fine removing it. It's hard to know if this interface ever gets called with that scenario occurringwithout capturing the data. ~Gregory