From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A414E7718B for ; Fri, 27 Dec 2024 15:40:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 87ABA6B0088; Fri, 27 Dec 2024 10:40:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 82C136B0089; Fri, 27 Dec 2024 10:40:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6CB546B008C; Fri, 27 Dec 2024 10:40:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4FDCE6B0088 for ; Fri, 27 Dec 2024 10:40:43 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D80798143E for ; Fri, 27 Dec 2024 15:40:42 +0000 (UTC) X-FDA: 82941149802.27.05C7CAD Received: from mail-qt1-f174.google.com (mail-qt1-f174.google.com [209.85.160.174]) by imf08.hostedemail.com (Postfix) with ESMTP id 34644160011 for ; Fri, 27 Dec 2024 15:40:12 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=dSw72Awn; spf=pass (imf08.hostedemail.com: domain of gourry@gourry.net designates 209.85.160.174 as permitted sender) smtp.mailfrom=gourry@gourry.net; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735314008; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RSSmOJS0JMADLmZoIu6pswsHmUSxbHwsAzwkUWUhfbc=; b=8q4jZI/Oayn2FUzHRd+YeHU82C5Q8Re3Gp4KqQNvUrYGYz6CDxL5C9Yh7y14xhhDFhkDDU NwgRS183RJOt1X8UyEkqnCGZj1eOev5GMhA4NMJTSDHqWRuSN9KM389yQatyw0VbjmTei6 AEGWgP5x5avIR9zKiq/x3pMtRBkt/Zw= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=dSw72Awn; spf=pass (imf08.hostedemail.com: domain of gourry@gourry.net designates 209.85.160.174 as permitted sender) smtp.mailfrom=gourry@gourry.net; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735314008; a=rsa-sha256; cv=none; b=GS47iafAO1Q7lIhvOWYEOn9nBm+hi+VoZyvJrnr6wmO9LZSHpPDiifpqdNfE7gQjz4oO+y x9mzmu9j4ir/OL43X0KAOZwYYGoNpgLVGfJFrClDwgeYr1s4t7hwsH5Zu8cr6vuxVQ5Zm1 15jo0bJ4Qp+ebH7LskRrnpLOyrhUiAo= Received: by mail-qt1-f174.google.com with SMTP id d75a77b69052e-46792996074so71254711cf.0 for ; Fri, 27 Dec 2024 07:40:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1735314039; x=1735918839; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=RSSmOJS0JMADLmZoIu6pswsHmUSxbHwsAzwkUWUhfbc=; b=dSw72Awn0Lv4CmrOhgdeNx7M60mrnaMXYONP9JBGFZHmA41FU3vMlnNLgTeTR7NnGT G+rBo6mLJ3322WVf69jrL+l4Kw19JTExnxARg/YbAmzP63ZVNTSHM/ytwiVz+HppSjaC GixOo0hghRYNxuLL8ghpon0Pw4GrXVIgc/12nsgz8D+wKLv7QmlX1BLO116O0eBPn3ba Rue9sDU3x7ldjn3W7tL1d2xRtvgGXwbnHHc0cABS9LU8EtBZEyLxiKWeTT1OK82JL7ib CHVo/msM755SnpGZptFT2zzo0z0/bszsMZlAIRMNte877Cg1Af9RKFA5Cpfp5QFBHUYZ D30Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735314039; x=1735918839; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RSSmOJS0JMADLmZoIu6pswsHmUSxbHwsAzwkUWUhfbc=; b=n47rM7T6gW/1lfZHWWj3obLtgVl7y27d0wq0reC6Cht03yOOr7bp8LM7yXxwpO6apQ jrXnm/xaVDHBl5EyQZcfkeXWwMLrwSKmUO5WtgbBGADuye5SUWhRPI/ncTjUMbtwwec3 oyzNswtpoKG7fM5+rZNCc6NfojgyeG6jtfQDKwIKXQtcB9hrOBCBAJYJNb1ta39GetBK 6r0XzF9kTo4y7wviHFOH7HBu0LCPcC49FynenGFb2P3VlNOhQwyRn1AXcMxopJo1soqE B9xwGt1f3fQvlKnsaYhc7h8DDTvu55F3q/o3aC/z9CFJVJ57UgvtQbrUhYL+pmIePwIH EyNw== X-Forwarded-Encrypted: i=1; AJvYcCV1E72T/KSnm5/rEBrd6xLjCHqkUF/HHEokRQXtFxY91/U8vRpXciiDtwvdkXqdsz/7sgM983tjwA==@kvack.org X-Gm-Message-State: AOJu0YxsblJF48fpaLT9iqW2juX16QUHShtesVhoOjO1YjE+B879yq7F qQIjDREY9ml1vGlSYxX1Nn6HfF9jp0Tj8yZepgshbi8fUXdphf8oTjojhTiGqTA= X-Gm-Gg: ASbGncuoI2Zwo4MKcQ3aePBtbB6yTpNF3v53teEKDnAfQ4+qIiyZUQvzXU4S2nnAaz0 MI4qTFiH1hhdgF5Gbf2ft374mCrYt9onk2UN94m6qQFWBnsboEWMLf0wS5UDNXCZT7sv+H/OIhm BWbnD7lLRa1ursgSzAky7sUySNchVY4v8aGlNWGjZS0d9sNKWlyQfAsSgJNSNi5wgvoa/PTxzzX 3tYI0okWdWmtzMtGS1EwtmCE365GWmQQJ1LIZ67dAl3cl5hDDAchItJwD8LkAYl5utjDjHg+sqZ x5G5xvI98E/xXlfkMJyIx3C/Z9AkzAJa9fHcB0w29DMBqd9SB5BLKss= X-Google-Smtp-Source: AGHT+IG0kmEJye4KbxdNtZW2ZCP6ubDGCb3x+c+8zIODmFiQEQb7LHSn4c1QZ17aNFTc/OnaWcIvLQ== X-Received: by 2002:a05:622a:54e:b0:467:6941:4ecc with SMTP id d75a77b69052e-46a4a977daemr568216871cf.39.1735314039094; Fri, 27 Dec 2024 07:40:39 -0800 (PST) Received: from gourry-fedora-PF4VCD3F (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-46a3eb175eesm80725521cf.55.2024.12.27.07.40.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Dec 2024 07:40:38 -0800 (PST) From: Gregory Price X-Google-Original-From: Gregory Price Date: Fri, 27 Dec 2024 10:40:36 -0500 To: "Huang, Ying" Cc: Gregory Price , linux-mm@kvack.org, linux-kernel@vger.kernel.org, nehagholkar@meta.com, abhishekd@meta.com, kernel-team@meta.com, david@redhat.com, nphamcs@gmail.com, akpm@linux-foundation.org, hannes@cmpxchg.org, kbusch@meta.com Subject: Re: [RFC v2 PATCH 0/5] Promotion of Unmapped Page Cache Folios. Message-ID: References: <20241210213744.2968-1-gourry@gourry.net> <87o715r4vn.fsf@DESKTOP-5N7EMDA> <87wmfsi47b.fsf@DESKTOP-5N7EMDA> <87v7v5g99x.fsf@DESKTOP-5N7EMDA> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87v7v5g99x.fsf@DESKTOP-5N7EMDA> X-Rspamd-Queue-Id: 34644160011 X-Rspamd-Server: rspam12 X-Stat-Signature: 4day1nryrtdupdo59zf4zjeptfyizt5u X-Rspam-User: X-HE-Tag: 1735314012-819556 X-HE-Meta: U2FsdGVkX1+SPCegUoaPgKVOnvEz38bFpJcznmgtADCm01tWLulhMZnZ2FnSasmEqbsR9jj9Qy1Gpk6Vr25XF0Pp7E6qfkPwNHI57ULjceNCfdqMxvHqFPVnqi1IlVSoJvFVnPVegvNTQqRYWzSO2JqFfOzbbypBQC/DRuBpr2VyqP3E3c0EdhmEG5ociXuoggYJG/P/SKO2B6ur6q6qx8xTqxoenMyPCEywPGXw+LlrwnwpeppzRoAF4QC8WbBrrV9KvEmnQw68D+RIlXZ5bvOy1gnwSoN+Uipv2i19bWEk8u03Drgs+TqYseRPtENxDlRF9IQdLU2jQwf//EPpneBSmG7oshZx5XT4wrl++d2xfp+bzZMBa/dB7ZGfVP6A4OHsAs1+Z1PKUPl1qZBxfxAxLcrqfCoCfzMMTT60zA/MH1oOdvzXgFNWl22R/Nf9bCP5Dr38V/yjD3AEGe4ca2bqD34U5l2X/8ypioWI/B/s2RQpalr9Fng+O7VaL7MjesfjHXrqxkLr3ar08pwK4js+zQwkTp6niA9Ynenn8BVQr1vm8O8r+XkxuH6wgCfh/DmYlAX9UAQI2fKQNzbCT1uX7/pAYIfkrC++nKubsMh0HG8fsXtzGapTkywBfqzTF67n7pueI0FGBlcTKG7jta79dfJaBSOXviOMWmdiKSZyFzCq3o/c5BVSZ7DKOhY7N9L7LP8V7Pv+zoJgYk1zn1crdqjs+REgSu//79hvrmhz/iW8McuAudHzZiO2+JfwX1jx4+SF6GhQfFITKVhzSuRdN1Svjs6Nx9yN3+MdaqlVpzXeLWOoRmPWGG5N5I6CfXNCrf6L1MY2hVkNu44LVWooCYNldSrUWI7NZtK7ba9MwD09YpNZmBZbQ7HyyPn7wl/9iwRhP82YHXXFSOWDuyau7vr5bQEnCJXa9jO7sjKLCSlaqaYpXZj0wV1a1gNchZgtYgTdwYTzk53PgMU LdUTr9Kc ld6cMFcYQw4Eu4ovbNLZrskfp6ZuEJNkr+oLHbcFlRPHI4lMUktKN+qXeRykCMPVm7Ix9YzM4gCwHt3dP1X56QerTwGikoX371Mhl3CC7+HZu0ZY2c9wChDwTbS5g6as4bWB0paaMzWgYG95/Nj7p4sNTdwIAld9vxUn78S+x4t0uQlU6yEGqsYQLnRFWWaNZTvXL2AZp77AjMgvFlf/aT437JqXW8/tgP6qc0mnkg0pwPk5NXPYX2q5XUKVAqSypgP6qfoAj2RCYmUBJsb1kyMdFaH5QzPAUxxPcOqxmuSwRHXfEY9lDjgk3Ckg0FZYt2bODM/65GRaS9DeADR1hzy9rPnhq8oKlFGz2HgG93y4atfNcaaChcUkina+kfoqXURw+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000341, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 27, 2024 at 10:16:42AM +0800, Huang, Ying wrote: > Gregory Price writes: > > > On Sun, Dec 22, 2024 at 03:09:44PM +0800, Huang, Ying wrote: > >> Gregory Price writes: > >> > That's 3-6% performance in this contrived case. > >> > >> This is small too. > >> > > > > Small is relative. 3-6% performance increase across millions of servers > > across a year is a non trivial speedup for such a common operation. > > If we cannot only get 3-6% performance increase in a micro-benchmark, > how much can we get from a real life workloads? > > Anyway, we need to prove the usefulness of the change via data. 3-6% > isn't some strong data. > > Can we measure the largest improvement? For example, run the benchmark > with all file pages in DRAM and CXL.mem via numa binding, and compare. > I can probably come up with something, will rework some stuff. ~Gregory