From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 579F7E7718B for ; Fri, 27 Dec 2024 15:42:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D85A56B0082; Fri, 27 Dec 2024 10:42:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D36076B0089; Fri, 27 Dec 2024 10:42:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD66F6B008C; Fri, 27 Dec 2024 10:42:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9DE696B0082 for ; Fri, 27 Dec 2024 10:42:29 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 39A8AC0ABB for ; Fri, 27 Dec 2024 15:42:29 +0000 (UTC) X-FDA: 82941155052.05.8EC0BE8 Received: from mail-qk1-f181.google.com (mail-qk1-f181.google.com [209.85.222.181]) by imf11.hostedemail.com (Postfix) with ESMTP id BE0CB40010 for ; Fri, 27 Dec 2024 15:41:47 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=uMDIT12j; dmarc=none; spf=pass (imf11.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.181 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735314107; a=rsa-sha256; cv=none; b=EpWCOtxO7BUAxhOV7aQTMdqqe1+nLaPPNpmBDtxhIn4Ef19YDMnWlpP8A+PnMUJuBxQO9P aJn6PIMBYtHLdkz2AoAqND343hyeExNpuWsEWChItwznciGA39y27+dB9NcyFjN5zceFm4 GYM80GUtDiJVotgHWvUXMD33SxsDzVY= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=uMDIT12j; dmarc=none; spf=pass (imf11.hostedemail.com: domain of gourry@gourry.net designates 209.85.222.181 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735314107; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ih3mv9HhVP9CuyhCNc0pl6V10JcWKow1s537mrauqXk=; b=6UxnoLaQjLCfnaKVhkBFleJNpa6DMiHlw0yqOuNRER/WsTvcJA4uUf6W1La8Zd2e/zmwb2 bOhjz6bHSpC8qxRBWe8zgIzICUjnW/w1cGfEi+sREMDERWpF070Z0frsfuXANDVRIUuWdf Jfh6lOfjyfGtz6cpmLjKXE6ZaYiFXpY= Received: by mail-qk1-f181.google.com with SMTP id af79cd13be357-7b6fc3e9e4aso639774885a.2 for ; Fri, 27 Dec 2024 07:42:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1735314146; x=1735918946; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=ih3mv9HhVP9CuyhCNc0pl6V10JcWKow1s537mrauqXk=; b=uMDIT12j2iwJG+GuEDiuQI4ieaUWs3OOReIOiGJlOX1fBEKJP/37rRZ55Qz57KZn7M vIiTa+4R43mL0UF7idSfxJU+zCwneCFSe6Ur8vnuqwjOOyo7GwubBmPi6bMxjIk0mcDW ZjqPql1hbkCnehwnfn64rSJJ4HC8coVHpKVxkmA0ft1+ffsbO1AdaK3f1vIEyoEauHIb vjoR27OQnQ3wcyEftg0lSBoZV9qjo7Uw0uQG++RnU9QfUc04WS3ucYYUtpoyb9t79pYW M2br5iM3mBbas9NYr1lwkvp0M8syQoLUV9oTXAjYLrHq2scvoyA6UPNfoOHXYfmMsJZn 7CFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735314146; x=1735918946; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ih3mv9HhVP9CuyhCNc0pl6V10JcWKow1s537mrauqXk=; b=F9RXvSJvf8WWm1+uooZiKs/6p3y+KgEvN9kL0gfb2n/ZwwWEHkW44ZNdlDzGbFwjjQ UdK5sumNkvhITpaLcIDt4MmYJLTqlMCLUFyJqMXvWMZCeGyqmSPU13q1soSQVdoo+F+K PblF+IDgPCBhNw2OFzZpCr73HSCV0v1dRCvnuCD9MTE/9avgz6h6U0KW9Qmd6k3CjDYt 2MkZ1BTbZis2sHOe91Vk1mWlhTlNC2D5MjL+visdzz7jhKyT4m24JrKTW38jKmFdpmna yEfaYntcaDhgyDsNVjTqiHEle0QBKVK6qpz+kNyWy1hrL0FI3ynE/vBdhaP6DWz8tXRw kyow== X-Forwarded-Encrypted: i=1; AJvYcCUV6h7fNzwUM+6dRS2H1IHoFvnSHW0Bak1OJJNRl7kWZNx82fHHE6NTChtu6GkxmyWMCEPkx/lnCA==@kvack.org X-Gm-Message-State: AOJu0Yzo/jUFLzXUN7Rh3ec82KjHAasi/rT2Qrq0yZ0MTNE6QSSN/ezo ny8tWDFmf1443tJ2dmNO+uAPulp3zoFYK1iSjt2bWbOmywSGC+Igg8iWS70S1+g= X-Gm-Gg: ASbGncunfw2AxSmhkJeCsB5jD4qmA2aEArzk6KZrxLsgaOugz5s5kLXB+W/TiQsHQcX fNv2weZNHPpMYCIP0bvzpbywfsB49EDa/AaefsaQ8neSbuQ8l04iwOXu/Bvwb4E/5Rvvb9ezU7A cXNijUKQTxc0iTnlXQixKeHE9ZFZjxBXU/8ojik1dfe4DPx3gnFSAIfR6rX8voYe1zYF9MW+dqC iG2KM+EVeTvoyYqjxTi8eoCZ5klMRtePRWalqW38SRqhSxrlIqNPAdDahsc2gFp5I70b2TIPscY VwE481mgcn9/v3AmbrEcpNcMP+iKO71mozK7EJbl77n6SXj9pu8UgA4= X-Google-Smtp-Source: AGHT+IEfI7GoNj8KLtAf3kiu7j17ni1bm+HixLrZEXhKIduco4r8v7iiMipIdhUhBo7cD7mFEFv3iw== X-Received: by 2002:a05:620a:240d:b0:7b6:eb12:d732 with SMTP id af79cd13be357-7b9ba83f593mr5201358485a.61.1735314146407; Fri, 27 Dec 2024 07:42:26 -0800 (PST) Received: from gourry-fedora-PF4VCD3F (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7b9ac2dfeaesm702998485a.40.2024.12.27.07.42.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Dec 2024 07:42:26 -0800 (PST) From: Gregory Price X-Google-Original-From: Gregory Price Date: Fri, 27 Dec 2024 10:42:24 -0500 To: Donet Tom Cc: Gregory Price , linux-mm@kvack.org, linux-kernel@vger.kernel.org, nehagholkar@meta.com, abhishekd@meta.com, kernel-team@meta.com, david@redhat.com, nphamcs@gmail.com, akpm@linux-foundation.org, hannes@cmpxchg.org, kbusch@meta.com, ying.huang@linux.alibaba.com Subject: Re: [RFC v2 PATCH 2/5] memory: move conditionally defined enums use inside ifdef tags Message-ID: References: <20241210213744.2968-1-gourry@gourry.net> <20241210213744.2968-3-gourry@gourry.net> <0dd42f11-2c2d-4fab-a115-2b0c8c69952d@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0dd42f11-2c2d-4fab-a115-2b0c8c69952d@linux.ibm.com> X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: BE0CB40010 X-Stat-Signature: steup4fqp3quzbza4rewz6twtm3kejac X-Rspam-User: X-HE-Tag: 1735314107-298214 X-HE-Meta: U2FsdGVkX19KewIgkqrZxa52lTeXLZPrHBigu5ylVtxzkcJ6TvPKmvKkb+PcPRUfuZdvpup5AO8Mv9TlRUhpvLV44EcwKZngHOgb3SkGWJvXUzXnp5qPBbCQ0spizRdaMaE2eBn26RnY6L8moBoLoSYQyqxcHyezmrCPCTl7zLeWA/Lq5o9lGDP/oSdF/bZcWPPZEZxAnK0NG3hsXiPZqjbAzojIlTTGSRG+IgO/pMJOtP8ldEAyIT3rO62IjF2sXhuVmcPmP9iPEDw9/RZhgO54yP7bLcQVnkDKbYsOJxO8S5q9qwf3jv0uk6qU/ed6NnvWey7cf+ChhxaKq0m/p1ULK0UpfTzdmM6RkacQO28hzQXDbBWpGu2Mas6GD5itgHzMymuiVXZu0yXANkJKNF+pV6ZV+J/g+UiVCsubygGk0I3ewxAejLzL/haBT4tPfL7Ye5lXhyXx/vnd3mVHk+3VrNSAUk9ZQwBGXDlLApMvjhDtk2/rB8XmbsJXNC3Akx2z6kEfIGQ3qeQggaQBtB8mzf7EcTgclX4JbynQAVLV9y6gtFo6o+kGqcOjNbnn20UG4gSKDHTFwI62fcPhmlMdwgP6QMrizWrayysRqz7x7RlHQCX15m7HoFQr1CfnczWs52eKVEZhERg8PCX4wcCInjH836s4cXl6u0rSvj3fOVM2XrEfoyv+WrDsp02SgRkLhjv6NEJiEwdeWlroGR6rTxFEZyGJJuTBAH75I9kT6ov6w4h77vMBoY9twA31GQPke5ebEZVv8hva3cerNvioMww/dvqyC+tvq8CtgQ88JxOLnxpd9TJOJoGvuDhZS9jxDPI8kA48b/QKxS1yNRHR8egITZt90lUMKhiUo83ELHrQ3UGDIpNxg3N+dpxFJjVePz4hc/rzhx/YzJRsdA/JzffaihpMuaToqyYHrmuWrX550vs6TW590hBptohFurw/kYMd4V7szUf400l S52zRy4U E652ZhC1IpwxncWpwvSZIaAWiVAQ//Ajk1pl27gZiwit4m/Z2EXTYWxwaJ5cN4XDo+X8yaS/OU6O/A/DGoZkn7JzqGAAd34GSbyPiUFtsgZLQKB0/JKuBoIU0ycmlthXpM18jIJlBRRlQnxNrGAPLvlNg6mIAdniL42AGlMNMYJUf+sfp6ofmF3nLOL9mZ36LSX3ds/auhCO+waVNUbQwqyRxmozIanx6tJq0BwlR9IuQiX2zwy8H/+6o1dCKZk9naxLFA1RQjXln0o5Ft7ZYmF6Apud5xOxVgMecWBSTlXgLwQ9hNk4iHtqGOWy5YcG171pjC5y4fEuSfAqUINwMG3zQb+dBnVE66I9EJJS9uQfhcsQ2mswbRCM5nzPeEJQ3Zrsl X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 27, 2024 at 04:04:05PM +0530, Donet Tom wrote: > > On 12/11/24 03:07, Gregory Price wrote: > > NUMA_HINT_FAULTS and NUMA_HINT_FAULTS_LOCAL are only defined if > > CONFIG_NUMA_BALANCING is defined, but are used outside the tags in > > numa_migrate_check(). Fix this. > > > > TNF_SHARED is only used if CONFIG_NUMA_BALANCING is enabled, so > > moving this line inside the ifdef is also safe - despite use of TNF_* > > elsewhere in the function. TNF_* are not conditionally defined. > > > > Signed-off-by: Gregory Price > > --- > > mm/memory.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/mm/memory.c b/mm/memory.c > > index 83fd35c034d7..6ad7616918c4 100644 > > --- a/mm/memory.c > > +++ b/mm/memory.c > > @@ -5573,14 +5573,14 @@ int numa_migrate_check(struct folio *folio, struct vm_fault *vmf, > > /* Record the current PID acceesing VMA */ > > vma_set_access_pid_bit(vma); > > - count_vm_numa_event(NUMA_HINT_FAULTS); > > #ifdef CONFIG_NUMA_BALANCING > > IIUC,|do_huge_pmd_numa_page|() and|do_numa_page()| are executed only if > |CONFIG_NUMA_BALANCING| is enabled (|pte_protnone()| and|pmd_protnone()| > return 0 if|CONFIG_NUMA_BALANCING| is disabled). > > Given this, do we still need the|#ifdef|? > the NUMA_HINT_FAULTS stuff is only defined if CONFIG_NUMA_BALANCING is built. The ifdefs around some of this code is a bit inconsistent, it's probably worth a separate line to try to clean it up. ~Gregory