From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0ED9BE7718B for ; Fri, 27 Dec 2024 15:36:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 015936B007B; Fri, 27 Dec 2024 10:36:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id F062F6B0082; Fri, 27 Dec 2024 10:36:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DCE2D6B0083; Fri, 27 Dec 2024 10:36:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C0EC16B007B for ; Fri, 27 Dec 2024 10:36:02 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5A58A1606AB for ; Fri, 27 Dec 2024 15:36:02 +0000 (UTC) X-FDA: 82941139344.29.809C540 Received: from mail-qv1-f42.google.com (mail-qv1-f42.google.com [209.85.219.42]) by imf25.hostedemail.com (Postfix) with ESMTP id 6F036A0010 for ; Fri, 27 Dec 2024 15:35:29 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=aOXsyBMX; spf=pass (imf25.hostedemail.com: domain of gourry@gourry.net designates 209.85.219.42 as permitted sender) smtp.mailfrom=gourry@gourry.net; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1735313720; a=rsa-sha256; cv=none; b=K3RRqKKFWUsvGnAFbxKBcDvHINWgqGvGGFsyypDBcwWL8DgX9nnqi2f75xViezNjKS7fm8 cRY9MN4afXFWNy+svuHZe6VxHZ3XpZiTWx8uGgzfRum3cpt0k/ZbQ0DV8pws1zgoBKkVI/ ZXyjvQ8FzEyWAYJz0aLEZOpfzh5xP1M= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=aOXsyBMX; spf=pass (imf25.hostedemail.com: domain of gourry@gourry.net designates 209.85.219.42 as permitted sender) smtp.mailfrom=gourry@gourry.net; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1735313720; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Krzrbn6PXOKlKH88VdMhylbF4qrHa0b2o3mXIp6plMU=; b=CMYomB8asLQZrkm4UyvEKk4jLp2OO7XYbr+jZCTkS1XbJHmDuev7VS6VT3ONQZvWzIkaKP lsScpP+L7yvQX4y+Vj5/t53Dzwq5aRMY1PFCZltTKAZOsramLqqtJZIX32O7BF+ueGzCAx FF3rA1Zt2EsYRsEty2GsvMidq+5Mk/g= Received: by mail-qv1-f42.google.com with SMTP id 6a1803df08f44-6d8e8cb8605so38586376d6.0 for ; Fri, 27 Dec 2024 07:36:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1735313759; x=1735918559; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=Krzrbn6PXOKlKH88VdMhylbF4qrHa0b2o3mXIp6plMU=; b=aOXsyBMXg3ddOARZMj1S/HCzRPDGni7DbMrkgaQYm144ZeeecTsRfcPAbnPPLre/eF q6fSiAqMIwfMg4xMNYlWkqjEvRI31UWfDuNFwDZnNxhgiCeuRPeFBluu4904XL0lJsOz /Mamdzk6Yo4oTH7sIpMNOBrOfU+AGVCfiAqFADpC5DBSeEbP635okNE7Q9Czn48/wQau hcFPjbPB5wJp+880DXRL0PCpb01EYCFf1qRF4lXzwRF0GmMx4c6iNZuiLwjx/1ThPyuG QkUv4GQ2aJJLcTKkOSRdfKcpUD3r7mNGJS6rYi2E7Nvk+7NQjmJrTSh9yPNbIdKsKkSC dRbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735313759; x=1735918559; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Krzrbn6PXOKlKH88VdMhylbF4qrHa0b2o3mXIp6plMU=; b=UTaFV8UNdQj3XbmTHJffON6ZRRxyFwY9+B/iNBwU5YOPl5L+ku0O0idZJlnKRiTS7d wS+dCclko71/Pb/uBVQZAlDlLK6wD11IB2wLDSgeercRq0Q0/qVgGKT6rbzPVJ3mj2QK vPSrsLcXUm+Lxa+XyFX2QEUYoUtZT+oyxIIlKj0mNO9X7KtzF5XLz6xd4Q9907L02FYP quUai3BryRZ6u4OAABsF82WqwqQ9XOE+2j940ZVnBFkCBBFuyCo4bJicT1iEz1K3zzIE AYSTmjBLFeONNBfMe59AcvEOtjRxzoT/oDpdywXiogiuM5mYysQSeNTe9zNINc6/tF/0 J0RA== X-Forwarded-Encrypted: i=1; AJvYcCVUcg6WFnx066boOePb5+cO+sWvUlf/qG++oNYuySdPm5CquwgL0xN6MLGeZEM5Wp3v80V6vr6A1Q==@kvack.org X-Gm-Message-State: AOJu0YyEEJ4pU3LMLZ+P5j3FV3vpBp0HHJCc4zSVJhFCoAD8lC3TSIHD EFpeD97UDitOQ86d5NN3YIiKZSQB3sBQVaY8GEwnLp0DXv7ai8aAdCssLaCP4NI= X-Gm-Gg: ASbGncsyuklrvTBNUXyWne4I381y6dPHgGFSXq9/j3SjRj8ffCKgGG/WPatN6qfYlYm jbU43EPJJzvJxStpwbRUYpjukJd1YZL0t+ZVsT22JYvgmyAie8/C1FxGCG5yQ2BIBeBJi9h+/qH b3nqxoqkEXUAAcEFcaXW+o3qaHOAHoqbPz8cno1Cf87l+ZeWumwm1TNTY49YyvLBCs14vkEslmH ARyde8aitMIq2/SOU8fDJclLiTaNq3cSbP099RzLY+LSWw7UX36PFiRsQMUyr75fWXkbYTf4B9O tqO7c8B5+BB2JvO5m0pG52PaGt+a+6qJCKX7+MUw35qojz96MHvXTBI= X-Google-Smtp-Source: AGHT+IFBiajcRqof2sDefXcLZ3WaH4m3mlxC0eaX7BM/iU+6OvZhFmWXLPQ08OqoFFdkc3vUHBeCyg== X-Received: by 2002:a05:6214:486:b0:6d8:b594:c590 with SMTP id 6a1803df08f44-6dd23307cacmr367478586d6.6.1735313759312; Fri, 27 Dec 2024 07:35:59 -0800 (PST) Received: from gourry-fedora-PF4VCD3F (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6dd1820810dsm77246656d6.131.2024.12.27.07.35.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Dec 2024 07:35:58 -0800 (PST) From: Gregory Price X-Google-Original-From: Gregory Price Date: Fri, 27 Dec 2024 10:35:56 -0500 To: "Huang, Ying" Cc: Gregory Price , Joshua Hahn , hyeonggon.yoo@sk.com, kernel_team@skhynix.com, "rafael@kernel.org" , "lenb@kernel.org" , "gregkh@linuxfoundation.org" , "akpm@linux-foundation.org" , =?utf-8?B?6rmA7ZmN6recKEtJTSBIT05HR1lVKQ==?= System SW , =?utf-8?B?6rmA65296riwKEtJTSBSQUtJRSk=?= System SW , "dan.j.williams@intel.com" , "Jonathan.Cameron@huawei.com" , "dave.jiang@intel.com" , "horen.chuang@linux.dev" , "hannes@cmpxchg.org" , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "linux-mm@kvack.org" , "kernel-team@meta.com" Subject: Re: [External Mail] [RFC PATCH] mm/mempolicy: Weighted interleave auto-tuning Message-ID: References: <20241225093042.7710-1-joshua.hahnjy@gmail.com> <874j2rp6or.fsf@DESKTOP-5N7EMDA> <87cyhdhon1.fsf@DESKTOP-5N7EMDA> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87cyhdhon1.fsf@DESKTOP-5N7EMDA> X-Rspamd-Queue-Id: 6F036A0010 X-Stat-Signature: xcfwf65d4nnj7f5pzj1ozf5fcmo7d1pa X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1735313729-902730 X-HE-Meta: U2FsdGVkX180zva+epOnDrvVOMmJzu1hYBKFrOU32LoJ32nG+kiS5l5CB1mAa5bOJZ7CQ78Ab9WC6QWgAIduV9w2Qzhw9sRk6aKFjHSHj7uIXxj3UAvQlNwfixqi+4MoCZa01uA7o3taQNdk7nacyVrrn5sDPr72aS5BQIZ9VeyxSL81KwzVm46Gt3jzzqg1j/leRMY8hpm9Rlv64ItyroSLCif5nKz14/2wUzs3ULTtEsbbzZxQ8hgamKwua7SJbjbLgPJwhIneqnaHMz32DIKfhB/DeZVvuMRvjlF/JFrIpAC3mP5au0HI/DqzP+VxWF/VI6HDpgHgqP3g20oIIF2jwMExBIlAKqP0JVSPLBhwA8d6JJiioq2T2Eole4WvpHNeBxmpJ9SqbiGdNDTfUBBdHRzT/3MSSuu0jf9HDOJBQIqCJzaV2nSMDHRqgePUGMSbAbTKDmjjjTz2PiNzGKIQTXT8lMfyN6H0DlXYCZB4Oriqvn7tFNRX561CmeJPqyf7FW4RqD4VvJueiFNtP+I6xgDIW040AcbsRPQAm+zMOvCJ1EFWST2KinpAqIbbc/pO0hHfJLGURVULuIIRnbeCcOKMwkWxoDUGZCEj41rXU3SfCm/UIgDL5VU2VHwVzRDGuaVi9NZi7mNqZewf4yHHVsvZF1pO6MQj4BXwtvaQknbPvmIwwI/HqFhDESdmT5m9lPgMr+yTIPHzNXUcJ8Hf6Gp+qxjaqHCPV8UbB90fi3b1p8jE7a/VAeVcpJG7Z3utCeqOFqYAcfsFp/gAzbtxPYVAGVWhV0z4v9lgE/JqrgwXAvcqXW2prCH1FZFedTLdOpEQAkGNKxhqDI18fx59nhh5x4g1K3BecNLn2GXtmUjNPeh4WKRsEOF7uE+1vYyoK6XJVI5CMAvi8rWNUwB/ohteXYtoTQkWgdUdSdEmNi6+ZWdKyMcWPsTqQGoCTGBl3X0EYVH8y0DwXvO nV4KD63i tLLnPS2S1v2BK2xnht+bK1NQuY8z7tumc+TYkEacvN+nBINLdgTMPgPh3sKwpGLyR6Jd1wNkXiqsQyfYdK+WLmM23UoPIOEo4Je5lB90uVLxds6ljHsW8PfQWBboX/f2sDKDh3wxmmhQNPAkSVatzNTMCEgjSJ1MX3r788/twkwI+7rxRVIEvF0SJWMBVDvKD4o9ooyXEKVX0e8fGJNfui6e77PwueB9HQUDEhh8zcpVi2ylMGGx73tIYT25as0P2RLgDYWex2ahH9/bce80qm80mW/UBscHU8qosHT2FprVGB0JWFidQUCzq3mbkwXoYnrCK10lC9sA/v5aVf8ycWW5NzvruJ/2+uIgTLqi7IMzsQ9UO61vx08JkSTFliXa1FuorFMftoH0lgpjDevIHet89cO/NImaSWMS6KDwb3+XCr85BeLuSW8bCEo3s71oPvIIe30rdOZ5OAgNuf7TrqPvNSxdsgllzwo1kAYuvQkCsJv2t0JYng3iogw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000212, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 27, 2024 at 09:59:30AM +0800, Huang, Ying wrote: > Gregory Price writes: > > This still allows 0 to be a manual "reset specific node to default" > > mechanism for a specific node, and gives us a clean override. > > The difficulty is that users don't know the default value when they > reset a node's weight. We don't have an interface to show them. So, I > suggest to disable the functionality: "reset specific node to default". > They can still use "echo 1 > use_defaults" to reset all nodes to > default. > Good point, and agree. So lets just ditch 0. Since that "feature" wasn't even functional in the current code (it just reset it to 1 at this point), it's probably safe to just ditch it. Worst case scenario if someone takes issues, we can just have it revert the weight to 1. ~Gregory