From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AAC2E7717F for ; Fri, 13 Dec 2024 16:28:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0AE966B00A1; Fri, 13 Dec 2024 11:28:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 05E586B00A2; Fri, 13 Dec 2024 11:28:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E1A9E6B00A3; Fri, 13 Dec 2024 11:28:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BAC4F6B00A1 for ; Fri, 13 Dec 2024 11:28:21 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7ACD1AF709 for ; Fri, 13 Dec 2024 16:28:21 +0000 (UTC) X-FDA: 82890467226.03.B09F97F Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) by imf19.hostedemail.com (Postfix) with ESMTP id 39A9B1A0022 for ; Fri, 13 Dec 2024 16:27:52 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=G8pVZ4qG; dmarc=none; spf=pass (imf19.hostedemail.com: domain of gourry@gourry.net designates 209.85.160.181 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734107287; a=rsa-sha256; cv=none; b=5y/HZZLOMQT9qsj3LO5eCxnKqnoGAGn0fbm4bNueTJg5uNCN6EWtf7vJM6zLCVQ7Kk7Unu KmAv0rXH1SyHV0QO8Psmp6P+SsS7V1WWOpIBVnMEB977bvj69tFWn6Sj1VhkXJlESNRrBN Hs61qXbFYtB/GFP6Ndv2dhIB1Kjgu2s= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=gourry.net header.s=google header.b=G8pVZ4qG; dmarc=none; spf=pass (imf19.hostedemail.com: domain of gourry@gourry.net designates 209.85.160.181 as permitted sender) smtp.mailfrom=gourry@gourry.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734107287; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0HkpUMdpT1bOGFdhaxI+95tgENUX+xpDF8wyAC3G/e8=; b=k0/exo2bO+cm3EU2pwmohthXkn+yPxWkiJY7NkNyBkqBEIrNZuw9KVTOzgLu/fOJMzF4kP 69vQjIvx9eArCW0fTJRwxgtMcyORzW75+LMQSZkH0bqXqv4g8T7trpqsCBk6YxnJu1Rig0 UPlcV6WEiYpP+ttbUuxvjabfRFIwtQU= Received: by mail-qt1-f181.google.com with SMTP id d75a77b69052e-4678f681608so20748191cf.1 for ; Fri, 13 Dec 2024 08:28:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gourry.net; s=google; t=1734107298; x=1734712098; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=0HkpUMdpT1bOGFdhaxI+95tgENUX+xpDF8wyAC3G/e8=; b=G8pVZ4qGCrWeg7ys0WZTV+an8A/5hAESN1N3/pl0uCHA7uXjBWLwNc43mIGYjRQAxJ 4HzY7q6IlvA+tfTSHrXaSbdezYblQNmX/CFO+1TH8PKejFYjcTsmoCpw8ZMAdgjvtwo7 3lYstVOMyM6+wuvwHz2pWxMDqIQsmD+uMw/UOmHXTqLzW02c59zFzf6b7ObxPzDbsmIV nZgCQkT6dz+004fEIyKyKlibXQWPo+F9nRYkxMUKHtqZdsDTzX1yNfqBl6cbs2e6atDJ h5bPKD33CWmCF4dMqRgZSD5hsgUJ5njTusQcclb9LXql7sqHVxkGD60eVayjA5DFgnQ+ LqUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734107298; x=1734712098; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0HkpUMdpT1bOGFdhaxI+95tgENUX+xpDF8wyAC3G/e8=; b=PmRxYJlP0jqj1TLsugt1dJNrksCA9+bEmd7IehM38ez7euDjF4M3TmtBf6E5mr2Lhb B0Cqz3qkoa2o+faZa4InwChtmXMcNwGEB6CKheaCzIAEB407Q/IrOZnz1Z5BtXs6yHp0 Ps8MXU4hsgc44PRgzRvqYkGZm1Hemk3wCCgM8QU/F1GQMGumJrieYt1O4uLfdZU9LqY8 zPA/QRjLkpa0tQzVMYQZoeGOORD7qBNJ42SG6BEt8g7CD78kldWfBxvV/2qa/VMdHD+O QVXI0ricuu9qv/5PJaTTy94eSC2IN/MaijS4nJBVohtEjr7q7nGEuF3lEfGh+gVbozU2 08Jg== X-Forwarded-Encrypted: i=1; AJvYcCVY7K+60KDDL6+DtPa1uxh6Q4BTugsd4D0cDp+Cn7szJJzjig1PTpdWvIr/hK2CxaJAK7CwBz7k7Q==@kvack.org X-Gm-Message-State: AOJu0YybIGM2MPkKeu2fjTge/hFjNTFCCGqtdBx/fM6QF0ytjswW/EUH NLe2N0ZLqWSJpEO+DkffntVMEUqTTkQpAYuiK0b4MPaC53tPIhZVrmRqfvbhY0Q= X-Gm-Gg: ASbGncvm9VM25shr0Wgs80zS1IQYtjuin+vDjh3wFrPrLdMQre3AUwlkm1R0BNz2R8H xc+Dy2JNIc18IDLqms/MCJOO92WPvhMy3j9SrhhR3W1noLYtD5bMT/rhsme1C14AAfmbqn/mu2S tdK5OYigDn/6r9L/C7c9onou+dckJ7qFsrlle54UTKHBMdcy8eBkRiiTOom2jrr6DGXU1DMzvJv IRd6ANulHbpxiuI5CTIsY/Rk+UpKUFwCjvAUIL9McU3zIDNyjQAwwZ6hgy9esLbs33qKdtpkVj1 HDB4b4L5iDHQfZiFM5jJH9PM0ncSsI0baaJyXQZCuw== X-Google-Smtp-Source: AGHT+IHEbODzADsorYd+LpJC068MW4TXFz13cw2XglTXpEdo0jaL87bcR5cQpr16MMrGC5XroMk8Hg== X-Received: by 2002:ac8:5a93:0:b0:466:a983:a15a with SMTP id d75a77b69052e-467a581d253mr49010891cf.42.1734107298364; Fri, 13 Dec 2024 08:28:18 -0800 (PST) Received: from PC2K9PVX.TheFacebook.com (pool-173-79-56-208.washdc.fios.verizon.net. [173.79.56.208]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4676e091d95sm49623571cf.12.2024.12.13.08.28.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Dec 2024 08:28:16 -0800 (PST) Date: Fri, 13 Dec 2024 11:28:05 -0500 From: Gregory Price To: Hyeonggon Yoo Cc: Joshua Hahn , kernel_team@skhynix.com, "rafael@kernel.org" , "lenb@kernel.org" , "gregkh@linuxfoundation.org" , "akpm@linux-foundation.org" , =?utf-8?B?6rmA7ZmN6recKEtJTSBIT05HR1lVKQ==?= System SW , "ying.huang@linux.alibaba.com" , =?utf-8?B?6rmA65296riwKEtJTSBSQUtJRSk=?= System SW , "dan.j.williams@intel.com" , "Jonathan.Cameron@huawei.com" , "dave.jiang@intel.com" , "horen.chuang@linux.dev" , "hannes@cmpxchg.org" , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" , "linux-mm@kvack.org" , "kernel-team@meta.com" Subject: Re: [External Mail] [RFC PATCH] mm/mempolicy: Weighted interleave auto-tuning Message-ID: References: <20241210215439.94819-1-joshua.hahnjy@gmail.com> <4ddfa283-eb64-4032-880b-c19b07e407e1@sk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4ddfa283-eb64-4032-880b-c19b07e407e1@sk.com> X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 39A9B1A0022 X-Stat-Signature: 16xf8xshndbzjbutrafc11kbm5bgirp3 X-HE-Tag: 1734107272-407162 X-HE-Meta: U2FsdGVkX18YQ8Lfa0mD3GH6uvCQZdcUm5LEcboPv/fUH9udMtdYqsY1+QMR+Get8QFuxsfd0g75ly/m8byH1q+Ixx31K2jLfZlPfw1oynI5tbLe5w5kAEUmxA/pt2ITl/k3NdLH6lpVVG6v7OHZGA7fT2PkdjnsGkzO7p4xal7XAEeLad33YcvXrClifh4W8RjA9WFpSrTB2WCpWYmxRfHlntylMRelQUjaW82xVDZXbLD2KR/v/WRaauwQ6U7oK5YKkQhoPEmqoAPWBPTXCIXre7pIgOYstTsF6L2V4JEf9QXLiV2QHYLaQJZmtTKcMuFQuqHtx75970DwsZm3705dKdWPQm2PtLzVsn2548uFyzrvx1UnyENwBo8XhDGaOJXxgPdFb6zJd9zi0OlnmMLDvm0azLn1IAM9b4HN4gNjvhxVwUb57hJf28nhDmvGwlGXMUcScbmugnSKJ4pb61XF5TdDGf9qW1rF+cFvdMeLzLt4enUpQZw/0NHEwSMT7XUEBFF7yBMTQddNuX72vjZyIjDMaPgfqULZnJpf9ibNdCxBWP7tQ5tKxkn23FtkzM31s+4PzIuR/yvMoDyqbo/3KVK6WngxB8cs14zSLp9wOUnK1P53JJ4EJ4idBcx0qox+PmU3xCkq7pwUdR7QlJF3TSHtA4CBejaOLpFp95/yHhfFVuGWz2Kv9MNvT3DIfze0pfuyq/GOGMatGOeMSzG5QMM5Cg0pGU+uPWxSOXrZ01Xa+Hu6tLmN42UJUAZxSZ0LL57O4woneG+crdf9leE/SLDxQBBM9tS5N+NUQUXn8e4X3eRsE9UVLP5StPcLAPYU5HPJ2IECSn3pMpFmK/n+oeRue/yNF60k+a/ZDqZlwpPkRevz0IN0VfDUAS3MbS8evTscjBpKJqiy1eabfa0w1M353x6EnVh7IFLZI1vlx1saP+DyUpOe5JF8iU7xCZuBmyaIidd8aeJFUyf DB7c44Tk Yi+aSrRVlWOM+gAnnRwZ7onEA47lrfoDdY7SeQry/FuubJbyiPuBMB+TPetYFgjT+HjAjakjkmCOs1SnOyzzD3JZWIAvqUHD4PiQTq/IZ686++yTodfYJGa9JKxe+MZZJ3fudHRVSgemnwfgEoMC8ybpdJkkOGJJ9JFVGPFoXRjThOUc94aw4yGrSUtz1QCaHK0ijyGGdSNHRX7sbqV+YsKnXR/XTc/K5zebtxM99b0eK1ebIGMOvn4QhtFChqsy02vF/jb7dyQ9+F01jai6bdHEEngw1FpR7QVTaS+xFpQFx/kCvpbvE1Nf09iSfhqss4Jsu0bVmWP2UZniIS+zdJsvXb0Z8ipzLNbVaHlJB9N8MJ8JmMqRfOdA+yPDWa/GPfAnBwhETZsd+XQ5r5KRoB9t4Xg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.063115, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 13, 2024 at 03:19:20PM +0900, Hyeonggon Yoo wrote: > On 2024-12-11 06:54 AM, Joshua Hahn wrote: > > This patch introduces an auto-configuration for the interleave weights > > that aims to balance the two goals of setting node weights to be > > proportional to their bandwidths and keeping the weight values low. > > This balance is controlled by a value max_node_weight, which defines the > > maximum weight a single node can take. > > Hi Joshua, > > I am wondering how this is going to work for host memory + CXL memory > interleaving. I guess by "the ACPI table" you mean the ACPI HMAT or CXL > CDAT, both of which does not provide the bandwidth of host memory. Then your BIOS vendor needs to fix their ACPI table generation, because HMAT can absolutely contain that information. [078h 0120 2] Structure Type : 0001 [System Locality Latency and Bandwidth Information] [07Ah 0122 2] Reserved : 0000 [07Ch 0124 4] Length : 00000030 [080h 0128 1] Flags (decoded below) : 00 Memory Hierarchy : 0 Use Minimum Transfer Size : 0 Non-sequential Transfers : 0 [081h 0129 1] Data Type : 00 [082h 0130 1] Minimum Transfer Size : 00 [083h 0131 1] Reserved1 : 00 [084h 0132 4] Initiator Proximity Domains # : 00000001 [088h 0136 4] Target Proximity Domains # : 00000002 [08Ch 0140 4] Reserved2 : 00000000 [090h 0144 8] Entry Base Unit : 00000000000003E8 [098h 0152 4] Initiator Proximity Domain List : 00000000 [09Ch 0156 4] Target Proximity Domain List : 00000000 [0A0h 0160 4] Target Proximity Domain List : 00000001 [0A4h 0164 2] Entry : 006E [0A6h 0166 2] Entry : 01FE [0A8h 0168 2] Structure Type : 0001 [System Locality Latency and Bandwidth Information] [0AAh 0170 2] Reserved : 0000 [0ACh 0172 4] Length : 00000030 [0B0h 0176 1] Flags (decoded below) : 00 Memory Hierarchy : 0 Use Minimum Transfer Size : 0 Non-sequential Transfers : 0 [0B1h 0177 1] Data Type : 03 [0B2h 0178 1] Minimum Transfer Size : 00 [0B3h 0179 1] Reserved1 : 00 [0B4h 0180 4] Initiator Proximity Domains # : 00000001 [0B8h 0184 4] Target Proximity Domains # : 00000002 [0BCh 0188 4] Reserved2 : 00000000 [0C0h 0192 8] Entry Base Unit : 0000000000000064 [0C8h 0200 4] Initiator Proximity Domain List : 00000000 [0CCh 0204 4] Target Proximity Domain List : 00000000 [0D0h 0208 4] Target Proximity Domain List : 00000001 [0D4h 0212 2] Entry : 1200 [0D6h 0214 2] Entry : 0064 Obviously if information is missing, then manual is the only way forward. > > + The maximum interleave weight for a memory node. When it is > > + updated, any previous changes to interleave weights (i.e. via > > + the nodeN sysfs interfaces) are ignored, and new weights are > > + calculated using ACPI-reported bandwidths and scaled. > > + > > At first this paragraph sounded like "previously stored weights are > discarded after setting max_node_weight", but I think you mean > "User can override the default values, but defaults values are calculated > regardless of the values set by the user". Right? > Agree that these comments need clarification, we'll workshop it. ~Gregory