From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A304E7717F for ; Fri, 13 Dec 2024 18:19:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C004E6B008C; Fri, 13 Dec 2024 13:19:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BB0686B0093; Fri, 13 Dec 2024 13:19:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A9EED6B0096; Fri, 13 Dec 2024 13:19:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8409B6B008C for ; Fri, 13 Dec 2024 13:19:48 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 2B135AF313 for ; Fri, 13 Dec 2024 18:19:48 +0000 (UTC) X-FDA: 82890748206.06.20C30E2 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf16.hostedemail.com (Postfix) with ESMTP id 6E5D2180005 for ; Fri, 13 Dec 2024 18:19:19 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Szo36KE7; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734113966; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pBRhGkgZxX0zvUoQiesXTl3MbXRcnvzIGjRjrAAWVBo=; b=KmHqY+Q/cDIY+gImxeYoTKHkdDIDOIroW3RpmwprhUTJ16kSCXhJeoNq8RqZW9mD+pGa4s +ELTvUHUuJGrmebXpDKamoyldNCekMXmM4OicpLImXsugjOW4N07NFP7BhSYTom+u7okCA dYrTQ0LoQugXq+G4s70IJiV4l+ldvBw= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Szo36KE7; spf=none (imf16.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734113966; a=rsa-sha256; cv=none; b=SoBQk218gTJZILxQttYNkFjkNZvN7qvnKyfqoNPDVXgl+O8Z8qHazQTwQBXkheRWFfC5dl jvHppJcGaWrrKvhwKEN9RsTXJotUzDuoq0Pq3m5aV7G/8hLq5+/AlT3h4KaCyAEjSZZQ42 NRv8cimYOjayNAD2OTgiVPJuUXpNtOk= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=pBRhGkgZxX0zvUoQiesXTl3MbXRcnvzIGjRjrAAWVBo=; b=Szo36KE7ZNhm73wXRKShO7e9ux UDSS8PZfynPyyw1R4y3/X9qj73BvIXwPMen1+yE+HLxQvmj47oMq/hjcgUY8+FQXFG2DwnI0O3AkA L+Svbl+w82guGUZxmYEhyx3MgDetTHMXrEO1x/2onPFMDQCqp0fZEwHqnouJWXyYk408NBgl10J7K m6wl9OwNsN68fikh8vkVMNGDHLtKUJG1QlPmAupZfZ6kq9fFxpf+Ft0DEJiFYtA0kgfbB6rTuniRv IlXKeE+v2DSD3P37ylahyUXQzo2jbARUu5lR5wRMM+ui7OoNdglN/JRcrYHFgh+xeWm2UXg3iAMVG KQerXNXA==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tMAG7-0000000EtDL-0PtS; Fri, 13 Dec 2024 18:19:27 +0000 Date: Fri, 13 Dec 2024 18:19:26 +0000 From: Matthew Wilcox To: Suren Baghdasaryan Cc: Peter Zijlstra , akpm@linux-foundation.org, liam.howlett@oracle.com, lorenzo.stoakes@oracle.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mjguzik@gmail.com, oliver.sang@intel.com, mgorman@techsingularity.net, david@redhat.com, peterx@redhat.com, oleg@redhat.com, dave@stgolabs.net, paulmck@kernel.org, brauner@kernel.org, dhowells@redhat.com, hdanton@sina.com, hughd@google.com, minchan@google.com, jannh@google.com, shakeel.butt@linux.dev, souravpanda@google.com, pasha.tatashin@soleen.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH 3/4] mm: replace rw_semaphore with atomic_t in vma_lock Message-ID: References: <20241211082541.GQ21636@noisy.programming.kicks-ass.net> <20241212091659.GU21636@noisy.programming.kicks-ass.net> <20241213095729.GC2484@noisy.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 6E5D2180005 X-Rspamd-Server: rspam12 X-Stat-Signature: e3coj9wy73cfph74fxy48xn183d47twd X-Rspam-User: X-HE-Tag: 1734113959-323113 X-HE-Meta: U2FsdGVkX187ZprCLsjUyd6tQck2oFCEb1HYv0s3N758t9iDlHE4TkROFIToyvwlBRyxS8thM7m2BkbXQ06W1VUzJPVHKZ9U/neG9zpeYH3e98XdJsA+BZGkb7z98XkzCwv5gTnU2PqaX/Jv8NH7byP8own7uUo+3GTITM9wdrxt0tqMFFE+Wr601bLjEOH8tJ9UcIhr7qaqFPvGkRbRDS86KQXmzwtPMPK9mrt6IlO4G3gSAKuU3GXFEirbQghuWRzEoxRwVZchQXTDdzngPHw+LA1Gwe3pW0DHXjP/NuXb90N9gIc7G49ufq4fLsMsk1uVikSYwTJi0k73EnhVj2UahQy5UUmoq9IIfJ6I4g75aCmE3+b/IaL+JSweRkKEGXg8el0ByzSVZ//3XMEjwV6xSFCPJIqX+KkqUefgEiKiJZDieS3qCObZJEBdFIPhAbs1mB6m6T729CThVGOQuEWo3w/AO8kzd8+sgp5kduBl/2DU827zkkRiYBLDBqNeAbf+sAZX+aQ9+SFVUzdq4ffLnSjfRmOSOe/1FCIySAb2argkd5MRpXsIRgKaSA0/IZ5ExEvrEq5huQHFxmS7jkmN0xak3Zw5aayZflrBpc8IkdAr/3x4cX+9sMbVH5vGc3Y+mMNR0GX/9CvWY2u24/7EXI/nbQZikfRi+Sd73Xmcr8p4+wjcoS5Renazlpl7bsq+h7DAJpkZf3Nr0ZaTWRo2i+ydW8EpWbjIIyi+IryDHTJ9Mr3yKxam1Py++OKNbgJ+1whGL1I+l2nP2NFEWNii5rWxmPRK0B50PlR72CpfK8UxPEFDtlDSs1D2TqBogUBcly4XdHIjZo2dQYP+jE8Fytiwy7vHhxAGBVaZrey/FR9Q/ZzPKaobdjvRzQerJhl9n0HXzQpKIVuQqO2RkfM7dcpEVwvB9Cs1LJEDCO9JMBxSdGG+p4RB6zj0t4WlG4A+37BOQV4oQMqIyGz utSiXrW2 YcBL61Z3DxHTU4xhlJ5fOwAiAN8uuYhiqIN8UUwwMTEmheJVJ3plw5v7XH3xEOUA8R6ZI6AyEpDdE6yi3qfgueMJ4+ePot7/fMl7fQuPqztsu/OzO05aLXIfQ1g4HN+TU0HJijE36/xJ3v7bVb2ZJxwkNZ1aapcgnfVIBDuIKySlTo1kwF1Ur8RAEqxkXmU1xKcPLyi7haJdF41gUehK0hnU/qnL4cvcbcc91uFpbYNtHaHqGxZEofp8rHlIfYO7FavlRXFVcAihCDF76Qm3wurttkg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 13, 2024 at 09:45:33AM -0800, Suren Baghdasaryan wrote: > think the simplest way would be to move the definition of struct > rcuwait into a separate header and include that header in mm_types.h. > That, with some uninlining like you suggested, should do the trick. I'd suggest struct rcuwait should live in types.h alongside list_head, rcuref and so on.