From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 330D7E7717D for ; Fri, 13 Dec 2024 14:00:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A4A546B0082; Fri, 13 Dec 2024 09:00:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D3C06B008A; Fri, 13 Dec 2024 09:00:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 873BD6B008C; Fri, 13 Dec 2024 09:00:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5AB926B0082 for ; Fri, 13 Dec 2024 09:00:43 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 07187AF5DA for ; Fri, 13 Dec 2024 14:00:43 +0000 (UTC) X-FDA: 82890095526.30.D9603B4 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf06.hostedemail.com (Postfix) with ESMTP id 94BAD18001C for ; Fri, 13 Dec 2024 14:00:22 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="N/unFoiP"; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734098414; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=b/zRpTKnrIJp0faKm/LlsijhU32ffBRRjkg4+JwIMG0=; b=DGa2NQQ7nV3rgF0AcmzprWaLMQZRF4tM0ybOQV/bTJyVyeXbSu7zhHVnKcFRSRWzv15KUg gLys1B0rvN71uVactJBTm0JpNOB2CLttsgCVDiyOVUmm53K7Jpu9wBXnctnzjkCwIkMgfE JSogt7WwjnG0Fc5V6onawPlcAR2Qj2E= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734098414; a=rsa-sha256; cv=none; b=YoZk07H5oI+c2cux6AtaxEPaU9Ocl4jjjE23SY5Vq0n0oCy0md+GGPmxDNxsMhb3O+HkVu wLLD+9ITDEHDttcfAIekMMe6YnWfrxt/hlCWWnNINX4fcGxtolY/djKx07qjUyNi2gs3B/ EJihtbNa052OKphPRGeHi+OAk+1st3E= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="N/unFoiP"; spf=none (imf06.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=b/zRpTKnrIJp0faKm/LlsijhU32ffBRRjkg4+JwIMG0=; b=N/unFoiPoMcBVEWrdz/bseksnU HWyNFmcLTMrnu6Zyr+SGyur+eniNVij+jh/zDoP++OgLVnsJ3WqL2tQU+v9pBDb95AJANvRSm3Bpo j/RpiivvX8i9N45u1b/4rLrAzI5qaE+nOzvYsfTmvjSvFG+51Y4uRAzMWxqTuISPD5fNX9wxy4cHn Yx/8IbBRjX8ym9ZLPpVUH2dLKMf2yuMb7cJpjEoBgnEeiSm56VQfwQeobrYvzIhD4Fq+t3WGwozBw rDsH/dn31ywKWga99p0GWS6pIUjvJVk52C4O6uYZa+UFWmI15IVusWol4lGeoKtu0E57WNAarclIp 3kmRnbEg==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tM6DX-0000000DNGx-1Myu; Fri, 13 Dec 2024 14:00:31 +0000 Date: Fri, 13 Dec 2024 14:00:31 +0000 From: Matthew Wilcox To: Kefeng Wang Cc: Amir Goldstein , Lorenzo Stoakes , Jinjiang Tu , miklos@szeredi.hu, akpm@linux-foundation.org, vbabka@suse.cz, jannh@google.com, linux-mm@kvack.org, linux-unionfs@vger.kernel.org, sunnanyong@huawei.com, yi.zhang@huawei.com Subject: Re: [PATCH -next] ovl: respect underlying filesystem's get_unmapped_area() Message-ID: References: <20241205143038.3260233-1-tujinjiang@huawei.com> <69b72e3d-b101-4641-9ce5-51346c93a98d@lucifer.local> <041dcc1a-0630-27b9-661b-8c64a3775426@huawei.com> <568698a0-c2f2-45d8-9d8b-e22e942fa422@huawei.com> <3207edaf-826b-4545-9c9d-906bfb4d312e@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3207edaf-826b-4545-9c9d-906bfb4d312e@huawei.com> X-Rspamd-Queue-Id: 94BAD18001C X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: rwf1i58zwuu4foutgega6q6a8xdfo6r3 X-HE-Tag: 1734098422-364477 X-HE-Meta: U2FsdGVkX18Iww2Fh8VwedVcRkLGD7du+AQR/zg//TlDc/z3ZPmp0vyZrEaPRLpAkTjHuQsCYHwdw6GRh/iWuZdaEwm0NNGrZhXroth1cCG+alfEakT3vy0GjY/ULUXkrLk+Iw/HK8Wqo69gIkXJjYxX76lcbNbOH+bvaIM176HDh+3jCjC3QWAODNYNIUWTzlGCOBd9bi9qVLOYez9vpjrBvS1zD4RRBcBiZ4h67o67RBsIFCJ0DeASk6LJwh2KhWXMjYazG/BgUEeGv+yWZEq/40XEFLNmf5fO8pCSe6JQyifsYd+OV/QHFlJtq0mE4ltTzjuK6T5NFHY7zdr8EJ4IiZRallmyE9KeoBjGGoWt4HnGSfHIQlFtVyogTXW7obrdwz8XrUyKdCujbyC4H7BHok5pQPTVqtf0FSKuzef0PgH+nzOHvPXQBouJzu8HgDL8mTKB8yeiAml8DZx4u024xMQg7GPxljCJgaUVUwIoogQZVvNxvKDs079ybJ3+6VhbxzuA38yTcWKPRHvzIcok4TEVt8nNkUfLl04NXaFqqV6bGXy+xVgjyis7rnfbRpHKRthHa+KbaamgZKDvPn4MjnxoTjTK/3z0UVEl0yek/+x21W3m60WJ0RI6vfJddC1h6EF8doOZt8MRZAiL2QDFYNfOCK39SyqvK3NqkLO1qDAB4Ee9NoVv8o5Yja6GuVkkEPXeII78zI1Z2KcXN3ohBukaT28vtIb1Pk9/8NX8oKJ0acysiVmOeODu2YTTPKHK+j9A2kVQFhNN5wHrbXRmRHs0mmbuN3YQ5hoAwRbCcvLDuadt39isSnLHcDqdVzUM1Os/Wy//VbPUvlBYnxknA7gqCtbaAeDrhfJV+IrUziB6rP/Zuwk3NDlkYV26sWJ8NVMZOrZH+V4/bxcP6q5sR0RVnCHAP/s6jmEhQydMba1iUZ5PBpJ/AT6lTH/J4rQkt856VMwAXDbJdEb BKzvSWmO ILASqRl3V5n6391lT6+mO0IPAWtT+8qMBEHRe+RkCN5jgmcLzdIBZIbVZhzwAsA6Lj80cqJyTcrU4wJypcxpld6RWGqhhNujTbbRl4R5amt7q6Zv7lIOATMxrwFr1lnkdPop3dulJqEXAxl5tnoVT6eMXUCy0XdC0crNwWiR3kPzzoITMZrzRYwbajOj1U+B8k1pUG3REnrUTHvv+skmScuWXtgUvdM7+Jlf1/BJGf0HnweX4jr9x2AHagkkFD/YHuQSV4SmGI7tR+VhX7Jirjz44Sg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 13, 2024 at 03:49:53PM +0800, Kefeng Wang wrote: > > > On 2024/12/13 12:25, Matthew Wilcox wrote: > > On Wed, Dec 11, 2024 at 10:43:46AM +0100, Amir Goldstein wrote: > > > I think this patch is fine as is. > > > > This patch is complete crap. The test-case is broken. NAK to all of > > this. > > > Hi Matthew, regardless of the test case, the original issue is the > ovl don't respect underlying fs' get_unmapped_area(), the lower fs may > have own rules for vma alignment(own get_unmapped_area callback), > thp_get_unmapped_area() is one case, what's your option/suggestion about No, filesystems don't "have their own rules" for get_unmapped_area. get_unmapped_area is for device drivers.