From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0004BE7717F for ; Fri, 13 Dec 2024 04:26:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 78B556B0089; Thu, 12 Dec 2024 23:26:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 739FC6B008A; Thu, 12 Dec 2024 23:26:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 601F16B008C; Thu, 12 Dec 2024 23:26:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 3FC436B008A for ; Thu, 12 Dec 2024 23:26:00 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id BBA7C1C736E for ; Fri, 13 Dec 2024 04:25:59 +0000 (UTC) X-FDA: 82888647534.11.66DABD6 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf07.hostedemail.com (Postfix) with ESMTP id 6C28940003 for ; Fri, 13 Dec 2024 04:25:25 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=HOoNQD3U; spf=none (imf07.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734063930; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=My0SHQUpu62rcyOrwOonKkzsemVCfWxmo1o+OnfXBuI=; b=wzUADJl18ZxJv8BAeMdBY+STOTWe1Jtt3mXxliHCCilVbh3thGoG01UtGCypDKucrisDXj VAauzSQvZRQL0CzdKQr1i7VRBTwMMWJsgmfaLDgsjF1PQgmi3N25CTmKgLGPPfB+cALrVA 5Xm6+CwjKiIQghb1dfFcOzjGXihh+FE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734063930; a=rsa-sha256; cv=none; b=oV42WYVRLS0Q28GKOh2f4BRRd7z8yEanOEhne6pywd/wfzlkuxedzXOcjnc/CDgSqyI/e4 7IsjXcsT0dxxb8tAxs7AfiJwT7ENPz6bOpfKxIk/Y8qDIl9UCv4rV5LyzQPF2pWJyIMpvB SlaQoCwIcb+ZDIZFabbjwpXh8JZNx24= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=HOoNQD3U; spf=none (imf07.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=My0SHQUpu62rcyOrwOonKkzsemVCfWxmo1o+OnfXBuI=; b=HOoNQD3Ulnks5Iog+Us28NwrdK 117jQcS2A0ryRhLofl3vuAnmRny644itiBM//jeYZ0UbVgKWFrjYnXM7xq7Dt6xx8f55+5wT3WAJB Uhym5UAQlQZ1ZWWvWl0evuYuC0wYSOnWtW+sbnTZLQx82mhpES+Y/Be9SIBUQ5XVLmRASbt8T5Hx4 N4P8u6d06oOOoYjQFMJL8Jx1lPY+87hXvo17FLYErF4kBOtZO5iYT+vXT8kJeiC8o2moUodlcY3Fe eyJ52TQ1xzO/8E2YisZ2/+ksAoop6Ob9UnfY8C9wWPwYHrj7mUYb92yLmoFn/S7x19wW8GZr8CLrZ e3/6Vcww==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tLxFL-0000000AFEj-32OF; Fri, 13 Dec 2024 04:25:48 +0000 Date: Fri, 13 Dec 2024 04:25:47 +0000 From: Matthew Wilcox To: Amir Goldstein Cc: Kefeng Wang , Lorenzo Stoakes , Jinjiang Tu , miklos@szeredi.hu, akpm@linux-foundation.org, vbabka@suse.cz, jannh@google.com, linux-mm@kvack.org, linux-unionfs@vger.kernel.org, sunnanyong@huawei.com, yi.zhang@huawei.com Subject: Re: [PATCH -next] ovl: respect underlying filesystem's get_unmapped_area() Message-ID: References: <20241205143038.3260233-1-tujinjiang@huawei.com> <69b72e3d-b101-4641-9ce5-51346c93a98d@lucifer.local> <041dcc1a-0630-27b9-661b-8c64a3775426@huawei.com> <568698a0-c2f2-45d8-9d8b-e22e942fa422@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 6C28940003 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: ubxopo34ej1k4wqbsawzs8afi51bc9d7 X-HE-Tag: 1734063925-596654 X-HE-Meta: U2FsdGVkX18bXNQ0U17CpOzsL603kX0/SGB1lLE2mfKWnWoacOCNC13jhJrnBHyjB91JQ4ceKgJq7jWbsseqLep2ob18h+kZ6VbpSiR9rwYQwpizF1/eXkC7+4fGb73PPdg3ahy6V7wTUKJzS0CjnNRS2Xr0ql90n18PyuYTcf3CHIfOWYUrxE+sM7bCt4Ly8bab92WSVSc1ue+Q/CSiv9WUhCUmtZiEDZX1yr7yUoev52I9w4Vgjmut8IfoEYWvtr50+Z0D29JMD3q9VOkObApwXdDyqx/3nc5g/u4/ncCUjAyUtKcffywuIXlgI/V705VGf2T9nlCsNewvPaDB52b2cnP2eKU+ysnIW0TcjE0z331rKjUK1V9xP10CQB2FS2O34brbZ+oHkv8urUNgxN9jjPLiHr7ek+JtAywgNz+vexJX7AiK1GgsAKfAG01nbOPCXPxWM2HZC+sTY2PAF2Glwxf2jT/pHXKYBIz2FaqOH/dg2bOp47k1B8FBFoZjvJ41bS90FC/0d2J2lfIQrPK0lQpCu7xOIjEAG4Li2a27YzeX6o3rR9FK8DW8F1MVI+x2cBbHWZJ2w0J5UVRsS2zlUCtT802l4s5Q8fU8tqnwGt/A6pbqzZp/6knChoYH7TDAfsYJw9tPpgt0R4gth4MDeBrAErQRbY+xD8XwH7eWgqFa+jBDjwjrdY3kj34xN2rFEmvvn2UZeYvXEKhUwiptnYgPstB3FVYbAcpS0qIETJ4Z0903gZ6MmHUrlpYBHsPwcY9EL0/NKzNtp9Ow3duTro2wfwiq4zT7Eiv3+E0uqqCV1/8E9Ck2IHGxOlBdLQ3jmRpK3gDPU4EJW1woICx9+vFENVHQ4VbSNDRlq+YeCNCEEA7lp/33jGKsb2jKG7gOMd+VOd8diIRyGz384myVtscVjGVJ6/RpHl5cRneqKx+xW5sSS0sl5OEpO3x3V4ghnXpqQBVLZMy0bGt azQkMJN0 ITRBiDGOGDHZz4e9Mg6R2Vc3iqLapcka2TuQh8Lz9CN+3qo+W9DNkTqzC7tObsFF9vdLrDkNh6SI9GP++tTctFtLrwwZY7WWcxQeYKV1/AGsVd5CIjwN0CBa2UGIO+ZP8Pp8VtK9wJT1g97iYQDQBTCWHihkI25P7EH3lHH5t2ntKkuBvnCbWnaskSQ97Xd2B46ZalBqfWotSjnBCiywTqTVgXyT0uuK//e7dpWRN6C13kFW7/UqP9/4V9CMlKMx5uIWYZgmxtg8ApRaJheXSUJSapQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000047, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Dec 11, 2024 at 10:43:46AM +0100, Amir Goldstein wrote: > I think this patch is fine as is. This patch is complete crap. The test-case is broken. NAK to all of this.