From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3D94E7717F for ; Thu, 12 Dec 2024 18:04:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 808EF6B009C; Thu, 12 Dec 2024 13:04:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7B7F66B009E; Thu, 12 Dec 2024 13:04:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 680796B009F; Thu, 12 Dec 2024 13:04:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4ABA26B009C for ; Thu, 12 Dec 2024 13:04:45 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 15E9E140555 for ; Thu, 12 Dec 2024 18:04:45 +0000 (UTC) X-FDA: 82887081774.24.3426E23 Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) by imf02.hostedemail.com (Postfix) with ESMTP id 6454180029 for ; Thu, 12 Dec 2024 18:03:52 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="PAwn/Knx"; spf=pass (imf02.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.51 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734026663; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Gp6TaF3jjaaKLYE76g5laJgR/wPOP9s3SiCC/jHJpgo=; b=sbTv8cZcD2W2Lf7lD2fGVOwp0D1YvJNLX2xMTGOWVadwOChzpaRyGr7BHzu9xoTFpuwehq LQZZCiM4/jkrV/1nrjGu7Xhi+48uegMNw9BqpHHJROvh9/aJZdOZRoAYKcSFoELZmNR8EN FOkz2lf2xPDDXnq9X1d0aYCAoFAeGME= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734026663; a=rsa-sha256; cv=none; b=qYhIfE5LaoR+TpWYCChw84BiQeTmplTx63RSwP8+5EcRaixsaW1D2R2qNnZ6coC56+7oBj YdDde2EBeTbnF7xbqprTIko54TnXt0oPTJjVIHQXWArgHJWrnA2we+fZLCqHGsllv1CRPb q/urRroAfbmhltcMdrQxCJJjrT+bCvM= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="PAwn/Knx"; spf=pass (imf02.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.51 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-5401e6efffcso1021962e87.3 for ; Thu, 12 Dec 2024 10:04:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1734026678; x=1734631478; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=Gp6TaF3jjaaKLYE76g5laJgR/wPOP9s3SiCC/jHJpgo=; b=PAwn/KnxF9A90FRfGuZsHxxPy7mWTx8a6bigQuyy7kjkORv6EdSXfSUSmm6r5cF4V4 hx+UvXV5lt3BeHbI1F3PQC6yZyFoO3ofxmR6WhXsIEHYAKevc+w8Y9Xn7aaX0Jn+9vxa RgRnTREWIyLj4V3kukShUaplLe5p2UxqrRVFaoqrK1xpoYNm24rVBuIW2/4jVCFAAxuw rd3yQ3GAqTdliZSEcKCaDI1/rPLBUsiB4OS1Z9q4AYPB5BFqnlb7lhni+bqXESW3Zl9i DMETKEfexTYbqQqvzAFzDuT76TCrUkTJRGl1c9VWsIi5PMiAQO8KnEiei2XH8z0Ou6SF H8tA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734026678; x=1734631478; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Gp6TaF3jjaaKLYE76g5laJgR/wPOP9s3SiCC/jHJpgo=; b=MpNL6yPV7JQj9lVUNGcJdQFtTCGnY8Kqk2iCWVirbkkEi4+934lNTJwr6xuF+OA9Fd q6bjQRfcdB+ytxkyLlcvyLIH1+tAYYGCkuqUs6mx0aU+oGJ4vKu/P7jMkJZ/OsopP4+x vcBD0fJi0zcw7VK/rhBuu01ErfsBilEruRBzzfQCln1+NH7/OR/1q1tvVe965EWjYAWR k/dRIqe9/81DvFLJXl5RRqywyveWJmfQlj6bTH0qIaQ7A7aDaHRTNaPiyIvWG0xSZTJv t83bFpww8uTAUEoWA9rDfckjtweafPjitoktKQftlxbWrHkwpTsI4w5bUwh8YMiXcVIu 1cXw== X-Forwarded-Encrypted: i=1; AJvYcCVL0PVippskHpSelFiDMS0teCvwvlk9QR5G+NtigL/56Abei9ZElc15N5GhHoXsfWxoQyI3ATNmsg==@kvack.org X-Gm-Message-State: AOJu0Yy6Bqj5g75yndwBbmWwg5N59fdeAz9SbHoeCowzWugTkjFnwJO1 q7nQSDd1bHpJ7rBOcZ9EqGD+1Rx5Rr+jlsxRqyGSGAb2ffhXwQh7 X-Gm-Gg: ASbGncuIoPoBD9V7n7nUtPUvkIA9yayk4WVXTrB1MU7EaRmp1yvt2EraADNy/S/eIZ2 +/8H5BQluNnV8Utkwk2HVyBhfq6R/hTtapKAWBEiQnVxl6bD+DRD/qNVnzksbifDyvQsn3lgmYL aY3Y7+3BLt/be0mFTHlu0KNkVzpdoH0Ybdo2qU98bBpUzUWeh4u8A1UC3zrkaS10LR9/bCazI2a kfD3EMRI0R47Fz3XodlcAHIRNeZcD60MUm8TSSpXi/w1VGYGRdbRoe7ag8F4JJ1BgEyr0OOIiDy lQ2UrzOP/90= X-Google-Smtp-Source: AGHT+IGTq1Ka830880GIKR/9qF6lBhoVptaMDHpCbWGtqaCSDnf0s6HcZZnUQDniBpJW03L5tzu0Zw== X-Received: by 2002:a05:651c:a0b:b0:300:43cd:3b11 with SMTP id 38308e7fff4ca-30251e66657mr6241691fa.26.1734026677444; Thu, 12 Dec 2024 10:04:37 -0800 (PST) Received: from pc636 (host-90-233-194-189.mobileonline.telia.com. [90.233.194.189]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-30035db98d9sm19102531fa.37.2024.12.12.10.04.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Dec 2024 10:04:36 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Thu, 12 Dec 2024 19:04:34 +0100 To: Vlastimil Babka Cc: "Uladzislau Rezki (Sony)" , linux-mm@kvack.org, Andrew Morton , RCU , LKML , Oleksiy Avramchenko Subject: Re: [RFC v1 0/5] Move kvfree_rcu() into SLAB Message-ID: References: <20241210164035.3391747-1-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 6454180029 X-Stat-Signature: cwbke85er8xagsei1hjkfe89fw7oej3u X-Rspam-User: X-HE-Tag: 1734026632-699329 X-HE-Meta: U2FsdGVkX19ZucVoFbGX6oMTE65S+nx1QmxgA0svAjQGGcaQ/Wb9Adz62XSjKwjVTPKYNFUlkOYngP8kaKQEsm/EpBYVc2MYxK0mSxa0nGiwvNXRY82xH7VbyhcqN47IoHJfTU9JwZu9c9V5hRYiMOSd3VaLo13KCCJxnQAaRIESgw/rjHUmx1NPxVkFmdgNfc8rArqQWS0yAHLdSGt0tvTG5DyxkPcqZZYEb+p33OpX/h/gDC002IHFWPow/iMGelfGJr6kDr6stIfNW5GJUQHhBOaCBcZ53ibQ1vdyujjJ00UPCtd2yxIohfFpa9ZbvRHeoioufCjWBVgRTlJnQLOBzxQz8rl9vIAmri6ypyvECC6g6DZwkQtXpTtToYJ+md+AYVfexDmVfbME+xNLXELC4dZFDOSIEsl5Wq8Dqho5nX1GfX5hzT0YV8f0ufZnvEx50gw5iwYonLb45Tj7047o4RrnjwMmhIx2OEfD9srA/iWSZiY7nBu5vdr0ALIF6vMCprZmMpPa4AsR7qVbNbQHVMqbBQRqugorEBWNSI3XtheSUbpSu7QQwVGqvegS1ByDwe1lOcwf5T1D/RxxeP2OmQnL3IRLH42Lw3z2DJkDR/KQJQ/SGDCzwNZz76CJ03HcM/I1Mwgp2AkU3SC/RhaSaSdeVSS+PcDs5w950blk5sxr0r8Vz7TLxFJD/jIDO/qHJQkYkSzeG51QaJkrMSaZkZ98Yz4fYgAGFzgaBRpd8ONocnvdWmOLfaJUjscay8fOiSwdrj85hdnyuNZJ15DOPMlurdqKugPu0ThfxUL5HD7ZfiZL60g/u9gZga2Thp/MaTQGb3p4mid+CsSSd+OpLHZBbOwUT0kmLUrN0aN48dgwctA6rQBG/Roqijdij2zQDpIYZtYoUU4nOuoaBWo4f1p1RZ8DqzkZcrI/HvMMwYJph5N7z6q4JDPp6Xg+MreyORpfmkVEtyQgfVu 92nNGQ3H S1u+umRIDIX9K7nAybXWspbHhtra7xI/CDfXaXSDuRu1hqYcOf3W0R+U5yu6ecK8V5yTRTQO21FMfhGXVFRSIYywOPKi+DRjEtdL/186IFsU04cnUQFeFw+p5TDhMLK6uDQq0Bg3HEGN1D8BBOd8/XAAkaNOyGhYDyZ58qqigudIRqX71ePb1E8K4/+M4VJxEpkLSf+bpSSb0qak0k48x/r+Sm6OvrzpWGbLFU4SSpOaqV4vwwAjmwSg9LEhVktfoVbYmIhyj6EJ8EzTBYDQ748kAc/8otQ3kzr1osZK6sN8E4JNhtFlSYWYk1goIgVUWa4fQSapVhkmx+owtTm2Bj91AOyniHJlRSQ49OGfAaB/F9Zdn+MWCmJAr+nPYU8sgHqe1EJ+zgLrCJvImHwp6Nk33UfE6F0NPG3XO/8Te2jpM2oUHlJ7x9/+QFToy5Cy4eNUN X-Bogosity: Ham, tests=bogofilter, spamicity=0.391084, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Dec 12, 2024 at 11:30:36AM +0100, Vlastimil Babka wrote: > On 12/10/24 17:40, Uladzislau Rezki (Sony) wrote: > > Hello! > > Hi and thanks! > > > This series is based on v6.12 kernel. > > Could it be rebased to v6.13-rc1, which is a basis for most -next branches? > Right now patch 5 doesn't apply on v6.13-rc1. > > Please also Cc all slab maintainers/reviewers. > > > It is an attempt to move the kvfree_rcu() > > into MM from the kernel/rcu/ place. I split the series into a few patches so it > > is easier to follow a migration process. > > I think this is not the best approach. The individual diffs are not easy to > follow because they copy code or delete code separately, and not move it in > a single commit. I get a much better overview when I diff the whole series > against baseline, then git highlights pure moves and local changes nicely. > > Having moves recorded properly would also make it possible for "git blame > -C" to show changes that were made in the old file before the move, but with > copy and deletion in separate commits it doesn't work. > (but note it seems it doesn't work so great even if I squash everything to > one patch - were the functions reodered?) > > And with this approach you also need the temporary changes. > > What I think could work better is to do: > - preparatory changes in the existing location > - splitting out kvfree_rcu_init() and calling separately in start_kernel() > - renaming shrinkers > - adjusting the names passed to trace_rcu_...() > - maybe even adding the CONFIG_TINY_RCU guards even if redundant > - one big move of code between files, hopefully needing no or minimal > adjustments after the preparatory steps > > Makes sense? > See v2. We can go that way, so it makes sense to me. Thank you. -- Uladzislau Rezki