From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B9A8E7717F for ; Thu, 12 Dec 2024 15:45:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1FCA26B007B; Thu, 12 Dec 2024 10:45:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1AC7E6B0082; Thu, 12 Dec 2024 10:45:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 09BCB6B0085; Thu, 12 Dec 2024 10:45:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id DC6326B007B for ; Thu, 12 Dec 2024 10:45:28 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 494CC8018A for ; Thu, 12 Dec 2024 15:45:28 +0000 (UTC) X-FDA: 82886730990.18.9F97CAB Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf25.hostedemail.com (Postfix) with ESMTP id 18211A000C for ; Thu, 12 Dec 2024 15:45:06 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=uJnWz775; spf=none (imf25.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734018310; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gLVuf3vyv80xWoO2o27xzYEmbbB8WpyOLkmBiyviyXE=; b=KTf7ButqNpIOXH6bIcc+MUW1+t8cJWMmMeemeq+cw6rnu/c5aTiekIdKnC6HtTlyLdFT5M WT5hAkFeTatubHR+CpsxnXoQvcfjCCzI7uV3lqxZaV4DS8o0wtPWrQWR/cLZkAtfxIGzQv EtPfeZDH8fyEBMOMPygoJp9mlfwVjqs= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734018310; a=rsa-sha256; cv=none; b=aVuy+VZHPPqUgzBs3r+i9D5se16mYwGVJbFu5q4Cr3b0bgbzYy6McoWtURl88nQ2rwkpgA IwVYgREHYTElmOu7ODhNyGzpFg3JLwNZ9RwIDG944V3kcvmr5mf9c2isrvXGZudWHKyKId I2uXXKUTfB14yHV+a3/7Hz7JcEmzLRI= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=uJnWz775; spf=none (imf25.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=gLVuf3vyv80xWoO2o27xzYEmbbB8WpyOLkmBiyviyXE=; b=uJnWz775hrBH4mNu2PbI84umbx l/F2RNZ5jSV5KiaI2Pk7DXPT6/eYy8Tmc+NnTQHi+B3U8au3Uh2/7PHG57s2QL2qhGaEEylh1ClMy 4AQMfIYJfrqjGgh9CvuaJi/yQPRfuchYc11ejbDYdviGkOQTVE9QLh/G8VJZhC+8C98yzkHycG+bk bGu3l0TKJXxQ5oNEfusVJfOpDBDhqQbAmyiHu2gyosA5gJOpSEA7j/JLUd9YsqqUSx8uphdHqPonn oyb30XErb1KiqBaoL2v8UpLN5wbEvKmPFJyxAMSufj8U2oMNj/lfKSW7dIdstyTZ1EZP+npAARWAu EV1dkJ1g==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tLlNM-00000006Xse-3Ve9; Thu, 12 Dec 2024 15:45:16 +0000 Date: Thu, 12 Dec 2024 15:45:16 +0000 From: Matthew Wilcox To: Lorenzo Stoakes Cc: Andrew Morton , "Liam R . Howlett" , Thomas Bogendoerfer , Vlastimil Babka , Jann Horn , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org Subject: Re: [RFC PATCH 2/2] mm: make mmap_region() internal Message-ID: References: <80b7c4ba4f0a2b3084117975bd1af62a403ac881.1734017293.git.lorenzo.stoakes@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <80b7c4ba4f0a2b3084117975bd1af62a403ac881.1734017293.git.lorenzo.stoakes@oracle.com> X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 18211A000C X-Stat-Signature: pm141eyc6duy5fmiy71u8c6xkp534kmp X-Rspam-User: X-HE-Tag: 1734018306-564498 X-HE-Meta: U2FsdGVkX18yxwwFz959nkWsIMHcsbBdG4YUnOoVaUY4nZFBedA/0TuHr3Ns3ITmYyIE72zTnn9GdPp92GUGrfLrEHr2UNB/k5OnUtrDFGoGkn/sI0tY24HqD4NqcULkIwdxJ6YSXnrcSizuMkDrBd9PrAlpSgxXNHev38/7A7NiusF5XTq/ZM/qwWQxDZkFO7IgoXY3rd5ZAk4k6RzgNC8a1CU8nYIkuZnSSeBFXc9sN0xKvboPR9gTkfTSDmWwCIWa7NYn/kI7kiiZ+jBNOZsyCUymMb2T2HcDitXasupFhJ6zw7Y5dznjoQHlgC7eGbk8dMreipqZmp4VCBtbSPtVNxCM91DZkTfnyVuA0zQFurx7ZKK3iHk6Lqo11GO+hCUVh1NxQ4Ej1GI9pid0OQQ3QfR8IyhaVjouhRhvlYHIAfk7qdlTMA9I5tbGiYDzw21jmQfQF5fPe31nY7FX5qBH4js/tdxkUDeTal+n780uiUbop/ArGhi+KjWZPaOlw7qEASBSeqvDJYgw28GeNX33ip2qfvcVPjgRgpdvHeRpdWphhzoBH0Dtlt82go/MusFE/PsmEzF5ASqMi+hmEzs//fJPZIEeuhNqoZ3X0Yf1uHxwYZNPBWk0vNYWSmaWoiaGZqrWPyoLdBNjglATBFF3mXsDqdqFwXyZSMkz2WOQhrPtwxWsF+lW7CGWS73XXoyq3iZW5P0oJ8gMahOAWxd7Q4BvFUHFyLRU4isV15pw9vgAPWEvSwYYIii3kZFeFsb67GYzhCebt8RI2Ev53yxcMwJcu0Dy0ro/p+9eBl1EjFD3tzDLmdS3ONHBwAl1YcnFPY5Ibap+2JnqUelDLwWmpuv96pe5wu1bgmaf+LvFf/xIsZ0EU6ybnRMkuk+IMb0KwRwOr3qqZfvMKFIx5H7IqfA0jYufYUSZIA55W0SFrdLKQmGN6aP92ZqUcR5EAhao0BiKwm0nfMOiR3n L2MnaTw/ On5Dov//5fs793oRAfB9CC3xz+vRh2VbScvYV4yMA7iSnCajs02+e9SI5GQiCqAtht/UBEgiYClnSr2aJxLrkO385vTm2jy1UkB5FRBi1w7V9axMDorNyTM6lk8hkA8bbyS9xPYElquc5vNjvxLo+v4ruIuH46BLUyZKoO49KqWJ4APVOhxbxCuW1NufgZd2vGFuwdSAmk5mzX748rVStHCeaO0sc7hdEhF2x5RCEawXLkIIPkuYdW6bkUmj+c9oSKfjUs8A1Ooio3W633X6BdK6n4w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.012182, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Dec 12, 2024 at 03:36:47PM +0000, Lorenzo Stoakes wrote: > +++ b/mm/vma.h > @@ -242,9 +242,9 @@ bool vma_wants_writenotify(struct vm_area_struct *vma, pgprot_t vm_page_prot); > int mm_take_all_locks(struct mm_struct *mm); > void mm_drop_all_locks(struct mm_struct *mm); > > -unsigned long __mmap_region(struct file *file, unsigned long addr, > - unsigned long len, vm_flags_t vm_flags, unsigned long pgoff, > - struct list_head *uf); > +unsigned long mmap_region(struct file *file, unsigned long addr, > + unsigned long len, vm_flags_t vm_flags, unsigned long pgoff, > + struct list_head *uf); Please don't line up the arguments with the paren. Just leave it as two tabs.