From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0111E7717F for ; Thu, 12 Dec 2024 06:31:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2A34C6B0082; Thu, 12 Dec 2024 01:31:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 22C2F6B0083; Thu, 12 Dec 2024 01:31:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0CD6F6B0085; Thu, 12 Dec 2024 01:31:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E02336B0082 for ; Thu, 12 Dec 2024 01:31:13 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7F8DDB0419 for ; Thu, 12 Dec 2024 06:31:13 +0000 (UTC) X-FDA: 82885334532.02.5B621CF Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf03.hostedemail.com (Postfix) with ESMTP id 9DFAB20017 for ; Thu, 12 Dec 2024 06:31:00 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=197QYJLo; spf=none (imf03.hostedemail.com: domain of BATV+197d639d84551e46db20+7781+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+197d639d84551e46db20+7781+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733985046; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=FKgA3Ux1TcmweyU18/LTQwOhDOq1BHQNtEEmqWuqfWY=; b=1uk78dG4yKrDkmyRthg33TQoqApCv/yv5VFquf16jf5Y+2cW/TeP06Xgpzn3mCi6nFI5QZ KM6iP+ffU9eDL8yB+Jn02iCTDCvGRQALd4pRrhDzMMPPMgMYO9Vj4Kir1cTZ5ZDb4Oyjbc TQIT7mRTF4FOb4xhWkINw+LfZolxU9U= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=197QYJLo; spf=none (imf03.hostedemail.com: domain of BATV+197d639d84551e46db20+7781+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+197d639d84551e46db20+7781+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733985046; a=rsa-sha256; cv=none; b=AlMcEwHKtXs6YEUFGQNquWdRsBRYHO6L2dPVP5kHdDy7CEGiBualfRAWvtMOCU5kbkpoJi VBOQxv00CY5lBUHJpFEAUADjs1B/EKFkcwsBjD8kGItLZwZd3Fx6dZfJCS3EDz7zM29axK x1aJ3Bf6VQ52dKd4Fgaz1AIvnQsWs2Q= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=FKgA3Ux1TcmweyU18/LTQwOhDOq1BHQNtEEmqWuqfWY=; b=197QYJLoZR/5lotRCC0oK847R+ S8hCSex9Lb/CsdLWKs27p+G9NJOCpCeP7DwPdSUnf13cjRWUdfn9bno0Nyw8SiLr+IIVFK8oneRAp iRt5dC7pQvfuROUDnFBwXPlS/rIJDUbYkLvCwegf/pyB1LNmBTFVbzuBHrKzN9LWp0pNILhDIapOt DG6DpvC2r6EWlIfiJ9p9mDKo7LRjeunVp8ey3c+pmSPHSthaz1qfepbPKgGOVo4oqvkF2/G3npgDl 5suU69zGMcKDVNVtkhmTB3BdOgcgMEXklInOtYfUIU2gz3uWt12trMxlXtLPBEvWJDGyp/KwI6531 G/PRZpKw==; Received: from hch by bombadil.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tLcj7-0000000H3RU-3xaB; Thu, 12 Dec 2024 06:31:09 +0000 Date: Wed, 11 Dec 2024 22:31:09 -0800 From: Christoph Hellwig To: "Darrick J. Wong" Cc: Christoph Hellwig , Jens Axboe , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, hannes@cmpxchg.org, clm@meta.com, linux-kernel@vger.kernel.org, willy@infradead.org, kirill@shutemov.name, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, bfoster@redhat.com Subject: Re: [PATCH 14/17] iomap: make buffered writes work with RWF_UNCACHED Message-ID: References: <20241114152743.2381672-2-axboe@kernel.dk> <20241114152743.2381672-16-axboe@kernel.dk> <20241212062641.GD6678@frogsfrogsfrogs> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241212062641.GD6678@frogsfrogsfrogs> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 9DFAB20017 X-Rspam-User: X-Stat-Signature: kwjfbhjnmyexn1y9z3dgbggr5d5ypta4 X-HE-Tag: 1733985060-375520 X-HE-Meta: U2FsdGVkX189bj0Mj6ALXDvrd9qLiG7M0CLOIgHqmwqUUzI2y08i/zzev2yT1ifVpf0wc+JJhbqDtIzxYMz2cecB7cBLKi1C0yivyhzj9WHIPV+dNSz6YMbkg2pvDkRkG9OQJKe1169Apa/eLAGPhRRIVd5zznT/uBG2+n1phmoT/709hOlq6+FrmP3pz9FYd/2eFV4nHtYgl7abVrPyj7E/LWTadRChWthGCjUdOxXZ+d6uortCwJZ3iPvnllOnOKKD2NbDOgOKBn+2q0+AePM/NjBiioMU2NP0EObL+ekjMQ+MX89fjAJmwNtiFVT6cH88Gk3bmV1WdCBBGSq7XMSWOI+0LpcAUWoQ9Cw6xdO3edGDW4vRR4DeIluqOKFrrGiullcLyTW7Eb8RClfOY08jEvxyR9EhV8JkqwgCjtiVg6TZRL2a+vLo5uZXiJl7qnFImOkVqFXjrcltzCUn9HIORTvcRpQMPY3cDWakMKuy+i2dK7HsXTCcvIgymRNOcF4gle+ki1+Gk7TfHwPlnLUXnPrvqXJrEMRmdEPFAjpkAv3g9X+wLqgpLM1l5lSNIzxINq2KRICHOK66k1dcgOvhgqNEriV/nHi8GC+ZfagskqBEZ25ydTTh1V9lR1UTuYwPTKb2IHM3q4eKsvDoIvQ+CggQh6bJWbeH4PdXzqRHc1N1tS7LfNmB/9wvswJmuMQrIaSGW8D8vmPWtR7EeSReK13yvBNeRC7A0c0uRz9t3gmtxWE5bEO47wQZIu+DRRCoUt23iBIpp6rh843J67fLokw/Oop3vPAp0PgZ+vO9YJWhLG2AwTcYjEXdA+Nstvqy7NUiejHnD7CqUEmZzm63RS3l3oPKvtZW+iXOe5TCHhqFpKjqK70Yqtra58U6dxoRRSej9DvcEG9fcd37XMJP/F+nc2yGfLSItzHpCWyRWxjOjGw8MU11XTNLYYfAcW1PZPBUPUfjo4M3UkN 3njBMBTu TfWtHjlTShofWsFc1ggDPBpr33uioWi3PZBK/BPqdp10kzuaurjO2Vsz91ljnBDjaUiaLfq5VHNElb4hA/A9FR8qBpzEZLRGL2pVj1W4wNgTeQS/ve7h3NZK35j2Ms9D/dXUFwF1vPoNa9PeFnn5rcFZfLtJBWnIBkSZmLB4ck6++MSOiqtcuo+U3i0WSb7aPB2OYblo83LAVLjEzayXEQ9ieCMspl+uLc4SIwoycg+2PDbsX4itInB0HxQO6v3Kmi/5HD8XYqn94McmuQ3xA7HgptYaksAd0wkhANiKSWw9HusaBfEnRlAmygIMOfjhCjDJKckyqUEeN+pVd6pqTSg8QFA2U8sez35+bH2q5o8GJ8TTLTePYGEl8z0AjuyDGe5q7gIg4ycMaKl3Ytc0uX8dqbqMGx17QXcMQ2azkjaCAK2j1N2YilEWWT5ya3Y79T6uyN2zm47SQ885lVBCCX1g2eyilASgMLsfyPfoibqvex/YgcpxntZ6i4nL+gXFGTTutCi/v6EPnfOKmRw8CvwocJQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Dec 11, 2024 at 10:26:41PM -0800, Darrick J. Wong wrote: > > iomap.flags and the IOMAP_F_* namespace is used to communicate flags > > from the file system to the iomap core, so this looks wrong. > > Not entirely true -- IOMAP_F_SIZE_CHANGED is used to communicate state > from iomap to gfs2, and IOMAP_F_STALE is set/checked only by the iomap > core. iomap.h even says as much. Indeed, some of the non-initial additions already broke this. And now that you mentioned it I ran into that before because it was in the way of some further constifycation I attempted in fs/iomap/. > Though given that there's a 4-byte gap in struct iomap between flags and > the bdev pointer (at least on 64-bit) maybe we should make a separate > field for these iomap state bits? Probably. Preferably in a way that isn't too painful for Jens, though.