From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83FC0E7717F for ; Thu, 12 Dec 2024 05:50:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C78C36B0083; Thu, 12 Dec 2024 00:50:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C288B6B0085; Thu, 12 Dec 2024 00:50:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B16CE6B0088; Thu, 12 Dec 2024 00:50:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 945746B0083 for ; Thu, 12 Dec 2024 00:50:24 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 227BC161629 for ; Thu, 12 Dec 2024 05:50:24 +0000 (UTC) X-FDA: 82885231506.04.165E5B0 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf06.hostedemail.com (Postfix) with ESMTP id 126C8180007 for ; Thu, 12 Dec 2024 05:50:04 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=LxJPtnMV; spf=none (imf06.hostedemail.com: domain of BATV+197d639d84551e46db20+7781+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+197d639d84551e46db20+7781+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733982606; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pcELzZSVcZp1+kgY3EddYDKju3cmFn5oocwvVGhpALw=; b=KvPQpSpw+CzVanzk6Lfh2+5TVeBrMYXPGzW2jhK7o8iTtjxPymOGULz6f/1mme9oeuisw0 XQiTXXoR+w6cvuEAmOw4X+ClOuz3YjRL5zAB2BvFXg2d5pB5TWakpZV58DQXnm7qKmCwNJ 75XBAkEW9GDxAeyKTB3p7UnOEwoJj08= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733982606; a=rsa-sha256; cv=none; b=NemSJD3gcW3kNxX4XWun5LEpqR6P0XcgR2NwbLKFlBRW2Mr3raseYuDEtWHCnWQxI4bt4G Ot9rf9AAD2ISY2xtFrLaNP8h9D27WlhZY6KuHVMZxHuztdg6gbwrNr/zKLhdVFE4sQb/N1 GZftU92+1h6DzEUzo5dqjtOLwttEkN0= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=LxJPtnMV; spf=none (imf06.hostedemail.com: domain of BATV+197d639d84551e46db20+7781+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+197d639d84551e46db20+7781+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=pcELzZSVcZp1+kgY3EddYDKju3cmFn5oocwvVGhpALw=; b=LxJPtnMVMgJ3H+5TJzZZ9z7wS+ RbHDYNbA8oyTIKQ8dXz8E9KQalQccSW/uJ+CD8jGmMTb6F+Iogje1GseuTRVuYxOnfDobUHnmbOOh IYmuv96LZdVwrSIPEtv2LaUZsDgxxlTEvQfDaNj8p+u16ORUWAukW9oTg2vxO5Jp2YDRrBcqqR6YG P0c22F1xHFrYZQFBk6vc3WU0+9BZzuNOgEJOsO5aLddQPTNfbtkSQK4EQGXn4iWPuPb0X8eC0seZa L1KrbEKSTzpk1z4voFKA8PoR34ldMVgEwmc2/5IFgED+8BX+xvshdrHZ5VqcmmqIRYeTVLXzimy5o Lk9hXYpA==; Received: from hch by bombadil.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tLc5b-0000000Gyq7-47gi; Thu, 12 Dec 2024 05:50:19 +0000 Date: Wed, 11 Dec 2024 21:50:19 -0800 From: Christoph Hellwig To: Jens Axboe Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, hannes@cmpxchg.org, clm@meta.com, linux-kernel@vger.kernel.org, willy@infradead.org, kirill@shutemov.name, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, bfoster@redhat.com Subject: Re: [PATCH 14/17] iomap: make buffered writes work with RWF_UNCACHED Message-ID: References: <20241114152743.2381672-2-axboe@kernel.dk> <20241114152743.2381672-16-axboe@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241114152743.2381672-16-axboe@kernel.dk> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 126C8180007 X-Stat-Signature: m1pr9i4rhmydza8rk4mrs9yxry9k8sse X-Rspam-User: X-HE-Tag: 1733982604-532195 X-HE-Meta: U2FsdGVkX1/jIB75M9VT693yiF0zABgOLPHt3baeKWm6DGD2ONJ2KK58he4DyrK24tMcPcmO9ToeJAen0wQ/EbUtjVaN7k4ttthg7NfzxKh3bSeyPidCKnE/Z6kJYMU3sfWRs2NJ1tHqrGfP7+yyQTXLsuKdVCqo/pN+3qbqldk1jwLXSpkSs/TNE2eBrWKU3DUDT1XFlnKnJUC8WuznL7Wc0EvvB1C8OtjeZ5cQfPyLl3GrYPj8QXQpCFzMaHP3tLv/y8WPr6JIdXviGhFo662yR+dU3N33IWXBbKVUq6nhLH7mMcJE2b9nx3etLyeFCE0IA/PQs8g56DxMnHBIZ5g/8STHAQPOnZKGTgZ7nj0s7FEBrl4RwbGtV2ah1ytBgDsPk2SCmoVmnYqB+b+X82kL7ul1aYiZO41QgeGC5bTrBP0BNArGq9E1CoYk6aP9OlCTgsIiHKxu+LsnfUM9jdq7sZXGWkfGysmaVUDmNp5CjaeoboAiY4FflXLqLZxn0mMv7B9RxKCgM3b/itEAGz2n7hUiOCENUCK2T9kUEUhc8txV66wlo+zEhn+SHzzShvlkMPN0tBup/0ixn1/PjyBO/QAvU6zqfUHAOsLp6JT70WC+P35uPxe/C5AwE4yjL23noTzKUFRgxWZC6Xk4m2JR/QXLlUJXXukns8SY88TjBXGp6dZKiVtXHNa2RSIC6guhSn52pY5Cjy3QBhixc0ipqXkwGNsFi/eM0dzb9bY+gFTTVq4Cg6OawKa3rG0UTHDutLmfJt0oTCFhq6TDDwzjb6+iT/PhfscVs4hOCKn65QzkbnUcgb9xRv4P7oxG7mkFe1mTZJtSBWOfjzI4Vp+bpqjNjgMSeROUtT51Ipwx77JBTOaKM0lgQkSx8W4KKTPI+VcSsQTpvDnNHNvrrW9Ebypxtp1MFXsbrQkydHjmwR0U46YsLMcmmRRWaQJfhcpOHBTGz72kaEDRfQS tvns2CNb HqNbOwbuVUTb2uXulFTi6bHPITmTrxuA2FPLU488w9mBoP7PErVUk/TY8YL27eqEK3ozfGbGKRxRc8ppjWZ2BkduMcVOSRDjyFOm7UraKDtQEx1tIrY7wZ8QJB068giUrmr9UnmvuJotkr+uz3pprz2yb/XeP1JzoeAbUUKltlTYhUipMrghahEmTMlPjZ1GamlgTKY5/PpD/cq8j1Aj4qSrQ2oVCfYaZzavkfHXtbUslI790sqQwxxk59AUavk67hUXogqsWJEbLt19eJEQ5fcMHw/XujfpTXl6bV2DZ53H1RLU2HzBT5p+UYaYjATeOH1CxfaEsRne4eK1SthFDN+bDDL7pb7vXHV1Y1zJY/FFTN42wdjqUl107pgO9wdkp8keb6akwmw0iMpGZljxG/wwhMhkw+AD3wQJnZAk5ZQal7bY09iox+94IFr5FayMXPmTaWTxZaWA3RWsPClFf6SNMiotYGHRDWOM37ZgyXkKJtSBqGENle7uu5ob4k8bank5pgjlpMVd6uuIgn9AGMuPC6g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 14, 2024 at 08:25:18AM -0700, Jens Axboe wrote: > + if (iocb->ki_flags & IOCB_UNCACHED) > + iter.flags |= IOMAP_UNCACHED; > > - while ((ret = iomap_iter(&iter, ops)) > 0) > + while ((ret = iomap_iter(&iter, ops)) > 0) { > + if (iocb->ki_flags & IOCB_UNCACHED) > + iter.iomap.flags |= IOMAP_F_UNCACHED; iomap.flags and the IOMAP_F_* namespace is used to communicate flags from the file system to the iomap core, so this looks wrong. > size_t poff = offset_in_folio(folio, pos); > int error; > > + if (folio_test_uncached(folio)) > + wpc->iomap.flags |= IOMAP_F_UNCACHED; I guess this is what actually makes it work. Note that with the iomap zoned series I posted yesteday things change a bit here in that the flags in the wpc are decouple from the iomap flags, and this would now become a wpc only flag as it isn't really a fs to iomap cummunication, but based on iomap / page cache state.