From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E69E9E7717F for ; Tue, 10 Dec 2024 14:04:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 724A36B01AE; Tue, 10 Dec 2024 09:04:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6ADAC6B01B1; Tue, 10 Dec 2024 09:04:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4FF9D6B01B3; Tue, 10 Dec 2024 09:04:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2D45F6B01AE for ; Tue, 10 Dec 2024 09:04:17 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id ED681A0B04 for ; Tue, 10 Dec 2024 14:04:16 +0000 (UTC) X-FDA: 82879218072.25.176EB15 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by imf24.hostedemail.com (Postfix) with ESMTP id 2EB0F180025 for ; Tue, 10 Dec 2024 14:04:11 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=DEDsrBoM; spf=pass (imf24.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733839440; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i+NNeaYmHlmh8gm5fSO37R0Vb2l2jcx8fasgMdmxlyg=; b=RkhzMMEdsO3h1cLqTaGF5cAVN7mgd8enUlk/m+i+00F5TRmtpfvXTFdL8gNh0z4HZLg5t0 Mi59m0crISdVx5DMiULFx+qwaG0Qu8M5mjiHtP9oJg8Wevx72qP+znupJwsHKXKwA5WJLD xbrDDlBe1mWJbRRUsmQZm2YvmClrESE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733839440; a=rsa-sha256; cv=none; b=6wi8FPJDfd1MBb88TvjtVhLEfX+hWbrdz+erzOTgNuT2sOXve1n6o8iX7dr/+vxh20jZZP MHAoZHqdf/22momlBbAA3QJXLKjdy++Fqad5KV7JY/8bDO2hncGoZvemLRRoUfTFpaFc2/ TABJVC5Ou1m1EKKDpvsuxqllcm4FD5w= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=DEDsrBoM; spf=pass (imf24.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2163b0c09afso25284315ad.0 for ; Tue, 10 Dec 2024 06:04:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733839453; x=1734444253; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=i+NNeaYmHlmh8gm5fSO37R0Vb2l2jcx8fasgMdmxlyg=; b=DEDsrBoMp+8/KmvmGIGWQEuO/1hGhjX+HFEjYHOffdjBBYpt0rAB89xwe2pOu91yqN 1wV3y+AmYdl5gMY079gkXu3rWlm8XtQu4reCnrePCh609OrOU5jkJj/iV9csDPdr7Oi7 BXHvn9Pz7GQqzprDh2KNGMK+FuFPauIQ1RHI/C+H3h17fXms6MefEb71joteB3EZ5fVg E3G7CXbA9QPRkSSmB4rjSvzhLHLn/gWf9qJmm8ivHQdXQDN/IoF6622mFzFqxJTzhXS4 pNF5A378zkzegOn48afE4ihP0Fjbg+pFmm1IjT4sE4vw6VSFaUKzMTtfZpayjXz46GSR B57A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733839453; x=1734444253; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=i+NNeaYmHlmh8gm5fSO37R0Vb2l2jcx8fasgMdmxlyg=; b=eBgiT996mF/Xyzhop8l8Wpv1OXt1pq81RYTRHy6pVPPR+Oq6qS7LRYzw0F3GZKejrz h3AViLbRhB2kdovQOTHd/3jM5bl9p8ojvaqITYMpXdR2iVLGWbkNHwR+jJvxhY8KpsnG tilWO4dZliM+x009KxkFEvkczwzYCo5Ecj6+vUr2Z97izZlfvgPQU3PE/3U8eHVv+TtR W23GSptH81yIn5v4um5io+ni0EgmP8STZVaj6/ADbZU2YwKG2ltFO/I//zHgW2ns4dGu L44I7Jf1gXACOuad0jWwqqt30AR7scSgo5BJSLJi4ciNQ0Bsf2jW+wQ8jbnn6Q6Tw259 h7cA== X-Forwarded-Encrypted: i=1; AJvYcCU8lxoGrWn/7RdnFC3oSCifSz7AYlyJs2XVK16dK/LdbyNOu2d2r10gQE02RV6nmijvAWoT+B6hfA==@kvack.org X-Gm-Message-State: AOJu0Yxbb/xswulDEre3oOBLyek8URRxJFcwxNuTE8uN+fyolnG6Wy/H E+TnvR0uBDaSEqZKeEnirtz++vzJkDSkyhRaxn1yDUyzb7YtMQol X-Gm-Gg: ASbGnctZuQUcdxiqMF7nclgwOalzIVMvLk9/yED62zxXlD5dMf+Zz5sq08VQfN7QqFM +4t30G0Scx7cLaZ6U5RbbvIWEtJ46OLrHNYffRoXuGnzJAltOifr+k4KJI+PPu2oEJWX0cxxdqF 9vSQxraKpCtuA0QIgqNKtcwrRHdSmypFbPBt1cMFuFUxhAO3htlu2icJqjLDRClievQseJc0PQ8 awtUwfnLI2iuGc+jfOF4Xqw/Fda2c2roq3ONkY0XfC2JEwTRLS088N5amWYOvkUep29InJC4cUB maadOA== X-Google-Smtp-Source: AGHT+IEXu9OZa4XCGE8wdC/jMN67ImmFB5xyrjrRl7eYRJR6b95jFq50MzfWBHGU8rHvB3VOkfNhww== X-Received: by 2002:a17:902:d482:b0:216:2804:a241 with SMTP id d9443c01a7336-2162804a274mr224124255ad.37.1733839453417; Tue, 10 Dec 2024 06:04:13 -0800 (PST) Received: from MacBook-Air-5.local ([2001:2d8:690f:73f:ecb8:cdc:8c50:63fd]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21653b0d4f5sm33114375ad.70.2024.12.10.06.04.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 06:04:12 -0800 (PST) Date: Tue, 10 Dec 2024 23:04:06 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: "Matthew Wilcox (Oracle)" Cc: Minchan Kim , Sergey Senozhatsky , Alex Shi , linux-mm@kvack.org Subject: Re: [PATCH v8 16/21] mm/zsmalloc: convert SetZsPageMovable and remove unused funcs Message-ID: References: <20241205175000.3187069-1-willy@infradead.org> <20241205175000.3187069-17-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241205175000.3187069-17-willy@infradead.org> X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 2EB0F180025 X-Stat-Signature: w6z853a78e44bij6tjkfj8m3g8d4ctdi X-Rspam-User: X-HE-Tag: 1733839451-472040 X-HE-Meta: U2FsdGVkX1/R57M/zZ9+39fH/CA0UCgJhnMCuwgr5xVy89LSgZvOrpTbPS8DMf4Sk4CfDruv4oxE5FDbsR3HQWNDnkCV9hWZdmIi/xRDlO3r3weGRyajehR81GT+jISI+itCcuTDGsqU/xuP+GsNwowMkIk+SO+U0qaKkF29c6ZHzOOqA5rg5EI1RWuyqMgdR/WywWSRrGmp+Jp01zO2HWGDKBgQeRtJadKFd9F0egCr0Ivrn1Ts6sm54CseJEPTD6kzxCbrqxGRIyc1FGshKT2HEVgK3ZlRi1Aka6ovoGgILtc5SkHHoIBDt/ebr8CiQ9uzBaNW5cK9FJGqcuTm03kN6YAstey1XD3ffBSbX86w5LLDay+adm0rTjmkVCRrCmuKNWCEb3c6dbWIBvUFpBPm3wbvTmj9qSPpw58rfg4ojxFEteYY55xhYtqzWw2GAcELwCnAvPetTG+KMRDKGcH9R+9UCXhkHfckPTmDfrUbKM+tg/WdChJ+GLoMpfjg2/6LJDpdv2HXAT0Ho1ak986SYYb8CspfPEBVyncHoyvULAWdpzqb66X0r5fCNHWpao2zdYSl4V6g/z06WY/SphK/isnz9TyKI8crbkzmvP7nQ1fAMg2U+rBcS3EsSdEzKhkRKv1n7OIxGTuOVs17dUhmXylwpWmS2m/LCue4qW6Au6FBxa9MAaG40dou+yQmZqcvMExUzdodTY+dcM8cIYjzkK67dVPv9FjwfBeYcUF3JscnxB1D/ViSvgvc5+KT47K6jYLE3nr+hYdlSLOnpGFt31DpYBfFeDMCcq46DVYllCj59i5gK+QsB3VRC0UtGRaAW0olkvQbaMajvJJ3wlIMlBNtQsqGr4klOg8EiPXYzRZqJuNyoJaOKtDbKnzbRli0PkokPA0oN2iXSstlCyjTrED3Jv9KImoOlnMafffTBciawPJQIONQrjd835eNbJP+rPdo8u4XJs7Bu6C eRG7S1Uo xmCgIQ2Dc3nLHXTtVcvXjzIrzQhqK/lT6gPk1mZctBs3i+4NCOQjKXH7m0ERze257NOXkXxB2/7euL5rqH11D+vYo24KYnukJjOOEp1M450q+E19HpJw0iydmD/XQ+jCBuihOgbFwPjhXk0Sl9xrLMnx106r5hfAeyQTVmqdj5wTvaOq2Kkg6z69SIXczY1qiPM/rvj5ZuS3XkJKkRt8mYCpONG4a7ri+8Vh2j/+/CW9WcyZQ+s9pzInr1zUjvwdHCYSdSU8JPPzEFpZFAEQCGh3fQ0a5eeu0b3Z2j6VooWK83h0PaD+2kvBHuwHthyO9Eg9jCe/GpRv1QF4XJvdADDr8cD4Ak9z2qojM578E939QTumLFK8qfZQkemciMbhobl3+FEQTvx7gNBbuIepyi6YV2XvHxi50836TH03tsiE5FhXsamIXflNA0lfbCEoaxnhsXmHVpA6LxCi6wwaPPCI5HC68jpu6cyVT X-Bogosity: Ham, tests=bogofilter, spamicity=0.220969, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Dec 05, 2024 at 05:49:53PM +0000, Matthew Wilcox (Oracle) wrote: > From: Alex Shi > > Convert SetZsPageMovable() to use zpdesc, and then remove unused > funcs: get_next_page()/get_first_page()/is_first_page(). > > Originally-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > Signed-off-by: Alex Shi > --- Looks good to me, Hyeonggon Yoo <42.hyeyoo@gmail.com> > mm/zsmalloc.c | 33 +++++---------------------------- > 1 file changed, 5 insertions(+), 28 deletions(-) > > diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c > index bf1db07c58cf..16e3d6705563 100644 > --- a/mm/zsmalloc.c > +++ b/mm/zsmalloc.c > @@ -470,11 +470,6 @@ static DEFINE_PER_CPU(struct mapping_area, zs_map_area) = { > .lock = INIT_LOCAL_LOCK(lock), > }; > > -static __maybe_unused int is_first_page(struct page *page) > -{ > - return PagePrivate(page); > -} > - > static inline bool is_first_zpdesc(struct zpdesc *zpdesc) > { > return PagePrivate(zpdesc_page(zpdesc)); > @@ -491,14 +486,6 @@ static inline void mod_zspage_inuse(struct zspage *zspage, int val) > zspage->inuse += val; > } > > -static inline struct page *get_first_page(struct zspage *zspage) > -{ > - struct page *first_page = zpdesc_page(zspage->first_zpdesc); > - > - VM_BUG_ON_PAGE(!is_first_page(first_page), first_page); > - return first_page; > -} > - > static struct zpdesc *get_first_zpdesc(struct zspage *zspage) > { > struct zpdesc *first_zpdesc = zspage->first_zpdesc; > @@ -783,16 +770,6 @@ static struct zspage *get_zspage(struct zpdesc *zpdesc) > return zspage; > } > > -static struct page *get_next_page(struct page *page) > -{ > - struct zspage *zspage = get_zspage(page_zpdesc(page)); > - > - if (unlikely(ZsHugePage(zspage))) > - return NULL; > - > - return (struct page *)page->index; > -} > - > static struct zpdesc *get_next_zpdesc(struct zpdesc *zpdesc) > { > struct zspage *zspage = get_zspage(zpdesc); > @@ -1955,13 +1932,13 @@ static void init_deferred_free(struct zs_pool *pool) > > static void SetZsPageMovable(struct zs_pool *pool, struct zspage *zspage) > { > - struct page *page = get_first_page(zspage); > + struct zpdesc *zpdesc = get_first_zpdesc(zspage); > > do { > - WARN_ON(!trylock_page(page)); > - __SetPageMovable(page, &zsmalloc_mops); > - unlock_page(page); > - } while ((page = get_next_page(page)) != NULL); > + WARN_ON(!zpdesc_trylock(zpdesc)); > + __zpdesc_set_movable(zpdesc, &zsmalloc_mops); > + zpdesc_unlock(zpdesc); > + } while ((zpdesc = get_next_zpdesc(zpdesc)) != NULL); > } > #else > static inline void zs_flush_migration(struct zs_pool *pool) { } > -- > 2.45.2 > >