From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EE4CE7717F for ; Tue, 10 Dec 2024 14:01:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 96BF36B01A8; Tue, 10 Dec 2024 09:01:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 928D26B01A9; Tue, 10 Dec 2024 09:01:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7E25F6B01AA; Tue, 10 Dec 2024 09:01:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5E3366B01A8 for ; Tue, 10 Dec 2024 09:01:01 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id B6DE941D23 for ; Tue, 10 Dec 2024 14:01:00 +0000 (UTC) X-FDA: 82879210512.14.B5D2972 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by imf07.hostedemail.com (Postfix) with ESMTP id 84AC440052 for ; Tue, 10 Dec 2024 14:00:34 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="k/17E1aS"; spf=pass (imf07.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.210.175 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733839246; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DnLxt/pb6Bll+Ve2uN2GG0M1W5aGbZivN9//lY7Y67Y=; b=YHuwVsOaOCwmhAwER2H+Uko5hwBi5jdCqTFZEz4ENtBIJOFNlaq3Tz0VoZzgoH8zmM+TeZ hxPuOblU4Gq13Vtsh3mTaJJ7lUsVbaPsHR7UkUxj7Z/RcVtiQ99koc4PNwEYuFgBIt4BFw 0/S5CK50eCzaXH56Atdy+WYjOFdZ69c= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733839246; a=rsa-sha256; cv=none; b=McZ4gnPG2tDqE6pLeds480SC/BNI8gF29Y6oOGQ96CGlV3uLRJSotsN53Mmv295kpfyW2M DciD7kC55KEB+SeG8B3baR4exP9qn8va/Q4VBrH3fLwzPIgUZ50mMIrXiboVBSQNzcj/At QHpqvNNO2CSrBj3IHHw0j1yl0fRNamc= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="k/17E1aS"; spf=pass (imf07.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.210.175 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-725ee27e905so2398561b3a.2 for ; Tue, 10 Dec 2024 06:00:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733839255; x=1734444055; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=DnLxt/pb6Bll+Ve2uN2GG0M1W5aGbZivN9//lY7Y67Y=; b=k/17E1aSf+xLb8fhEJk6Q/pTIrOIz60uSkYUscZlCpgcYsFWKQrI9eWOFOqQkvxKBh DWLWX3uoZ0iPCw3/tgkVIMjNb1+S91VY12W1d8yEunp5KUR71O7BGELqyG2lP8JI3Slm 7XS5ufq/tnkQD/2mXWXeJh56jISqbBaN19TnlKkuOmt+HZoEh59nfPpDdIc1GQzF+1Yx OX/SZlxy2crPZUUKouAdcjwSvODaqo7rHwdCiypSCgWGIO1GYHTRWKbtzdkL9Lh7tmWy fdUVn+FmL8bMcBeto/Ea3JK3IYpMt/xAsECblas0ThAh/3bOo7eO7LGLWiQEOXWJGoRu uXSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733839255; x=1734444055; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DnLxt/pb6Bll+Ve2uN2GG0M1W5aGbZivN9//lY7Y67Y=; b=oOfZmVcHJlc/Pm8FuKXvOEFmALLW18Qc7gEuT40CFHaU8GtEFpURNpP0caQQ97zoeD uI+94Fli+PWRLv4U+VbIHEfI0DdJ12QjYRoBV+7yVqELx7q+zV52kQxbZFxoGjDjtIDL 9rHyG0Q9UFKbS4YnMJh0DUTw3PV1pnVio6QEJQL4vSvOEOWRORMl4IdVTTTvq6PhJcn2 bTgaqsZJxALeBmcZgWPWhTDA4vx3SdY3YeCBsC8Z40gpD92g0JR4iFwWAcc2lzglNMev h5XM7ONULWC3DAxTj4IBZpYcc5MGD64jqZ8MnxGcBtfoXBIee3jJOwe8HtMxQ4OSYnVe IP4g== X-Forwarded-Encrypted: i=1; AJvYcCULQTTYC5Z4Ue8cN1R3TMSzkUOgSaDF6tJ8h9zYgLG9w4k4GkQUDZE70IC67fAuqReL7ZDK/pMSwg==@kvack.org X-Gm-Message-State: AOJu0YygHB9QfXgKIaghe1ajGe/U5/qVhQEiq2N8Xkxdak+ucSTcKPLv ZPDMH1XEBVIVC/DdusE/pz8HfgST6b7YyyarOUUCLZbdtSIIFdgzo2iPtUIA X-Gm-Gg: ASbGncvXgThfDX97JMqw1lyQjaMXh/fzen7FtYIdH8+7Ru8zYnOLDETxVH5bmuZgShS F0uS3/0K6lZdM/2gojpRWNVsOXj6BlXpiUhrfT4scobSuhCfnAiL17Uck5+1+LTt+RY/uMZTKgO loPWXTRhvIIs1HQKE6SZuSnCmk/RYu7/qUMY0DuwSlvNNrE0V0AACmrAb11DSq4aI4WNfc7SUP5 nHANWeEBrD55tF2f7sEYxN79rung8ge3uaAXVKjcrnYW5O3FG+S80ZsoIas/HXmfx3LHittJ5vN peE6oA== X-Google-Smtp-Source: AGHT+IF4oK4RjV62StmGcH1F+juZyH1kETxUkeTCvuIySBQzsvQ1qwwVh7PBo0ix2VaqDofqtGdlyg== X-Received: by 2002:a05:6a20:7f83:b0:1e0:d848:9e8f with SMTP id adf61e73a8af0-1e1870bb422mr25205586637.13.1733839254858; Tue, 10 Dec 2024 06:00:54 -0800 (PST) Received: from MacBook-Air-5.local ([2001:2d8:690f:73f:ecb8:cdc:8c50:63fd]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-725d3fc95fasm5863499b3a.177.2024.12.10.06.00.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 06:00:54 -0800 (PST) Date: Tue, 10 Dec 2024 23:00:47 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: "Matthew Wilcox (Oracle)" Cc: Minchan Kim , Sergey Senozhatsky , Alex Shi , linux-mm@kvack.org Subject: Re: [PATCH v8 11/21] mm/zsmalloc: rename reset_page to reset_zpdesc and use zpdesc in it Message-ID: References: <20241205175000.3187069-1-willy@infradead.org> <20241205175000.3187069-12-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241205175000.3187069-12-willy@infradead.org> X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 84AC440052 X-Stat-Signature: tgm3h9tmoyug3twgi766nfxiqedpm5rz X-Rspam-User: X-HE-Tag: 1733839234-179177 X-HE-Meta: U2FsdGVkX183h6/M4nHQZaL6SpxhUoL6DxZ6392alXynFmJJdG2Dj4npIAfAN1mARCD5Hu7tYwhF6hpPud7BtdgWjE9xgB7eBm7LTc7ciSDrILsdnCViVstCopkhx0jS4W0QCjWHzxuU5nb9cHLPdsxDdcyl3qvkfq4iMIEBO4DfeTwPgervo8VgDu7YB2jMW4963r7bUn4XkcRyk3JiCztzzFuDO1aYp0uY1sb6Bk5wPFYkowmgXRdesuOdmsWHDaYwBf2R28MqOVPsIntH6IeKVnDm+LKoNY1g8hbpXXDevy9fOePueUWkAOqgUKFuO4qSaZDaIx2eExvU2qdb5WhoKK36e6tHJfD3UlC558HjZ28YCUxkQ4geTh8r6OM742S79kiDLY8Mt+SiQZFAJYGwr1ar7DHC7TY+Tp+3j3Wt0iZGbA6mmMIiFRYi0NZ3Lwc9NGNsByWf9ln8DbPjNZ8mN+383+ZdN7O2P84Gt1k+Sk2Xr92BCVZrcN1hXFhQiusJ4A+i6D0koZjcGu7BsP8D6wV6m2UT3ZH/HZs6Bog5dM3W1wDUR1z1hyS0jl3WHDUtACc5DKf87lUuAQQV+n60blpynwPJLtpghVBgYaXFxKRwKtH20Xkgye08lGcbe+x3h9qwdTp/XtKvENYQ634RLKk1gohyLh1lzsEO7IvBLbeO6JMzj7/mKWno/yKtPajDS96Hbp8W2HBbcg6L/tNvMvA+yAf4lpehsAfLMkRobl9EmD4I+qeV8qssReiwpRdezvsvR0Zz0AKb1kep2OZrHzP7dicVAoSk8Igj5D6mZWMy/bwLQwgtRb6OceO5y1KEI//Zk/CEqiQo2y4QZcMLPrjzR6XroEBTj2dt18RWhSaVy+Ep4xKyxUIA834N/y9TfFtx/RhaCHMTjdy07FHdAmvl0aejo475aASLrlt/lyKLGNrfeC1nGzfz6S25ji+J0DzJxTUTrJaMVlP AoszxqRT sylzW2Qw+uqOJ/ezaHadE9Ggl3gmoUh91Hv+RtDNp3NLqoR2AlcbPhpuUVeMrThasfycZ21OcYKThhjvrJ4OphYP0JuWDRpXyVUOZXmfzu+lYCS9bJXATSRFl7ZHc+e/K3gxjojkS63+NWzOVcrOhJ4PpFO48F6QE/ZYogR1ZOl3qEi7E6Pol+3T4nIBItYXadM6sHk3MP1e0gHKXXJIeDjmf7MlO+6DSXC/+3J11axoNJaLEhja34tIThlMlOotkNEeWawFcSof3wqs1Q8xB6GJeHIB4ektpXvYNBj7foPreofYLJs7zWCNUKYLXcvqGKFGEzLVm9E7HLaA9bLsChr9qTaBFU1Bq5ZnzL+bgigbD+V+wKlN/bZEfvNR0+lvUxm1LRLM5c9mvXcb4JiHhDmgGbAcPkAejhVXWWYxFwHciLHVHa1tE2SSblLaPe72VIK5zxz1ZIoDkKmj4mWKFxbeLN4piRCc0NNg4ma6psF+OiIpA2Y0pQ0IK/vNxqHbfU/Gt81U0Tfg8IV/aAeyauEmeOg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.239622, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Dec 05, 2024 at 05:49:48PM +0000, Matthew Wilcox (Oracle) wrote: > From: Alex Shi > > zpdesc.zspage matches with page.private, zpdesc.next matches with > page.index. They will be reset in reset_page() which is called prior to > free base pages of a zspage. > Use zpdesc to replace page struct and rename it to reset_zpdesc(), few > page helper still left since they are used too widely. > > Signed-off-by: Alex Shi > --- Looks good to me, Reviewed-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > mm/zsmalloc.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c > index d8f2f8e5c877..87b2b100782f 100644 > --- a/mm/zsmalloc.c > +++ b/mm/zsmalloc.c > @@ -861,12 +861,14 @@ static inline bool obj_allocated(struct zpdesc *zpdesc, void *obj, > return true; > } > > -static void reset_page(struct page *page) > +static void reset_zpdesc(struct zpdesc *zpdesc) > { > + struct page *page = zpdesc_page(zpdesc); > + > __ClearPageMovable(page); > ClearPagePrivate(page); > - set_page_private(page, 0); > - page->index = 0; > + zpdesc->zspage = NULL; > + zpdesc->next = NULL; > __ClearPageZsmalloc(page); > } > > @@ -905,7 +907,7 @@ static void __free_zspage(struct zs_pool *pool, struct size_class *class, > do { > VM_BUG_ON_PAGE(!PageLocked(page), page); > next = get_next_page(page); > - reset_page(page); > + reset_zpdesc(page_zpdesc(page)); > unlock_page(page); > dec_zone_page_state(page, NR_ZSPAGES); > put_page(page); > @@ -1884,7 +1886,7 @@ static int zs_page_migrate(struct page *newpage, struct page *page, > zpdesc_inc_zone_page_state(newzpdesc); > } > > - reset_page(page); > + reset_zpdesc(zpdesc); > zpdesc_put(zpdesc); > > return MIGRATEPAGE_SUCCESS; > -- > 2.45.2 > >