From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76C84E7717F for ; Tue, 10 Dec 2024 13:44:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D538F6B01A1; Tue, 10 Dec 2024 08:44:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D03B06B01A2; Tue, 10 Dec 2024 08:44:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA4866B01A4; Tue, 10 Dec 2024 08:44:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A01006B01A1 for ; Tue, 10 Dec 2024 08:44:22 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 21CBFC0884 for ; Tue, 10 Dec 2024 13:44:22 +0000 (UTC) X-FDA: 82879168260.18.CBBEC8D Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by imf24.hostedemail.com (Postfix) with ESMTP id 665FD180016 for ; Tue, 10 Dec 2024 13:44:17 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=FOOhcnzY; spf=pass (imf24.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.216.44 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733838243; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wka/oZOWIt+noAigQomrQ049Iy6YvaSmrFSiPsRCJJU=; b=eDB+/dHuACOHbBc/bKbkW4h8TM2461mYgNRHyFTcOm1WXmjvbumpSQfV/pS7IqOEVotwL+ 4NKI7GDUCF0pv0uyIYp05DmMJcwPw2NW8LvEpV67oMSqWt7qGc3sv3FoxWThjq7NT9dTre CaXAs9wgfrudioUsI/mZdEhL0lDQPns= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=FOOhcnzY; spf=pass (imf24.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.216.44 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733838243; a=rsa-sha256; cv=none; b=wUkvTdzQnn3GYzojGELO9kWihiW2I/mPmBDQaChh7S9/FtdavmFlhRm3Lx7UE4TYQ4Kyce 841/13NqCqVmcxQ3ZDfDaEmdP/NCVCOa4ZE6N0PmWXWwTcjTKqQRGd5/Mc1aXIT2C42g0E EMfavpB9LT0ORem4ODGoRJHu8FfTGYU= Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-2ee86a1a92dso4043887a91.1 for ; Tue, 10 Dec 2024 05:44:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1733838259; x=1734443059; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wka/oZOWIt+noAigQomrQ049Iy6YvaSmrFSiPsRCJJU=; b=FOOhcnzYJuPJLmKUjmvOt3UMxDGtvWwlS8Rn1nplHbQkhkupf8r4MiX2X7RJ25Gf2i xC1Z7ZTwkRPStdVdhTU1yQYfvtcugLrDJ33uZcuTXJMqwQVscuuPYTTtXbVPzbNlph6v QV0EiPs8FmFOtr/ouOjgSbE1I5w2A6qPmYnVMQ6d1oRkPTIVtf9PRLV64uz6LGkAmMYt zxTpMlRuvbIMt7TPhkZ6i0r0awYhcNAaGQiLOnSDiD8b9ORf0MDvqO6ZMMt0hEQ3gzZH Y8yrT9FirDAx8UQgAfoOXO6FeR/vWLY4LhSdckUpa5fH+6E7Dxe87Dw85AfczKQCqSKI 1IcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733838259; x=1734443059; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wka/oZOWIt+noAigQomrQ049Iy6YvaSmrFSiPsRCJJU=; b=Q+oRPNOTHsFFomzqVCALBe9Es+sdq622IfM8MTObrAkhAcTL8btDVZ2i20ASNZ7pGA p32bQggz0EGqdI3uGlvwGYRYTTc5H0vQJloAccSsJSZOKM+7hc0PIRaplNg2WseKAXdH 7IIqep4T9Y+AWyMUhEabkeIluDqQfVJTvA51KSqWHbpxtV37eHGPkx1Vj0Shn2zlRh/L PQjaqICUDe2vYsMlsN43EEEqTG7tiVfJn49JTmZdOEAsUQKsftALTFm7+XP4yiPGA7tG BdWqBsYiwPAhMVDk5QH0oS7xjRgpnFWciQRzZny+2m1EqihzV9CdiriPmDL5EcIG04q5 WFOQ== X-Forwarded-Encrypted: i=1; AJvYcCVin3jnTvwo5n9yp0PSWwBUraKgkmsvwVWanlPqk4yOWWu24ceXldnKkem3Eg1NFeU9iVKvrmrfNA==@kvack.org X-Gm-Message-State: AOJu0YxdkSRrOzcvKO4SemnPStOt46eudxodESJ/vxpnZzjgmElziFOi s6v+N/STyCW7hg1N9Dum/e4V1sK26egmhutEtX2TdqDeKSB4RSgs X-Gm-Gg: ASbGncv6O1kg40alW30ouoqa5FF8iryV+gjC2G+B2msa/gvpROuORKTauXALllw/30e Bd2Fpo4FT7+V/kIPrWlCbl36PUZ+Fd4M6Cg/sCmSVk7KAkNTlXGi6cNPUM5306t/QsQdzdH/FXI 5Znt9MdOM+aCplwIKzlsvjtPR1d42s3Jf/0yfcad99nr2NI9XEoixu20iSdqwBN46FYTLlLipWE Z2wXLlVKfH9HxGBaHt40JudHEIqCHbbh9Pf2MCuoUs9z1BUaLP/QptLAKVxVQSo2gbHAxBO9QGo Gqn06Os= X-Google-Smtp-Source: AGHT+IHgbnv+p3O6Nb2CZ92CVvXFw0h7GeERdR3/c1mYjPn7xdh9K7jpbakzLZkcZucZH6WYLr0x6Q== X-Received: by 2002:a17:90b:2701:b0:2ee:aa28:79aa with SMTP id 98e67ed59e1d1-2efcf110248mr6814630a91.6.1733838258606; Tue, 10 Dec 2024 05:44:18 -0800 (PST) Received: from MacBook-Air-5.local ([2001:2d8:690f:73f:d049:fbb4:193f:e539]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2ef87e133casm6734312a91.7.2024.12.10.05.44.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2024 05:44:17 -0800 (PST) Date: Tue, 10 Dec 2024 22:44:10 +0900 From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: "Matthew Wilcox (Oracle)" Cc: Minchan Kim , Sergey Senozhatsky , Alex Shi , linux-mm@kvack.org Subject: Re: [PATCH v8 01/21] mm/zsmalloc: add zpdesc memory descriptor for zswap.zpool Message-ID: References: <20241205175000.3187069-1-willy@infradead.org> <20241205175000.3187069-2-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241205175000.3187069-2-willy@infradead.org> X-Rspamd-Queue-Id: 665FD180016 X-Rspamd-Server: rspam12 X-Stat-Signature: 3hgcxy7a537ozxxeixkghta6pusciqbp X-Rspam-User: X-HE-Tag: 1733838257-534120 X-HE-Meta: U2FsdGVkX1/DZkywOTRitD5GRhiCKDe5W5OGvAYxQjUL55y77D6YN8M5ios3lmZi1ZOlNmZEdw+qcKVhPqr6ILZEjhmbI64DdXNPNlcvEh6JfHPnf65eZk+8TsObhhuVjCW/LagT6Fpsd1vXCsaR5DiowU05V20LilCFbrjSZKTE6jV74T4QRf9sl/b1YO30p1mtaXhU0ABV8NhKvLW2eBd/HlMn6puF7UE7bYDSssiwyEs8ipdRgFwa3x0sR2CYoWvthOqm4rPJsWUVT8vk+QWO3rMYfagEdMVLDpvznDybrp7AZZkZkr+pbjkZG7Gh/6RX9HId9CE510y+EbeZdcnpE3Jb8Z2Gj0IE+qW9h1jnowPe1Gn1EmW+vkj+uDm6VneIPJZJ7SEQhdqtRQmYpIMJjLIOrknSuWevoTWPkWx18jhFBujDwy9x7ow9fPWeqq63/9pqTGinl1nL9KVmvmYvALpdh8xhNFm3grunkgnpIsdQUTZ2jBun+Eqm2OOzbr8v7dgN7wR73aKh6tkz0zRnhG2Si2arEt2fsK+0cbvcpgOJeq/GEHKirP5weAwDn1+7TfF7R8U0z8l2t5n8DUQbuctxkkXOx4oRC355wDk7LUkS8g3Z8rLv1i1MFSmb0lhsSnBGSZGnlkj0qr5vNIyiDKiLXaAqrKjWYd73IorSm/lCUiuruimSoXB9uXnAKUDtoSGKIGou+sfdCMB207HJB9je9wahvTxfy3viENfxkhjhlWTvgPmLWqmF8fm7yQHPXiYAtOw09H3YjaSwnGn0LhIgCusW3uVxPui7fATcq52OYwc0Ch/fXAJ5woxTjpw1bXIKGuWUNE7XIOPj9Grcdb32hBcXU0/nkTegw795vFZgqDn1boIHlo85bAAdMBMafHoq8JATxqTqdUNCUIekrldi36d5Yt5WcMW8GHySZOZN63icuDqFCoyQsBJDp9GhYEIBI755I52Vppe qLpRfGfI TDXTXzqX/4UsKoMFaJ/nRc3/pdTi02nHLo+S+R6wYSsoEbenxuBcpDfanF00Bl/dbk759/8Wwd+u4YdcEqmwltrYHzuKuiRgRkFbgY93tnbgYHVXMl5KqP7weaNnhv0qAsicjdcP5TDo2x01E1/iiblQ65KjMjUvp4tz+BzrvN/1a82mSS1AculAKRWOn44+X5+nmkl9MSp5cdYBieW7ncVPKp757vsvYxrtS7RvKeFIyByNgmQiiYCdL4C9F5kcQt/9YVxaLUcjAO3bRsvsJctPAnG9rIE6gp0UNRieN3RTp9Wjuq6yH23IFAd5idvmVENhQbF+iLLzaAtZbM9CmnrNQMntvGiUQRYsz3mcKXaISQSilDZ6lagFsmhjZ2mE7NxnPvPxHYtZ69Z/KWxpY8vvXD/R8RB/jR15RJ6xwhwB/K91esd9GODKk5d9U9ZvDSTCVFUMHpvk8LkCrgbWMa92au6ihkYUVh8oe X-Bogosity: Ham, tests=bogofilter, spamicity=0.040904, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Dec 05, 2024 at 05:49:38PM +0000, Matthew Wilcox (Oracle) wrote: > From: Alex Shi > > The 1st patch introduces new memory descriptor zpdesc and rename > zspage.first_page to zspage.first_zpdesc, no functional change. > > We removed PG_owner_priv_1 since it was moved to zspage after > commit a41ec880aa7b ("zsmalloc: move huge compressed obj from > page to zspage"). > > Originally-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> > Signed-off-by: Alex Shi > --- > mm/zpdesc.h | 69 +++++++++++++++++++++++++++++++++++++++++++++++++++ > mm/zsmalloc.c | 9 ++++--- > 2 files changed, 74 insertions(+), 4 deletions(-) > create mode 100644 mm/zpdesc.h > > diff --git a/mm/zpdesc.h b/mm/zpdesc.h > new file mode 100644 > index 000000000000..9ad232774469 > --- /dev/null > +++ b/mm/zpdesc.h > @@ -0,0 +1,69 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* zpdesc.h: zswap.zpool memory descriptor > + * > + * Written by Alex Shi > + * Hyeonggon Yoo <42.hyeyoo@gmail.com> > + */ > +#ifndef __MM_ZPDESC_H__ > +#define __MM_ZPDESC_H__ > + > +/* > + * struct zpdesc - Memory descriptor for zpool memory > + * @flags: Page flags, mostly unused. > + * @lru: Indirectly used by page migration > + * @movable_ops: Used by page migration > + * @next: Next zpdesc in a zspage in zsmalloc zpool > + * @handle: For huge zspage in zsmalloc zpool > + * @zspage: Points to the zspage this zpdesc is a part of > + * @first_obj_offset: First object offset in zsmalloc zpool > + * @_refcount: Indirectly used by page migration > + * @memcg_data: Memory Control Group data. It seems you forgot to remove the comment about memcg_data? No strong opinion about memcg_data from me, tbh. > + * > + * This struct overlays struct page for now. Do not modify without a good > + * understanding of the issues. In particular, do not expand into > + * the overlap with memcg_data. > + * > + * Page flags used: > + * * PG_private identifies the first component page > + * * PG_locked is used by page migration code > + */ > +struct zpdesc { > + unsigned long flags; > + struct list_head lru; > + unsigned long movable_ops; > + union { > + struct zpdesc *next; > + unsigned long handle; > + }; > + struct zspage *zspage; > + unsigned int first_obj_offset; > + atomic_t _refcount; > +}; > +#define ZPDESC_MATCH(pg, zp) \ > + static_assert(offsetof(struct page, pg) == offsetof(struct zpdesc, zp)) > + > +ZPDESC_MATCH(flags, flags); > +ZPDESC_MATCH(lru, lru); > +ZPDESC_MATCH(mapping, movable_ops); > +ZPDESC_MATCH(index, next); > +ZPDESC_MATCH(index, handle); > +ZPDESC_MATCH(private, zspage); > +ZPDESC_MATCH(page_type, first_obj_offset); > +ZPDESC_MATCH(_refcount, _refcount); > +#undef ZPDESC_MATCH > +static_assert(sizeof(struct zpdesc) <= sizeof(struct page));