From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F112FE7717F for ; Tue, 10 Dec 2024 11:22:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B9346B0184; Tue, 10 Dec 2024 06:22:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 768A46B0187; Tue, 10 Dec 2024 06:22:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6579B6B0188; Tue, 10 Dec 2024 06:22:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 486D96B0184 for ; Tue, 10 Dec 2024 06:22:46 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 047D3140625 for ; Tue, 10 Dec 2024 11:22:45 +0000 (UTC) X-FDA: 82878811260.24.7904D7D Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf24.hostedemail.com (Postfix) with ESMTP id A47C418000F for ; Tue, 10 Dec 2024 11:22:41 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=CQ6khhXd; dmarc=none; spf=none (imf24.hostedemail.com: domain of BATV+8c38dece5ebcc54df4cc+7779+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+8c38dece5ebcc54df4cc+7779+infradead.org+hch@bombadil.srs.infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733829744; a=rsa-sha256; cv=none; b=RTX7gzLF9PeYDqzPlF/FdWxQI+NV4FmnH4ZHpDlwzv5DioWDbNi79qo9MCPA5pkeuCjLFy 3gOL4PqNWUdyu95oq9RnhHNMwqY9h5+q9+ufxldEFYmHd6aoidah9o8PzgN8bfPuiE3ETx l0N5chWCU02g2KQIz8fIwNdPE9tMufk= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=CQ6khhXd; dmarc=none; spf=none (imf24.hostedemail.com: domain of BATV+8c38dece5ebcc54df4cc+7779+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+8c38dece5ebcc54df4cc+7779+infradead.org+hch@bombadil.srs.infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733829744; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WwO2WwMmgUHVrbMnAEHD/hczXHCTvxPmE53VtScaPRI=; b=qt6BRKYyrQw2mNtTL+OlYMLzHbCBoQenZbsV/cw6YeBEz8uaT/cJ1LgjHLN2uN24ZJzOnP goEqHOzXPtU8Y6eib0MlqULGQX3rRUPnuK5hekFvrK3garA22hj3xB8GhAG1cyTBANFT3A GogKlIb2MdSUeXkc81BAKptbIjO2F08= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=WwO2WwMmgUHVrbMnAEHD/hczXHCTvxPmE53VtScaPRI=; b=CQ6khhXdcNxbSInmE0iCXUYCVp I3AKvSwOHbA356SDw+74PdaBpNxfCNg4EnYBwktitp31HA5s9fnyh+WIONLihERbtPi3ut1Dy+llM Uvf3MoyQyL2iXDOJ0d3YYhLkmYVTs2lyoW1+ytevXnHly2pS9mr7r3ct74HRcJS8bCBcLos9QrBxm u6tZO1RpuKQQL8NceSOnBngMYudGfBvJVPCFXhcFj2SRoPs5/Cp14UzE6TbgOcil8mEckYISEu5dH wYxfxMowNVxz1S+dUOJykYiEV+61er0QeBQ40Yh8HsKb28B0DACwhr9URIJ+tC3nvg9ffnNVbfO8m H44GYjXQ==; Received: from hch by bombadil.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tKyKB-0000000BIlk-2Dj3; Tue, 10 Dec 2024 11:22:43 +0000 Date: Tue, 10 Dec 2024 03:22:43 -0800 From: Christoph Hellwig To: Jens Axboe Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, hannes@cmpxchg.org, clm@meta.com, linux-kernel@vger.kernel.org, willy@infradead.org, kirill@shutemov.name, bfoster@redhat.com Subject: Re: [PATCH 07/12] fs: add RWF_UNCACHED iocb and FOP_UNCACHED file_operations flag Message-ID: References: <20241203153232.92224-2-axboe@kernel.dk> <20241203153232.92224-9-axboe@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241203153232.92224-9-axboe@kernel.dk> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: A47C418000F X-Stat-Signature: qbxm6ji6xuoomq1kegt7o11mfbj3sxnt X-Rspam-User: X-HE-Tag: 1733829761-597200 X-HE-Meta: U2FsdGVkX194O6TVKDzeilPMysmJ8byZ5MNZwJqXg2sro0/sItvC1QO7HSQFurT6D1ljn8Ux2B4zXN05lULG3qwUex29nTnLvEFT3eYjV3SovKxT6xYVAyl+BQmA5A6t23ebxswybjHwGCetYy4T9c84lMDywST/F4wsdhanh6KxjcThTLi9oK7vXTuAa6U5aV02GsPsNWttboi/bRRT46/aiPpEwNWzmMJLmmFfbqWZGMRGPp4Y7R68hfy8HidqbcamthfuFs9ek/Iui8nzAOnktgAuAQINwh/EmV7lj/Ca+EmbaGA/LYH6lnlWkyKrE/Wtm3173Z/Wjqeb2zx+RU1W9y/LwhqUp9Gz7G0xGV3Pi9HijMBEvb2cva2XMkq1Kd3nYsBbfkS2X+S6TiN/7Rj/jUbyecRbOjnXVZ4bve/q8VQDKGpMxSJJ4tYcZwQhO6T31kiRZXy+SE7nW+F7PQCUI2f5siD1U2yjXG0oa/+pCWTkkF6sRUzj2KE36VQias0LSIz4tbmPnxeHHxMWejnBekw96PWjtjhj16CN8/AjjsVCv5gMHiWPNk6AOeA6vjhmNpGY7H1u1yxg9l5wGZp0PSj39rEorXUyaAkxk4O/CiouvYWBV7ZCOCF7nMVklLrcKeyexJVfJd77MOV8V5CUiw77BT7Rk0D6ZAZ2a0J8ePKCwuBEZ5c/ub6fcwPA4UiRMWjHkTNh1JC8cGUY+s9mu4U6/hqabUgigjGLdNPjWUPUVeJ3RMJ4UpFtcQjuzB4qUz0kSL8p/FaCsCu54omO/aLz+Pk59Wmr6j3uXclFMld9S8N+iNn2mr5bX8np8ccBgV4AOOkRNrw4YN4qL+L6iRCi2mpdL80Fe5D78TGw80W4npUYWIWxAA6x9RYS1JIjoWTYnlZP96UzASaWmRZ6EjAkturp0C4P/s37BIt0/SVg4uLABsBd/fg0YOG7g8wGcWpeXCzOYEey944 7A930/IP spRc2wAP079AUC9Y+N0dLkj++Gl35bbukCVLa7iPvG6SqATAtLnmjR9FUo3TMcG8L6Bd88JJqiepoEQEGJd+JeugGhzDN6FCTr1y1NzdL2M6EpaNSr4B7sW6nDUMHz+caQTfwhwHzp9mRCe9KwBUeUb+puHoNivtudjEm1tAhHPElGVVbrEPCd+N6XWJXmUUf7eFjOfPbbP+l8gDz4mYbtnKbjzieQCiCJz4Y7lNe/wx59BaeYxPME3EQXw3kx4eTpB+THaHVZIiRfqGEIp19Zg5TmRBwqURZrhpDlpSz2nTrCQqUl2a1F4V7x3WriIVddUdtsl8lpe3f1z9P81cAsLZVU/qfloHE/5Z4tB06kD+1G171Lm+DjuPMh4x8ZeSE3yPUCFPxLOS5aNoFnTDPCxQxoNiPAR6tEqD1xy/5G9asKehCelpMA3ECNDJIo1w4TLleqDobfiyTNpfh2j04IYDCDS0ZtDbNjUS/zEZXzfxc9WyI7x3J2ooBAXoTYpi/9MqXHVXTaRUi8CpiWF7q+FRNgg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Dec 03, 2024 at 08:31:43AM -0700, Jens Axboe wrote: > + if (flags & RWF_UNCACHED) { > + /* file system must support it */ > + if (!(ki->ki_filp->f_op->fop_flags & FOP_UNCACHED)) > + return -EOPNOTSUPP; > + /* DAX mappings not supported */ > + if (IS_DAX(ki->ki_filp->f_mapping->host)) > + return -EOPNOTSUPP; I'd argue that DAX is always uncached and could just ignore the flag. Same for direct I/O.