From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E87B3E7717F for ; Tue, 10 Dec 2024 11:21:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5E4A56B0182; Tue, 10 Dec 2024 06:21:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5933C6B0184; Tue, 10 Dec 2024 06:21:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 45C666B0186; Tue, 10 Dec 2024 06:21:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 28A8F6B0182 for ; Tue, 10 Dec 2024 06:21:30 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id DFC2F41928 for ; Tue, 10 Dec 2024 11:21:29 +0000 (UTC) X-FDA: 82878808194.15.0ADCEAB Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf20.hostedemail.com (Postfix) with ESMTP id 40C441C0010 for ; Tue, 10 Dec 2024 11:21:05 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=zcjUZusi; spf=none (imf20.hostedemail.com: domain of BATV+8c38dece5ebcc54df4cc+7779+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+8c38dece5ebcc54df4cc+7779+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733829666; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NT/3a3rEZgq3xUYsqnnRVuevWBBPFET2HIdWrD8NKYc=; b=QPQhiGAw2fQifQt6jq+Z6Lpidx7ijJ8zO6EHn2BSXWy7s6nHRTa2sDLfJES2835LH8VSsK frGF9x9uYSP/3aU6jtBQ5wOxaF4z1Q5a4zZFvMvTgoDgWEqRXCOKVAbHKHBemT8GX6Pvsx 1ND2n9NSfREQTNOIcYjUsG7hxyZF9eU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733829666; a=rsa-sha256; cv=none; b=nFBCB/Nlu7ib5tGX4+KnNLMI+1i+2K30JBacPba7G3ZymZ/3grztmGmjEpKsGLqxSfvX4X 8iGJZIjCI+o+Sa3i+Yng1V6iZM3Vo2BDfzZcdkVu3ob3sW768Zs/usyub0kUiOP4ZGqYEr 31PgBAWBY2kDauCrS9Ea3QEEhRbmt4Y= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=zcjUZusi; spf=none (imf20.hostedemail.com: domain of BATV+8c38dece5ebcc54df4cc+7779+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+8c38dece5ebcc54df4cc+7779+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=NT/3a3rEZgq3xUYsqnnRVuevWBBPFET2HIdWrD8NKYc=; b=zcjUZusi19WyAixdgpsul6WCTi A8CECH8hTCtlczdv4N3164EW1/F945LrspENuMONS9V9CaiW9GxtYe1wR3mLr0qj859wfI03wFK17 pysYfdGtaEZ1rgTiIk0lhbHyp4JMjjnxohpZPIYGFuBj9XniGualL4kcOozgiIG+JLW+MEUJPbW3/ NoC34YcRQpCRhFb2Hx30s2DDKr4g2OrpwyBb4UyygwZTgaJvcJvulc4GHxi+rhQe3IiD149UQ0uQc g0fCdZoCXf1CF0Ex/TrMbGKuMMXn86vY3x+fIgRI44X5QLuf9ck4T9tYaz/eu6r2dGgkbRv8SxdDM TdyPxIPg==; Received: from hch by bombadil.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tKyIx-0000000BIcC-02SU; Tue, 10 Dec 2024 11:21:27 +0000 Date: Tue, 10 Dec 2024 03:21:26 -0800 From: Christoph Hellwig To: Jens Axboe Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, hannes@cmpxchg.org, clm@meta.com, linux-kernel@vger.kernel.org, willy@infradead.org, kirill@shutemov.name, bfoster@redhat.com Subject: Re: [PATCH 06/12] mm/truncate: add folio_unmap_invalidate() helper Message-ID: References: <20241203153232.92224-2-axboe@kernel.dk> <20241203153232.92224-8-axboe@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241203153232.92224-8-axboe@kernel.dk> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 40C441C0010 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: qgz6giez8pijn3tka5n59ypf4sk77h46 X-HE-Tag: 1733829665-355134 X-HE-Meta: U2FsdGVkX19+J5UIPtI14TQ4EYWKdOZhlKdeV+5IMs1sizYNnNwQr6s0A1FK8IeWYHy2+gh8PFKLU++wOE1iWzFSC+z5orFED3GTlnUYql1+qbzfsZtTmnNxNLnA5VhVnovVdonvoWhsgT0mUN+n2PRO+oJty11Cg0HajfxOXfCvtJieYp/SO2Ocgdft+fScJxD0K2YoWLUmKZfUrK78z9+0W9dkgT+ssR2rVS5674BhicQBKUADNwD27wm6DbdBFluJmoyHMfxEwgs3LDsqLDlBmPWCr6mYzHqs9ZVhNSQEaEIsr+9TgFFc9VqhFywt+fHBy6UAPHBF3JBHVIAjtn3FvIaffqOC0IFgADFBGgfRXCGRtVg9YxBxr8UnvaaFRILla1UKLAkvMMsojn4b2Jq/Oead3j+67aTGS1/VlF7fL+FJ1WlpuTbGcgvEqXCWeIax2QYN4jKcNkn8m7ecn4i1NSSb+OSWig7/rImi0xXyZjYWfBrsbGQ4SinBjrIFVWbkaG4y7r5qnQV8159ouRsyT4GKhPeUJNQB1F7pndrOjR/luTCL9MZ3f+Jlv1h7YDkNliQmJOuvOQuM7CMW7A/MGpFdgeMz820B1+iyBuvjO9MpRg71ip6e0IjU5TbKpkFe/BFNPVxLdBrSJ2Rxr7VzTpUEDWl9tT8v+s1OKqxOyw6RFn8mYysV38Of/1JlQIvhc0e4upj6/i1Uzc9wzITKI1zG7ESTRO1KLTdL9FMIjuE6g8vf9GLoarxa5/OQoI50nWgBmNUsTjoSUXzYyK4P+OugxZ7ovcNqwx5JwqIQ6fcxOALahrYXUZXUjp0+yA5iviZr3ZtBe5kc//4Qf0UObZmFG/y2MqItZR8KV4O0PNrvxOlR+zRJPIeH2r2nTwKXltvMwBbhaWt/y5rMmVOLfgBIzmgcomDa07jOSqjHmqi7gTIo4vWghM/uQypWNzIr6eZzekXV6IpJiIH XeXDfBPd RxzhqB4dOCxnxQ8qtrbmuXgaZfim6jVvReqXhwCnjsRFvUHybWxOWQiUQ6qkuNpttP3usutBiEunwwKD3+iTktq4eeorP0NibYaWK7nWdd8hD24Ncyb/tZx9q73j+r304IvAz0/64bj7qsO7RCfYk3N4jHT7KqCKbJrs4b90Wc5B49F5IKXw0K3xbK9uFBWxylJPX8xc608fS/KAIvn9KdmgkR4/eF+v+9rxOinyPtg6qI6NWkJcfhpmpqiNIVBmm6WM87Mw58C4Nw4lXVsEW18ZhBKIpCmGaSi7btqPWZnnw+3vDVRzxrIBOfl4V8A5tTzN+hou3czRz1/dr3ltabIkOlAnLsNFL/am6DdN/NOIM4IBy2mH7M0efpUlvInCNqhjKEC3DgEFSzkbjuJN3bgQLdqfCO9VYXVzGLU2tEO3e63nq/y8i2v+S3o//RyWyei5m7fT6JCzc6id0AqXijh6FGfjZnBJOEEupXVDXSA4MDHw4ACN7lVwzavukQ21s3anZ5XNBF+mhTrMFXi6vsLcTng== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Dec 03, 2024 at 08:31:42AM -0700, Jens Axboe wrote: > Add a folio_unmap_invalidate() helper, which unmaps and invalidates a > given folio. The caller must already have locked the folio. Use this > new helper in invalidate_inode_pages2_range(), rather than duplicate > the code there. This new helper ends up the only caller of invalidate_complete_folio2, so you might as well merge the two instead of having yet another invalidate/unmap helper, which are getting impossible to track of. Also it is only used in mm/, so add the prototype to mm/internal.h insead of the public pagemap.h. And a little comment what the function does would be pretty useful as well. > In preparation for using this elsewhere as well, have it take a gfp_t > mask rather than assume GFP_KERNEL is the right choice. This bubbles > back to invalidate_complete_folio2() as well. Looking at the callers the gfp_t looks a bit odd to me, as it is either GFP_KERNEL or 0 which is a valid but rather unusuable gfp_t value, but I guess this comes form filemap_release_folio which works similarly.