From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C921E7717F for ; Tue, 10 Dec 2024 11:13:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BA9D36B017B; Tue, 10 Dec 2024 06:13:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B32126B017C; Tue, 10 Dec 2024 06:13:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D3646B017D; Tue, 10 Dec 2024 06:13:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7B29B6B017B for ; Tue, 10 Dec 2024 06:13:15 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 06DAEA082E for ; Tue, 10 Dec 2024 11:13:15 +0000 (UTC) X-FDA: 82878787530.04.63AC7A3 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf22.hostedemail.com (Postfix) with ESMTP id 3C505C0013 for ; Tue, 10 Dec 2024 11:12:50 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=h7tIgdUP; spf=none (imf22.hostedemail.com: domain of BATV+8c38dece5ebcc54df4cc+7779+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+8c38dece5ebcc54df4cc+7779+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733829179; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KKxeo5Dq7PDirXiUbx/lnvud/6krnOHXEt33uvRUtdY=; b=X9a/ipjIRDuhKQ6EHp9NsXpqJCVLG5kgnOh3XlNpqkRrw/8NfARjDdcNWNNvrW8cqi8R84 9OOa4RwN0/JlrnQfMwhQcJ3ng+7jOxUViWgP4vKPhEE7L75XlEEinRnSV/OlHQOAAsTIAs j/htMK1nV6IqL0B8TWOuCu2nyaS7wcg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733829179; a=rsa-sha256; cv=none; b=8j4oE6FymLB4GoVq2R7ZA+K7SZLJjD67HT3MczlsOo3AC6X54aYS27YhCtZze9+h8Lt9q5 cnXiMHHgF7ZIQoI9nvuqzUllLiGb8KgeVHhbnQDEQ/9/lKpqGMOnV99e/bCt7bkwgybzos oWfQXbQ0hvuwwCNCkFP7UKL4y1Lfizw= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=h7tIgdUP; spf=none (imf22.hostedemail.com: domain of BATV+8c38dece5ebcc54df4cc+7779+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+8c38dece5ebcc54df4cc+7779+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=KKxeo5Dq7PDirXiUbx/lnvud/6krnOHXEt33uvRUtdY=; b=h7tIgdUP8MwA7O/zZThtdrtm96 BolgGocQDA8egdF9mwnwKR1CCWvI49LOz4mLwh9kg5TwySZHXceK52esfmbM0YFaFRRzKzA8m4FdO VQwuFUwdavHhpyZUGgKZLYHkW/w2O7zjAMAF6lsY4Kme5sPbMcLAYfNqD0rFXB4rvexWoorYNgBt6 FwvCShatDxXvlzN6CnXwCVRVqPmQO1WT11LOrQjTVThpmrrvPl4D6TnJyl8OE8fGEdTe+ZbLF5xN9 HtAHkE3OS1H9A43/+fyIKNPzxaD9f5pO2JI2lBmKTTLbC1rwQUZLsn3IFHwqfU0KCn0p1QB43VxzP UTUkuTEg==; Received: from hch by bombadil.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tKyAx-0000000BGuD-3s5G; Tue, 10 Dec 2024 11:13:11 +0000 Date: Tue, 10 Dec 2024 03:13:11 -0800 From: Christoph Hellwig To: Jens Axboe Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, hannes@cmpxchg.org, clm@meta.com, linux-kernel@vger.kernel.org, willy@infradead.org, kirill@shutemov.name, bfoster@redhat.com Subject: Re: [PATCH 01/12] mm/filemap: change filemap_create_folio() to take a struct kiocb Message-ID: References: <20241203153232.92224-2-axboe@kernel.dk> <20241203153232.92224-3-axboe@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241203153232.92224-3-axboe@kernel.dk> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 3C505C0013 X-Stat-Signature: m9iok19ze8167yxt45nse1x9wpk85x11 X-Rspam-User: X-HE-Tag: 1733829170-531773 X-HE-Meta: U2FsdGVkX18Y6V68JLqvV11CEZQO2HuQxbePUhYWpPROJD+ZTX4y6wzyUrDhTC1rSRygz9/Jc74C6ecPqOpiOgynevh69jzPHjjbca/SzV/D3NmdeyxOAXNq+AUdxZHnIBq/iZscyzouRSdZOxGTXw/B3R37zmt3LE/hu2kcF51L6b/WMQksNMV2q/FeI9FB6Z32fn1C5lbFaSOz0a8jcxMScuh2Te0Og/mcpG2JWzcNby9DOCsTdFGYlfuwqgIbFvKgtIYgInTR+tTGLw63r2V0Sw/H6Ny+bOKpzbn62Gc5wpIWUHDeIgpBCZHwe/AgLEY+vzWPugcpzRM+5mzzyFdf91eRH0VDScD51g/q9NGsHvRa7LNr1o8QEbok/wm4M3e7BKuVfmgXgHoeeGSMJhLdsLPwfWcyZVdhCr6S2TcBMuHz0pWukEqpMMnLgNBRKjWoKHKa/YhAPoVJFGS9w0Y58n3vG2VtmRUBMHi3jPTPhA7w68Nx7doWdNwrEE3TYTS7+4TJV/bb3JNS8ww5d7gJE70W4clfkrOfwWJOMIrR1OUBQNc5QlYVaRW5hjQHbM0nDDOfb9nN1lza99BeBDhegoEpslqus1xgdTUODnxnZ92v+pBwvotiIDp6YYiUlQOXiUdEllmWq2heueKkHVHsEZKAOrmacjefBP+GdIqqQtGLVgPtcSc58nPq2wecuPdPLQj+BkB/dqpKQ/tyk1GZwLrET7V1Ay3GeuCiQLhkMJZKB6lrIi1s4yigwoPu3wquTeAdbif4GSi0DWdYiYBgyEEa5gBivByX0/V9MsWNQS99jLQF0F0Ig9UT2RodYt3XDbxZd3H6g8uKiic5ry1izHyT9FGXCmcOFEYQTCHYfgkqU6smo67dtUS/ZA2psWMIxvyXrLqR1KjMt993lh28jiwMVnxhDr7ieHIn80tTBT9Ifl2YcrtJu29S1YN404pJgNnUoW1IMUgAjCD ZQ+1THiP Ge8n3nrAr0N3RT+EO5/nWV14NJF40CMEcPRdOgog8CvHupCvapcWY36oANbv3rLkzpgdW1OmuqAcR32YYkCDrCswPakVVFyAYvqhiJsJEsh43glXt1lKXJUOY+WCoO2ZrW1ggKtqu7of8Yj+eBwd+xuSkGfA3tzmKt5CLDMWblBOtlVmbZAKO8iWczV2uwEZuP4pkCIzRLi6FfkL5mCbL7tcFohObjOcDjj+ydMziWG33r5467qK3KZpFAYIxIFlUZkle7kjExhebtRn3HABa5Ib1StbohXaobU7O/EsBBTQT5K8Ko1V4bPvHUVH2NyKYVSaZRi4mfr4I9tOUgTCGnrMBAd4FHz4IrBK6KvD/aNbA5YlhdoXWbxAxpCNWn3yxXqOq1pGJqKLuMl7F4dfebx4buPc2ntg692zRAjiozXtaWphqdottnB6+IDrRWm3GfCTJNfSfSt8mXxvMDLeERHNMgUgPsVtl8BIRsD/rRlqW0SyUZcQr4z1AgJdZTHdz8RXy6J520S3gFkRsl1PXNo8EFg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Dec 03, 2024 at 08:31:37AM -0700, Jens Axboe wrote: > +static int filemap_create_folio(struct kiocb *iocb, > + struct address_space *mapping, struct folio_batch *fbatch) We might as well drop passing the mapping and deriving it from the iocb as well. Otherwise this looks fine to me.