From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA187E7717F for ; Tue, 10 Dec 2024 11:15:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6535F6B017D; Tue, 10 Dec 2024 06:15:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 603816B017E; Tue, 10 Dec 2024 06:15:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4CB026B017F; Tue, 10 Dec 2024 06:15:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 2C3866B017D for ; Tue, 10 Dec 2024 06:15:38 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C925CC07AF for ; Tue, 10 Dec 2024 11:15:37 +0000 (UTC) X-FDA: 82878793494.16.5258813 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf25.hostedemail.com (Postfix) with ESMTP id 8C3E4A001A for ; Tue, 10 Dec 2024 11:15:20 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=rWsNa9C3; spf=none (imf25.hostedemail.com: domain of BATV+8c38dece5ebcc54df4cc+7779+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+8c38dece5ebcc54df4cc+7779+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733829326; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=N/E7hy0e3ZL6CA1y0gJJQ3G4S6LexU1tKKmXtYfoVgk=; b=GSInWDI51q+E8BGMzlsRSRxKkkwIoWEtf7wK+N/DfN4yOEGK28HvejmBbVq26Dap6M1fvc 0/6O5+yehHcyDxopk7OBndVyQeD3K0+z+34Kpwo71QckVGsjVIekSfi1ldkIEX8cSmp58R lvGirbU4hEf2M4JlT4QVIWQdpsmcTNQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733829326; a=rsa-sha256; cv=none; b=S2if6DXvSxL6SgCb/ndWSwpxIx1XvCaqYfLD3qA+WXQH9IMPFsMmZh7+V9MNzE8f9cHv9C tUsXa0rOCViTHgKA9sGvmPN92tNLXzvxhXVFZaSS51qfb8bDCD1U6SwgD76KM5NTbMps6Y oXJ9xB2Sd87V/kdwzt6XQR9nTWAuO+k= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=rWsNa9C3; spf=none (imf25.hostedemail.com: domain of BATV+8c38dece5ebcc54df4cc+7779+infradead.org+hch@bombadil.srs.infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=BATV+8c38dece5ebcc54df4cc+7779+infradead.org+hch@bombadil.srs.infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=N/E7hy0e3ZL6CA1y0gJJQ3G4S6LexU1tKKmXtYfoVgk=; b=rWsNa9C3hUiV0XpoBLC3VMcT/B 18VfAxVIIy3/EJ+CPRs3i3Vwgo5jfKmoR9KiTAjxFvVmTisdWYU4A3GmLpthiohiU7MDG+/S/xFvN GT8D93VGZ3SSCPXnsaTKb2JPyCEVG6uM8r7Z2veGHaezDyGdPVBhWTxWFd7CmZUNxhSgVulw81535 iwkSh2APe/lmZNwZsiznTtNd7UkxLIgPkHLp4n9Ap7uQDRi29tUR49RNYtvQg6ZpgdNnQr/il2GOx mP5T7qMljTIx4aumSZib+9rX6pDj8ym/TUNOzaYHX3ijjQopUWbxSkcmdmG3TZmWZbsglxBcO6tZi 3x7iiq5A==; Received: from hch by bombadil.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tKyDG-0000000BHQJ-0fjJ; Tue, 10 Dec 2024 11:15:34 +0000 Date: Tue, 10 Dec 2024 03:15:34 -0800 From: Christoph Hellwig To: Jens Axboe Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, hannes@cmpxchg.org, clm@meta.com, linux-kernel@vger.kernel.org, willy@infradead.org, kirill@shutemov.name, bfoster@redhat.com Subject: Re: [PATCH 05/12] mm/filemap: use page_cache_sync_ra() to kick off read-ahead Message-ID: References: <20241203153232.92224-2-axboe@kernel.dk> <20241203153232.92224-7-axboe@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241203153232.92224-7-axboe@kernel.dk> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 8C3E4A001A X-Stat-Signature: 7wmehadcz3aet1wnuwg8ks6955p8d7sq X-Rspam-User: X-HE-Tag: 1733829320-643372 X-HE-Meta: U2FsdGVkX1/blMIlXG5JbPLN8v0cAuQrbHMqYAEUmio5aFnTq7+PDbPej7qfy+VhruWr7rRa3ppoHgBVt+n+Hk4DccYItgegYuU+kdHSlYSlPVVI8/sNx9d99X9secFxteIs0AuAYmww0IbtCnpbxcOyULscRHsMeBAWp2sGu6QhD2vTjbJIMMuAbzvRCBLndvt0PDffEL2dCS4MEOH4S0blGrazn3KxEAkoe4J3+715+pMRZFkWVS+di/ckfKOcXZ1gR5mxKKTL5uWOeExupvD3cEl+SleBWcnIbaFb1JW2aBS6SDPGoYx7YEmP1C+XtZZY3cvkA8zMsMFQcKD2hzc6VOvj/ZD7mvIB+WPDp0dAqQw5b3xv3ksS5tJc7oyGgNbP+U10qrCSsA62UYSfHX380jnocbqG94uuM4Ro/BdD0x1QA0GSeujWfXw/+i50DgUfJ4IysMn1JbxToY/n2FZKiCQjcCnDCZt0D2rNdEbYr7QyrUJ5kQ00R/YG86fdnYSDlBKTCGNH9Ar65/0SuI3Nai7PpifJwnH0DBQly9nUywTiLdqaxwVwkeDrhcyu5zK9+VZLd4firntVlILIXHhVRyqevdN5W29YhVsp8ddtuYg/hXs0ZQ/DtqkKmfHaYi79jx+NjAnbFs5QOk9iKPdDU98D/PtCJRgLyuEaWLM8k4Qx5PTPfSeBOTny1PFOLr0jSrdnoApZN8jDBKMOLxhyEz6WRrCeuZmiK8SDU/BmqGsh8DGbAYfd/8JY/7/R2ddcSIJWzi/bOeZz+zb1UNAi2yyXS/C4xFlvz58F3ImYsRhbkXbW2B9TQn8HcNx20Wndr5juZWbSW/XXl1Kn4N9XuILykUGZqATsAoOgsCn1BKq8CUhVxWLCWSIDn9pv7shOZEJNhkSoajUNHHoE93l5G62N3hbDkIzFLe2Wm8BirRdEc6uaT90FBvP9Tf4tWdPp9pED9JXZPVEh7wb MrXBzoQ3 OfqiM5b1Si1PWIyTrHMF4PnN1BEjtrdBoqz/4OOJ5Sd7qDXRh4v9vjPSmxYQngKDlBE6NmJTmWRaV1913eRtRTGvguA4cV5m7Y6KY4k3lmbmwgKKaXvzQeRafH62XKn+jWVJZXZphiXL/1UbWD6waL5Ix4ZfrYKYVd7IDGVz0cKGiJ3BbeGmsmBwHYyhud7BDriG9uPQ1Fi99KgKgpI/8SP2BwYC3SC8JrcPxobSU0Uwpu6XikVwahO8WFdpcMEeRG3UVPOphdjyEY6SPzG18qYwpXr6BvbCSm7zPTEM+2VgXt/B7576UEJVvy8K6nrEvhi88gkbnojFfVp16CFhpG2RiGObiDFQyl/jHw2vgX2fsxv/JRnzP41o9aGebKWOJczPsCQXnJ8cw3+791yLkCTD6SeoGi/NPIt60rSPEohEfhpr07EVa2Vq+RYJD7bE0wv35PbKuTs7aOveiZPE3M7HAoarl+mo3/JtEUEEMCryd25D9rjZhQfcrgFsgAH9zVe8/URpDWsA1z82H+YyFXhA/YA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Dec 03, 2024 at 08:31:41AM -0700, Jens Axboe wrote: > Rather than use the page_cache_sync_readahead() helper, define our own > ractl and use page_cache_sync_ra() directly. In preparation for needing > to modify ractl inside filemap_get_pages(). > > No functional changes in this patch. Looks good: Reviewed-by: Christoph Hellwig FYI, I usually try to keep these pure cleanup patches that don't even directly touch the series subject matter at the beginning to reduce the cognitive load.