From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E38CEE7717D for ; Mon, 9 Dec 2024 17:09:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 614FA8D008F; Mon, 9 Dec 2024 12:09:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5C55C8D0058; Mon, 9 Dec 2024 12:09:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4DB568D008F; Mon, 9 Dec 2024 12:09:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 301CE8D0058 for ; Mon, 9 Dec 2024 12:09:22 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C085B140303 for ; Mon, 9 Dec 2024 17:09:21 +0000 (UTC) X-FDA: 82876056144.16.91F5E17 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf09.hostedemail.com (Postfix) with ESMTP id D8E72140017 for ; Mon, 9 Dec 2024 17:09:05 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf09.hostedemail.com: domain of cmarinas@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733764140; a=rsa-sha256; cv=none; b=K4u31WRumuQp+wmJp5+1vruakt21PiZhvLKzFZ+LTbo9EjcTcbXcVNULdHj7PAEgr1NvRy CCn9KyMCpwRdaSLvT1TkFdROQxQAW0oNgkxvDT51jmT4HzuCx+iM7gJ/pbnQYS4QEsQpv4 6Xk2eBLuX7Qkb7Virvb14u1mpQYOVOc= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf09.hostedemail.com: domain of cmarinas@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733764140; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=CBrKVQhvPvvcGdXyQR2n+0aYYfxMfPaFR1fpM4VzZuk=; b=5ldsBTQ8g7pYdjDdt1wMK5Dlq/Ctw0M7Z3AjY2SGARJEKYzUl9/0M3vasmFYF/CMWoAc2D 1exiA7T8heucGH5h6N8ykFZVW28B7qBDSnEVXGV3PnXv6A/lNWNMjqan8tnrMqM2IxfiuN 9jQ7wO7+Ke5xVZMHhfaVZOqo8/xca5M= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id C14D4A41823; Mon, 9 Dec 2024 17:07:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1C016C4CED1; Mon, 9 Dec 2024 17:09:16 +0000 (UTC) Date: Mon, 9 Dec 2024 17:09:14 +0000 From: Catalin Marinas To: Anshuman Khandual Cc: kernel test robot , linux-mm@kvack.org, Paul Gazzillo , Necip Fazil Yildiran , oe-kbuild-all@lists.linux.dev, Will Deacon , Andrew Morton , Kees Cook , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/execmem: Make ARCH_WANTS_EXECMEM_LATE depend on EXECMEM Message-ID: References: <20241209031251.515903-1-anshuman.khandual@arm.com> <202412092048.tTzJ5szH-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: D8E72140017 X-Stat-Signature: djdbfrh8bgrdkzgstd4x1cifg71sp3ng X-Rspam-User: X-HE-Tag: 1733764145-201669 X-HE-Meta: U2FsdGVkX1/PxwFTldaqlA9vzmqS4AF+LeRXonRm1YTFLRXh6vuTRBusyc0fduXMyWVQ/2/2PbD30GsXYEMf6fKR5uYPXGftN+1qzNdIZ2jQ3iO39L8ZTqJlzV8XeCnl9lRQ05Yg8pwOtJu9cormpyxOOt1mzF20laTklEhh4T2GjPpJU68NEVscpzgXHDljMMI9tyDd28LGIOEG5WDX/EFfDLhWAh0P39NnAbWkPmPrzQaOa7FTClhZUzcBM99gvtavFtBHbzllvCF+8VzZLLz91zHaRrTmacy1pnOF+tBScMy+tkL+jq4d+3OIt+oYXf00MrEnZ4rRbXXcd8KuNIZFdR5uzf3DEaWogPZTQc+GOQ6xseq991/bmKcD3P6vM4LBGomrVwaKPTlpkUYjgtZjx3CqMCRGiahoGOun/q9/NklUdSw1P1Hl34XoyGxooaHIbt+ifX909P1O55qgJ7c6v1sh/hjy10pwfZNpk/w+wzJrSrFXoNGoaRmf3PMJAVkYk6UgRwMnZH0+KV3exjUZDgVTu3Ogx5k+nYmC+/1SOh2j8XL12n7YN07U+QA+gjQKsl22XkKRFgveJ1S5jCak7diymm0UBtyh6M78PFRcXtQQpfyGAUnKIzTWZtUbVNkVCaRskEdJoMj87uHrHTl5IZGaA3uUWZUTMtzDJIcyLsnA1JfZ0/QHkQJGi9KOIzmJ9+hCPVWS3A29xMZlyjIl8VTtiitWQv20y2PqGDANlf3Q/CYQYfaxQsMhQS+hkTKJECN5L9mJ4VIyuA2rUjfq/ys+CSODsa4MGc0QMxxWg18VzYr1ATeSe5pV6Q/Ei1HdfH5jcF/jzh5dcZq/aKZku90JDT1dN+I9aNGduSA+L6nsYXFovivoruwj8XFbsbYrJ1GcAx/8ao3fA9l+SbqjZnE/2gnPFUB07XRgBLwzRzqy2NV69vlyEwK+K+E+OmoU3H/+Fn7eY5yEFEC kZxCkpG8 iBOqApsewzigUH3WZEcshM+E+OjgWKjdFqctInxOuPMrxLCiHNPcxuHT4W+OAxgVeCEc8KfaCNY03v1tqjlj5wjd71vAMH8iBijlPa8ayYs0n5LfjONxQElXn54deSxE71+0HQFiwEjFeQmcBvqcOEsMGxY2JRUIPNTIUZiF19+8SDQmm6IY5Du3GDFPFyshPH8tQxYaL/wcl5mroLva8J9OsUT5vbhnuPcA7ig6Udt6EFJ0jlX0hjKogcvAsBQoHPPs9ozw+RSXLecHr2FZh3+3adBCY8rdiI/jFTPhcciou+veR0eZC5i8z7JwU8K46twEkiXtGQA7GEU8Bcli4wM8jF1QQugieUtNV4aI1YQ6YgG/sxsyCGJFexp11qrdY2ddGTPhjZm8s2SNx11A3ZprxPM0dxCFH38lWrtFXAjx8mwOjsaqMMT8jZHtz/Zu9ritXcUgcCZctRbWplt5dFtIOHBtJMBYXqScavTXtGMBfOBADWOARTbtbYGbAnRwnVilARC7xcxoirlIdgBwbZyKwyW2RmUvkP0seraB/OM8oBoM+K6hTxlZ3GkTNNVworev3GYItz1LIKKg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Dec 09, 2024 at 07:43:32PM +0530, Anshuman Khandual wrote: > On 12/9/24 18:06, kernel test robot wrote: > > kernel test robot noticed the following build warnings: > > > > [auto build test WARNING on akpm-mm/mm-everything] > > > > url: https://github.com/intel-lab-lkp/linux/commits/Anshuman-Khandual/mm-execmem-Make-ARCH_WANTS_EXECMEM_LATE-depend-on-EXECMEM/20241209-111533 > > base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything > > patch link: https://lore.kernel.org/r/20241209031251.515903-1-anshuman.khandual%40arm.com > > patch subject: [PATCH] mm/execmem: Make ARCH_WANTS_EXECMEM_LATE depend on EXECMEM > > config: arm64-kismet-CONFIG_ARCH_WANTS_EXECMEM_LATE-CONFIG_ARM64-0-0 (https://download.01.org/0day-ci/archive/20241209/202412092048.tTzJ5szH-lkp@intel.com/config) > > reproduce: (https://download.01.org/0day-ci/archive/20241209/202412092048.tTzJ5szH-lkp@intel.com/reproduce) > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > > the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot > > | Closes: https://lore.kernel.org/oe-kbuild-all/202412092048.tTzJ5szH-lkp@intel.com/ > > > > kismet warnings: (new ones prefixed by >>) > >>> kismet: WARNING: unmet direct dependencies detected for ARCH_WANTS_EXECMEM_LATE when selected by ARM64 > > WARNING: unmet direct dependencies detected for ARCH_WANTS_EXECMEM_LATE > > Depends on [n]: EXECMEM [=n] > > Selected by [y]: > > - ARM64 [=y] > > Although above mentioned config here has CONFIG_ARCH_WANTS_EXECMEM_LATE=y > and CONFIG_EXECMEM=n (actually absent), could that really happen though ? > > Tried making CONFIG_EXECMEM=n (rather deselecting) but that did now allow > setting CONFIG_EXECMEM=n, it always remained set. Reverting this patch i.e > the current behaviour is also the same (CONFIG_EXECMEM always remains set). > > select ARCH_WANTS_EXECMEM_LATE if EXECMEM > > Above statement seems to be selecting EXECMEM as well but the intent seems > to be a dependency check instead! OR arch selection for a config brings in > all its dependencies as well. > > If the selection is always, should this change be like the following ? > > config ARCH_WANTS_EXECMEM_LATE > bool > selects EXECMEM This is wrong. What ARCH_WANTS_EXECMEM_LATE means is that, _if_ EXECMEM is enabled, the arch code require its late initialisation. Currently for arm64 EXECMEM is selected by KPROBES, BPF_JIT and MODULES. So if you don't have any of these on, you don't need EXECMEM either, no point in selecting it above just because arm64 wants a specific behaviour (late initialisation) for EXECMEM. If you do want a patch for this, I think for arm64 we simply need to select ARCH_WANTS_EXECMEM_LATE unconditionally. Not much use in having any dependencies really, it just adds to the clutter. And don't change the core Kconfig either. -- Catalin