From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0713FE77180 for ; Mon, 9 Dec 2024 13:35:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8D1AD8D005A; Mon, 9 Dec 2024 08:35:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 881A78D0058; Mon, 9 Dec 2024 08:35:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 749938D005A; Mon, 9 Dec 2024 08:35:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5577C8D0058 for ; Mon, 9 Dec 2024 08:35:54 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 05A51C0590 for ; Mon, 9 Dec 2024 13:35:54 +0000 (UTC) X-FDA: 82875517998.22.1436F7F Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf20.hostedemail.com (Postfix) with ESMTP id 566841C0008 for ; Mon, 9 Dec 2024 13:35:30 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=cAcTwbTT; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733751343; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gBY5yvbKAw5suqcX3k3+O1C9fceFbg6i89ShHzn6yEo=; b=sAyq5y0ybQroTe1edXels3qCRhT3fggltS07NghRMdtbjAvKKPwXoygiL6eKf8inbtXaj+ KnaoltPrSA8DgGD5K44jBJ4SH72ITnn8/KUrbeCyI5jbS5TRomhVjTFWor9H7kn/HXtLHC Xp0Qtpnwp3TqSJEGKGTVzWhBSBmtQ/w= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=cAcTwbTT; spf=none (imf20.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733751343; a=rsa-sha256; cv=none; b=1GnHvKfHSUlPbj8IoCx3bOZQiuDte4Y6B11oFGSvSLM1093ohjxoXoETEyGXWqwZ8E0XOe ShhfsKa+re+CyolYS1FY8ytpgEHbaBYO8Efu1Q5InsS2dZBXZAejtBHQWzm8YodFpGdUpn UmRWd3hUqJndNPBL5pBGEa1n1gJ6H+o= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=gBY5yvbKAw5suqcX3k3+O1C9fceFbg6i89ShHzn6yEo=; b=cAcTwbTTHbdqR6+Nl5YVOyKSPp l//uvmEFdTrOrZM3T8nWMdnIEDXR01A7nM/LfyCBrr+2YeYROVthMYhZg7OX7eDRPjYNyZJcWWP16 ojpsJOtkCw6sWFtgmp+PWSUV0RNBfGB8pdaRtfbc6nzz4WDCeSqStG5qLY8/nFiD51H6w7xPeeP+8 hoN2oG53wQ+JuJUrjO0jhyAfpQA0uybHaDiNCTkfeC9BQD1bAk5To3fdwUYfA1xlLqL+3QvfMkCbQ 5Ba724hAK5XMCAgkerB9OMTG4SExHCpdGDdTwxvcbaitAQhtVhNLdWSzUu+4Cpokt5Z1jk2NF3RQE WVKJHrpg==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tKdvI-00000002L8G-0pO4; Mon, 09 Dec 2024 13:35:40 +0000 Date: Mon, 9 Dec 2024 13:35:39 +0000 From: Matthew Wilcox To: Jinjie Ruan Cc: viro@zeniv.linux.org.uk, brauner@kernel.org, jack@suse.cz, akpm@linux-foundation.org, Liam.Howlett@oracle.com, lokeshgidra@google.com, lorenzo.stoakes@oracle.com, rppt@kernel.org, aarcange@redhat.com, Jason@zx2c4.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 2/2] mm, rmap: handle anon_vma_fork() NULL check inline Message-ID: References: <20241209132549.2878604-1-ruanjinjie@huawei.com> <20241209132549.2878604-3-ruanjinjie@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241209132549.2878604-3-ruanjinjie@huawei.com> X-Rspamd-Queue-Id: 566841C0008 X-Stat-Signature: hbi64iqxb786jq48zkabttmxjswich6m X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1733751330-553805 X-HE-Meta: U2FsdGVkX1+zbnU7EuoMNL0kE8gxKvk9bFU+DpZaNCFefutRvHjpZI0EwRnT9QInJ91fqVnRGqHCT2hzRBd0OuERn8oZ8GhoJni0NZSCJmyDz/97uAnoPz//k5CtHxcyVhgc/Okby6s9aE83zpgv5tuOqoOS2tRc988aXKZ/E0Y93200mzEV7Pfhp9aV/N79o2R33gYoUB0yyCpHlp02wkGojZ6OlY2EPqQst9u+RQCzVo8VSUwskqOJxYEqVnnlxB/dTjPAyGNp1LK78u3XK0R62QqGP83MyewnrYTwJn5+s8O5q0H0XwOBFkfObvVjAz35PJbqgK9Z42AUXfJej5IUPsaYbIS2FYHCtdYrtkfVLvT6obPkFOHbQkQyyjAwxUx/QE+SuxGE0X8rJ7O3kgAI3I3Zkqab2/nt6Ofme3DqJIL1599kxDR/BHHhCaaSOLRGVT+1cEBpQ6yC73Oy7nW0o6H9om8MKb6XFenLFlb2MaDhgHLNExHSB3MMHKxKTF4MZlRwzWW+ytNfxrmRnyjac8f80wWRDeixnQcnKcMO0+MJRhOBjulUSt3sio8YdpmLHMfsNz9VCFNsz66MjJbCpFGxGQhLyajlks7L1W0+XmFUj/zmUMKazUPlEOeW2udQHr3+aWAVi3Kg29GfOI0G8QHQgIeeABAtuZEjO+jnibsd4lxSGvNKYqzM3BbdnuksJyCop7tHb1jwijGeXqU+POiVTcN6kyfNwgTOcJOe8pGAsByXuYuf1stExOUhTCZ1SJSdPDjqXrvcofzBU470fv6hCnpTq4K+gzA8vZUE2FAANA7T1ZfoBKxJr71XCKWuAZlf4g4k9SOU+JjDt53iGn5Lnd6ecyY+UChuzTBPdkXbCpvYmc8aL++oJ+WPu+kzylyFwL76qL4YL5vqkYgWyEOh3Oxa0jdCH8tEY4/kN41pMycuezTT0xxaOVh46WCQPgguK+akcRzmPO8 yckYrSBO 2gsJ0ba8BFPz/H6ZGJxCdfuqARJJXExrWVjkee7fRkIQoZHampwolFetggzvWQhHPhliP5EjgsB2QefoXCxGIxBqRQlanA3ciFLBzC9cFzpSqT2j3SbMM4OZv2tzLHYAAtYW0DlKcjUsZxdUpToj10bUgEKbz7zIDbMfcb7Hp+ith35AyHzT4U/Sh+8A6dHU+42Hc6NgfzlrC92YqvSv7041fN1FrCCaO0rMC/ic3vLPQJSLdNG9fQ49zWtEW4WhVvZ0aKV9YqmBNeTFHq2pXZ0KLO9sGzPETKS1FL5LgYhJJVgM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Dec 09, 2024 at 09:25:49PM +0800, Jinjie Ruan wrote: > Check the anon_vma of pvma inline so we can avoid the function call > overhead if the anon_vma is NULL. This really gets you 1% perf improvement? On what hardware?