From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E93F0E77180 for ; Mon, 9 Dec 2024 13:33:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6D3D58D0059; Mon, 9 Dec 2024 08:33:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 65D008D0058; Mon, 9 Dec 2024 08:33:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4FE5E8D0059; Mon, 9 Dec 2024 08:33:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2C5908D0058 for ; Mon, 9 Dec 2024 08:33:38 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B136A803E2 for ; Mon, 9 Dec 2024 13:33:37 +0000 (UTC) X-FDA: 82875512706.14.470A281 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf01.hostedemail.com (Postfix) with ESMTP id BCE5D4000F for ; Mon, 9 Dec 2024 13:33:19 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=KAFLDDT4; spf=none (imf01.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733751196; a=rsa-sha256; cv=none; b=yspSmF29XLYpwgc4kxMd9OAv7sXFNrrbRgbWYr7nNYkv6EwdqOAFARszwzRMPKRGNk1r4r TidimIHQWMk3WPFUd7Qtk6mYwNao+79oYdq/kWIDBsk9ScO0+pZNIkmcuBIxhYNrR5zhZD FQT+qOY0yIGvrRmCJ7mMIt7SquC2Vv8= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=KAFLDDT4; spf=none (imf01.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733751196; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JwRD+IiIqDzvQkDCWIfHd6pynPfXRcD4dvO863qu9CY=; b=dGiQItdIgf9sHxwYOPkZxqs3w6FasWcFTmwYyTlT0uaNXGDuZPPphTFyQLlcsvZwO/UsJN yzOKzEO4JYjTJ0Ro7QVqyUJSssJGWMzbCVi9IF9RfSiZrpby7UtdmDBN3v35iTZ6kV+DxF kB/ZxRHeEvkVDt0GK8RO6946pauIVB0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=JwRD+IiIqDzvQkDCWIfHd6pynPfXRcD4dvO863qu9CY=; b=KAFLDDT41w9/otyh71Nr3wkbBV 1ZyJZr+l/NJ6ETcFfZDBXJbB0hAEjqbpp+jK6WS9Gr+pIS1/Bcv4ko6LkoDH1/gYceN/v5EMd217/ bKA9jlyPycTtsauD3XDVRsJMQnZuDo5Snf6kw9sou0ApJpJn6wiW0hMZVxu0aIXexQCpQJi9xzWYn aGWWc20JjMvCocdSGgMS82ksXijmw6Zd5yAp48BDLGvB8z2yEuAu3kpxHBQ2WbYEx/7nwDNwqf8uh aK3inaF9agQgXbk8oEGSJo3SMSCqSetPpd4r9+ChzTyjGPvAKuLUxyEAdvQuJ3GH6IYJljsFzC6x0 H0xoTtWQ==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tKdtA-00000002KHw-2mym; Mon, 09 Dec 2024 13:33:28 +0000 Date: Mon, 9 Dec 2024 13:33:28 +0000 From: Matthew Wilcox To: Jinjiang Tu Cc: miklos@szeredi.hu, amir73il@gmail.com, akpm@linux-foundation.org, lorenzo.stoakes@oracle.com, vbabka@suse.cz, jannh@google.com, linux-mm@kvack.org, linux-unionfs@vger.kernel.org, wangkefeng.wang@huawei.com, sunnanyong@huawei.com, yi.zhang@huawei.com Subject: Re: [PATCH -next] ovl: respect underlying filesystem's get_unmapped_area() Message-ID: References: <20241205143038.3260233-1-tujinjiang@huawei.com> <4a8e2901-12b3-b700-383c-3193adc0ed60@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4a8e2901-12b3-b700-383c-3193adc0ed60@huawei.com> X-Rspamd-Queue-Id: BCE5D4000F X-Stat-Signature: iie6msm1i3p1frtei4f9yugz3jbxikk8 X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1733751199-65881 X-HE-Meta: U2FsdGVkX18MVLITgtdRIwck5P7L2y+DCkOi77BfJbX29XeYjM9cIZYvzP7VxZuw6HiLtTVQVORdKrMEC/8Wi+wom5zZhe6m6Mj0FJNtCLkhqUCzilGr+Iht4S7v9QbR7ULv+bi9Aak12lwjATriy9DkajuXzhKAjFCseQObVriqyA3pVg4gKMTD1955V9ZemdUJg3aqFU3oXKoi18+ET+WhRqPBizJRb2ygOSIoNFPhTA5fZTKMAl+x1Gxr3M1quHtB9HQHT4Ue35ekuxMhTIgLgyCGWav5Lg+UF+bhKd2Yh3J5Jp8vnKQ/Q5vv+ZxUrzHsQeoIS36As716F1z8E5x/H/TXGU2LHgjmd2UDTtdLgigzPK5L2bDrVji4vrpaqKCi9Cxx+XdniThUUu1QbXZwApfC9repIPSYAg0ENqL45395OxWTNmut35pfsmpP/1L+J0gzENFfm/ssCqwOML/Tlil74JMKYMOpouBiUA7nhdinQhQxm2qED4GrqQ5swG9+wccIcygYes2gYb1WgJb7QxwSQBmZ3JzD9VHY6fmc26y3XOzURAFxTqnhO00xfKdNUHAVOQKry7+lqFtyFooB734O0nUhELblBnFKmVwEZpeU+HGO3LenMmMwc59sdBfNSLyp+3I85jVjP0jOb1OahBopQqfcdlKcfd3BBAq/y7gnuVpT7BvKRwl+6LKIEEhD6If0jiwsSyVk5YGZLpD/mA3yw5SthuYNwmlEkhf6LZMnWMODxGTYytbQX17A3hyxBLiFbqn3aTkqAKLfH1BLc0mBTyes7QLkldN2BDnpMDmDdng7AxrWFuLTzOAW272EuicEvAy50PmYd0eTeOShJCwMC+l1Wb2wjQ+2SQeEPPcwSl1g55plkbOInXKGjs3ACTpFG0eLnZZwf6dI/o35hiitmC+DAk9vdK8U9OqH86eU5yUftOa5xGn9P+mVpnaYHl5SLeksjC7pALe dbUBQcEJ aY1llJ2rsrVqHOBCqr6XX0e7ICFm0/8LIGKC2YuXU0sL1wQ5+RXyIB3s089TKGvIt4qOQJFuD/Ly9FYy2ZJBehpKeiCL0ESb/EMs+c1jJQ3vd76K/c3d/wu5vGVVI1BYDZNGNR0azCtEcB4dTvi7hSdxSflbNhy0FjN95rvioXALfFsXSr8Q6lFb3nKr5/9vxMt/WP/olQ+YyE+3/n+eSLePeI3cEIZ8isdZodKcakvU8NKLcpLyKbeuaX7YhecTIAnReDO9rcnkcdW3qkVD+mYPVYtZqPtN6jHCoI8kjbXa/w5c= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Dec 09, 2024 at 02:43:08PM +0800, Jinjiang Tu wrote: > > 在 2024/12/6 21:58, Matthew Wilcox 写道: > > On Thu, Dec 05, 2024 at 10:30:38PM +0800, Jinjiang Tu wrote: > > > During our tests in containers, there is a read-only file (i.e., shared > > Show your test. > > I mmap an overlayfs file with PROT_READ, and call madvise(MADV_COLLAPSE), the code > is as follows: > > fd = open(path, O_RDONLY); > addr = mmap(NULL, size, PROT_READ, MAP_PRIVATE, fd, 0); > ret = madvise(addr, size, MADV_COLLAPSE); > > The addr isn't THP-aligned and ret is -1, errno is EINVAL. Then your test is buggy. * Check alignment for file vma and size for both file and anon vma by * filtering out the unsuitable orders. You didn't align your mmap, so it's expected to fail.