From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAC61E7717B for ; Sat, 7 Dec 2024 17:14:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 65D9E6B0341; Sat, 7 Dec 2024 12:14:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 60C106B0343; Sat, 7 Dec 2024 12:14:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4FB1A6B0344; Sat, 7 Dec 2024 12:14:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 2ED776B0341 for ; Sat, 7 Dec 2024 12:14:26 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 8E2C3A016F for ; Sat, 7 Dec 2024 17:14:25 +0000 (UTC) X-FDA: 82868811186.12.35713A8 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf18.hostedemail.com (Postfix) with ESMTP id 3E7661C001A for ; Sat, 7 Dec 2024 17:14:14 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="vx/sykzz"; spf=none (imf18.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733591655; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+m8LqA+l0VP1e4fQDn1Gn3p69MDF3GIuUMy0vbg9kcg=; b=gL/WZjNanqZOcQGROu/ISWXzyBIq+fzQ8aeZnTrGWg47wS48d1ltOVx55L88XR5Q8ns2iA +8D8QXDmq3WaYR8UfktXZsC3lWPiQKsYwMJ2gzPFngG/lyN4MqiFGWU6OFbHXSvS6Ie6vi BxAqDEzlCl+rf3wSkiB9YWXUAtMRMow= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="vx/sykzz"; spf=none (imf18.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733591655; a=rsa-sha256; cv=none; b=1uJEI2fC8rlT29MM1c+uJBPC7aqLkK8vFQNd7fpkidt5DebjWXD9cqA8KkGEPCEarWWdBw iReaZowBZMbGUTNduuhls2mC07VVvnv9peNkPxQq4ciegBJC6U/nBIGCuY9vfVRx5mBauc k6OFGsWBCcTm/8rhY7BZWDwK70Ez2iA= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=+m8LqA+l0VP1e4fQDn1Gn3p69MDF3GIuUMy0vbg9kcg=; b=vx/sykzzxk4L7k9Kk8E4O3I1xK bXUlbhB/mVrdDuCMgXaYxCplWZWLPbpnvhYpQLOXshJzJb2DWjwdUn/OF5nxIMBVvR/P7+vf9roRF k6ZpuQsFb7xw3hC1xOsn2DY+4g7u24SU2Y/NUdj/MyFxNpvLhMDgzCRhza6jmEp9F5E1Djv/qE5IL U89GMDdlS0SGe3ELeFiSeR01Iy8Tn5sm/e2rxGrU9zQ2D1b5ZnrheMsEy9CLzWun6JIlWv4ShVq4r bSuhw7+RbNwchu7PqXsALkPlFVkxwwoLbpem/hSrgc+3HiZmVWbP7lqu3LUVs99BJ0CThSRZhf/vl zb3js1NA==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tJyNi-0000000GIgZ-3RBZ; Sat, 07 Dec 2024 17:14:14 +0000 Date: Sat, 7 Dec 2024 17:14:14 +0000 From: Matthew Wilcox To: Junjie Fu Cc: akpm@linux-foundation.org, gourry@gourry.net, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@suse.com Subject: Re: [PATCH] mm/mempolicy.c: include pagemap.h directly Message-ID: References: <20241206220037.5c0cd212d3269dd8a6f36e4d@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 3E7661C001A X-Stat-Signature: g6j13f4mnxjxdmi6w5uxzubb5h7d8pnd X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1733591653-396705 X-HE-Meta: U2FsdGVkX1/6mxnBJmNWpuOAp//Wq5yrPiA5Q05z/h6P96tca8CTzvZXZDxJBvMe0RjmYkn2z1gwCo4fZHDocKycjpvK/u0CAlksbRD0qCn9V8K8PrQqldzT06QBDScfuvuYMSXfnI1hC4PN6KgZFfMfWXXyxsaV8at5AvH4PKI7mJVZShSvFCiTGbxzbF0Sk5uA0lqfBway4diFaZCjZaPHReTV74NJCEN4+Hjg9YgCMdOGdhjUKz7hEhGYSUfM6CcgaA1RPQp7SHOjHvjODsiyisysrfC1/u1wtA9y6+ZI0Y6p7WG7WP/2knkcNPS7C/0sAfURfe32yUMQapI2YtWXrKdv7PrjgYM1HZ3mDy8nHOQtW72UYKiaSo1wB1CMScZVRWy7SHAix7cAWIdRL/9+2xouqk5V68m0X0q/+38SVVETSM2P5YAOSVqSXraUhaJ1RIdzZdN8zlCGLNfSO5dv6wrjZIM6JYIFanh5R3AXBix1Siohb97W6PG5ScaJlHF1U+x2S2xaJJw6Iep2BEKT/7M0Cr6YV0zxW4/viJUVwhgFbqltaRYO4ZLQ4icE4SX+ddkWJL26ln6qzcKCn+U5vpqQfLm3YWD8bIQnD8h9A4ovmZrxouSknx6XhftqwKw/mFJ0KQpFpMqmsnAIBFySd2PCgnxnerHT6VIZDdvOeCYwbAf/eHAh69mebaUDVRv5AXwYUr1dSRH0uOY/3JlrtvEcdirA+TgpN8yErPTb/L+PVqOsDjyckeef7SMeGxwvm9utxgXDJ70mc7d9hnpfsYXPGBinsJYYECbR+tdXx5h3uwRnQX2NjrPROFonDL+TVhKkhx1QoDvI4Q2H/4L56uvB9OG3F8KmjqPletBd05n+qWUN1D5bgX6EzWRmOqUtw/ZEbVWBDfMHAOnBQEF6sMhMVfzPUHGnYsRVoHKWnXzaHDy2qE2EGVVpWczogpWEn3gzWmrttd2GTlO lJZO5lJB fnggA2VgvP4b4Xp40/aLjLVYPKlcDT71pllAa6pxNmOEMCiibr9Vxl1fbsY3H8DA9TW3gDngxfa4s3+wiROSJ3mwtj9XGNAz1LcRSLJ0PgUctwSX7vdVw661hIzb3bIhZ+477Jc5SkMEd5ThnPqQDUg+ZaiTHv4dVMkE7wJg8TBD9tOSjLHPwzJXoPVTLcR6YT6g8RdoYICFmu2wfnYGqoPui5NF5+9qSip8j X-Bogosity: Ham, tests=bogofilter, spamicity=0.000086, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Dec 07, 2024 at 04:14:30PM +0800, Junjie Fu wrote: > @@ -113,7 +113,7 @@ > #include > #include > #include > - > +#include > #include "internal.h" This is in the wrong place. The linux/ includes go before the asm/ includes. I like to stick to alphabetical order within that divide, but other people have other preferences.