From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22374E77179 for ; Fri, 6 Dec 2024 16:42:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 85F406B02A4; Fri, 6 Dec 2024 11:42:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 80F256B02A5; Fri, 6 Dec 2024 11:42:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6D6556B02A6; Fri, 6 Dec 2024 11:42:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4E3046B02A4 for ; Fri, 6 Dec 2024 11:42:49 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C6109B0427 for ; Fri, 6 Dec 2024 16:42:48 +0000 (UTC) X-FDA: 82865102880.04.D59D7E7 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf17.hostedemail.com (Postfix) with ESMTP id F2E2140009 for ; Fri, 6 Dec 2024 16:42:33 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Yg+zQBad; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733503349; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xI6iU9R30iJ3Jjx4/OlpWrJL9ovNCAtVHCgXvuY6Wf4=; b=qiiDi+6l7tOD56bgDE+IgLKeeDUis+442ZFXDwiF6IPmLpp2+P32ehGM0w2UX56czvejQ/ 0l9zo4tasgXb0aZo2UxZv1ctySyS7j+ZZywerQGY/Dl3psa7hfJyEPfyHuJPcaD8NoklHR jZCnnhWR0rUq5zxZu6W9ojRRNDtAx5w= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733503349; a=rsa-sha256; cv=none; b=bpomx9TdW9tofnaoSuH+2oB6/M1WSDNPMRBfFd1o77vfcWpvCfeauVdP/5TiTm7JAr1JX4 Ik0rAYLKh+F7U9OIeSjW051mXgtRJx7OdMtzo6/XRLaGjh7UB01DFhWc6rT0k+6/ikqNi2 HllV1yMet+4iJS15a4rjVxQ1ljYFn8E= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=Yg+zQBad; spf=none (imf17.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=xI6iU9R30iJ3Jjx4/OlpWrJL9ovNCAtVHCgXvuY6Wf4=; b=Yg+zQBadL2RReMzhNt9YfusmTS pONti2Y8NgqgQs/58L9fm3q+W60yR63GKCa55ONvHzTyVHse7xRa5GMi9xmraY96rzKeATKJkSANc eixg15ipj3gMiXVtC/NeV0vX07FQW7jaI0dKByOr9JfTZ5y2zbygk4jV98fObPBDeFoYvWlfXs4LI D0dJyRCJn/97mRDIt/iah2lzkHveVYs9+MLQ8Ts0cfT1MRUofD2eNEBzsLpRS5fRqORUZrFbpNPmF W9MOJg5URCI0WESl8DhDPTMf2IfosD4/VR2MszUUwTBXW7F13LGyEvj0H96NIcUsvLr6MfgAr7UXk 8X47g7fA==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tJbPb-0000000Ek11-0LRo; Fri, 06 Dec 2024 16:42:39 +0000 Date: Fri, 6 Dec 2024 16:42:38 +0000 From: Matthew Wilcox To: Zi Yan Cc: linux-mm@kvack.org, Andrew Morton , Geert Uytterhoeven , Vlastimil Babka , David Hildenbrand , Miaohe Lin , Kefeng Wang , John Hubbard , "Huang, Ying" , Ryan Roberts , Alexander Potapenko , Kees Cook , linux-kernel@vger.kernel.org, Geert Uytterhoeven , Vineet Gupta , Mathieu Desnoyers Subject: Re: [PATCH] mm: use clear_user_(high)page() for arch with special user folio handling Message-ID: References: <20241206141938.2750393-1-ziy@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241206141938.2750393-1-ziy@nvidia.com> X-Rspamd-Queue-Id: F2E2140009 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: rqrzmpj8tzbnw7887u1p87pmqz1mp6pq X-HE-Tag: 1733503353-496246 X-HE-Meta: U2FsdGVkX18oaXRlg9bvUNq/ECdK/UWomMt6z0V84WC48/riHn1ht07T1XQe6V0Pq+vBmueQMBmNxWLNKOXuk2y98vbouoZuWJ4bp1qFKLQadCVz5XMl3kkUEMST2Cfn6A0xmaPsP5HEdEWkYU/870h3cPKXc+yqentlWP+B3N7eixSfQL96auaM0Ef/2ugnhF9zGGT8Utv5SVt28q/IktKdVHMLSykStQyRgGTcw//iuLTu/KsV8mDbDZmMKWYJm0YFJ4SwHEpZEHLSQlHh21j5ruLSeWIsDFjMCTAlEONPEJ8T+JRI0SLbqHU+j+vr0vgmauUMrVKNMjMNXKyNXxLzO7bGKyeIYzEpTnwqsU90mgXxZsxBBIEfG6zyXKqSDqxoWdA+Q7RnK0Q4oBlKBT6o3Dy07U3lR4d+1YX/vFm7B/8tAedoU3bzvXPcFlD2EH3mUhLrcn23m+ePvbuySarzVTyi7dPBEdZvFbplxVtuO7nvdOs5E23L2+vUU3QC73SEddr6vcYm9wvTsk1V0j6cwj4b12yyq6Dc3BLX3TwH1TmfDANc5GVWBwfhQPQnTsw0qrsJo7GgN2oe3yRb8G9a2eS67filA9+BR1fMY9MptmFuwA0mKNkTCUr01ksUbkUJcd5CgVRJzrifCyzJf9RMeBbcs7v8Hs6kxyYyyrtbqtTTa8AWgYqZEFWV8WOWtOWoGndXjis4HRtm9YYqhZq7JNbWm3jA0ItaPVH/AJJ/zSl4csxqmR5VeFOD0+hlNKLxM/2jwBMulU7R/NVsDZPCLViPp0ryBYWxHzUTH0GnsiMCdPrAk4FrWU5bYeag8K0YEmZAxg8mWzVv/cAXc+7UpteEn9dKTmGhOAVhjcvri4etB6Vm45uMpniwf08jO2AgapWFrNBKKpuahp4DRDfzq8MfdLMGPKT4wkiTo6yWG8mngQFrsUKuJoDnxjrI0b9Zc9per36IvlyZJvb lcq/H9U2 UzLtmPuPPDK4+qV8tGO/B8J6ZmwDgHr9USsXzlxa1ZvB7+zqI3Z/w8GfnnRnTAE8KPySlNT4ximYC1zvFuGRGOZaPFLz6otsUWbtfk9tazl8KZm6JzfLfAl7He04FBsOqKUZ9QYGLwmQftog57fYcANzRqy4YSTZcvqcLuI4jOQI+eXsTNXMnlZRy83V7ZUadVdk80CJLIlO2sO9zE4dm02SUHdJJ1sBehu70DNLS890q00aCJUp+LTDFeu17wUPOXRqYgkBcnw1QM6QvZOA4xP9QjzeNm6M4PLhetS8E5M6dIlrBFrq4piuJBZ0dUBcaWoqY4E5AF6O9+hggNlGMc3Rd/y58aE1oZshwv6fLalV99Xk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 06, 2024 at 09:19:38AM -0500, Zi Yan wrote: > For architectures setting ARCH_HAS_CPU_CACHE_ALIASING, which requires > flushing cache and arc, which sets folio->flags after clearing a user > folio I think arc just has some legacy code left that needs to be ripped out. See commit d5272aaa8257 which took away ARCH_HAS_CPU_CACHE_ALIASING from arc. Looking at 8690bbcf3b70, I wonder if you want to use cpu_dcache_is_aliasing() here?