From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8684AE77179 for ; Fri, 6 Dec 2024 07:36:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A07086B01A3; Fri, 6 Dec 2024 02:36:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B67D6B01A4; Fri, 6 Dec 2024 02:36:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 857AB6B01A5; Fri, 6 Dec 2024 02:36:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 619366B01A3 for ; Fri, 6 Dec 2024 02:36:00 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C0DA0A18FE for ; Fri, 6 Dec 2024 07:35:59 +0000 (UTC) X-FDA: 82863724734.10.15C0178 Received: from mail-oa1-f46.google.com (mail-oa1-f46.google.com [209.85.160.46]) by imf02.hostedemail.com (Postfix) with ESMTP id 3F62E80002 for ; Fri, 6 Dec 2024 07:35:26 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=quarantine); spf=pass (imf02.hostedemail.com: domain of dennisszhou@gmail.com designates 209.85.160.46 as permitted sender) smtp.mailfrom=dennisszhou@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733470545; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=e04UQN4Bgq81Dxa3sAw+VWMHnoxLZmrzryZOBk+bxd8=; b=1ctwxseAdL/aSuAkCcEQYk6Vt9/p1YVk/8l2Ev1wOJLA/DNRrJoAAkVQejqF5PE4NJY9Y3 03NwuSgMjHnGY4qezr3ypEFlab0A26pZkikJN4wKrT4KnPUry8qfIE6my55n0LwGlkCrqK b9SQNm7hCjra5whl0IvNxnXgjHVtXto= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=kernel.org (policy=quarantine); spf=pass (imf02.hostedemail.com: domain of dennisszhou@gmail.com designates 209.85.160.46 as permitted sender) smtp.mailfrom=dennisszhou@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733470545; a=rsa-sha256; cv=none; b=5ljmVaSmUtzo2GpVFAQuL8JF42GqMOtL0A4R0tLW7/VVHpwh3DIURLph+LUi49hTbTolp5 9wMBbR2KhJRNGhrr0B0K9gIOM4S7sl9/OpMdZQe1NX/T0bTqXolWZ+lxHcIs4z2m4yeZQD YnB5vt5cz5i1RKQQY9tB74BNLrjBlbk= Received: by mail-oa1-f46.google.com with SMTP id 586e51a60fabf-29e998c70f9so1211818fac.2 for ; Thu, 05 Dec 2024 23:35:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733470557; x=1734075357; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=e04UQN4Bgq81Dxa3sAw+VWMHnoxLZmrzryZOBk+bxd8=; b=Lu0Ahf1lom2KkvfdUXovsuH46Hbqv0oePsnK7v79BSkj0FLdAvPDCvTO4HPSX2kCiI gZhjcU0E5AwmWTiIJsY94RmFK+UJLQslXz9s8TjgXKD6TC7Qxh+l1LFLDJHgKgnYWRzO e9WvSztvwyoEF9sQlEwJ2SsdPIiS35+zYS068wrzV0esz90Yg66/e9dM016kcqBIYEVY EQ3++UeGXKIlE3977oz//uRT3Q29lgPjjVtjnAuxWY/Jffn3Q6V1SCahwMq77nhg+VmW /Xcmvs0t3Q2edAEE9IfIKb0NW5Tb4hGcb449rHImp6TlZ0zcOhsAo7pOoRJ6xeZdqfyA MPLw== X-Forwarded-Encrypted: i=1; AJvYcCWu+g4tSW/6fOUQnTl6Tb4vbln9Djn8niQ5VsgEKyOZ1mmxp+u/if9QGeRZpS9VoL98xx5hObcz5A==@kvack.org X-Gm-Message-State: AOJu0Yw1LeO/WfOmohmB11zqGl7a0RPPtqj6xUaCoJoAbURy/V7kNe3O +Bsyh61QABhdhWTJjZejZ9P9iS2I9jzJV+zUUZuIoxKgu1nU+cL2 X-Gm-Gg: ASbGncungdg2DCBipznPHzfqimRSzpuUfzueXHGG8sltTKeBohiGDScFI79lGrKapth m/geiuZpZg5aTircJC+KL5D2FqvJXJsl/rzsgh06PMfCTRRLjh2qGDP2+olSKIyM5hc/2EByKoy TBk88rcLOq9jM6QWk/TuGEeW+vZEYLEXNE0FSQL/WCMMbrZB2gmfSRSidnXMdt/YsS6SJwrIZqs 0Bq1Pcqbtacrl0RBfrpC3XpdhPNlDMrp8JWK1jfxV7CinU3qdVFwSfP87dU X-Google-Smtp-Source: AGHT+IEuZaAtLFt7J5lrqNm1axRoJWe4AUHjojGK9/xI3HOEczyiq8ngMxRqB/ki0aT6JOUV5jSY9A== X-Received: by 2002:a05:6870:3b8e:b0:29e:247b:4f77 with SMTP id 586e51a60fabf-29f733405d8mr2472478fac.20.1733470556826; Thu, 05 Dec 2024 23:35:56 -0800 (PST) Received: from V92F7Y9K0C.lan ([136.25.84.117]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7fd156e1e20sm2442332a12.32.2024.12.05.23.35.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Dec 2024 23:35:56 -0800 (PST) Date: Thu, 5 Dec 2024 23:35:53 -0800 From: Dennis Zhou To: Uros Bizjak Cc: x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-bcachefs@vger.kernel.org, linux-arch@vger.kernel.org, netdev@vger.kernel.org, Nadav Amit , Arnd Bergmann , Thomas Gleixner , Dennis Zhou , Tejun Heo , Christoph Lameter , Linus Torvalds , Andy Lutomirski , Ingo Molnar , Brian Gerst , "H. Peter Anvin" , Peter Zijlstra Subject: Re: [PATCH v2 5/6] percpu: Repurpose __percpu tag as a named address space qualifier Message-ID: References: <20241205154247.43444-1-ubizjak@gmail.com> <20241205154247.43444-6-ubizjak@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241205154247.43444-6-ubizjak@gmail.com> X-Rspam-User: X-Rspamd-Queue-Id: 3F62E80002 X-Rspamd-Server: rspam12 X-Stat-Signature: 6rrtahxbj6qu58i4jaz6z77tet1hs1mz X-Rspamd-Pre-Result: action=add header; module=dmarc; Action set by DMARC X-Rspam: Yes X-HE-Tag: 1733470526-283396 X-HE-Meta: U2FsdGVkX1/tK0/QCTzu3qyWIp23gq7kRpe7OsKUFKz27tmjAZokBuCHmS0NvUfxOwAAR+vvKvvk5YPl/eXpNI8OB7Fv1Jb4woU55Pmroi34qQVQs3MpAn1BggxIBlaLL1Gw4DobLh3FvxVyv6JPdA9h+UV+bQpo/BFbN+UoqQHzwo9Z2fBFR4ZLODyURSJXCLuX26EsH5sHrvZjFD4ymJ5uNLXrD1PtgIPXlwidDlkp0FiFHJ8NBA1VwZYeG/53T8iCR7Gj75oeUBBLIZ08q+NPTKXIfk3VNrHcg4CcrcBwpDVisPrLxwcFvKAKcDYiodhEEmgor/K0DZi8w9INKEGi5wuT4XkAEJOCMxbm9AodR1sTI4Rgok2Y6bAf81e44WXOuhZm+wYj+WAn0qaHVskQFV/3GXCBaR+zGy9FWbZdo4OBFvNTTyDG9l77J6O6a69BFVgaM2j5hHW/KFgf5yjxpTyvqLcYKWlCylNi9jNrsJVmEgj2+oy2otDIantWzK2lIDvve/c3SGYmuuZVRedf/yilj7UszZCOabZvPffItmnsTQoolfJaw3R46+PD23L3RQdbh+9adUQgfycMxSLNr0XIQPM2AEIDYL9lVZ0C3mXUTjpn5CIhGLyoHn60/Q9i6qXI6bZnFmUyJWJRz4ZUPVpnhZ4uwCSNMgyaVVdCEp0ANEfLcZAmiPlISLyX+nou19rRcmT7sobKaQdfxAU0QDCNhB0CDFDbQA6KDgr7UASacN44iMWvxNNs9ahcMOTQNAQwuJkCSY0+M72p6JXMMP8n8M9dDwwd/sv3+MYwjk54/vNcWKSSM7ScsuzMsiHtCvQzZlo5VpDFQw3vXTAHH9RnkCuzy4ZF97d7I6qRj5fSRbQeTOEkLN6gjnebqE6BXvRdGp+QeZ7rMlm8DSHgCrllVvUGLr17ZFRkwAZ3+oCwOE9ESXNXweIORduImDuo60g3cWBge+GNPQc 3FwXy516 xqIBnvXPzB+Jg1sKjpx2lTAU2OthuFL9f9eNhZwWA8qdUYQyNXCQRLz7Iqo3GymAcRO2yTIF2S7eB2cE/x9wYdrwbaODzjZMePMPsgG0HqXusZ2jjUfGdssD4YJxykI5JE9GlCBbkg7BI517tmWSKGX/81zw5eSfiYO2nw6GwYVGPgQ/mqk7cCBP0lXpzA6HdlIx1x+0dBexsVtVqbQJcR8x4bzTnNOZyoRkjL0cxbp1jmIsglLxS/vYWSA2Kbtqm9KpCaIb9zmcMIghw7wnPf5YpwkQjUWu99x3VpRDEyGSg1S2qsjDcHjAJg0P9JwP3bZX50C5u0hQW8+CYubI2QlljbPo8i6hUfRqRUxBJiNqbTMBSgQStp8KcFb3dmeLX56w9WVbuWIrh1yZPDv3BdTRIrv6PD6p9ISl+sSiPYTfy1/d2kDALvP5kwcakzmDsPoPjXwslJ9iwiZkS8Phlb0xfqZafgGF9OIWECDQiKTtdLggfhJRtPUzJz++UNZJvP8JP2M1YLAQCmeFC6+pY7syDt8JWDiwEDZJAYT5JIIdSbwjbOEycJmUZ8jebG0tu0yxJXQSvazbBE6K6a5ne1WW23jxReOWn8G+6zoj1dC8Ni6m/SzfKi1TkYnXrch0nDipPz5n/DQgjLqdrBFlPVZz9yKzUc4MtnC5BRfuRYKv936HsDm8dz11gM6udo5lMZL+oI0sVZPDch85xIgkArpONOVE24sF80dxK+uQ1K7qcceZZWNmgFKjlgSfIXfHmYHvOwd++nXZuDGx1lDjAsMhDyyRvSWaBfmtwc56YQP/eiHjvO34GvBZ76zzRKFGJJkj0yKnaFyTTJLqUsQTByMAkeAnMnwwhJZuoBLmqRWRqjP4m/wH1Jt8e7Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Uros, On Thu, Dec 05, 2024 at 04:40:55PM +0100, Uros Bizjak wrote: > The patch introduces per_cpu_qual define and repurposes __percpu > tag as a named address space qualifier using the new define. > > Arches can now conditionally define __per_cpu_qual as their > named address space qualifier for percpu variables. > > Signed-off-by: Uros Bizjak > Acked-by: Nadav Amit > Cc: Arnd Bergmann > Cc: Thomas Gleixner > Cc: Dennis Zhou > Cc: Tejun Heo > Cc: Christoph Lameter > Cc: Linus Torvalds > Cc: Andy Lutomirski > Cc: Ingo Molnar > Cc: Brian Gerst > Cc: "H. Peter Anvin" > Cc: Peter Zijlstra > --- > include/asm-generic/percpu.h | 15 +++++++++++++++ > include/linux/compiler_types.h | 2 +- > 2 files changed, 16 insertions(+), 1 deletion(-) > > diff --git a/include/asm-generic/percpu.h b/include/asm-generic/percpu.h > index 50597b975a49..3b93b168faa1 100644 > --- a/include/asm-generic/percpu.h > +++ b/include/asm-generic/percpu.h > @@ -6,6 +6,21 @@ > #include > #include > > +/* > + * per_cpu_qual is the qualifier for the percpu named address space. > + * > + * Most arches use generic named address space for percpu variables but > + * some arches define percpu variables in different named address space > + * (on the x86 arch, percpu variable may be declared as being relative > + * to the %fs or %gs segments using __seg_fs or __seg_gs named address > + * space qualifier). > + */ > +#ifdef __per_cpu_qual I read through the series and I think my only nit would be here. Can we name this __percpu_qual? My thoughts are that it keeps it consistent with the old address space identifier and largely most of the core percpu stuff is defined with percpu as the naming scheme. > +# define per_cpu_qual __per_cpu_qual > +#else > +# define per_cpu_qual > +#endif > + > #ifdef CONFIG_SMP > > /* > diff --git a/include/linux/compiler_types.h b/include/linux/compiler_types.h > index 981cc3d7e3aa..877fe0c43c5d 100644 > --- a/include/linux/compiler_types.h > +++ b/include/linux/compiler_types.h > @@ -57,7 +57,7 @@ static inline void __chk_io_ptr(const volatile void __iomem *ptr) { } > # define __user BTF_TYPE_TAG(user) > # endif > # define __iomem > -# define __percpu BTF_TYPE_TAG(percpu) > +# define __percpu per_cpu_qual BTF_TYPE_TAG(percpu) > # define __rcu BTF_TYPE_TAG(rcu) > > # define __chk_user_ptr(x) (void)0 > -- > 2.42.0 > Thanks, Dennis