From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D3EAE7716C for ; Thu, 5 Dec 2024 09:16:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C81B16B0083; Thu, 5 Dec 2024 04:16:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C315F6B0085; Thu, 5 Dec 2024 04:16:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF8E66B0088; Thu, 5 Dec 2024 04:16:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8D4BB6B0083 for ; Thu, 5 Dec 2024 04:16:54 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 13C65A1488 for ; Thu, 5 Dec 2024 09:16:54 +0000 (UTC) X-FDA: 82860349614.20.AFE6E1C Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf14.hostedemail.com (Postfix) with ESMTP id D81D010000B for ; Thu, 5 Dec 2024 09:16:34 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=MIT9aWdY; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=DPf1E07q; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=MIT9aWdY; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=DPf1E07q; spf=pass (imf14.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733390197; a=rsa-sha256; cv=none; b=8e4l6tA7GC04DiA6DUjaSPNUhUKGdrFW17t/CVdQx1iVjcJGpy4lGYxxe17SoWCkAh804H 1GBETh+bsbSHQqfsEKX4htE4nAkcqToULfe6xBV86T4D1C02dczlc1Ci8NtFk9G2m9Deds JjMabWrwUy4j5p8UTTVcf2BBaJUwo2c= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=MIT9aWdY; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=DPf1E07q; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=MIT9aWdY; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=DPf1E07q; spf=pass (imf14.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733390197; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Exos+Q3ir5xTGxhDlEiLEF409xFDOMwB2dsvHmrGW3E=; b=6wo3cyYzWAV6O7MU3uqCOig9Zw5Lwdv9LRT5H4v0XyC+HfuuRyYph/e3DxA5ZDb37rqY3s 2b3YV81O8V68f8C/V6LH3MIcty1+z5Bn5YAj/ANSOkDj6W0cxOytXXZSSBx8q8mPXyKpuy rDOj6Uu+UxwZgLJZtLi+TVCqGQ4Fqkw= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6BD032120A; Thu, 5 Dec 2024 09:16:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1733390210; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Exos+Q3ir5xTGxhDlEiLEF409xFDOMwB2dsvHmrGW3E=; b=MIT9aWdYDvLSgewREbp9gRVo6oeMLRUjzAyGDtRJEJWH0nTnm04bf8qnqtrFaVt0lGo3OX LGd6tLLfV/BE0iLOUcyMkT8aurWBZltHFwvpWnfNhL/RSi28ZiDs3dnWMCLv1XAzEa/QO3 ascFbNjtjisxoWOJw323IS0sRI87CtM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1733390210; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Exos+Q3ir5xTGxhDlEiLEF409xFDOMwB2dsvHmrGW3E=; b=DPf1E07qO+1y3XQ4S4GsgoATOUxRYecBy2oP4skuAdX5AVB0zpDTpelniyOkYxMfBB5dcp fIRIjNNzqiabF4Cg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1733390210; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Exos+Q3ir5xTGxhDlEiLEF409xFDOMwB2dsvHmrGW3E=; b=MIT9aWdYDvLSgewREbp9gRVo6oeMLRUjzAyGDtRJEJWH0nTnm04bf8qnqtrFaVt0lGo3OX LGd6tLLfV/BE0iLOUcyMkT8aurWBZltHFwvpWnfNhL/RSi28ZiDs3dnWMCLv1XAzEa/QO3 ascFbNjtjisxoWOJw323IS0sRI87CtM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1733390210; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Exos+Q3ir5xTGxhDlEiLEF409xFDOMwB2dsvHmrGW3E=; b=DPf1E07qO+1y3XQ4S4GsgoATOUxRYecBy2oP4skuAdX5AVB0zpDTpelniyOkYxMfBB5dcp fIRIjNNzqiabF4Cg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 04A75132EB; Thu, 5 Dec 2024 09:16:49 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id OUfuOYFvUWcNfwAAD6G6ig (envelope-from ); Thu, 05 Dec 2024 09:16:49 +0000 Date: Thu, 5 Dec 2024 10:16:44 +0100 From: Oscar Salvador To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Vlastimil Babka , Zi Yan Subject: Re: [PATCH RESEND v1 0/2] mm: don't use __GFP_HARDWALL when migrating remote pages Message-ID: References: <20241205090508.2095225-1-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241205090508.2095225-1-david@redhat.com> X-Rspamd-Queue-Id: D81D010000B X-Stat-Signature: 9ii8o9yxg5x6bxwu77b6c4eetdehkupq X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1733390194-245584 X-HE-Meta: U2FsdGVkX18rEgWVbNUpzZP9W0rZW01fxWjfQxu0ycDqVuRzyafK8YjuWUbRHPOOxSpJfjAFI0zijvrZK/BWINZRknGFbNXk9DoQEc3KOR0v6FvvJTesr52o0LugwLw+opF81hANQaOWKASax3FDU+kY5Gf/aiP4gYs+yHkUYmMnOpdyrqbBYT89AHdIwEjRJMofqJV+B7Y5nMeW7wpFUqAV1NHb1NxOVPSGElx/z0QOVglF/NpWKXacTsosQjQ2X3WSI+tuDrMWo+w8IaMvHj8qV4dBtyRm2vEXygx6mlsGZBzPy2axPNN1Gk5mCsVQKOCcZKz+TCKpq9pqKB34yVXhlqzH71wsfU3HInWTZOLz1GK/RB606BtrzpODihEqV1fDb6sp9nJaySDqoo9XydDP6ZgIeSYmiHKYzHjmYv4Zl8jp9+3ZAapAvxP6BMK2H2Eetz1/vLgGJ//gsL+a7lNtEdG58+FVyUsP2coof1nUxqixeKtgWyj+gLmay5QAEW0uUeuqAa2GWQA4J1cuF+BeiMXLrQyptLkRrvzS65okwOmOqPYKiNNQJbTzBX2oF2QAV+FSupOWyJIMzt4UcvI906PB1cFUt/AZ87nn9qOze7mTpwlrJ3oemesqm+VHyXOA3l8kaJ5DCYVTFxb9opRR0BLqVKZnB0c3Tl6bX/b2GdhH9r3w01uDYmvEGk6Nliik8ItOB/0wbVj2CDCnYRKKJ0IMQbFfDR2QV8YtAq58TF3plYsnFwSelSR1QgynmHTAAcEs0MiI61SE5EQT5CGV31LjnMwGcPbrm3ClQtiTFXLEgcYNcXDrib5quI7xfkTd4Dd/nS88NKOrah5W8Dd/z9uG2rlLRYojXOTSOrLh39r7QuJoQDr7lXh+ULg2gZuW8lO7A+yAkOAsQIsSK8S/HNEHTUQrOiqqSRoPTDgqN/g35HB4hrgIH0GG0UZdkC8dEoviV9JjnTLPb6M BSuK167G zWfdKMGbDrMCpFHzRaJRowOa1lZxtdGJ6bF0slE4ENDY0DMLSfffwou+iOhbgJe/j+t1LGBZsPx7y1/0gUYhq5d2AzNpRGG5ok7S7JbO6LYcRNekCd97Pl/I7QljMmGqYrYdgMJ2hUX1GpaLFF9FYqNeZrdCSF0i/9/HSI1ni/I312tDdF9cCwGKYHJuBE+N7frsAIdncTTSbj5f0pq5Z0UFMBUJENp2E8fMhzYk0goXXPnDzOMsLvPkBQQxvIWBT34eQcP2CFzIr2huG1RPXc5P+4b6Sc0LXn5P+vxLPbTXVer3Tfe7YYoMjwg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Dec 05, 2024 at 10:05:06AM +0100, David Hildenbrand wrote: > Resending via a known-working SMTP setup. > > --- > > __GFP_HARDWALL means that we will be respecting the cpuset of the caller > when allocating a page. However, when we are migrating remote allocations > (pages allocated from other context), the cpuset of the current context > is irrelevant. > > For memory offlining + alloc_contig_*(), this is rather obvious. There > might be other such page migration users, let's start with the obvious > ones. After the insight we gained from yesterday's discussion, this makes a lot of sense, and I suspect this was one of those "that code makes it that way, let's copy it just in case". I will go through the patches later today and give me ack. As you mentioned, migration code could potentially derive the policy of the old pages and try to respect that when __HARDWALL. It might not be possible though, but I guess it is a worth a shot. I will try to investigate and see whether that is feasible. -- Oscar Salvador SUSE Labs