From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 598D2E7716F for ; Thu, 5 Dec 2024 01:57:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A037B6B0083; Wed, 4 Dec 2024 20:57:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 98B566B0085; Wed, 4 Dec 2024 20:57:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 82BF26B0088; Wed, 4 Dec 2024 20:57:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 64ADA6B0083 for ; Wed, 4 Dec 2024 20:57:11 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 09E89426A4 for ; Thu, 5 Dec 2024 01:57:11 +0000 (UTC) X-FDA: 82859242200.12.0468110 Received: from smtp2-g21.free.fr (smtp2-g21.free.fr [212.27.42.2]) by imf08.hostedemail.com (Postfix) with ESMTP id 496FF160008 for ; Thu, 5 Dec 2024 01:56:59 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=morinfr.org header.s=20170427 header.b=rsk8276i; dmarc=pass (policy=quarantine) header.from=morinfr.org; spf=pass (imf08.hostedemail.com: domain of guillaume@morinfr.org designates 212.27.42.2 as permitted sender) smtp.mailfrom=guillaume@morinfr.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733363822; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IjLNNGvNOI6B31kAryzNagbK4F2cDGeBpknM3DNt44E=; b=a0Ap5BX3WtgpJrsko24Gb0nsUBUHAncfsT3+/fgzH7YKRQN6FVgnsVPifUwLvco4+lXfbo Z8+D2LbvDFlqrbIiZWPkoWvaRdJ0pQeiP9w5oOL9S2eq6qz/pm44mT+13vVQv6w4/48z+i s9sJgtYvnXy6LdGJGVSREji0QX1Z3gw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733363822; a=rsa-sha256; cv=none; b=N5ymvPhSqIQR8vwk4Wz/l0zxTIdiTvTSt8GiZiLUBhF1rSyXr8dEQsnLSr6yd7ZmjzdgzD ccTV0hDyMwfMj76QvFwoqMdbOaPc/iVWJhbRoU6+sWOPOoCs3L4p0uMEuynUmhNdYuupE1 lV7+xL0sK6V5+8gBN4NOLJyftVQGJ1A= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=morinfr.org header.s=20170427 header.b=rsk8276i; dmarc=pass (policy=quarantine) header.from=morinfr.org; spf=pass (imf08.hostedemail.com: domain of guillaume@morinfr.org designates 212.27.42.2 as permitted sender) smtp.mailfrom=guillaume@morinfr.org Received: from bender.morinfr.org (unknown [82.66.66.112]) by smtp2-g21.free.fr (Postfix) with ESMTPS id 1FF9A2003BE; Thu, 5 Dec 2024 02:57:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=morinfr.org ; s=20170427; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=IjLNNGvNOI6B31kAryzNagbK4F2cDGeBpknM3DNt44E=; b=rsk8276ig8VS+Y4y4hoG0aD1nQ FWus6rX2P10TJUv7gRUGWSfXxyRqM4G+aIlrl618N9iPAndL3yho14Bu5u9fQ9QVE54i2RwX7fDJE 2YVbNoh2MDr0N7Uo7nHy1/IyFfz4oL4tnlTKJNahKhmPxTeEs7HqMMj451RPlc1pFiaU=; Received: from guillaum by bender.morinfr.org with local (Exim 4.96) (envelope-from ) id 1tJ16x-001IBZ-1W; Thu, 05 Dec 2024 02:56:59 +0100 Date: Thu, 5 Dec 2024 02:56:59 +0100 From: Guillaume Morin To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, oe-kbuild-all@lists.linux.dev, linux-mm@kvack.org, Muchun Song , Andrew Morton , Peter Xu , Eric Hagberg Subject: Re: [PATCH v1] hugetlb: support FOLL_FORCE|FOLL_WRITE Message-ID: References: <202412050840.umPPa7cK-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: 3aczap3cnbce4s5megmtzynftjadosg7 X-Rspamd-Queue-Id: 496FF160008 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1733363819-254586 X-HE-Meta: U2FsdGVkX1+3cQNjtODPwduRdEqQKsneG2OQRy98zdb3J05ih/iwAZk3x35fMgF2NDts2Ppg15WJy5YJTPZqdI8Rf75UTnGtuM3Xg/E4srhX4H8NkYeaU0rT0UbXVOaIpAguqM15qR1FGgiDzWOJspcs1hvjgCby3W3P9x/7yYAx92VATXM/V+NEle4AFROzRMm07flNYzEL5VlMfLZUsJ4+YMof1o8lDiLXLOxAMRDO7VXlwA5wG2l5OyMO16p1dDA3RlDhw3NggoRTuqsV3iROxNHbd6mdarBGuCiKCzsJmAtMYwdUcXC6PMIglhBhJ9F0BTcHzBOkrd0SlzHIywRKZY66LraZ1UKgMhNN/8tdUaqXJFKHuH/pqga7hnX98Hq5gKCZhuU0YUnNCI4XHXh5NfW4DEtI/CxwHaSzNaxCBy9/k3op7ZmguYXtDAsp4A6EDbVCNJME4npN0Enn1lMPZhgM7VBbvhyhw94lJNPKTnrUa4CbDvkTGF0Fbupc6dj6QW1m9XQCy3RiLh8CnBMXlrK6dMfIyZQvozkiBUT2tRmevLQshXhaiqgjMaXX1XNb0WMHBXdMfBVOW1m0N7Q6mraylFbf9iLlSGDLhqImMDqAicyq4weZM5stqRgX4vhktd856q1eZY5aTkCs0KxA27PiYoJisqqTtGgaIDqX24fb4AqSdfSWRDxCNhtpLH6ElB2h5OWi7QOvmT1Xwydiz6X8spXmOYypBR2zXGZqEZM5ZFPbKchbFxmWKLKIjgruShpxvolaRX1cVzzKwn1WmdoxUGlozwRQm5yoZXzEzW7T7oj/3dqpVq1gLCHlCnxklLyRJZoSgE0ZUh8D4fNCTE789/Uu8lKK6xq8dn91+Dp4SaMxSz115g/hB3OXaVjJOluhXWofu+EGC4ATN+JDqlB5gudhmcaq8G6nZlzEIStMNu8xHVUaafHx2hU7NqJEZedIk89k2PUhXY4 Kokt+5qZ pA2qHQgrXkysMqoNOy9U4tL7DGbPtEYs+0yhfRq2I2n62Pl2yKbqPlWoh7L3jx9kiTzy7BlSG7wy1EDpyyEQziNRFH0/GWdXmCaE7sbkXpkbRe8fLfIfh5gNpfye9AQUNy7YkMuDASnKIedZ70KyH80cVZz+kuQT1ksKUQngJn/kXvPTPEfwha+sFSF96z5H6ilg1r3LjfPbMFZcZezajlwlmxQFwPAf0flVK0Jd6fjYyG56HUiHWeoFXU5Yor+3SyBHb8pAGRBZzT2GpcubiavVPY76emTB3A4Nt4SiQ5UnafoJLpX/6y1tu8NF0qZzkUByF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05 Dec 2:42, Guillaume Morin wrote: > > On 05 Dec 8:39, kernel test robot wrote: > > All errors (new ones prefixed by >>): > > > > mm/gup.c: In function 'can_follow_write_pud': > > >> mm/gup.c:665:48: error: implicit declaration of function 'pud_soft_dirty'; did you mean 'pmd_soft_dirty'? [-Werror=implicit-function-declaration] > > 665 | return !vma_soft_dirty_enabled(vma) || pud_soft_dirty(pud); > > | ^~~~~~~~~~~~~~ > > | pmd_soft_dirty > > cc1: some warnings being treated as errors > > David, how do you recommend I deal with this? > > There is no prototype for pud_soft_dirty() in include/linux/pgtable.h > if CONFIG_HAVE_ARCH_SOFT_DIRTY is not set. Should I just add one? I am going to respin v3 with that. Let me know if you think it makes sense or you think it should be fixed some other way -- Guillaume Morin