From: Guillaume Morin <guillaume@morinfr.org>
To: David Hildenbrand <david@redhat.com>
Cc: Guillaume Morin <guillaume@morinfr.org>,
linux-kernel@vger.kernel.org, oe-kbuild-all@lists.linux.dev,
linux-mm@kvack.org, Muchun Song <muchun.song@linux.dev>,
Andrew Morton <akpm@linux-foundation.org>,
Peter Xu <peterx@redhat.com>,
David Hildenbrand <david@redhat.com>,
Eric Hagberg <ehagberg@janestreet.com>
Subject: Re: [PATCH v1] hugetlb: support FOLL_FORCE|FOLL_WRITE
Date: Thu, 5 Dec 2024 02:42:06 +0100 [thread overview]
Message-ID: <Z1EE7gIlaSI3V4SY@bender.morinfr.org> (raw)
In-Reply-To: <202412050840.umPPa7cK-lkp@intel.com>
On 05 Dec 8:39, kernel test robot wrote:
> All errors (new ones prefixed by >>):
>
> mm/gup.c: In function 'can_follow_write_pud':
> >> mm/gup.c:665:48: error: implicit declaration of function 'pud_soft_dirty'; did you mean 'pmd_soft_dirty'? [-Werror=implicit-function-declaration]
> 665 | return !vma_soft_dirty_enabled(vma) || pud_soft_dirty(pud);
> | ^~~~~~~~~~~~~~
> | pmd_soft_dirty
> cc1: some warnings being treated as errors
David, how do you recommend I deal with this?
There is no prototype for pud_soft_dirty() in include/linux/pgtable.h
if CONFIG_HAVE_ARCH_SOFT_DIRTY is not set. Should I just add one?
--
Guillaume Morin <guillaume@morinfr.org>
next prev parent reply other threads:[~2024-12-05 1:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-04 18:26 Guillaume Morin
2024-12-04 19:01 ` David Hildenbrand
2024-12-04 19:13 ` Guillaume Morin
2024-12-04 19:30 ` David Hildenbrand
2024-12-05 0:39 ` kernel test robot
2024-12-05 1:42 ` Guillaume Morin [this message]
2024-12-05 1:56 ` Guillaume Morin
2024-12-05 1:23 ` kernel test robot
2024-12-05 2:05 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z1EE7gIlaSI3V4SY@bender.morinfr.org \
--to=guillaume@morinfr.org \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=ehagberg@janestreet.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=peterx@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox