From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60F99E7716B for ; Wed, 4 Dec 2024 09:00:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E7D4F6B0083; Wed, 4 Dec 2024 04:00:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E54676B0085; Wed, 4 Dec 2024 04:00:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D1C3B6B0088; Wed, 4 Dec 2024 04:00:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B41C66B0083 for ; Wed, 4 Dec 2024 04:00:44 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 623BE1A0EB4 for ; Wed, 4 Dec 2024 09:00:44 +0000 (UTC) X-FDA: 82856680620.07.57F48DE Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf19.hostedemail.com (Postfix) with ESMTP id D14D31A0019 for ; Wed, 4 Dec 2024 09:00:26 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf19.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733302836; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TGkrUIOK/o63mrqNdDYDHJlhGNtDvFUF9t/TpwiJRQw=; b=V2VPN94g29nR/BIo+mRdmoAtKL8MVbFsCoSbvDDYNdcyPqQtCdgEuQ1Uzwl3qrikpq7nVN P5rjzBFP7pStlAqtn4eL2R9YAn5aW3PhkMJlOk2UVdejGPcqWiCYf9dbvbSs7zP3OWZGM8 Re2o7KImAqY883nO7dws5Hp8JQIl4DM= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf19.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733302836; a=rsa-sha256; cv=none; b=hwFg678n9xmpFbClTSMapUWAfNiDb12iJ5iXSgD9sHx0rKnI1H+s/yoB7jRWYy1fE09Tb6 9eMGcY68bh28J79i8q4/W+FhbZiCYS30q1J6V1NyYsC5cD+79Pr6umRcrjDG9o7/luoJYf kYwyIGaQo2p1sX+JRGL0lOtg44yv9/w= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id F095A21167; Wed, 4 Dec 2024 09:00:40 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 51CEC139C2; Wed, 4 Dec 2024 09:00:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id kxxfETgaUGcyZAAAD6G6ig (envelope-from ); Wed, 04 Dec 2024 09:00:40 +0000 Date: Wed, 4 Dec 2024 10:00:34 +0100 From: Oscar Salvador To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, Andrew Morton , Zi Yan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan Subject: Re: [PATCH RESEND v2 4/6] mm/page_alloc: sort out the alloc_contig_range() gfp flags mess Message-ID: References: <20241203094732.200195-1-david@redhat.com> <20241203094732.200195-5-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241203094732.200195-5-david@redhat.com> X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Action: no action X-Rspamd-Queue-Id: D14D31A0019 X-Stat-Signature: 6i3acqrkanc9fkqw984iah7k5ynt55ta X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1733302826-872391 X-HE-Meta: U2FsdGVkX1+XVtvuN2vPSabRl4JTjq/8oHYjy5yyZ5JN1wm/ms/u+mB2sM5mqnDqRmNiwsFFhyrPreCEk5b6ctAK9s3JzKRwtDtR2zDjXiWOyfVIG6Thj9yGInmal0sb7PG3xf9wbuHkKefDoP6Gv7IM4fFT1jY8E0m0gL5hxL1ZNN42oNoMQ0cBbU9wgToAYu/7qCuTE7e9tICrFzvPjCv4+1pW72vs17c6q2Xn85gl5SmJGQeAOooYXTKYOuvzQuaTu8RfVkh7S7UG9EieH6k+fwmwdtsS2qhpe8Jx4w3fW+GBsn74q9AZdvjpZtPsBinpaAe54C4mxJvHWTy6CucBIetvWyr2U9b0Gtj0D/3ghzSFjBgjDfSQVamlknl/urV4Xux58enWOcIwAX8ppPfZy6xdfKNlg5AUf1NIXTnJ1iDNqL/CUbxIC36JIBAVTtkVORCy20WMoTBg/zAUAWzhGsrlspM9VcmgjYW21E+BcyF0AmZ/7D8fJEfG1YW/D3vpuKo+sIzKjHZOqU0dt+vJViWyPbeh9XtsHzrYDALG+A7mY3gveVU0C96aTUbQtMF2I2Ko1HUo1h2dENlpRUb0huBubnta+5GfWKjpQg9DOFcBtYJWplEwhb2AZr0S9ex+sr+TK3kRTK1jQI2x9+om1Q1Mmkn79tK4GM15aLoaSRx2kbRbpAKdD036KlF+fXGHaGSwcAaNZRbZfFRSq41+7KgjbitxyeAV00rvBV51Z7Iu0WI0VUrInt8elb5BtZ1qe8Ol2DL48sUMoe9w/C9oStpY2U41cce5CKh+aGzWptCBxARWUkfIv81FXj4DV7gsBIYRKpzCt1Q86UzhzRmso1hO/x6X2h7zRGZ7Bd8l4Q1VqaGeBszlRl/D2LORU8CMl3wJ2mi1pfyW+5Ob8zK7PME2eGk33E7RMvP6hFf4jYjqqKlPh/IM8q9f5WIE7IqYhIzhukRDPX74TPl U0rYNTy5 XSzoWLdo5wIzWnxb7lYIAuN29NhPu1PJHsJE1HOlkORrv8A603yDF707D/p8OAVLM2l0eRydTToxyR53gL4IjDWwnMaXR9vTf1TPNG2q6Q5BZyCav5lYUsdnx9V1J39br8XBLW7ohPa+8bqg0extIYBAGA8luoOvDdPJrNTEDGybma/8K7k6sRAy9q7N1K4imdctw82nFhHwcbkjNMWxB+Lv6D1GMTSX+j7g+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Dec 03, 2024 at 10:47:30AM +0100, David Hildenbrand wrote: > It's all a bit complicated for alloc_contig_range(). For example, we don't > support many flags, so let's start bailing out on unsupported > ones -- ignoring the placement hints, as we are already given the range > to allocate. > > While we currently set cc.gfp_mask, in __alloc_contig_migrate_range() we > simply create yet another GFP mask whereby we ignore the reclaim flags > specify by the caller. That looks very inconsistent. > > Let's clean it up, constructing the gfp flags used for > compaction/migration exactly once. Update the documentation of the > gfp_mask parameter for alloc_contig_range() and alloc_contig_pages(). > > Acked-by: Zi Yan > Signed-off-by: David Hildenbrand Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs