From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44796E7716B for ; Wed, 4 Dec 2024 09:00:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BBDC06B007B; Wed, 4 Dec 2024 04:00:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B6FD66B0082; Wed, 4 Dec 2024 04:00:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A0DCA6B0083; Wed, 4 Dec 2024 04:00:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 821066B007B for ; Wed, 4 Dec 2024 04:00:05 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 257E1140EC5 for ; Wed, 4 Dec 2024 09:00:05 +0000 (UTC) X-FDA: 82856679150.24.0ED7F3D Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf25.hostedemail.com (Postfix) with ESMTP id ABD60A000A for ; Wed, 4 Dec 2024 08:59:52 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="Ee1l/Ah+"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="zTnU/GM2"; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="Ee1l/Ah+"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="zTnU/GM2"; spf=pass (imf25.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733302788; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dpM2g75VsCwF4ni06a0Pzx4MSEcEE2LipOKSwUbh+bo=; b=ApUq91i9bq8ewip568Kz3Dm3E5UpO9C3AFMNwRDxVon5ynTUZWO+MbhpPOxLUy3x6XNpk+ uC7irH9Ryr3pERxF6LdqZKusxkHb5bb9UikZWOSPo9yjshJA29777gc/BtpB5OGsRNhjcf CpWIKckJmQLNyrWqUgd+XhOz8o+XLhE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733302788; a=rsa-sha256; cv=none; b=pzq4oruc7tzdL4joIk0y1LhCi+JiBIYNgy5UmaplTuW1IHgP3u0Zk8hDdqntXudAuWbW4B 2VX+J84NZmA4J38RWaosHvlWmLuDnnMwNP9eYNhs+MEK4pQ6stxcvaYekufnRp5xxs0mqI JyxcfMX7FN9R6m8rfrZ1BFIw5UyabRs= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="Ee1l/Ah+"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="zTnU/GM2"; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="Ee1l/Ah+"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="zTnU/GM2"; spf=pass (imf25.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.130 as permitted sender) smtp.mailfrom=osalvador@suse.de; dmarc=pass (policy=none) header.from=suse.de Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 76CC52115F; Wed, 4 Dec 2024 09:00:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1733302801; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dpM2g75VsCwF4ni06a0Pzx4MSEcEE2LipOKSwUbh+bo=; b=Ee1l/Ah+Pm5rKdmO+heBpdxK+OnoQ1Y6vsDu/7UdtyhbeTig6IMM+ir6esMbt7WsVye4Dj TYUsezH0zs8DaQMlZByRLKBlew8vVBji8ZWQWGso6Ka1ti1Jh981Qda3YuzLSycRLRrda7 8BCgN9p+ZU/U5Pjl0WZ6wKu9G+1ZGmo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1733302801; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dpM2g75VsCwF4ni06a0Pzx4MSEcEE2LipOKSwUbh+bo=; b=zTnU/GM2sKznNNBKjO8JuBYwiqqwB3w6yaFytNWcjcrWE9hbjOk6QGtYs5hxmvQTfY4zO3 8vHnKuloPcTIbgBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1733302801; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dpM2g75VsCwF4ni06a0Pzx4MSEcEE2LipOKSwUbh+bo=; b=Ee1l/Ah+Pm5rKdmO+heBpdxK+OnoQ1Y6vsDu/7UdtyhbeTig6IMM+ir6esMbt7WsVye4Dj TYUsezH0zs8DaQMlZByRLKBlew8vVBji8ZWQWGso6Ka1ti1Jh981Qda3YuzLSycRLRrda7 8BCgN9p+ZU/U5Pjl0WZ6wKu9G+1ZGmo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1733302801; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dpM2g75VsCwF4ni06a0Pzx4MSEcEE2LipOKSwUbh+bo=; b=zTnU/GM2sKznNNBKjO8JuBYwiqqwB3w6yaFytNWcjcrWE9hbjOk6QGtYs5hxmvQTfY4zO3 8vHnKuloPcTIbgBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C5389139C2; Wed, 4 Dec 2024 09:00:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id HKtXLRAaUGfLYwAAD6G6ig (envelope-from ); Wed, 04 Dec 2024 09:00:00 +0000 Date: Wed, 4 Dec 2024 09:59:55 +0100 From: Oscar Salvador To: David Hildenbrand Cc: Vlastimil Babka , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, Andrew Morton , Zi Yan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan Subject: Re: [PATCH RESEND v2 4/6] mm/page_alloc: sort out the alloc_contig_range() gfp flags mess Message-ID: References: <20241203094732.200195-1-david@redhat.com> <20241203094732.200195-5-david@redhat.com> <96c92857-4850-4f85-9474-ac193c5ea48c@redhat.com> <04c1d28e-bbea-4499-9a6d-770f9ca53ba9@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: ABD60A000A X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: b557o6x7bjnt41q6mr37izdg59xd3kxn X-HE-Tag: 1733302792-826548 X-HE-Meta: U2FsdGVkX19fzHdnuAk4LDb95KOADqfkaXywQwTc29WhVyNzOMiJRXQCqoL8Uh55UH7ur0IA1vie1zGKTvH10ezDDcJZ5HZxfZxncYuAWArfGo5ezgeez41zWWTEdF2HDFDlB8JpHgfGGV2x/Yw/u41msrVEe13Iwtgl5hswA4TnXdGrnnEr7QGzkJw+cLuwUnStsyURe0Gu8tZ9etKJUGA+p51c46YFVYa/vd8+zKSWHRA+Gc4phGqBr5oarYz1sCZx+uQqWwL5rkeXSEPFkYjXAiCFTQUv2wImAmFo3EuKKAqtY1+dIKdonFsMejTUKbP2zf5yez55T5JqgRu8jLWOISaKb8gWo0Twodi1C4bXoGN3OunrtfNEVbOQD4mRqhWBPxO5jstwErrYPrBT1USThqiWMSnavjvkhTmF/73mLp4GLUX1Y8EjaEgF6lkIyBv27H2BrA1iQA8K5KNaCijW2zco/nKAQLVbEgjcKydC+mU2oUOj+cJiQ7gLIOO+bCeKap/WWetqCuzBCazc3KKDpSMxKZD1uSpv4e14uMMyf5nK6yQk9+z7y5a+N1XlT97Rc7ZUFKkEkC+mXOXHmuSze0FlmBW7u9vG/wZPzOVP/LKQlURXwuvLHEK++IauouLJXWWiO6910OVx4zKgF7kCu5u0/YyNjAxcNlpJlM6AyxnfcwOnMZhH0g7R9i8x/J4qgDI2yf343omNXkOeCjvMAb0wveFag/2qu9XbvomnAEjaO+80m/S6pnsP1s1/2josyH0Rzf0MvfM8PGcmyuq7PbJNBk2ddzGB80SJGHNWpjOtyHBnQ+SBscFRZF7KEFj8D9l6zAPdZzU1d7J3MgkyEKVJvpzrvAJA8m48lFH8MaUg2DKLIJv4mf/MvR9EVxTdnCHvZYOXC8q6ziRYikdRXtFZkrusnda9ZwgXd7KqbimChEcp6Vv0OQ7qljQE0m4iVXAdwffNrLEri6e SRQ0LS2q JgIGWNAHuyZ61uTveBo04uBj7lnwf04aV/+YvZG5KTptA6NSACPWK+XlVAsZsDnv/rUsLrlWLk3ek3nFoMlHqZlD0pYxfdDR7LIuu88/d0zOEe0ia4nxEgK/PbnTPyl7qou7gPIn7DnxCLSSvUwa72fChutP4Ainq0oYgz7iNXhlPifXFnKd/MrPL4G08PmQ2xj1OQ0jqvPEj4FXMoCRWoajmHhJeCdJp627MLzjMBkAoMSI2oTBjkvlngfRdaUk76ITyZ8k5JHqmkAj01jq/t2HYboF4g4I4Q1AJAY9R1DN0YTq1SykaXkV7gQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Dec 03, 2024 at 08:19:02PM +0100, David Hildenbrand wrote: > It was always set using "GFP_USER | __GFP_MOVABLE | __GFP_RETRY_MAYFAIL", > and I removed the same flag combination in #2 from memory offline code, and > we do have the exact same thing in do_migrate_range() in > mm/memory_hotplug.c. > > We should investigate if__GFP_HARDWALL is the right thing to use here, and > if we can get rid of that by switching to GFP_KERNEL in all these places. Why would not we want __GFP_HARDWALL set? Without it, we could potentially migrate the page to a node which is not part of the cpuset of the task that originally allocated it, thus violating the policy? Is not that a problem? -- Oscar Salvador SUSE Labs