From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B37DE7716B for ; Wed, 4 Dec 2024 09:03:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DE3916B0085; Wed, 4 Dec 2024 04:03:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D92EE6B0088; Wed, 4 Dec 2024 04:03:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C81816B0089; Wed, 4 Dec 2024 04:03:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id AFCDC6B0085 for ; Wed, 4 Dec 2024 04:03:31 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5317EC0E71 for ; Wed, 4 Dec 2024 09:03:31 +0000 (UTC) X-FDA: 82856687760.21.746C8DE Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf27.hostedemail.com (Postfix) with ESMTP id F382440002 for ; Wed, 4 Dec 2024 09:03:11 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf27.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733302996; a=rsa-sha256; cv=none; b=g0KRfrluEFJ/vuLbCD+Q1qa20sbcuZNTBRmhjQ9GZIWM5a/S/pqOzuZ5dNFHCwh/NNUuTk LFpLeTN/ofM49/Np5y9aWMz+sOGD220YJVCJNiTvNpAh49VTqvBftmrb40k4nmOOgw/V00 KQc5/VxVO7A9Tby//EhCTtS21gyHo00= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf27.hostedemail.com: domain of osalvador@suse.de designates 195.135.223.131 as permitted sender) smtp.mailfrom=osalvador@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733302996; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ywTnp4/Sv+64CfrtrhNnzI96LOiUWNdzN1oMV+Mq6WE=; b=mlwcJzXGToKTP2ndpD5NCdouUl8m/J0e9x7XFW7hy6SmAOo1WHn9wGr39Sgz7ZA69qIpok J9IKxuIUF+wxYmNE8wVZBTAzB7OYqVFGOqRPBio1fOr9MV8IRuSFQLh+YthdH+TyBrvlmL NYGYzzTUGo5DTrshluHYy5t3dXVjG4U= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 0E5F91F45F; Wed, 4 Dec 2024 09:03:28 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 6AC88139C2; Wed, 4 Dec 2024 09:03:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id DfrUFt8aUGfgZAAAD6G6ig (envelope-from ); Wed, 04 Dec 2024 09:03:27 +0000 Date: Wed, 4 Dec 2024 10:03:25 +0100 From: Oscar Salvador To: David Hildenbrand Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, Andrew Morton , Zi Yan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan Subject: Re: [PATCH RESEND v2 5/6] mm/page_alloc: forward the gfp flags from alloc_contig_range() to post_alloc_hook() Message-ID: References: <20241203094732.200195-1-david@redhat.com> <20241203094732.200195-6-david@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241203094732.200195-6-david@redhat.com> X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Action: no action X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: F382440002 X-Stat-Signature: pg1igeqw4fd6emfk3fygas7ccadta1mw X-Rspam-User: X-HE-Tag: 1733302991-825070 X-HE-Meta: U2FsdGVkX18wFvs1SdME1Rp7Elrcx+m/4AXf7giNDHf+mYj7fborMDThPaX29E+2cjlSYmlSRD7aUwbbapQqI87ivzFTYjHNYqvvGKVBG24YXVfSYc17cmgbgXezO4SLSVX8srjQ7R3oOPCSjITImfZlsHtShy/IuD+vBq4TpE/vcmSyAbuvQ4kfv0ixdwjE8KNGVcnwCub4Vo5rHLMx4n2zpayw46NQwSxsH2TMCcKeMjKQomalTN2dUkDNy1WydBzpQA5q1l3+Yd4yEnGISQQgwb8BxHOjZDHoA9c7WsaEDm6PF/JXv6U3PvLVAZ6opxaT4YTHqL8ctf3eiGGBhzk5/kl1Uooa6F5eRt+UB6hhF37/D5TgEiyPoiTdF8zdp5tjjPU9CL67n4zBIu4GWRPltdOlj37Y3QC7ACjGEDeuL8vmc/IGAtIkiDoS2l/H2QcUlM6phmhZuP1GJu2ziGhUjsFe4a8Awxt3J7iT5HdcMXpB6K73J7QDp23Tp8cxyqH1xJhSwdVHJrj/Kh6eZT5jk8f7gv59tQCOwa4Y2FXcd5fUrOrAmGXdC43aINmAU/qj7z6MJHcXQStDaheaBjOzhSV7gkpG1E6zjnQMPOUuHnt5mncX0MLlES2aXYkiUSStb7mMG4x019l29fOjrAbrsWEElvf5V2ab4lRDvA0kRH1zycvq7uQt8u6dhSXV6XDr7g4w4rg55PE5xa875hd8cfImFOyTA5okU3uBZsN2e87MSPTGg+US/4B4cETN1OSsokZsIbJlrWS0nmT92TooBmtwAlbRxVbL8SvQ9OzA0ZE+LSk78yLmLsenmj3HFBdBwclqPlMn0cgu7z9ft0iX0XWA2hzxTXiUW9u8/B80H75Wjz0L4xAPJMEmQSdJvYo3tO6hFWpR0E1rEgv9Wbeko0pNWKz+f4KKA9CykLQUvog2xKsewyTpa1kr5khmc8NEMVgxyBWei87C2V8 pCMGuieH zsASEO+sHzlLCIBwBTWNE//2grGcFN1X50bOBO550EJTqdmNOe0HwYs9f6JJlpDO2SD0yWzS4JeDTB8MBbOIbLPUmXjrrCBOa3qCCGgZVmdNII32jqYnNckM8ReCSL3GAga5y0HlgiTfBUdzJBe1+CpI5UHi8g9qmqWtuprIG5mZtDSbYdLd+o2XigHL0zWtuxvIQIEHOyya85m0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Dec 03, 2024 at 10:47:31AM +0100, David Hildenbrand wrote: > In the __GFP_COMP case, we already pass the gfp_flags to > prep_new_page()->post_alloc_hook(). However, in the !__GFP_COMP case, we > essentially pass only hardcoded __GFP_MOVABLE to post_alloc_hook(), > preventing some action modifiers from being effective.. > > Let's pass our now properly adjusted gfp flags there as well. > > This way, we can now support __GFP_ZERO for alloc_contig_*(). > > As a side effect, we now also support __GFP_SKIP_ZERO and__GFP_ZEROTAGS; > but we'll keep the more special stuff (KASAN, NOLOCKDEP) disabled for > now. > > It's worth noting that with __GFP_ZERO, we might unnecessarily zero pages > when we have to release part of our range using free_contig_range() again. > This can be optimized in the future, if ever required; the caller we'll > be converting (powernv/memtrace) next won't trigger this. > > Signed-off-by: David Hildenbrand Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs