From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69D54E7716A for ; Sun, 15 Dec 2024 00:39:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6CA7F6B007B; Sat, 14 Dec 2024 19:39:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 67A996B0083; Sat, 14 Dec 2024 19:39:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 541AC6B0085; Sat, 14 Dec 2024 19:39:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 366ED6B007B for ; Sat, 14 Dec 2024 19:39:34 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 853BC82BB6 for ; Sun, 15 Dec 2024 00:39:33 +0000 (UTC) X-FDA: 82895333976.07.9FEFE80 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf07.hostedemail.com (Postfix) with ESMTP id C2B5D40007 for ; Sun, 15 Dec 2024 00:38:55 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=qVqT0ecJ; spf=none (imf07.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734223159; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=blAmohXRs9at+HamL5FS6EkRRQ6jC3J+Ym8WUxcXnYA=; b=5Oom5NaElehkOMbIPiQOqIAWs8PodygqOkXlwHg60icJBwpyWmfOr4KYfoJHpskta327/9 YZQfu7E2TmOVC3dbH4iAwclJeYPGmmn0Js30HP1wgg4eAioHCb9YU3DZa325vYGL8sFBUp Oer/m2WW+JSTgXbDzaLp5r51x6rimos= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734223159; a=rsa-sha256; cv=none; b=WeOtmh0CbXWaQB/YSaUIRFfcR09f9j0b5jUhDLMUV6L72KaA8aAKhC2kjVv7dD8R/IzkTt c+0VHe+wpLO+kIvwElhQH/nfbVajx5LIe2DF7PPV3cjOvuIXbTGFYFm4qvP7RtKh1X/tK8 7cIfV5pvRTHEzSuNvKtsEKVKGOLKYkQ= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=qVqT0ecJ; spf=none (imf07.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=blAmohXRs9at+HamL5FS6EkRRQ6jC3J+Ym8WUxcXnYA=; b=qVqT0ecJFv+8q586RYNyoKOk6x mLTEuRWKgr8hyOa99W93AGNDywVc/IVk3WYph2UOp0cyrafxJLYH90Xbd8pQ3UL+JxgnSUxJQfP/f zI1tR3uM/bvLmOXyi/pUEbVTktbXHRmEXSCCNJNN3G/MYD4iIu3J0BMwsG5BrTe/i7MYAbF+8BAXB z1a1KD1a9pITp5RGP6qU9eeN5sBo8mspiyecYq0LYBz6g/OMh5F+DRaJSweIHnBgMtl+3FwqQh5dT 62l0letUYISXD2GiwthkhyoO48FRPRPj+tGkc3tdAbQL2eT6e8qqWwTjCWIrLANiDifQk62H5vv7s OP9C3DDg==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tMcfI-00000006B66-35qg; Sun, 15 Dec 2024 00:39:20 +0000 Date: Sun, 15 Dec 2024 00:39:20 +0000 From: Matthew Wilcox To: Luis Chamberlain Cc: hch@lst.de, hare@suse.de, dave@stgolabs.net, david@fromorbit.com, djwong@kernel.org, john.g.garry@oracle.com, ritesh.list@gmail.com, kbusch@kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com, kernel@pankajraghav.com Subject: Re: [RFC v2 10/11] nvme: remove superfluous block size check Message-ID: References: <20241214031050.1337920-1-mcgrof@kernel.org> <20241214031050.1337920-11-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241214031050.1337920-11-mcgrof@kernel.org> X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: C2B5D40007 X-Stat-Signature: 7u33gurfja99m81gdsxog1ph71t7m7ph X-Rspam-User: X-HE-Tag: 1734223135-891697 X-HE-Meta: U2FsdGVkX18dU0w1lvtu8Rl7N16bGxADkenNz8Kx0OvLN8bBTh5IY1iSYKo3+r9a/+EsNHHwcFP1WXncRTO4L4czy5emd5/QFC7FiwfyupjEZ0p6YVdm1Y29bvBtGqtmIfRDnHYBh6SveYSxY/Ah8uA74UG1MCPK/mE4oJH1wJIAkcUFptH5CRHyY2z5QC22phCZhtvJpp7tykYXHjYlaeKJ3TeP01asQUwnXD0xdYS5nxdZP/DdXdf4NZRILsAW86F5XC+zToxxddUDmYErgnUc1KeTNxkh9kTKaKGxURIyPF7OiFsYL0c4siA5mK7iY6E37mk8hyhsbueIfH+pdWlupXg+AAdP2qfVcmTY6YiSWEp/esM9Dq09t5JWpRXFj65YjR15Bv7WK7b5tQMrgpcgIw7CpNm476hfm8CaFikYdGPHT6IoOz45Ww/B4n/Hg6uxjt8PlcFaGxv0Oov1NCpxGOWL/hw71/trB5PdLSICm8x9lTRZhmE21geFsN5EykOaWsQyqugoEEXXbKKN789ji8GXyl+49Oz8oGFqpqqnxFFrZZAe1fYyKDTWn/PXxhwoEntPgpHnqL6clBN1fQd5bpqg2/8BldyTRzS3Qt1sRGTbMx3FwlIAVWzX3lRHCInc1D6uVcsFxAFsZkmWmB+KHYwkxEu1jmKpB2MlREFMT+bSHbUAwCgN/X5LqqVQg+qcOgdEo3Sma/iSQ9pTiOGYgUVkvLWCOqrlpa3xzOTZFFBbtVreIxuNKTQPgZJsyBpK5FEfiEum3N2eMPKYAiSJ5kWMs6yS1V8kjciHzUXQj9eoPc6Mq7LDUL2QswudIbyUhxOhAXzJPyECdaZUo3aCYccKPmkBn+2UHuHYszXIlWbfrk2QYByyY45f6eyy4dQEc7McUsAMkA/t/F4+CXX6rttysGcUPFT3megAl5aZUgW60rkfzvfyCDsBiQAPLYTLAZNiNf5k8fBzsUz ZV0sWNsL cizb8BAf6ItfWku5R3snir5vApRpuoB3m2qQNvmzRbQdhdxN8Y9k/wYDda6wMBOx5WDdnIFgXVQrC0s20UsAyUNYxiOu4Vk9NMy1HHEb/JsqPixsoEK/wAmTFjdP7Wyi57eZDW4wKV2iYhwY3XMo0SwsPcYIg7vU0Eud0NpL/UkGjyxiyVDC6U1bSuptJPbrbhSW6T1tXnMK4Pyz5oad3li8ji0x7nWu8WqIM+tYQEydFRtHVvwhOvixNwx10rVrxFOYqsq/3hDNRGxIK8wKmO+WIfZenUvQ/39mUF2bFfeN5U2Du3mueSLMAM3PMOPobdHz3rwxsZmRaRjI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 13, 2024 at 07:10:48PM -0800, Luis Chamberlain wrote: > The block layer already validates proper block sizes with > blk_validate_block_size() for us so we can remove this now > superfluous check. If this patch were correct, it couldn't go far enough ("valid" is now only assigned true, so it can be removed and the function could return void, etc). But I think there's still utility in checking the current configuration to see if it can be supported by the block layer, and setting capacity to 0 if it's not (so that the namespace can be reconfigured).