From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B36A6E7716A for ; Sat, 14 Dec 2024 09:18:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 240EF6B0099; Sat, 14 Dec 2024 04:18:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1F0766B009A; Sat, 14 Dec 2024 04:18:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0917C6B009C; Sat, 14 Dec 2024 04:18:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DC4936B0099 for ; Sat, 14 Dec 2024 04:18:25 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 8F149121D2E for ; Sat, 14 Dec 2024 09:18:25 +0000 (UTC) X-FDA: 82893013224.11.46AFBC6 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf21.hostedemail.com (Postfix) with ESMTP id 802CC1C0003 for ; Sat, 14 Dec 2024 09:17:32 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b="I/UmBmQl"; spf=pass (imf21.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734167885; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WcqJw9z8Xi2dAQdId8Agf80AKwGPMvw7TFoeRY/+4Ac=; b=iw54Vuv0xXcHzar/uJHU2A/y6Bh0SUlVL15MTJEsqOd0EHvCXKOF0ZDy/UDZcMmnBB+mvW aYKlR1H32gJfYzKz9uGTjhw4zZMJrM4VGssep5VG0XyY9Zw+05jeGLNOqj1jqyXs2qD1AH taLjffOnk0+xeKGjt7HMUgbVuN2zD7o= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b="I/UmBmQl"; spf=pass (imf21.hostedemail.com: domain of agordeev@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=agordeev@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734167885; a=rsa-sha256; cv=none; b=Xw1K9h88gUaHK9RHPffDDWHz3qB5n9dhYA/19PpMwdFbHy7it0p6GeQdXvx/MvUAucECKY fxIB9/+QeoEy1TTwyXeWyWNGwGjW4VJRceAeJrmPiSmLONFFOVASgdCQgQAiQvHUK43OGw 291XsCRc8tMV4diHxTFRH1F375jkx3s= Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BE4TRso018926; Sat, 14 Dec 2024 09:18:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=WcqJw9z8Xi2dAQdId8Agf80AKwGPMv w7TFoeRY/+4Ac=; b=I/UmBmQl2elfBnta0fgFP4KIKPmTOS87BDuXUdfvunjUzU DBFBiHewXvraVPVJ5BdH69F0phsAI35o3uk4MOYsA8hTzNWlCoy2sWcMDHk4czB8 GKnSSr9Mo95tanFUfFCSwycT6rCTRd7OCfAViIA35B+EIg77u/zAt09TI906NQ0U s6DmSCzPQa1l+MwQTnQsRxoU37BoaXvPU1ukkJmri8nX462n+feqUPUaE+U2FCPJ dMsZCYg9VdWV63zsb0/9h7Mfi0FniTZQEN+4nsWlZncS/AEQ3Xg5hMCoun4p6cl2 oXaa/MTHMgHtbMfq2zKuQ1r8TqTLcQgCFPpZ1Dzg== Received: from ppma12.dal12v.mail.ibm.com (dc.9e.1632.ip4.static.sl-reverse.com [50.22.158.220]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 43h2gb17v7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 14 Dec 2024 09:18:21 +0000 (GMT) Received: from pps.filterd (ppma12.dal12v.mail.ibm.com [127.0.0.1]) by ppma12.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 4BE7mNOJ032734; Sat, 14 Dec 2024 09:18:20 GMT Received: from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225]) by ppma12.dal12v.mail.ibm.com (PPS) with ESMTPS id 43d0pt2mtc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 14 Dec 2024 09:18:20 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 4BE9IIK434996732 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 14 Dec 2024 09:18:18 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7E91A20043; Sat, 14 Dec 2024 09:18:18 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6128420040; Sat, 14 Dec 2024 09:18:18 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTPS; Sat, 14 Dec 2024 09:18:18 +0000 (GMT) Date: Sat, 14 Dec 2024 10:18:14 +0100 From: Alexander Gordeev To: Andrew Morton Cc: Dafna Hirschfeld , linux-mm@kvack.org, muchun.song@linux.dev, linux-s390@vger.kernel.org Subject: Re: [PATCH] mm/hugetlb: change ENOSPC to ENOMEM in alloc_hugetlb_folio Message-ID: References: <20241201010341.1382431-1-dafna.hirschfeld@intel.com> <20241130185121.02da011be898052454116c4b@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241130185121.02da011be898052454116c4b@linux-foundation.org> X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: LXEOui7LmHJ84tox0LpDxDn1svrhYRcq X-Proofpoint-GUID: LXEOui7LmHJ84tox0LpDxDn1svrhYRcq X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 malwarescore=0 impostorscore=0 suspectscore=0 bulkscore=0 phishscore=0 priorityscore=1501 lowpriorityscore=0 mlxlogscore=651 adultscore=0 mlxscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412140074 X-Rspamd-Server: rspam05 X-Stat-Signature: 133pg3yswg9ofn7ti339murd85xgui97 X-Rspamd-Queue-Id: 802CC1C0003 X-Rspam-User: X-HE-Tag: 1734167852-655946 X-HE-Meta: U2FsdGVkX1942G2i1c7flHXjdMAeLRxsXLwpSj4FFMBBddNqqLJsHiumBEoUUPExwxdw71rWoZx/cIlyOdF9fQ85/gnAOvQ0drn0Uw/3sDb5xduFUGgaEZyWmGh4fUDwoC+bnBkX/1pedY9iXfeQsD72/eepzmVhOc8PBqTddT6B8k32BFK2w9v/fHg8jXu+831JDcNAF5JKpweSLmchbiSHe3x9taA2aJPo2U+zvfNlwRN3Q74Axn2Fb+wFEyoyCt0T1HiYQ0QHqbVJfa6dO9f82nKqOZA6+UEkDG0rxnfboiugSaZO7GakI/F9QzGL7y9ZYDC7RNxAX3+rEs+NoWLokBS+Fl/ose8qzDsUb5F8TdS7Rw+46mMQ6UxYGelE9vGGc60STM2N7udQLudBe5t0SOc2k/GuFf00g6d3e9YTxB4Lh1iRy9c9aStbVg3n505FpCJ22/cQBhaJsDDOeu4RsxNJpF/DYL46uEH/h7fk+yzLp+24eIqgEVpoojRTMc6sU/zpZ/h82/ztrFf+ATTjx2ds9mR6a6swjJo2UQWuE+838nFkKqCUNduEZ3F848sTZ1HKEQ4VC3SCfKbRJFBcPYXc0Q52ZgWY5X1sBW5OV7PP55cCuk5o1fshEz6Z4eYVle1jV0O7PIR1kDBWdQqTf3/pQFuwk+Q4cX8w8uF67283yaK4J8Pg/UmQcYbp7qIgaPZkfSr4pmBoe2KwHK01Ix2EEjbrGnX66JmDGNaNG2PqkAPSlSiW7Dz+6dnu9JCyHNaw1JPfAqh7+mgNKwS9g+Rh1G0WxP+lNMihGJYFGdihSDYrmFvg98YcSL5Qe0ySlBE8FckQSVgYa+er6TlJcmAS8/gjvr78NL0RcyKMU2t+vjvVhN940WNWu/ynTJhu2AH+cUBuWGyyw1NRSapD+f5FAJ40R4N0u5RcHtORqoFcJAz7LLKb2ZkPPN3oLNyltIf4uWBSUMKHSRW iVcsvHNZ wRZ2OUh8HkSAzpalCAyQ53EdnZYye+2FRu7LMSl5dZsS2EPEuk0XYJnmqM8zA8QU1e5qI53DF7+KVKBVGIZYdBHKdSxBUwiHxME4havus2D4yTI4hMBpvhlIJWR23B0LCt3sWOvMmsUb3SlNYMYTaECS00ooL1pBGKtjSjX7plnlx//JSzmDLPXNx8JdT1XioRKsxIMAm7rhNgkoaWQOeJAXzURUfGqlNfMwnrpVOOT8ltn7q5hKMtiZ5Aspm9jlbDBjZqi06D2Sq5+jZVy/wDHOGZ+SFFHJFrhq+wssU9m9IN6NmOGtofYYdpiy/vDbkkVf5V+Zqtg9eRMFMhoI/mX9dylM6g5wEWURJ0fGNB4qTjJl8ypFEn8Nn1E6dLdxRtiaWDNDwPRYN94Uhm/x+wZdpy4u5rA2yymF71yCqJIBoC5w2vLVnF2LfyOZOsQZJXYr/KiBhhoyjMVVgXLaCwu1vZw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Nov 30, 2024 at 06:51:21PM -0800, Andrew Morton wrote: Hi Andrew, ... > > - return ERR_PTR(-ENOSPC); > > + return ERR_PTR(-ENOMEM); ... > err, yes. ENOSPC is for disk drives! I'll slap a cc:stable on this > fix for a decade old bug. This fix invalidates the comment in hugetlb_no_page(): /* * Returning error will result in faulting task being * sent SIGBUS. The hugetlb fault mutex prevents two ... */ The problem is an attempt to write to a MAP_NORESERVE huge page (as per [1]) causes an infinite page fault cycle instead of SIGBUS, at least on s390: q = mmap(NULL, hpage_size, PROT_READ | PROT_WRITE, MAP_SHARED | MAP_NORESERVE, fd2, 0); ... test_write(q); 1. https://github.com/libhugetlbfs/libhugetlbfs/blob/master/tests/noresv-preserve-resv-page.c Thanks!