From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14718E7716A for ; Sat, 14 Dec 2024 04:03:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 79B096B007B; Fri, 13 Dec 2024 23:03:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 74ACF6B0083; Fri, 13 Dec 2024 23:03:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6124C6B0085; Fri, 13 Dec 2024 23:03:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 41F5E6B007B for ; Fri, 13 Dec 2024 23:03:04 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id D558CB0805 for ; Sat, 14 Dec 2024 04:03:03 +0000 (UTC) X-FDA: 82892217828.08.575F773 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf01.hostedemail.com (Postfix) with ESMTP id 930E640009 for ; Sat, 14 Dec 2024 04:02:41 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=u3CFx5fW; dmarc=none; spf=none (imf01.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1734148969; a=rsa-sha256; cv=none; b=Ue/nsmzNxNQ2lZTApKnUA9LFt7tJIGJWWzep6R4Jhh4ETCvdS1FluG4kUBIxMcsox+Yujn 9Tk67EMBWwwuIArwRSDB9oiaA3SswD07pRhRnLFjAPg9MSkAhHT/4whJL7Mn3aK6I7yRyc WyS2rCM70jMK3f4DpMp7kb2+S3CSmsw= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=u3CFx5fW; dmarc=none; spf=none (imf01.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1734148969; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jaQ9uekgW3wGOKyDaJmcvtRmbzNiIXaD1Ad3D9xZuyQ=; b=pZGEsn7ZuyvF3mboMFjBbJ3rI+gwnFMurO4DbxY6tS3gk5V98s6cPin8Mskf8ltJ/L2Ufk GYtPg73QEctC4owSXXo4kdUoLf9KNI2YDfjhIr6bImgZ+jp752mFXi6A4ZtoCWobRFFNwo nAR+jogsOC8mawqqoYTg7Z6jFLv6a1E= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=jaQ9uekgW3wGOKyDaJmcvtRmbzNiIXaD1Ad3D9xZuyQ=; b=u3CFx5fWftMx/DFfIvvxtvHyu1 bogj6kmX3dZi3EmWlApnq6qtk/gG7+EGgLswu0bvUzSCn6foj2WKKWW/jlekJYSABYYwCKZ8247hI CwlmmMekA5hdiw6KtmWHLgn6qM/1PFhpK+Hp4sh/6UWWR5cPERfURhJOJnrhlC8ipHJpvmZiH75JM 0wkNSMAD/rgNOp9xKK5WlCAGhCs1zdyYNOCK6WXfjYfGuduubkB4beXFuAoa7C2JEFH6Muei6M2mn Cf6BGsEa6Us/tsy1mvCsoOr0rjhFCGLIprO5ch9+r8SykAJHXK67zIHh706DjOmFnnHBnhsv90Iad 4HvkUqvg==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tMJMj-00000000Btk-1VfQ; Sat, 14 Dec 2024 04:02:53 +0000 Date: Sat, 14 Dec 2024 04:02:53 +0000 From: Matthew Wilcox To: Luis Chamberlain Cc: hch@lst.de, hare@suse.de, dave@stgolabs.net, david@fromorbit.com, djwong@kernel.org, john.g.garry@oracle.com, ritesh.list@gmail.com, kbusch@kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com, kernel@pankajraghav.com Subject: Re: [RFC v2 02/11] fs/buffer: add a for_each_bh() for block_read_full_folio() Message-ID: References: <20241214031050.1337920-1-mcgrof@kernel.org> <20241214031050.1337920-3-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241214031050.1337920-3-mcgrof@kernel.org> X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 930E640009 X-Stat-Signature: focbdgtegfqeoofgc4ckhwro3z8x6nsp X-HE-Tag: 1734148961-409931 X-HE-Meta: U2FsdGVkX1+5FJr8z7vRNjU5JC2fqv7d2xRRxSqKMyfZ05XQkYpRUxpFZEweTJbNZwoPsECl/zJvKYwCrzGt0RR5kh89CRJJuTT0UNBEtbwTqIcyW3qh8CO1iIRo2Xy5KiR9YN1rEo3r1lr6FEtRmv0pLh3cEPwXxxtQPJNFD4IXYpDRYe0wmq5Io3YUFOjVdq3eDWmD+Rc4AA7OTVT8CxxiAynjMBOphw14wluy6dXpn7iY7sVwuwIb5PRkz162zhGGZWY2NxkyyNmcVd4DMW7LLbCgHlmBmWS0avbKqORy9aSI7kDivyd12YoqSQ7eK9d/tEa8KD98aN23ROY/d9xejdyPxoM6z2rImjL43W0YlhEpTQjz1WDUsN67mRevXj8p/B73wj/xzjlYo0mmU9WcczXZcj+4+LII0QP9AW3ROvU/GpNkKCmLmvO/8Zm6fCJDf5hFesiGbdFE/oqP5SMtwu1ekVEYvt8W6nf+ptrzbzlgAvlIYmmGRvB5P4SfbbIMTRhx7ISrxU4Tck1C2sLCDwakqoJxzgz5a4ILQzplSJx0JOsJKr8pdzclzG0W6+/2Gjcaq51wJsLiIiXtBFcDhARfjVfTmghLPTTJyDwFRBq0e2xkObTtHcWNrvmIgGkVqXWBl7mq34PPQaH4m2/f00aTyU7YZAE7CuLiwXxIUObFbeaD9P/w5Bgv+RPtV7wLlo777cq3Nz/gNOZDBX4KCdMiimgkp2/fuzWqC7U9qULSWpfctEJ4NH3eBiRuULy0thA9QEAwaQhjGtH6c+m8poqppvKkhJ9kJOUBn4C7w8TOdLY4LXQi1hLe3Jks0F74Z9hYnKEN/F1wmUt9osLuNXYEqh97/LbL85i+iaR++MXw3sb4DkLW2WqdxTdvFdX5MmoyBR1g85A9H3E6PTPrtzYYhCVUtcHWK+sVy/uQmupUfM9a00h9Q4FmVtGEKLWhKAnRwDik6zTPeF6 G8HP+y8s 33MK34/opeSrgVTMKsiq20nNH+T/0m2DwpwDLdo6qYKZV5wiAKvDwFyvi5AW62F1ZbPumCKrBtDUcOMRTkv/kGr+B84ezAhKr0ApwwBj5EC3ZRHxVZ2vtbYeMEs8KQKhbkV23TXAQvMSgjSsHAJsJCfzB8RE+FN0DK3EXVFQKZnA/hHIklJdWBjWt5eAgaZEeNqADJCQRkVURVtaXLfLbPo/hlYUuoowRYcs/yknKuTz5Gg/c6BAtmYnunMR/oJftevXtu76rluIyjZKMwiw/hbw0Pr68XvKgEacyNo1CB6ol9nE6v/DqSfEkDRcHB+VqHo6N4xpHVrkFZFSQdjWHhfgJzTMuM4PagK9BWk7kLxQ0RP772pS43EKCgg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000451, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 13, 2024 at 07:10:40PM -0800, Luis Chamberlain wrote: > - do { > + for_each_bh(bh, head) { > if (buffer_uptodate(bh)) > continue; > > @@ -2454,7 +2464,9 @@ int block_read_full_folio(struct folio *folio, get_block_t *get_block) > continue; > } > arr[nr++] = bh; > - } while (i++, iblock++, (bh = bh->b_this_page) != head); > + i++; > + iblock++; > + } This is non-equivalent. That 'continue' you can see would increment i and iblock. Now it doesn't.