From: Matthew Wilcox <willy@infradead.org>
To: Luis Chamberlain <mcgrof@kernel.org>
Cc: hch@lst.de, hare@suse.de, dave@stgolabs.net, david@fromorbit.com,
djwong@kernel.org, john.g.garry@oracle.com,
ritesh.list@gmail.com, kbusch@kernel.org,
linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-mm@kvack.org, linux-block@vger.kernel.org,
gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com,
kernel@pankajraghav.com
Subject: Re: [RFC v2 02/11] fs/buffer: add a for_each_bh() for block_read_full_folio()
Date: Sat, 14 Dec 2024 04:02:53 +0000 [thread overview]
Message-ID: <Z10DbUnisJJMl0zW@casper.infradead.org> (raw)
In-Reply-To: <20241214031050.1337920-3-mcgrof@kernel.org>
On Fri, Dec 13, 2024 at 07:10:40PM -0800, Luis Chamberlain wrote:
> - do {
> + for_each_bh(bh, head) {
> if (buffer_uptodate(bh))
> continue;
>
> @@ -2454,7 +2464,9 @@ int block_read_full_folio(struct folio *folio, get_block_t *get_block)
> continue;
> }
> arr[nr++] = bh;
> - } while (i++, iblock++, (bh = bh->b_this_page) != head);
> + i++;
> + iblock++;
> + }
This is non-equivalent. That 'continue' you can see would increment i
and iblock. Now it doesn't.
next prev parent reply other threads:[~2024-12-14 4:03 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-14 3:10 [RFC v2 00/11] enable bs > ps for block devices Luis Chamberlain
2024-12-14 3:10 ` [RFC v2 01/11] fs/buffer: move async batch read code into a helper Luis Chamberlain
2024-12-17 9:56 ` Hannes Reinecke
2024-12-14 3:10 ` [RFC v2 02/11] fs/buffer: add a for_each_bh() for block_read_full_folio() Luis Chamberlain
2024-12-14 4:02 ` Matthew Wilcox [this message]
2024-12-16 18:56 ` Luis Chamberlain
2024-12-16 20:05 ` Luis Chamberlain
2024-12-16 21:46 ` Luis Chamberlain
2024-12-17 8:46 ` Luis Chamberlain
2024-12-17 9:57 ` Hannes Reinecke
2024-12-14 3:10 ` [RFC v2 03/11] fs/buffer: add iteration support " Luis Chamberlain
2024-12-17 10:00 ` Hannes Reinecke
2024-12-14 3:10 ` [RFC v2 04/11] fs/buffer: reduce stack usage on bh_read_iter() Luis Chamberlain
2024-12-17 10:04 ` Hannes Reinecke
2024-12-14 3:10 ` [RFC v2 05/11] fs/mpage: use blocks_per_folio instead of blocks_per_page Luis Chamberlain
2024-12-14 4:46 ` Matthew Wilcox
2024-12-14 3:10 ` [RFC v2 06/11] fs/mpage: avoid negative shift for large blocksize Luis Chamberlain
2024-12-14 3:10 ` [RFC v2 07/11] fs/buffer fs/mpage: remove large folio restriction Luis Chamberlain
2024-12-14 3:10 ` [RFC v2 08/11] block/bdev: enable large folio support for large logical block sizes Luis Chamberlain
2024-12-14 3:10 ` [RFC v2 09/11] block/bdev: lift block size restrictions and use common definition Luis Chamberlain
2024-12-16 8:55 ` John Garry
2024-12-16 9:19 ` Ming Lei
2024-12-16 10:13 ` John Garry
2024-12-16 10:23 ` Ming Lei
2024-12-17 20:51 ` John Garry
2024-12-17 10:05 ` Hannes Reinecke
2024-12-17 21:00 ` Bart Van Assche
2024-12-14 3:10 ` [RFC v2 10/11] nvme: remove superfluous block size check Luis Chamberlain
2024-12-15 0:39 ` Matthew Wilcox
2024-12-14 3:10 ` [RFC v2 11/11] bdev: use bdev_io_min() for statx block size Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z10DbUnisJJMl0zW@casper.infradead.org \
--to=willy@infradead.org \
--cc=da.gomez@samsung.com \
--cc=dave@stgolabs.net \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=gost.dev@samsung.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=john.g.garry@oracle.com \
--cc=kbusch@kernel.org \
--cc=kernel@pankajraghav.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=p.raghav@samsung.com \
--cc=ritesh.list@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox