From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC2E6D4977B for ; Sun, 1 Dec 2024 17:55:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A00DF6B0082; Sun, 1 Dec 2024 12:55:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 988646B0083; Sun, 1 Dec 2024 12:55:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 801F66B0085; Sun, 1 Dec 2024 12:55:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5E3A96B0082 for ; Sun, 1 Dec 2024 12:55:47 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 06187121002 for ; Sun, 1 Dec 2024 17:55:47 +0000 (UTC) X-FDA: 82847142798.24.599B429 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf20.hostedemail.com (Postfix) with ESMTP id 552821C1076 for ; Sun, 1 Dec 2024 17:55:32 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XxYV8dg3; spf=pass (imf20.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733075734; a=rsa-sha256; cv=none; b=gqlJDXKtbxUZH9DCVhqu2ryEQgQVVQTrw9a5aU6Mqsv98SIKxTKOgUHcwMFIpHPxMRrluF YJy5qozcEsT8GKJ0huimV7XJMFC3QK9QvF/Xl8k9nFvm0otikIkCIq3IEBBVvjccTJCfTM yBYx26n34uoF71xzwVg97RLy6phH4Cw= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=XxYV8dg3; spf=pass (imf20.hostedemail.com: domain of peterx@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=peterx@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733075734; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Bj/FRfspWv/DskWdu4ezgBxsZYrptmYDnGDs7cuKhHc=; b=SzfhUTwv6rE0sKuH14B5YwaRAsjB7cDj3LfmXAwq0bIKqo9Zir860UKygQX+KPi54tPL9V ZqyiQTiDSGlLSPNk0Dlgk7HIbt8Y08atzgbFafrffOmE4tlfUWAcrdNrx8prqU/oa1uAhU /WtKk7HBrulbIR5OYmhBkXjuXPSs1L4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1733075743; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Bj/FRfspWv/DskWdu4ezgBxsZYrptmYDnGDs7cuKhHc=; b=XxYV8dg3yjgCkLiuu/0iTorsX3EAXWBI6ufO6OEhhqnH8bWsZ1N4nIF2/B8XJ02lkfdjoC NVbbK8mKV24xaCqpvfwCawdC9KuTjFvZNFhXXeuq+KAy2D1DcRDOv7ipFIkQrpSRocE/Ag 1LyTadmgxFoF0SgdG003DV7jCyFbgKY= Received: from mail-io1-f72.google.com (mail-io1-f72.google.com [209.85.166.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-67-T4XsuP3wNYmauJ-cgkmMvg-1; Sun, 01 Dec 2024 12:55:42 -0500 X-MC-Unique: T4XsuP3wNYmauJ-cgkmMvg-1 X-Mimecast-MFC-AGG-ID: T4XsuP3wNYmauJ-cgkmMvg Received: by mail-io1-f72.google.com with SMTP id ca18e2360f4ac-841a3f2aebfso275478439f.0 for ; Sun, 01 Dec 2024 09:55:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733075742; x=1733680542; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Bj/FRfspWv/DskWdu4ezgBxsZYrptmYDnGDs7cuKhHc=; b=JIMS7DDBXyzBbA1m+xZNADgQwnJeIMqUrAqL0MdNVHyHjsKKxedddxMl+hPDO43V+/ ejarC8+oYzxB/folvoHZK6G4RUTFPnXE7wQMRXT9h0MV/bLUd9yK48rHiKcTRc0y8NIY QySYRsxxDpCuoIVlNI5ljIk3Fm0Ji8Zqco0zBKGWidysNv8biB46caUe6n6JGPtLeB/f BCf+xpt/chB5g9l1bAb63yTbPHxoZBOEdGx1Vrpog7Xc9F7jUkMDI0t6O1WUcuXqJDfj Egse8gHQktflOSBdBkKbE+cx1+0O254+5A7cz/rmjABq05CFjfVcF8M9JtridwSgcCXd gTWQ== X-Forwarded-Encrypted: i=1; AJvYcCWdpW2xsI2TR/+8P0gLithvPxCtW7eGKPmC7+F2NmvLJyaSIUMRbiqyxrQHKAYNSxL8M8DA5vT2zQ==@kvack.org X-Gm-Message-State: AOJu0YwtTSZ3JpTHUZiL+DU4sib2VwmX+Y2kLyTY50TZIs7sxs4oIxyq t8WoxARbDef/I8OSNz7+oRXk1F8YySRT1+Q+h8VT8Rs8+6mU0oCrBnFfoz1jfmWeD7/FSziD4A6 9OljnYlJ2pDIBp5NPjaar87AWvQ4QCn3OzAuVk8wGuvgxRKlq X-Gm-Gg: ASbGncs/SjItcssl94K87hNbiH1ys9+QdYp4L+BR3acqNlrNBe0bcbOl9MO6m2bb9Tk wI8aFfP85Ce4Cch4308tu4OoKbGFQ1x8rOnGyKGTZ0vaDxIVLngQWGcBKd2Tgufkhx66QFJ+ABl JSUDa7s6/fXzxyuNvPVEcHV9JyIc0aUysGWSbdWQuhMomMJARLVjrETQFozBR1sWlzwoJYxkjx+ jL9GIDwqqEX7Iq3L4p6vp9TeSZ2gtmovNXxs5iKOMkOkWzdCVM+RIFSCt/rcw6OUnlkm3Cz2cNY ZrOza5X9J7k= X-Received: by 2002:a05:6602:1485:b0:83a:bd82:78e with SMTP id ca18e2360f4ac-843ed0d5db1mr1823653339f.13.1733075741816; Sun, 01 Dec 2024 09:55:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IE/C29sEt8k4hWcQ9UZmsHjRNvozdtx0q9RcLM88/BVqTagSmnFuAl4NtUM6pK3J/5zeSzg2A== X-Received: by 2002:a05:6602:1485:b0:83a:bd82:78e with SMTP id ca18e2360f4ac-843ed0d5db1mr1823651239f.13.1733075741502; Sun, 01 Dec 2024 09:55:41 -0800 (PST) Received: from x1n (pool-99-254-114-190.cpe.net.cable.rogers.com. [99.254.114.190]) by smtp.gmail.com with ESMTPSA id ca18e2360f4ac-84405faf14fsm171115139f.42.2024.12.01.09.55.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Dec 2024 09:55:40 -0800 (PST) Date: Sun, 1 Dec 2024 12:55:36 -0500 From: Peter Xu To: Ackerley Tng Cc: tabba@google.com, quic_eberman@quicinc.com, roypat@amazon.co.uk, jgg@nvidia.com, david@redhat.com, rientjes@google.com, fvdl@google.com, jthoughton@google.com, seanjc@google.com, pbonzini@redhat.com, zhiquan1.li@intel.com, fan.du@intel.com, jun.miao@intel.com, isaku.yamahata@intel.com, muchun.song@linux.dev, mike.kravetz@oracle.com, erdemaktas@google.com, vannapurve@google.com, qperret@google.com, jhubbard@nvidia.com, willy@infradead.org, shuah@kernel.org, brauner@kernel.org, bfoster@redhat.com, kent.overstreet@linux.dev, pvorel@suse.cz, rppt@kernel.org, richard.weiyang@gmail.com, anup@brainfault.org, haibo1.xu@intel.com, ajones@ventanamicro.com, vkuznets@redhat.com, maciej.wieczor-retman@intel.com, pgonda@google.com, oliver.upton@linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kvm@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-fsdevel@kvack.org Subject: Re: [RFC PATCH 15/39] KVM: guest_memfd: hugetlb: allocate and truncate from hugetlb Message-ID: References: <768488c67540aa18c200d7ee16e75a3a087022d4.1726009989.git.ackerleytng@google.com> MIME-Version: 1.0 In-Reply-To: <768488c67540aa18c200d7ee16e75a3a087022d4.1726009989.git.ackerleytng@google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: aKJ91iNrkX8gDcDY4mPygeKfCSAa9Cb8XZ0gIGbcOR4_1733075742 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline X-Rspamd-Queue-Id: 552821C1076 X-Stat-Signature: gf5gc7u9zx8mhxyet6km9qggb8ztpzih X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1733075732-725600 X-HE-Meta: U2FsdGVkX1+pkn8jagDAJs9tTBAxhy970aCoiQogJTsS9jpdevsvJuLes/Y7ITPY1V9QOTlDr6H3z8Wa5sQcCDkG3a0MAEfqV4Xt8TTcY209rvz8VoPf7UNx6zvo68AwHbVvdW2lJNwoZcefiadvlyXQ7gBQZLHzt9Oyb35PsJuwpyW30L6jffmW2fOj6ILyQewthE1dqCeBWFuWgaCzouFXaBiEu6wWSTSMYdIzoOxKr1vndesXqAuC2GPb9hyVUCDSoQFPRHR8jqpQARZAjLzT7tFYoQW9rLKxt8rTbFVVr/GoLUe7/foD6EhIbTbJmesdrJWWg3b4XvcTBGRwSOGM3fOC6OBGaThBDQ3WvaUhYTAO4LhHohqH/Fyrh0hilF8fFl8nby3/4Gkl90VTg+uov6LEfwesedWWMT+6SyryRF8m3rMepEdy+pUIXEtNF+kQNTiwWSkLd1b2+NTe9qUoCVKGpVoIeGF7lAw5a5q+SBLWZ+5AkfRMZrR5TvRXf1K51lA/u6NgMfRaUHY3/QqjhLiU58hr+PLjZ9XBKsO1dXcbLwtQQBiBUF9OXcDDCgDtZcFGpT7aedS5Lq0Xg9A+Y5aX3EE1wOVqUATuncfQRB3iHUafsHar7/P8Tzv1A30dlLI5VNLScuxVXeub47VCXDkorJa4304UrXdJNLeIydyaJvxobuuIvtY16H6Zcbu/NTt8jYXfARM6nL53itJs8QdD9JzaxHUnmM7Z3dpikt19ZUXQSYtYfi9ey8V1+UZpLP9PnDbUcU+88wd03xYd3mzHL/GUl+HxxVti8CM2UVpgVFB4Jn9xsUgV0u/+BrMZNz9i3PIEyCFK0TF2MhgUj0pkbbDZv3sZMVfsL1KvW0cN4C6hm0nyq142b+kMl/QJ6kX49sghRKxkqHrDocM3SEgFWTlcUOqqihOexgPAlzoFXdJtNy4pKrXmRm21LLIv51oDM9YPNOHD0bs cypRxCAA wViyUV69exWvKUWY9rPih/96ycLbIXsaoJfeHeQQwzQOIEZzzMjLBeYmbkqfbDBOolIGHuLEVUjMQdvo5XR59Heo+2o8mqDrX8jUU2IufYxtydS8dI6cFXclr2RbTR3r++lMt1LcqJ85AeZt5SyavOx4xECZQn8NTFQfpKU5VZDpASMrMsHW6nWVz0RS45hpFLaqzCzeXhQu/9nBX3pNDK3XYY1s/MPkuKbC/aZtUkJ8pSol3cXMRSTzc6PiOJBKl01U+V7FeXhIvN1wFJlcYicSX2uNxRDQrazMQaCWCqEFi63LEYQH3SbQLrPAahSP1eZrHI0aCAv3gNhfoQQ9RZhMg5PWJ56omRLiZmppy+wrLKY+jUajH63o8wsT8DNirBjKJlRz3U50YdX5XT1/WHSBIjoE9VUtAqgMs2uyb9TeaeptrFtnyJOjIfz8qYXKOVEc9LmLhP826Fs4ELsDaogKjcr+b8JAU4msL0Tecbpz9lTQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000195, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Sep 10, 2024 at 11:43:46PM +0000, Ackerley Tng wrote: > +static struct folio *kvm_gmem_hugetlb_alloc_folio(struct hstate *h, > + struct hugepage_subpool *spool) > +{ > + bool memcg_charge_was_prepared; > + struct mem_cgroup *memcg; > + struct mempolicy *mpol; > + nodemask_t *nodemask; > + struct folio *folio; > + gfp_t gfp_mask; > + int ret; > + int nid; > + > + gfp_mask = htlb_alloc_mask(h); > + > + memcg = get_mem_cgroup_from_current(); > + ret = mem_cgroup_hugetlb_try_charge(memcg, > + gfp_mask | __GFP_RETRY_MAYFAIL, > + pages_per_huge_page(h)); > + if (ret == -ENOMEM) > + goto err; > + > + memcg_charge_was_prepared = ret != -EOPNOTSUPP; > + > + /* Pages are only to be taken from guest_memfd subpool and nowhere else. */ > + if (hugepage_subpool_get_pages(spool, 1)) > + goto err_cancel_charge; > + > + nid = kvm_gmem_get_mpol_node_nodemask(htlb_alloc_mask(h), &mpol, > + &nodemask); > + /* > + * charge_cgroup_reservation is false because we didn't make any cgroup > + * reservations when creating the guest_memfd subpool. Hmm.. isn't this the exact reason to set charge_cgroup_reservation==true instead? IIUC gmem hugetlb pages should participate in the hugetlb cgroup resv charge as well. It is already involved in the rest cgroup charges, and I wonder whether it's intended that the patch treated the resv accounting specially. Thanks, > + * > + * use_hstate_resv is true because we reserved from global hstate when > + * creating the guest_memfd subpool. > + */ > + folio = hugetlb_alloc_folio(h, mpol, nid, nodemask, false, true); > + mpol_cond_put(mpol); > + > + if (!folio) > + goto err_put_pages; > + > + hugetlb_set_folio_subpool(folio, spool); > + > + if (memcg_charge_was_prepared) > + mem_cgroup_commit_charge(folio, memcg); > + > +out: > + mem_cgroup_put(memcg); > + > + return folio; > + > +err_put_pages: > + hugepage_subpool_put_pages(spool, 1); > + > +err_cancel_charge: > + if (memcg_charge_was_prepared) > + mem_cgroup_cancel_charge(memcg, pages_per_huge_page(h)); > + > +err: > + folio = ERR_PTR(-ENOMEM); > + goto out; > +} -- Peter Xu