From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FB4FD49763 for ; Sun, 1 Dec 2024 11:49:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4F4F16B0082; Sun, 1 Dec 2024 06:49:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A3D56B0083; Sun, 1 Dec 2024 06:49:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 36C086B0085; Sun, 1 Dec 2024 06:49:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1C66A6B0082 for ; Sun, 1 Dec 2024 06:49:26 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 82B1C1406AA for ; Sun, 1 Dec 2024 11:49:25 +0000 (UTC) X-FDA: 82846219764.02.90409EE Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf04.hostedemail.com (Postfix) with ESMTP id 37758403DE for ; Sun, 1 Dec 2024 11:49:10 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=NqiZK3Yo; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733053751; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Dr9H+wlzu/nk1VYpgp84ujqojTsby3R4MctkpXg7Oi4=; b=QxdAxklTHfP8SQ3U2L/8WGaud1Ha4zv85eve07tc9pzLiXNmnTWD96nP9x9GEEyqvIhdmZ rClngA7HnFqwqMmR5ZPnRPERCw4L7h0G7L0MD+28Yw6P88/Wnwp6T4AnlQpiDhNSaFEo5Z bwV3RIyQke+DBgFGBsXwiMiWPrYuNQE= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=NqiZK3Yo; spf=none (imf04.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733053751; a=rsa-sha256; cv=none; b=PGq0cbSVC19Y1n/cz2UGO+4ozkSsEJvzjIzJPfp9UPAkQl0OAbc67Q89E58es9J/7yZVbA og6i9AfDWmcOQWulYyxqy+jKY8M1AQRuUq5Y9MVIriKX1QLpZlQvnpLnvO9HXUTTDhb88E DyUxWb7iXapgGsebG6HyupCcfYdLw6E= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Dr9H+wlzu/nk1VYpgp84ujqojTsby3R4MctkpXg7Oi4=; b=NqiZK3Yoemf3bA/wRtWGXkKvDN tHhnlQoY0sN5UMnrQzofmovfc/QigFr6t1/0tbonjPx3eewJYsocQPDAo0TkvMrVsE6HJNFkNBMfZ dpj16e1HejDe0QJ+QvVjJ3NqtFGIHhas1AC25RP0V0EcElmjD2/Kg/+cQ600qfxIUAXJ64WbjkE9C tSIvJoU/he4VrUlwkhLYhtLPkKGbf5yZIRvBPnNx5820CfPO2OeDMnhiYbBIUPNI4piAOxG66d6k7 VclZgK6SLAtkxzSjIHe5FAm6QMyLSwBCSg/9rTrcjwe9A+Xu8xdfWTFf4uaZWM1uqACUPxuBeKsBL qye8YpWA==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tHiRz-00000006g7T-14Kq; Sun, 01 Dec 2024 11:49:19 +0000 Date: Sun, 1 Dec 2024 11:49:19 +0000 From: Matthew Wilcox To: Dafna Hirschfeld Cc: linux-mm@kvack.org, muchun.song@linux.dev, akpm@linux-foundation.org Subject: Re: [PATCH] mm/hugetlb: change ENOSPC to ENOMEM in alloc_hugetlb_folio Message-ID: References: <20241201010341.1382431-1-dafna.hirschfeld@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241201010341.1382431-1-dafna.hirschfeld@intel.com> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 37758403DE X-Rspam-User: X-Stat-Signature: 9uobg7z3nay78xt6ic9ybcdorrgshj8r X-HE-Tag: 1733053750-215686 X-HE-Meta: U2FsdGVkX1+vmIpbd5j/8VhPYlal7lgYYpLyyLnM0z2JqdxOChJifIi1dqQ4MNpI3Ip2mZnZGkzbLptIOdW+lXRBWhqfgCOi38k2Lc6CXYjdGL0jcuI3VvjFyUsbArXl7yJqaofoYUtsHaLepGtx+CFafTbk+BV+iP0AqU1Eb3OGjfHAGAUkNXieOR80xGCZdeTb2g4awstC7rO03uZ5DQUC+03+AGiwzNIXsiCYuEysepyOmk9HJkuC3WM3YjqDm2GonGsll7Hj9Lc0OdepW5I7DixaCWKBeMmJdlktyJlsPh24tWYtY1yTtWCsvXONld2LHgTMS0guNBBTa54XW2C3GHD4yPSr3ttHhqszKerTyfQodsr0JkO2g8e2w/DBKKlvF6w9nbSJbxxzwQEgA85ozz0QG/QbeCu6t4qHXzW3wAWZdDGuzxnPmGQ6hUb8nZ2wvmoaHsRXxRLwCJ1hZ9neOAuoAprJhQ0C/ZRzJADiHK9O0pQ5K3bJxtitMKvyul8gOZHNJTNtDv5Wqfe6dY9zNSkcx5BX00G1tn+2AqLMcHoeJRqzRShXN1U91HeoRP2I6YuyvDyJHwHLAe0s/hlAk4A37vdam5o7yYd2p/AwxdfAZ1v4RX4k2HMlLlfL1u7psC0ZMdYTuBKl+zErQDVvWGp8nAz3JUxNGFs/R/AeaLrRerDYntLfHwXIxaH5GuYb2w+osDAAmL81xFbjuFZVJayPGULD9AlsAYIQMk8HppDqi+pRpIEu1w0Cb5m+gKHO3A/BAeNjiex23JfoO93H7sX71OWUAEdtHm0ViWBjV48ABE/TPXfeilbHdar1Op1O+STgzryuDYkzVYjf2nggwoDpi+dR8EzHgQG2NYwgIMY+ESNJ0NQ4rGlX1rN/URoUUE7l2i3zQteN5BXbVB4w+avUwGOp2snyDcGqeaAJSqM5pDRCM1dg8zdX2RS8f7FPsetqsu0WIlMgpsW np14CZ0k MnNUe9Qaad36VC7B1J9pfnqZ5jB5Kcxaq95AaWMbm+kiU8vCzAvO/5NPEJHgakNLaf/b5cE/gNduk1s8bp3dz7hv5DJKPpSAqy27RjZ6QgfnBieT21D+HjFTXzPwVv91yFP5QKRQBih9P3PJ79X9r4/zHakOOhNd2WIJmX3DaombJObJz6VsWqgMYtTxHeOHhO675JTWbiSGIJfLMaOAlrpZMQ2FEBaZqq9/BbX/z9nwnYg5bdqUEm4+pj4DiEbVXVmVHtKWZaU6iCUWKyqCE2o6b1Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Dec 01, 2024 at 03:03:41AM +0200, Dafna Hirschfeld wrote: > The error ENOSPC is translated in vmf_error to VM_FAULT_SIGBUS which is > further translated in EFAULT in i.e. pin/get_user_pages. > But when running out of pages/hugepages we expect to see ENOMEM and > not EFAULT. Do we? ENOSPC is for media full, and since memory is the medium, ENOSPC seems entirely appropriate to me. It's been this way since 2008, so any change should be done with due care and attention to what else we might break.