From: Matthew Wilcox <willy@infradead.org>
To: Dafna Hirschfeld <dafna.hirschfeld@intel.com>
Cc: linux-mm@kvack.org, muchun.song@linux.dev, akpm@linux-foundation.org
Subject: Re: [PATCH] mm/hugetlb: change ENOSPC to ENOMEM in alloc_hugetlb_folio
Date: Sun, 1 Dec 2024 11:49:19 +0000 [thread overview]
Message-ID: <Z0xNPw1whVX-W0Qv@casper.infradead.org> (raw)
In-Reply-To: <20241201010341.1382431-1-dafna.hirschfeld@intel.com>
On Sun, Dec 01, 2024 at 03:03:41AM +0200, Dafna Hirschfeld wrote:
> The error ENOSPC is translated in vmf_error to VM_FAULT_SIGBUS which is
> further translated in EFAULT in i.e. pin/get_user_pages.
> But when running out of pages/hugepages we expect to see ENOMEM and
> not EFAULT.
Do we? ENOSPC is for media full, and since memory is the medium, ENOSPC
seems entirely appropriate to me. It's been this way since 2008, so
any change should be done with due care and attention to what else we
might break.
next prev parent reply other threads:[~2024-12-01 11:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-01 1:03 Dafna Hirschfeld
2024-12-01 2:51 ` Andrew Morton
2024-12-14 9:18 ` Alexander Gordeev
2024-12-01 11:49 ` Matthew Wilcox [this message]
2024-12-02 3:49 ` Muchun Song
2024-12-02 6:02 ` Dafna Hirschfeld
2024-12-02 6:06 ` Dafna Hirschfeld
2024-12-08 5:20 ` Dafna Hirschfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z0xNPw1whVX-W0Qv@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=dafna.hirschfeld@intel.com \
--cc=linux-mm@kvack.org \
--cc=muchun.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox