From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55959D6EC13 for ; Fri, 29 Nov 2024 14:36:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E429C6B0083; Fri, 29 Nov 2024 09:36:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DF11D6B0089; Fri, 29 Nov 2024 09:36:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CE0276B0099; Fri, 29 Nov 2024 09:36:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id B0FDF6B0083 for ; Fri, 29 Nov 2024 09:36:48 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 69D721411F9 for ; Fri, 29 Nov 2024 14:36:48 +0000 (UTC) X-FDA: 82839384012.29.3806D59 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf28.hostedemail.com (Postfix) with ESMTP id C94AAC001D for ; Fri, 29 Nov 2024 14:36:34 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=iA2QxMDH; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732891003; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=R+QHYfxQHuMOIF+ETq3lU99sS9LDLmBvDbwLhdfw4kY=; b=o7V8XGzI6inB6CqTe32eDmM6HP6al8yMONJKmZoyrpGOU/D7rts4eJVO554SS8BeS/XHxH S+uQZCZHWcrG29t417pVUAdoUtijwTeQ0DL7geVSsnppwL/d6s3hnU/lMYgSxeo0U8WG9C j4kK+TvVylXnJs3L2mzeEQCKCk+rqFQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732891003; a=rsa-sha256; cv=none; b=6snmxs8o3yIjHaQ5QS8tmLX0xaNVhDV3dFQEh+HckzgUcBAeR/8pwKJKvsDv3AdM1/0VDl 0x6d5935SWA+rXP1jSYQH5XOGqwdzu6E5xIQsJDqlPBqY/ol12fzirQgGjS4BcQV9Of65P zNGNKpP33LuEcPk69L1YqTsct3a96EI= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=iA2QxMDH; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=R+QHYfxQHuMOIF+ETq3lU99sS9LDLmBvDbwLhdfw4kY=; b=iA2QxMDH324OTfnkMpK975awwI sywYHsNh4toFQhoRSeSfc69GeI0RCwS6u1m/LZalz7r0An6mHrrM8JW3UsWuHzY4YF5Yl71F0ZCQu RkVxMtDN08YLDpSN58xFMLoOtoxqXU+oPbFfmLdl/snTLpyqq0UMFB1pvPzznKvzFNSEQgHuVHZRS 7gcIwFiB/Au+OQwhU9zsAqzmxosnBveudF3/lreRlpW5734t3njen+prig6u72fzq+3bW+3UM1+4k ZWV0l273E4BWqLA8I2ctYXn5kO2Q5x7MlNNppKdtnQrsdA7J+ubdo5f3Q1Y3QTIWgzWiMl+V5khBO sdBveVrg==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1tH26q-000000047Ta-3U8e; Fri, 29 Nov 2024 14:36:41 +0000 Date: Fri, 29 Nov 2024 14:36:40 +0000 From: Matthew Wilcox To: Alice Ryhl Cc: Dave Chinner , Andrew Morton , Johannes Weiner , Nhat Pham , Qi Zheng , Roman Gushchin , Muchun Song , Michal Hocko , Shakeel Butt , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] list_lru: expand list_lru_add() docs with info about sublists Message-ID: References: <20241128-list_lru_memcg_docs-v1-1-7e4568978f4e@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: C94AAC001D X-Stat-Signature: ypudzc8euuqmypn15pk4s8zuxp1jzy94 X-Rspam-User: X-HE-Tag: 1732890994-471081 X-HE-Meta: U2FsdGVkX1/egtpFV3PetBjstD1+IRzGYPg6cSoevclwv+XcAnxWjd27ulaDXQvJU7rmaB6UO6M/Dlc8/xT17XQteRM5fhVg/3gJbwo4xKXL58gyMuViwwXUaqSARwZ0m8/3vdecizYCk/mHhiHLoiSL0Tgq+CqlXr0F1uL2vfvmahuHR0iQm8iJsEGDs5St8Ks58tQCeKqSQzqmYoPkAoWS0gHle0K4OskpBUl0iM6anh7i0rFzJqj81Zks+9fHyqfs4KuZfH9QVEVoIKoA+mZGdT7vizcIpkv35KOdXtqiJ2bOORuXMzl7oQqOwejBvs8orjYIT9V0t+kW+2Jc0v4qikPGuymreyWJzNMUYM3+jvoTu5fd+qARp8kQF+cnnxEB4V2zq7hxjxpy7APB2lZljCF/94THoONdhIpgvIA4awVlpYxk8/HmVMa1KLHm1pINTNZISiarxQKgLfKtLy+zTG9GAJoHJ+uLPLWHjij8DaWLmTFayASsqJp6pJQnR/1u9I81SIEKrq32NTFpl3/kL51ReONjq4sjPczfWQpCouyQqSyQzlDCrgfXoSn47WUnOnhwpWl7RWvY/Q/R25Uj46PGrZTCY0qLT7+/dzvMJF5tgNvR+wbaphJwBLpPv5i1xS07k05/1PJ+nmNRu3scrrmJCM6tJpsiyzeLMJv4/teIqE0VnhqJDpI7csZ0S5LFsUPRFZw9xJQQdzlrwyp+vKou5Gz1lr/4n4vnmvrYH4w5pphqcN51DfwxwUqYLt9qRj0juTfsTEPRj5L+9rRii/+tB59uQH//MPA+uOPQBZFUXr0lxoPav/bra3YbqVqoqIhDiZ8qkw+zMtWOYDrCHl6VGcn8WCFFo0HvC6LPj7rfOrwlc4yL+2yFySRCNQ6fKy6GSJj7cJHMnzOeZnSuPmFAgVPwAC1jMNfH2dG5czjaPYAqADPcR5lyg5GEdRYMwAFYvbhtw2VZR3o yUkY6XPs 13TA72Lfwt1BdQ/I+xb8SdhbIbA3Nj/JWzJrX5Z+nSDH+1FckYFyo0eOZh+ePFlzPVMg6jHvUKj4O0jOwR5Q0WpuIYGAjzdtz9WefzLV52nN6aeCCxvgiS6kKkXkPjWkvnURydCDp56zs3rboecJMI3IThC+3QkqQ6iqR6ywVMxU6Bxif1CW1HDC4GuWyshTtkhtuJGPPWQcqOXPUIgRQHq/oHls7s+POHPx5+XYygObRBPcYluKQhQAVVrjOLO2B6WsZ4raJy8APJxazzskWYdynRw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 29, 2024 at 09:58:27AM +0100, Alice Ryhl wrote: > Oh I had not noticed the "Return"/"Return value" change. It must be a > copy-paste artifact from list_lru_del_obj() which already uses "Return > value". Would you like me to change that one to 'Return'? Yes please! > As for the other rewording, I thought it was slightly more > unambiguous, but don't feel strongly about it. I don't feel strongly about it either.