From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1D19D6EC13 for ; Fri, 29 Nov 2024 14:20:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 448F36B0083; Fri, 29 Nov 2024 09:20:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3F9C26B0085; Fri, 29 Nov 2024 09:20:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 299946B0088; Fri, 29 Nov 2024 09:20:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0BCEA6B0083 for ; Fri, 29 Nov 2024 09:20:33 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9D09E1211F2 for ; Fri, 29 Nov 2024 14:20:32 +0000 (UTC) X-FDA: 82839342516.20.CF5B452 Received: from mail-lj1-f173.google.com (mail-lj1-f173.google.com [209.85.208.173]) by imf22.hostedemail.com (Postfix) with ESMTP id 0CA81C0013 for ; Fri, 29 Nov 2024 14:20:20 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Urx+sHHW; spf=pass (imf22.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.173 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732890026; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ov12DWzgb/UPU3FhdyAKlLO1eWE/ZNSJ/oisuTw+9HY=; b=ufNzhP9Hsepm+VAgzRpVd/47Ya5Hustca4LzNLcd1YFqdXeySr4nPVRK3Lq4oTgHlzUTfO JL0XvWobE2JbxLXO/6wOKVDRCrhvy2JOp1DYaeuKh0jCn+xJAM1I4uWA90RHlNhacSeKdf OsAuUD8ZUgLzUrEoYEhUGA2uFkvzhUw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732890026; a=rsa-sha256; cv=none; b=tmqbOW3lKx0zzDWVN6sTvP7A+jQq0ZeybZbmya+UoNbA2JVgxvAK1lazOOTnD26MzhSMAC D/z3ceWs+tcbAY70kluNvW/Lz3HHRJuyIxTGm8he8kvbo9FsmRyP2JWLikEQmHAvC39lCY jicPSrpIzFBylpEw5J3eAStuBNVFtdM= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Urx+sHHW; spf=pass (imf22.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.173 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lj1-f173.google.com with SMTP id 38308e7fff4ca-2ffb0bbe9c8so23377601fa.0 for ; Fri, 29 Nov 2024 06:20:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732890028; x=1733494828; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=Ov12DWzgb/UPU3FhdyAKlLO1eWE/ZNSJ/oisuTw+9HY=; b=Urx+sHHWyZgHsUaOkgCdvJ+bpx8YTVqIgPLWcTeO75RfsgXWXt5Ehxktp/J4lO956Z /wVaToG8UorjYTUyBHFqJ3NE84KQHsJMGGMGGE/52YOeMLNVFhQyO+jSLy5Nrjeva4CM tzaKk4wxNox4xzXj/kMDUDOBWVS3AoEqn9fbM6URlnD4Eo7fETbhVso+Xh6FYqiGeNut zhE/edserD95ytG1jRXrQDlZsFck8GpFwMKP8A2khC7VQAXtKIaSQlfkPKCsPROB0L9u 0iav97B70Dy7rK3mdGcY/5fmOpfJsr8uf/Q25WJZvC9nJdisiS43GL5eEMtq1pj/vlzg +srw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732890028; x=1733494828; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Ov12DWzgb/UPU3FhdyAKlLO1eWE/ZNSJ/oisuTw+9HY=; b=YsaawwZKHliW2sv/yKjpS966DIg5noaZWMBWsXvWDixr4ZstTqQGfmEXXLymqdvis7 QOypTYwIkLo0qUz+A03GkZ4J8VUSeqJcZ2OzIYKYK76mb9KOp6bzIBTH7j/O7IY4m3fR 2j+bNrlZIiE27hOQXeuRbcKunBWgRwI53wnGeL8tkKYEpx0bB7/T0aOExPcgVjY66DGt Z7CQAfc8zj0p5Rc4j01RAogFmFGICJTtZtP2xjBV7JXfsfHR3lWtrq0WWXaRqKdgGH4T ZnRIU9HOgNeoxHuvVJkD0qxcIhABpxwPheGeszisoERLKkVwih5+8rxcm4u6w/SJsX3C qZcA== X-Forwarded-Encrypted: i=1; AJvYcCVg97WF5Dk21h6hz0cZ2tw260EAUzuQ1YXxzJnpRDtx+FXSezpO0l+6H9a1iDrhWsFtHYoBpXFYPA==@kvack.org X-Gm-Message-State: AOJu0YwE7sDIqIrOgV1P5UllHqcbNlsh+ESkgrZdlcFk2XshMkXQYc1s i4tCGB6dJIvqMl4gbl8klGNVSjN/OsDQQ+IZ3DdfZ6r2QsKbyN6r X-Gm-Gg: ASbGncski1Cu8vYOlTYLKyIhmc3eVu3WkozpHdwrSGUfNkeO1LDWjvlG/hveqcxhPdr fzPRMjzmIpLDqLwDsOexyfSnns33ff9t3dfyO1S6qRKHYvz818WLCoh+578TbC3/rCzEpttBELg KC+U8gZ31/F//5F21GSFS/hqPQnzCMxVl9ts728+U6VOin9EXu+iKJqvfdOU7iU9kfqUyzwJfQS b5O/6nUXpT4+shtMbSgIeVJZRSSG6Dssr6Xi5w/hSYyOzpcHTp+st73DznCM0gx7NPSDcUkYWlj DQ== X-Google-Smtp-Source: AGHT+IGUT6CEclltd/WGp4YaLqNyRCPTqgq1ZAEUO7JQ+l/iucwpW5srMhSlkIsp2PzbWTTd/GILGw== X-Received: by 2002:a2e:bcc1:0:b0:2ff:cfeb:cabd with SMTP id 38308e7fff4ca-2ffd6110b09mr76415021fa.28.1732890028116; Fri, 29 Nov 2024 06:20:28 -0800 (PST) Received: from pc636 (host-95-203-21-235.mobileonline.telia.com. [95.203.21.235]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2ffdfc74a65sm4677051fa.70.2024.11.29.06.20.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Nov 2024 06:20:27 -0800 (PST) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Fri, 29 Nov 2024 15:20:23 +0100 To: Vlastimil Babka Cc: Uladzislau Rezki , Suren Baghdasaryan , "Liam R. Howlett" , Christoph Lameter , David Rientjes , Pekka Enberg , Joonsoo Kim , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Paul E. McKenney" , Lorenzo Stoakes , Matthew Wilcox , Boqun Feng , linux-mm@kvack.org, linux-kernel@vger.kernel.org, rcu@vger.kernel.org, maple-tree@lists.infradead.org Subject: Re: [PATCH RFC 2/6] mm/slub: add sheaf support for batching kfree_rcu() operations Message-ID: References: <20241112-slub-percpu-caches-v1-0-ddc0bdc27e05@suse.cz> <20241112-slub-percpu-caches-v1-2-ddc0bdc27e05@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 0CA81C0013 X-Stat-Signature: xq98hg9dcpfdc9b6kp1xeyiuek5wcgx6 X-Rspam-User: X-HE-Tag: 1732890020-824379 X-HE-Meta: U2FsdGVkX1/tzTTmB5NIKuG77bzCVno+p0HOMgkvdBtG+DI+p91lqnQoye4ZOGDP6fr63rFO0czrjT7VbbNjF0XXEE8hpg2BFcPfE2U25qYmd1WxsyC/+v1MAoV7w/N3yhsnlY8pt4Id9paUK5pZRonsuLfmmPH+3XSvJYsm+8wpMXFqk5rswdyNMPsqveTwLs1DXXtbqXTXYnc2f86ZL02dSARmnVM0yshHpjlCpPpMPz4pJezh0siMUXfP9xowmuzxkBksQCprgCdc44uhXQQHbl3j0OvmfQFtURkPvzeDTQzOB7W7edcj3rO7rykoOsr9EOr6iYDT/343mGb2Am3+YnN6GkrSHyV74f5Jowlh+iHA/kAoG8ahGby3rth9oD0qy9pn27k9F4VUQ8pnz80UEbRBNUrM95yv+mvzZjcmw2+kkdXY8zzud8Ey1bvxDJXtJ9T7wgCdG6+wGvEG8syJWvHJWw5XqPLApoSGpbFFmMPEmbFLGuRpovtiIBnOU81kSwGWAkyBM2haAXDV01AYDqaOv0VMYsv2HwhmubAIszD59Qlv1ksH1cZ1n/gydjiaqDmAbp53hUg/FKR9F4OXdSTAH14Xw+5X9ejZlm2kdix3DjwDdWU4of0TvahfDmFX9kr3ZGv2FRu9uOdO/bCT0s50/0sz+9xCU7fERnhHbzELIul0dYcXSbft00QWCt1SGcbmFvmoujpK55CbDCG0XocCXfMPhxHGAeFDmQIbIRckfqwdF3zJJHpmwy6dPzwsFhVcPPhVk5cXqSZo9qovpvT1zgH7dgLvsuMk9yMqiCqV41GuL6vzEIfT7SQSPZB4bBcjtbQgQ7wkTvxGLPTUHrH5JfYlY9aXLCGVHqCxRmoBbMHDY0c2c3658ivnNotRwjElDsoU7ovz41sOVc7U7ft4F9UvwfXR4cmYUhTQTM7JqvclEdj0lyg2mRbjyU/CWASi5ToyyKYR1zI o66CZb51 KixP9c6BnDSpKRRl+7Xak9eRT+Ci2PNwRjAY6lxHyfAoLC2ge3y42SGtklWROBeQUuGntJCFb1UmkoQJsL5rP1j9X0KQZ9yHfPZVXjEww0VorUiuk9yZT1KE6VOj8lvt5lYodh0TrvBprpBdsyQY+0n4ogl6ExQu2s/YWVemvMn1rpt/vUTJZLr4Hx/0hCFOXH7F/twrJg/9q9qYF+UazQhDeKi9V/XLGz391c17dS+24+yO61mqrJIKGres9yEExwlIvkzHAEym3VsWhMFmyFxwk9MVlPsAWws6kQPCdGcLscQlrtM1cfzreWqi9nkITWn0ed/4zj+APxPE+OXs10TX4f76f84Bjo3fO/qoGN3tUYc+5D6Nuozxp8f4s0iCNTmNjOmQddnD0UaFz6HnBQ5juCEX14Ck4XTI0AOVCggS8hRy+jExJDWDFYZEQygyiVwVx2JEwMBOxtX0KolmHxGgRTRc0hRv1oCmuRGWcWBobuj6uJ71CzIUkzRbOZ1aXi4U46V8kaeZgYvc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello! > On 11/28/24 5:24 PM, Uladzislau Rezki wrote: > > On Mon, Nov 25, 2024 at 12:18:19PM +0100, Uladzislau Rezki wrote: > >>> On 11/20/24 13:37, Uladzislau Rezki wrote: > >>>> Thank you. Let me try to start moving it into mm/. I am thinking to place > >>>> it to the slab_common.c file. I am not sure if it makes sense to have a > >>>> dedicated file name for this purpose. > >>> > >>> Yeah sounds good. slub.c is becoming rather large and this should not > >>> interact with SLUB internals heavily anyway, slab_common.c makes sense. > >>> Thanks! > >>> > >> Got it :) > >> > > There is one question. Do you think it works if i do a migration as one > > big commit? I am asking, because it is easier to go that way. > > Hi, I think one big move is fine. In case there are further adjustments, > those would be better in separate patches. That makes it easy to review > the move with git diff --color-moved. > Sounds good and thank you! -- Uladzislau Rezki